The length field is already contained in the ip6_ext_hdr structure.
Check it direcly in eth_parse_ipv6_hdr() before calling
_eth_get_rss_ex_dst_addr(), which gets a bit simplified.
Reviewed-by: Miroslav Rezanina
Signed-off-by: Philippe Mathieu-Daudé
---
net/eth.c | 14 +++---
1 file
QEMU fuzzer reported a buffer overflow in _eth_get_rss_ex_dst_addr()
reproducible as:
$ cat << EOF | ./qemu-system-i386 -M pc-q35-5.0 \
-accel qtest -monitor none \
-serial none -nographic -qtest stdio
outl 0xcf8 0x80001010
outl 0xcfc 0xe102
outl 0xcf8 0x80001004
outw 0xcfc
I had a look at the patch from Miroslav trying to silence a
compiler warning which in fact is a nasty bug. Here is a fix.
https://www.mail-archive.com/qemu-devel@nongnu.org/msg772735.html
v2: Restrict tests so they don't fail when device aren't available
Based-on:
On Fri, 15 Jan 2021 at 14:01, Peter Maydell wrote:
>
> I was just trying to see what updates the qemu.nsi file needed for
> the merge-all-the-manuals-into-one-place change, and I discovered
> that it's been broken since October when we removed the Changelog file:
>
> File:
On 210115 1033, Darren Kenny wrote:
> Hi Alex,
>
> On Thursday, 2021-01-14 at 17:17:48 -05, Alexander Bulekov wrote:
> > Signed-off-by: Alexander Bulekov
>
> In general this look good, so:
>
> Reviewed-by: Darren Kenny
>
> but I do have a question below...
>
> > ---
> >
On 1/13/21 2:47 PM, Juan Quintela wrote:
> Juan Quintela wrote:
>> Philippe Mathieu-Daudé wrote:
>>> Signed-off-by: Philippe Mathieu-Daudé
>>
>> I think this one is wrong.
>
> Wrong is a strong word. I mean that it changes behaviour and the commit
> message don't talk about changing
On Thu, 14 Jan 2021 at 16:56, Philippe Mathieu-Daudé wrote:
>
> Resending the MIPS pull request from MIPS patches from last week
> (2021-01-07) now than the "decodetree: Open files with encoding='utf-8'"
> patch got merged (commit 4cacecaaa2b).
>
>
After chasing down a bug[1] with MTE assisted KASAN and KVM, I've now
been able to rebase on v5.11-rc1 and test the combination of
KVM-with-MTE and KASAN.
For anyone new to this series, or simply pretending 2020 didn't happen,
this series adds support for Arm's Memory Tagging Extension (MTE) to
Add a new VM feature 'KVM_ARM_CAP_MTE' which enables memory tagging
for a VM. This exposes the feature to the guest and automatically tags
memory pages touched by the VM as PG_mte_tagged (and clears the tags
storage) to ensure that the guest cannot see stale tags, and so that the
tags are
On Thu, Jan 14, 2021 at 2:59 PM Peter Lieven wrote:
>
> Am 14.01.21 um 20:19 schrieb Jason Dillaman:
> > On Sun, Dec 27, 2020 at 11:42 AM Peter Lieven wrote:
> >> since we implement byte interfaces and librbd supports aio on byte
> >> granularity we can lift
> >> the 512 byte alignment.
> >>
>
Define the new system registers that MTE introduces and context switch
them. The MTE feature is still hidden from the ID register as it isn't
supported in a VM yet.
Signed-off-by: Steven Price
---
arch/arm64/include/asm/kvm_host.h | 4 ++
arch/arm64/include/asm/kvm_mte.h |
Hi,
This is how I understand the ecSPI reset works, after
looking at the IMX6DQRM.pdf datasheet.
This is a respin of Ben's v5 series [*].
Since v6:
- Dropped "Reduce 'change_mask' variable scope" patch
- Fixed inverted reset logic
- Added Juan R-b tags
- Removed 'RFC' tag as tests pass
'burst_length' is cleared in imx_spi_reset(), which is called
after imx_spi_realize(). Remove the initialization to simplify.
Reviewed-by: Juan Quintela
Signed-off-by: Philippe Mathieu-Daudé
---
hw/ssi/imx_spi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/hw/ssi/imx_spi.c
The VMM may not wish to have it's own mapping of guest memory mapped
with PROT_MTE because this causes problems if the VMM has tag checking
enabled (the guest controls the tags in physical RAM and it's unlikely
the tags are correct for the VMM).
Instead add a new ioctl which allows the VMM to
From: Xuzhou Cheng
When a write to ECSPI_CONREG register to disable the SPI controller,
imx_spi_reset() is called to reset the controller, but chip select
lines should have been disabled, otherwise the state machine of any
devices (e.g.: SPI flashes) connected to the SPI master is stuck to
its
From: Bin Meng
Avoid using a magic number (4) everywhere for the number of chip
selects supported.
Signed-off-by: Bin Meng
Reviewed-by: Alistair Francis
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20210112145526.31095-2-bmeng...@gmail.com>
Reviewed-by: Juan Quintela
Signed-off-by:
When the block is disabled, all registers are reset with the
exception of the ECSPI_CONREG. It is initialized to zero
when the instance is created.
Ref: i.MX 6DQ Applications Processor Reference Manual (IMX6DQRM),
chapter 21.7.3: Control Register (ECSPIx_CONREG)
Reviewed-by: Juan Quintela
When the block is disabled, it stay it is 'internal reset logic'
(internal clocks are gated off). Reading any register returns
its reset value. Only update this value if the device is enabled.
Ref: i.MX 6DQ Applications Processor Reference Manual (IMX6DQRM),
chapter 21.7.3: Control Register
When the block is disabled, only the ECSPI_CONREG register can
be modified. Setting the EN bit enabled the device, clearing it
"disables the block and resets the internal logic with the
exception of the ECSPI_CONREG" register.
Move the imx_spi_is_enabled() check earlier.
Ref: i.MX 6DQ
From: Bin Meng
For the ECSPIx_CONREG register BURST_LENGTH field, the manual says:
0x020 A SPI burst contains the 1 LSB in first word and all 32 bits in second
word.
0x021 A SPI burst contains the 2 LSB in first word and all 32 bits in second
word.
Current logic uses either s->burst_length
On Thu, 14 Jan 2021 10:58:07 +1100
David Gibson wrote:
> Now that we've implemented a generic machine option for configuring various
> confidential guest support mechanisms:
> 1. Update docs/amd-memory-encryption.txt to reference this rather than
> the earlier SEV specific option
> 2.
From: Bin Meng
Current implementation of the imx spi controller expects the burst
length to be multiple of 8, which is the most common use case.
In case the burst length is not what we expect, log it to give user
a chance to notice it, and round it up to be multiple of 8.
Signed-off-by: Bin
From: Bin Meng
The endianness of data exchange between tx and rx fifo is incorrect.
Earlier bytes are supposed to show up on MSB and later bytes on LSB,
ie: in big endian. The manual does not explicitly say this, but the
U-Boot and Linux driver codes have a swap on the data transferred
to tx
On Fri, 15 Jan 2021 at 13:08, Alex Bennée wrote:
>
> The following changes since commit 7c79721606be11b5bc556449e5bcbc331ef6867d:
>
> Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210113'
> into staging (2021-01-14 09:54:29 +)
>
> are available in the Git repository at:
On 210115 1323, Greg Kurz wrote:
> On Thu, 14 Jan 2021 17:17:48 -0500
> Alexander Bulekov wrote:
>
> > Signed-off-by: Alexander Bulekov
> > ---
>
> No changelog at all ?
>
> > tests/qtest/fuzz/generic_fuzz_configs.h | 12
> > 1 file changed, 12 insertions(+)
> >
> > diff --git
On Thu, 14 Jan 2021 10:58:08 +1100
David Gibson wrote:
> Some upcoming POWER machines have a system called PEF (Protected
> Execution Facility) which uses a small ultravisor to allow guests to
> run in a way that they can't be eavesdropped by the hypervisor. The
> effect is roughly similar to
Am 15.01.21 um 15:01 schrieb Peter Maydell:
I was just trying to see what updates the qemu.nsi file needed for
the merge-all-the-manuals-into-one-place change, and I discovered
that it's been broken since October when we removed the Changelog file:
File: "/tmp/qemu-test/src\Changelog" -> no
Perhaps I'm slow on the uptake today...
We have
typedef struct XHCIPciState {
/*< private >*/
PCIDevice parent_obj;
/*< public >*/
(1) XHCIState xhci;
OnOffAuto msi;
OnOffAuto msix;
} XHCIPciState;
This is a PCI device that contains a
When we first converted our documentation to Sphinx, we split it into
multiple manuals (system, interop, tools, etc), which are all built
separately. The primary driver for this was wanting to be able to
avoid shipping the 'devel' manual to end-users. However, this is
working against the grain
On 210115 1351, Christian Schoenebeck wrote:
> On Freitag, 15. Januar 2021 13:23:08 CET Greg Kurz wrote:
> > On Thu, 14 Jan 2021 17:17:48 -0500
> >
> > Alexander Bulekov wrote:
> > > Signed-off-by: Alexander Bulekov
> > > ---
> >
> > No changelog at all ?
>
> Yeah, that's indeed quite short.
Am 15.01.21 um 16:27 schrieb Jason Dillaman:
> On Thu, Jan 14, 2021 at 2:59 PM Peter Lieven wrote:
>> Am 14.01.21 um 20:19 schrieb Jason Dillaman:
>>> On Sun, Dec 27, 2020 at 11:42 AM Peter Lieven wrote:
since we implement byte interfaces and librbd supports aio on byte
granularity we
On Fri, 15 Jan 2021 at 15:34, Stefan Weil wrote:
> although I have some local fixes (available for example in
> https://github.com/stweil/qemu/) I am still struggling with 5.2.0.
>
> One problem which was recently discussed on the list is the directory
> structure of the installation (especially
On Fri, 15 Jan 2021 at 15:45, Markus Armbruster wrote:
>
> The .realize() method realizes the child at (1). It should use
> qdev_realize() like we do everywhere else, since commit ce189ab230
> "qdev: Convert bus-less devices to qdev_realize() with Coccinelle".
>
> It sets a link property from
Subject is incorrect, this is not a removal of the tests, but
removal of their execution. The tests are still in the repository.
This is more of a disablement.
On 1/15/21 4:09 PM, Philippe Mathieu-Daudé wrote:
> The TPM tests are failing, and no further tests are run,
> making the rest of the
Am 15.01.21 um 16:19 schrieb Peter Maydell:
On Fri, 15 Jan 2021 at 14:01, Peter Maydell wrote:
I was just trying to see what updates the qemu.nsi file needed for
the merge-all-the-manuals-into-one-place change, and I discovered
that it's been broken since October when we removed the Changelog
On 1/15/21 10:52 AM, Philippe Mathieu-Daudé wrote:
Subject is incorrect, this is not a removal of the tests, but
removal of their execution. The tests are still in the repository.
This is more of a disablement.
How do you compile / run them to have the LeakSanitizer checks?
On Fri, 15 Jan 2021 at 15:52, Stefan Weil wrote:
> I forgot to mention that some of the problems with the Meson build also
> occur on macOS with Homebrew: they always happen when a software package
> requires special compiler flags to find its include files or libraries,
> but the Meson build
On 1/15/21 4:53 PM, Stefan Berger wrote:
> On 1/15/21 10:52 AM, Philippe Mathieu-Daudé wrote:
>> Subject is incorrect, this is not a removal of the tests, but
>> removal of their execution. The tests are still in the repository.
>> This is more of a disablement.
>
> How do you compile / run them
On Fri, 15 Jan 2021 09:07:47 +
"Zhang, Chen" wrote:
> > -Original Message-
> > From: Lukas Straub
> > Sent: Thursday, January 14, 2021 9:45 PM
> > To: Zhang, Chen
> > Cc: Jason Wang ; qemu-dev > de...@nongnu.org>; Eric Blake ; Dr. David Alan
> > Gilbert ; Markus Armbruster ;
> >
On 1/15/21 5:06 PM, Philippe Mathieu-Daudé wrote:
> On 1/15/21 4:53 PM, Stefan Berger wrote:
>> On 1/15/21 10:52 AM, Philippe Mathieu-Daudé wrote:
>>> Subject is incorrect, this is not a removal of the tests, but
>>> removal of their execution. The tests are still in the repository.
>>> This is
** Tags added: fuzzer
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1911839
Title:
[OSS-Fuzz] Issue 29586 e1000e: Memcpy-param-overlap in
flatview_write_continue
Status in QEMU:
New
Bug
** Tags added: fuzzer
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1911075
Title:
[OSS-Fuzz] ahci: stack overflow in ahci_cond_start_engines
Status in QEMU:
Confirmed
Bug description:
===
** Tags added: fuzzer
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1910941
Title:
Assertion `addr < cache->len && 2 <= cache->len - addr' in virtio-blk
Status in QEMU:
New
Bug description:
** Tags added: fuzzer
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1909261
Title:
[OSS-Fuzz] Issue 28929 xhci: ASSERT: xfer->packet.status !=
USB_RET_NAK
Status in QEMU:
New
Bug
** Tags added: fuzzer
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1910826
Title:
[OSS-Fuzz] Issue 29224 rtl8139: Stack-overflow in
rtlNUMBER_transmit_one
Status in QEMU:
New
Bug
** Tags added: fuzzer
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1910603
Title:
[OSS-Fuzz] Issue 29174 sb16: Abrt in audio_bug
Status in QEMU:
New
Bug description:
=== Reproducer ===
** Tags added: fuzzer
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1908513
Title:
assertion failure in mptsas1068 emulator
Status in QEMU:
New
Bug description:
Using hypervisor fuzzer,
** Tags added: fuzzer
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1908515
Title:
assertion failure in lsi53c810 emulator
Status in QEMU:
New
Bug description:
Hello,
Using hypervisor
** Tags added: fuzzer
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1908062
Title:
qemu-system-i386 virtio-vga: Assertion in address_space_stw_le_cached
failed again
Status in QEMU:
New
Bug
** Tags added: fuzzer
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1907938
Title:
[OSS-Fuzz] Issue 28524 virtio-blk: ASSERT: !s->dataplane_started
Status in QEMU:
New
Bug description:
** Tags added: fuzzer
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1907497
Title:
[OSS-Fuzz] Issue 28435 qemu:qemu-fuzz-i386-target-generic-fuzz-intel-
hda: Stack-overflow in ldl_le_dma
Status
** Tags added: fuzzer
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1907909
Title:
assertion failure in am53c974
Status in QEMU:
New
Bug description:
Hello,
Using hypervisor fuzzer,
Fix now in master: commit e7e29fdbbe07f.
** Changed in: qemu
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1904954
Title:
lan9118 bug peeked received
** Tags added: fuzzer
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1905444
Title:
[OSS-Fuzz] Issue 27796 in oss-fuzz: qemu:qemu-fuzz-i386-target-
generic-fuzz-xhci: Stack-overflow in
Fix now in master as commit 6d3ef04893bde -- will be in next QEMU
release.
** Changed in: qemu
Status: Confirmed => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1907817
** Tags added: fuzzer
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1909247
Title:
QEMU: use after free vulnerability in esp_do_dma() in hw/scsi/esp.c
Status in QEMU:
New
Bug description:
A
** Tags added: fuzzer
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1901532
Title:
Assertion failure `mr != NULL' failed through usb-ehci
Status in QEMU:
Confirmed
Bug description:
Hello,
** Tags added: fuzzer
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1904652
Title:
Assertion failure in usb-ohci
Status in QEMU:
New
Bug description:
Hello,
Using hypervisor fuzzer,
** Tags added: fuzzer
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1906693
Title:
Assertion Failure in bdrv_co_write_req_prepare through megasas
Status in QEMU:
New
Bug description:
On Fri, 15 Jan 2021 at 09:05, Greg Kurz wrote:
>
> The following changes since commit 7c79721606be11b5bc556449e5bcbc331ef6867d:
>
> Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210113'
> into staging (2021-01-14 09:54:29 +)
>
> are available in the Git repository at:
>
On Thu, Jan 14, 2021 at 11:36:23AM -0500, John Snow wrote:
> On 1/14/21 7:29 AM, Markus Armbruster wrote:
[...]
> So I see two possible options for "not inventing a language":
>
> 1. Raw QMP
> 2. The existing qmp-shell syntax, warts and all.
>
> I don't see a tremendous problem with doing
On Thu, 14 Jan 2021 10:58:11 +1100
David Gibson wrote:
> At least some s390 cpu models support "Protected Virtualization" (PV),
> a mechanism to protect guests from eavesdropping by a compromised
> hypervisor.
>
> This is similar in function to other mechanisms like AMD's SEV and
> POWER's PEF,
On 1/14/21 9:56 PM, Gan Qixin wrote:
> When compiling qemu-fuzz-i386 on aarch64 host, clang reported the following
> error:
>
> ../util/cacheflush.c:38:44: error: value size does not match register size
> specified by the constraint and modifier [-Werror,-Wasm-operand-widths]
> asm
+Hao Wu
On Fri, Jan 15, 2021 at 1:15 AM Philippe Mathieu-Daudé wrote:
>
> On 1/15/21 8:56 AM, Gan Qixin wrote:
> > The pwm_qom_get function didn't free "response", which caused an indirect
> > memory leak. So use qobject_unref() to fix it.
> >
> > ASAN shows memory leak stack:
> >
> > Indirect
On Tue, Jan 12, 2021 at 1:44 PM Thomas Huth wrote:
>
> We can use the "Stupid creek" image to test the mpc8544ds ppc machine.
>
> Signed-off-by: Thomas Huth
> ---
> tests/acceptance/machine_ppc.py | 17 +
> 1 file changed, 17 insertions(+)
Reviewed-by: Willian Rampazzo
On Tue, Jan 12, 2021 at 1:45 PM Thomas Huth wrote:
>
> The "And a hippo new year" image from the QEMU advent calendar 2020
> can be used to test the virtex-ml507 ppc machine.
>
> Signed-off-by: Thomas Huth
> ---
> tests/acceptance/machine_ppc.py | 18 ++
> 1 file changed, 18
On Thu, 14 Jan 2021 15:06:28 -0300
Daniel Henrique Barboza wrote:
> The only restriction we have when unplugging CPUs is to forbid unplug of
> the boot cpu core. spapr_core_unplug_possible() does not contemplate the
I can't remember why this restriction was introduced in the first place...
This
On Fri, Jan 15, 2021 at 9:17 AM Havard Skinnemoen
wrote:
> +Hao Wu
>
> On Fri, Jan 15, 2021 at 1:15 AM Philippe Mathieu-Daudé
> wrote:
> >
> > On 1/15/21 8:56 AM, Gan Qixin wrote:
> > > The pwm_qom_get function didn't free "response", which caused an
> indirect
> > > memory leak. So use
On Fri, 15 Jan 2021 14:01:28 +0530
Bharata B Rao wrote:
> On Wed, Jan 13, 2021 at 05:22:56PM +0100, Greg Kurz wrote:
> > Hi Bharata,
> >
> > On Wed, 6 Jan 2021 14:29:10 +0530
> > Bharata B Rao wrote:
> >
> > > If KVM_CAP_RPT_INVALIDATE KVM capability is enabled, then
> > >
> > > - indicate
On 15/01/21 16:57, Peter Maydell wrote:
On Fri, 15 Jan 2021 at 15:52, Stefan Weil wrote:
I forgot to mention that some of the problems with the Meson build also
occur on macOS with Homebrew: they always happen when a software package
requires special compiler flags to find its include files or
On Fri, Jan 15, 2021 at 02:57:45PM +0100, Klaus Jensen wrote:
>
> As you already mentioned, the problem I see with this approach is that
> we have separate namespaces attached to separate controllers. So we are
> faking it to the max and if I/O starts going through the other
> controller we end
There are a couple of environment variables that we fetch with
os.environ.get() without supplying a default. Clearly they are required
and expected to be set by the ./check script (as evidenced by
execute_setup_common(), which checks for test_dir and
qemu_default_machine to be set, and aborts if
Cover letters:
v1: https://lists.nongnu.org/archive/html/qemu-block/2021-01/msg00254.html
v2: https://lists.nongnu.org/archive/html/qemu-block/2021-01/msg00296.html
v3: https://lists.nongnu.org/archive/html/qemu-block/2021-01/msg00371.html
git:
https://github.com/XanClic/qemu.git fix-129-2-v4
Throttling on the BB has not affected block jobs in a while, so it is
possible that one of the jobs in 129 finishes before the VM is stopped.
We can fix that by running the job from a throttle node.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
Instead of checking iotests.py only, check all Python files in the
qemu-iotests/ directory. Of course, most of them do not pass, so there
is an extensive skip list for now. (The only files that do pass are
209, 254, 283, and iotests.py.)
(Alternatively, we could have the opposite, i.e. an
And consequentially drop it from 297's skip list.
Signed-off-by: Max Reitz
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/297 | 2 +-
tests/qemu-iotests/300 | 18 +++---
2 files changed, 16 insertions(+), 4 deletions(-)
diff --git a/tests/qemu-iotests/297
Before this patch, test_block_commit() performs an active commit, which
under the hood is a mirror job. If we want to test various different
block jobs, we should perhaps run an actual commit job instead.
Doing so requires adding an overlay above the source node before the
commit is done (and
Signed-off-by: Max Reitz
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Reviewed-by: Willian Rampazzo
---
tests/qemu-iotests/129 | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/qemu-iotests/129 b/tests/qemu-iotests/129
index 0e13244d85..2fc65ada6a 100755
---
And consequentially drop it from 297's skip list.
Signed-off-by: Max Reitz
Reviewed-by: Willian Rampazzo
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/129 | 4 ++--
tests/qemu-iotests/297 | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/124| 8 +---
tests/qemu-iotests/iotests.py | 11 +++
2 files changed, 8 insertions(+), 11 deletions(-)
diff --git a/tests/qemu-iotests/124
On Jan 15 09:35, Keith Busch wrote:
> On Fri, Jan 15, 2021 at 02:57:45PM +0100, Klaus Jensen wrote:
> >
> > As you already mentioned, the problem I see with this approach is that
> > we have separate namespaces attached to separate controllers. So we are
> > faking it to the max and if I/O starts
@busy is false when the job is paused, which happens all the time
because that is how jobs yield (e.g. for mirror at least since commit
565ac01f8d3).
Back when 129 was added (2015), perhaps there was no better way of
checking whether the job was still actually running. Now we have the
@status
On Fri, Jan 15, 2021 at 06:47:20PM +0100, Klaus Jensen wrote:
> Cool!
I thought so too :)
> Question: NSIDs must be the same on each controller for shared
> namespaces, but can private namespaces "share" nsid across controllers
> in the subsystem? I don't think the spec is clear on that point.
Issuing 'stop' on the VM drains all nodes. If the mirror job has many
large requests in flight, this may lead to significant I/O that looks a
bit like 'stop' would make the job try to complete (which is what 129
should verify not to happen).
We can limit the I/O in flight by limiting the buffer
It is pointless to install ROM blobs for user emulation.
Signed-off-by: Philippe Mathieu-Daudé
---
RFC because I think it would be better to make the 'blobs'
option a 'feature' instead of a boolean so we can set it
as 'auto' and then in that case we could do something
blobs = have_system
On 1/15/21 4:34 PM, Stefan Weil wrote:
> Am 15.01.21 um 15:01 schrieb Peter Maydell:
>
>> I was just trying to see what updates the qemu.nsi file needed for
>> the merge-all-the-manuals-into-one-place change, and I discovered
>> that it's been broken since October when we removed the Changelog
On 1/14/21 10:02 AM, Daniel P. Berrangé wrote:
This will make diffs in later patches clearer.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Daniel P. Berrangé
---
tests/docker/dockerfiles/centos7.docker | 4 ++--
tests/docker/dockerfiles/fedora.docker| 4 ++--
On Thu, Jan 14, 2021 at 07:33:32PM +0530, P J P wrote:
> Hello,
>
> * We have received quite a few subscription requests for the 'qemu-security'
> list in the last few weeks. Majority of them are rejected because we could
> not identify the user from merely their email-id.
>
> * I have
> On Jan 15, 2021, at 4:20 AM, Stefan Hajnoczi wrote:
>
> On Thu, Jan 14, 2021 at 01:24:37PM -0500, Jag Raman wrote:
>>
>>
>>> On Jan 14, 2021, at 1:00 PM, Daniel P. Berrangé wrote:
>>>
>>> On Thu, Jan 14, 2021 at 12:55:58PM -0500, Jag Raman wrote:
> On Jan 14, 2021, at
On Thu, Jan 14, 2021 at 10:36:43AM +, Dr. David Alan Gilbert wrote:
> * Christian Borntraeger (borntrae...@de.ibm.com) wrote:
> >
> >
> > On 13.01.21 13:42, Dr. David Alan Gilbert wrote:
> > > * Cornelia Huck (coh...@redhat.com) wrote:
> > >> On Tue, 5 Jan 2021 12:41:25 -0800
> > >> Ram Pai
On Fri, Jan 15, 2021 at 2:43 PM Max Reitz wrote:
>
> And consequentially drop it from 297's skip list.
>
> Signed-off-by: Max Reitz
> Reviewed-by: Vladimir Sementsov-Ogievskiy
> ---
> tests/qemu-iotests/297 | 2 +-
> tests/qemu-iotests/300 | 18 +++---
> 2 files changed, 16
On Fri, Jan 15, 2021 at 2:43 PM Max Reitz wrote:
>
> Before this patch, test_block_commit() performs an active commit, which
> under the hood is a mirror job. If we want to test various different
> block jobs, we should perhaps run an actual commit job instead.
>
> Doing so requires adding an
On Fri, Jan 15, 2021 at 2:43 PM Max Reitz wrote:
>
> Throttling on the BB has not affected block jobs in a while, so it is
> possible that one of the jobs in 129 finishes before the VM is stopped.
> We can fix that by running the job from a throttle node.
>
> Signed-off-by: Max Reitz
>
On Fri, Jan 15, 2021 at 2:43 PM Max Reitz wrote:
>
> @busy is false when the job is paused, which happens all the time
> because that is how jobs yield (e.g. for mirror at least since commit
> 565ac01f8d3).
>
> Back when 129 was added (2015), perhaps there was no better way of
> checking whether
On Fri, Jan 15, 2021 at 2:43 PM Max Reitz wrote:
>
> Signed-off-by: Max Reitz
> Reviewed-by: Eric Blake
> Reviewed-by: Vladimir Sementsov-Ogievskiy
> ---
> tests/qemu-iotests/124| 8 +---
> tests/qemu-iotests/iotests.py | 11 +++
> 2 files changed, 8 insertions(+), 11
Hi Richard,
Sorry to take so long to get through the changes after your review.
I am still going through the improving process and waiting for some
internal company approval to publish the generator of the TCG
instruction definitions, as we have discussed.
Nevertheless, there are some
>> +
>> +assert(ctx->insn.limm_p == 0 && !in_delay_slot);
>> +
>> +if (ctx->insn.limm_p == 0 && !in_delay_slot) {
>> +in_delay_slot = true;
>> +uint32_t cpc = ctx->cpc;
>> +uint32_t pcl = ctx->pcl;
>> +insn_t insn = ctx->insn;
>> +
>> +ctx->cpc =
>> +void QEMU_NORETURN helper_halt(CPUARCState *env, uint32_t npc)
>> +{
>> +CPUState *cs = env_cpu(env);
>> +if (env->stat.Uf) {
>> +cs->exception_index = EXCP_PRIVILEGEV;
>> +env->causecode = 0;
>> +env->param = 0;
>> + /* Restore PC such that we point at
On 1/14/21 10:02 AM, Daniel P. Berrangé wrote:
dbus-daemon doesn't exist in centos7, it is part of dbus.
snappy is used by QEMU, not csnappy.
mesa-libEGL-devel is not used in QEMU at all, but mesa-libgbm-devel is.
vte291-devel is required for GTK3, not vte-devel.
spice-glib-devel is not
> On 11/11/20 10:17 AM, cupertinomira...@gmail.com wrote:
>> +/*
>> + * The macro to add boiler plate code for conditional execution.
>> + * It will add tcg_gen codes only if there is a condition to
>> + * be checked (ctx->insn.cc != 0). This macro assumes that there
>> + * is a "ctx" variable of
301 - 400 of 415 matches
Mail list logo
