[PATCH 3/3] virtiofsd: Swing deprecated message to removed-features

2023-01-18 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Move the deprecation message, since it's now gone. Signed-off-by: Dr. David Alan Gilbert --- docs/about/deprecated.rst | 18 -- docs/about/removed-features.rst | 13 + 2 files changed, 13 insertions(+), 18 deletions(-) diff --gi

[PATCH 1/3] virtiofsd: Remove build and docs glue

2023-01-18 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Remove all the virtiofsd build and docs infrastructure. Signed-off-by: Dr. David Alan Gilbert --- MAINTAINERS| 2 -- docs/conf.py | 4 docs/meson.build | 1

[PATCH 0/3] Remove C virtiofsd

2023-01-18 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" We deprecated the C virtiofsd in commit 34deee7b6a1418f3d62a in v7.0 in favour of the Rust implementation at https://gitlab.com/virtio-fs/virtiofsd since then, the Rust version has had more development and has held up well. It's time to say goodbye to the C ver

Re: [PATCH 3/3] avocado_qemu: add AVOCADO_DEFAULT_MACHINE

2023-01-18 Thread Fabiano Rosas
Daniel Henrique Barboza writes: > Allow users to control which machine to use in tests where no particular > machine is specified. This is a good way to run tests in a machine > that's not the arch default, e.g. for qemu-system-x86_64 tests can be > run using a machine other than pc-i440fx. > > T

Re: [PATCH v14 08/11] qapi/s390/cpu topology: change-topology monitor command

2023-01-18 Thread Pierre Morel
On 1/18/23 16:17, Kevin Wolf wrote: Am 18.01.2023 um 11:53 hat Thomas Huth geschrieben: On 17/01/2023 14.31, Nina Schoetterl-Glausch wrote: On Tue, 2023-01-17 at 08:30 +0100, Thomas Huth wrote: On 16/01/2023 22.09, Nina Schoetterl-Glausch wrote: On Thu, 2023-01-05 at 15:53 +0100, Pierre Mo

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-01-18 Thread Stefan Hajnoczi
On Sun, 15 Jan 2023 at 12:21, Anton Kuchin wrote: > > Now any vhost-user-fs device makes VM unmigratable, that also prevents > qemu update without stopping the VM. In most cases that makes sense > because qemu has no way to transfer FUSE session state. > > But we can give an option to orchestrator

Re: float tests are too verbose (was: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default)

2023-01-18 Thread Alex Bennée
Thomas Huth writes: > On 17/01/2023 11.44, Daniel P. Berrangé wrote: > ... >> And what i think is test float being overly verbose >>>> Testing f16_le_quiet >>46464 tests total. >> 1 >> 2 >> 3 >> 4 >>46464 tests performed. >> Could be written as >>

Re: [PATCH v14 09/11] qapi/s390/cpu topology: monitor query topology information

2023-01-18 Thread Pierre Morel
On 1/12/23 13:10, Daniel P. Berrangé wrote: On Thu, Jan 05, 2023 at 03:53:11PM +0100, Pierre Morel wrote: Reporting the current topology informations to the admin through the QEMU monitor. Signed-off-by: Pierre Morel --- qapi/machine-target.json | 66 ++ i

Re: [PATCH v14 09/11] qapi/s390/cpu topology: monitor query topology information

2023-01-18 Thread Pierre Morel
On 1/12/23 12:48, Thomas Huth wrote: On 05/01/2023 15.53, Pierre Morel wrote: Reporting the current topology informations to the admin through the QEMU monitor. Signed-off-by: Pierre Morel --- ... diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx index 754b1e8408..5730a47f71 100644

Re: [PATCH 0/3] Remove C virtiofsd

2023-01-18 Thread Stefan Hajnoczi
On Wed, 18 Jan 2023 at 10:40, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > We deprecated the C virtiofsd in commit 34deee7b6a1418f3d62a > in v7.0 in favour of the Rust implementation at > > https://gitlab.com/virtio-fs/virtiofsd > > since then, the Rust version has

Re: [PATCH 0/3] Remove C virtiofsd

2023-01-18 Thread Stefan Hajnoczi
Acked-by: Stefan Hajnoczi

Re: [PATCH 2/3] avocado_qemu: add AVOCADO_DEFAULT_ARCH for cross-arch tests

2023-01-18 Thread Daniel Henrique Barboza
On 1/18/23 12:23, Fabiano Rosas wrote: Daniel Henrique Barboza writes: All avocado tests that are arch agnostic (i.e. does not set an 'arch' tag) are run with arch=None in pick_default_qemu_bin(), and then 'arch' is set to os.uname()[4], meaning that it will take the arch of the running hos

Re: [PATCH v14 09/11] qapi/s390/cpu topology: monitor query topology information

2023-01-18 Thread Daniel P . Berrangé
On Wed, Jan 18, 2023 at 04:58:05PM +0100, Pierre Morel wrote: > > > On 1/12/23 13:10, Daniel P. Berrangé wrote: > > On Thu, Jan 05, 2023 at 03:53:11PM +0100, Pierre Morel wrote: > > > Reporting the current topology informations to the admin through > > > the QEMU monitor. > > > > > > Signed-off-

Re: [PATCH v2 2/4] bulk: Coding style fixes

2023-01-18 Thread Thomas Huth
On 11/01/2023 09.39, Philippe Mathieu-Daudé wrote: Fix the following checkpatch.pl violation on lines using the TARGET_FMT_plx definition to avoid: WARNING: line over 80 characters It's just a warning... @@ -420,8 +421,9 @@ static int get_segment_6xx_tlb(CPUPPCState *env, mmu_ctx_t *ctx,

Re: [PATCH v5 2/2] riscv: Allow user to set the satp mode

2023-01-18 Thread Alexandre Ghiti
Hey Andrew, On Tue, Jan 17, 2023 at 5:31 PM Andrew Jones wrote: > > On Fri, Jan 13, 2023 at 11:34:53AM +0100, Alexandre Ghiti wrote: > > RISC-V specifies multiple sizes for addressable memory and Linux probes for > > the machine's support at startup via the satp CSR register (done in > > csr.c:va

Re: completion timeouts with pin-based interrupts in QEMU hw/nvme

2023-01-18 Thread Keith Busch
On Wed, Jan 18, 2023 at 03:04:06PM +, Peter Maydell wrote: > On Tue, 17 Jan 2023 at 19:21, Guenter Roeck wrote: > > Anyway - any idea what to do to help figuring out what is happening ? > > Add tracing support to pci interrupt handling, maybe ? > > For intermittent bugs, I like recording the

[PATCH v2] ppc/pegasos2: Improve readability of VIA south bridge creation

2023-01-18 Thread BALATON Zoltan
Slightly improve readability of creating the south bridge by changing type of a local variable to avoid some casts within function arguments which makes some lines shorter and easier to read. Signed-off-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daudé --- v2: Fixed typos in commit message

[RFC PATCH] gitlab: wrap up test results for custom runners

2023-01-18 Thread Alex Bennée
Instead of spewing the whole log to stdout lets just define them as build artefacts so we can examine them later. Where we are running check-tcg run it first as those tests are yet to be integrated into meson. Signed-off-by: Alex Bennée --- .gitlab-ci.d/custom-runners.yml | 1

Re: [PATCH v14 09/11] qapi/s390/cpu topology: monitor query topology information

2023-01-18 Thread Pierre Morel
On 1/18/23 17:08, Daniel P. Berrangé wrote: On Wed, Jan 18, 2023 at 04:58:05PM +0100, Pierre Morel wrote: On 1/12/23 13:10, Daniel P. Berrangé wrote: On Thu, Jan 05, 2023 at 03:53:11PM +0100, Pierre Morel wrote: Reporting the current topology informations to the admin through the QEMU mon

Re: [PATCH 2/2] hw/ppc/pegasos2: Extract via_vt8231_create() helper

2023-01-18 Thread BALATON Zoltan
On Wed, 18 Jan 2023, Philippe Mathieu-Daudé wrote: On 17/1/23 22:17, BALATON Zoltan wrote: On Tue, 17 Jan 2023, Philippe Mathieu-Daudé wrote: Simplify a bit pegasos2_init() by extracting the VIA southbridge creation code into a new via_vt8231_create() helper. Signed-off-by: Philippe Mathieu-Da

Re: [PATCH v2 2/4] bulk: Coding style fixes

2023-01-18 Thread Philippe Mathieu-Daudé
On 18/1/23 17:09, Thomas Huth wrote: On 11/01/2023 09.39, Philippe Mathieu-Daudé wrote: Fix the following checkpatch.pl violation on lines using the TARGET_FMT_plx definition to avoid:    WARNING: line over 80 characters It's just a warning... @@ -420,8 +421,9 @@ static int get_segment_6xx_t

Re: [PATCH v14 10/11] qapi/s390/cpu topology: POLARITY_CHANGE qapi event

2023-01-18 Thread Pierre Morel
On 1/12/23 12:52, Thomas Huth wrote: On 05/01/2023 15.53, Pierre Morel wrote: When the guest asks to change the polarity this change is forwarded to the admin using QAPI. The admin is supposed to take according decisions concerning CPU provisioning. I somehow doubt that an average admin wil

Re: [PATCH v14 11/11] docs/s390x/cpu topology: document s390x cpu topology

2023-01-18 Thread Pierre Morel
On 1/12/23 12:58, Daniel P. Berrangé wrote: On Thu, Jan 05, 2023 at 03:53:13PM +0100, Pierre Morel wrote: Add some basic examples for the definition of cpu topology in s390x. Signed-off-by: Pierre Morel --- docs/system/s390x/cpu-topology.rst | 292 + docs/syst

Re: [PATCH 3/3] avocado_qemu: add AVOCADO_DEFAULT_MACHINE

2023-01-18 Thread Daniel Henrique Barboza
On 1/18/23 12:42, Fabiano Rosas wrote: Daniel Henrique Barboza writes: Allow users to control which machine to use in tests where no particular machine is specified. This is a good way to run tests in a machine that's not the arch default, e.g. for qemu-system-x86_64 tests can be run using

Re: [PATCH 2/3] bsd-user/mmap: use TSA_NO_TSA to suppress clang TSA warnings

2023-01-18 Thread Warner Losh
On Wed, Jan 18, 2023 at 8:12 AM Emanuele Giuseppe Esposito < eespo...@redhat.com> wrote: > > > Am 17/01/2023 um 18:17 schrieb Kevin Wolf: > > Am 17.01.2023 um 17:43 hat Warner Losh geschrieben: > >> On Tue, Jan 17, 2023 at 9:25 AM Kevin Wolf wrote: > >> > >>> Am 17.01.2023 um 17:16 hat Warner Los

Re: [PATCH v4 1/2] arm/kvm: add support for MTE

2023-01-18 Thread Cornelia Huck
On Tue, Jan 17 2023, Richard Henderson wrote: > On 1/11/23 06:13, Cornelia Huck wrote: >> @@ -2136,7 +2136,7 @@ static void machvirt_init(MachineState *machine) >> >> if (vms->mte && (kvm_enabled() || hvf_enabled())) { >> error_report("mach-virt: %s does not support providing "

Re: [PATCH v5 2/2] riscv: Allow user to set the satp mode

2023-01-18 Thread Andrew Jones
On Wed, Jan 18, 2023 at 05:29:43PM +0100, Alexandre Ghiti wrote: > Hey Andrew, > > On Tue, Jan 17, 2023 at 5:31 PM Andrew Jones wrote: > > > > On Fri, Jan 13, 2023 at 11:34:53AM +0100, Alexandre Ghiti wrote: > > > RISC-V specifies multiple sizes for addressable memory and Linux probes > > > for

QEMU iotest 267 failure / assertion in migration code

2023-01-18 Thread Thomas Huth
Hi! I just ran "make check" in a build directory where I did not compile qemu-system-x86_64, and got a failure with iotest 267. Re-running the "check" script directly got me some more information: $ ./check -qcow2 267 QEMU -- "/tmp/qemu/tests/qemu-iotests/../../qemu-system-alpha" -

Re: [PATCH 0/1] hw/ide: share bmdma read and write functions

2023-01-18 Thread Liav Albani
On 1/16/23 22:29, John Snow wrote: On Fri, Jan 13, 2023 at 9:10 AM Liav Albani wrote: On 1/11/23 01:07, Bernhard Beschow wrote: Am 9. Januar 2023 19:24:16 UTC schrieb John Snow : On Tue, Sep 6, 2022 at 10:27 AM Bernhard Beschow wrote: Am 1

Re: QEMU iotest 267 failure / assertion in migration code

2023-01-18 Thread Dr. David Alan Gilbert
* Thomas Huth (th...@redhat.com) wrote: > > Hi! > > I just ran "make check" in a build directory where I did > not compile qemu-system-x86_64, and got a failure with > iotest 267. > > Re-running the "check" script directly got me some more > information: > > $ ./check -qcow2 267 > QEMU

Re: virtio-iommu issue with VFIO device downstream to a PCIe-to-PCI bridge: VFIO devices are not assigned any iommu group

2023-01-18 Thread Jean-Philippe Brucker
On Fri, Jan 13, 2023 at 10:57:00AM -0700, Alex Williamson wrote: > On Fri, 13 Jan 2023 12:39:18 + > Jean-Philippe Brucker wrote: > > > Hi, > > > > On Mon, Jan 09, 2023 at 10:11:19PM +0100, Eric Auger wrote: > > > > Jean, do you have any idea about how to fix that? Do you think we have a > >

Re: virtio-iommu issue with VFIO device downstream to a PCIe-to-PCI bridge: VFIO devices are not assigned any iommu group

2023-01-18 Thread Alex Williamson
On Wed, 18 Jan 2023 18:03:13 + Jean-Philippe Brucker wrote: > On Fri, Jan 13, 2023 at 10:57:00AM -0700, Alex Williamson wrote: > > On Fri, 13 Jan 2023 12:39:18 + > > Jean-Philippe Brucker wrote: > > > > > Hi, > > > > > > On Mon, Jan 09, 2023 at 10:11:19PM +0100, Eric Auger wrote: >

Re: [PATCH] target/tricore: Remove unused fields from CPUTriCoreState

2023-01-18 Thread Richard Henderson
On 1/17/23 23:03, Bastian Koppelmann wrote: I'm not sure of the purpose of the hflags. I assume they are hidden flags that hold some hidden state of the emulated CPU. However are privilege levels really hidden state? At least in the TriCore any guest software can read PSW at any privilege level a

Re: virtio-iommu issue with VFIO device downstream to a PCIe-to-PCI bridge: VFIO devices are not assigned any iommu group

2023-01-18 Thread Eric Auger
Hi Jason, On 1/11/23 08:14, Jason Wang wrote: > On Tue, Jan 10, 2023 at 5:11 AM Eric Auger wrote: >> >> Hi, >> >> On 1/9/23 14:24, Eric Auger wrote: >>> Hi, >>> >>> we have a trouble with virtio-iommu and protected assigned devices >>> downstream to a pcie-to-pci bridge. In that use case we obser

Re: virtio-iommu issue with VFIO device downstream to a PCIe-to-PCI bridge: VFIO devices are not assigned any iommu group

2023-01-18 Thread Eric Auger
Hi Jean, On 1/13/23 13:39, Jean-Philippe Brucker wrote: > Hi, > > On Mon, Jan 09, 2023 at 10:11:19PM +0100, Eric Auger wrote: >>> Jean, do you have any idea about how to fix that? Do you think we have a >>> trouble in the acpi/viot setup or virtio-iommu probe sequence. It looks >>> like virtio pr

Re: virtio-iommu issue with VFIO device downstream to a PCIe-to-PCI bridge: VFIO devices are not assigned any iommu group

2023-01-18 Thread Eric Auger
Hi, On 1/18/23 19:28, Alex Williamson wrote: > On Wed, 18 Jan 2023 18:03:13 + > Jean-Philippe Brucker wrote: > >> On Fri, Jan 13, 2023 at 10:57:00AM -0700, Alex Williamson wrote: >>> On Fri, 13 Jan 2023 12:39:18 + >>> Jean-Philippe Brucker wrote: >>> Hi, On Mon, Jan 09

Re: [PATCH RFC 06/21] madvise: Add QEMU_MADV_COLLAPSE

2023-01-18 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > MADV_COLLAPSE is a new madvise() on Linux. Define it. I'd probably have merged this with the MADV_SPLIT one since they go together; but also, it would be good in the commit message for Qemu to include either the definition or a pointer to the kernel definit

Re: [PATCH v4 4/5] hw/arm/aspeed: Add aspeed_eeprom.c

2023-01-18 Thread Peter Delevoryas
On Wed, Jan 18, 2023 at 11:31:57AM +0100, Cédric Le Goater wrote: > On 1/18/23 03:42, Peter Delevoryas wrote: > > - Create aspeed_eeprom.c and aspeed_eeprom.h > > - Include aspeed_eeprom.c in CONFIG_ASPEED meson source files > > - Include aspeed_eeprom.h in aspeed.c > > - Add fby35_bmc_fruid data >

Re: [PATCH v2] target/tricore: Remove unused fields from CPUTriCoreState

2023-01-18 Thread Richard Henderson
On 1/17/23 23:33, Philippe Mathieu-Daudé wrote: Remove dead code: - unused fields in CPUTriCoreState - (unexisting) tricore_def_t structure - forward declaration of tricore_boot_info structure (declared in "hw/tricore/tricore.h", used once in hw/tricore/tricore_testboard.c). Reviewed-by:

Re: [PULL v1 0/2] Merge tpm 2023/01/17 v1

2023-01-18 Thread Peter Maydell
On Tue, 17 Jan 2023 at 12:09, Stefan Berger wrote: > > Hello, > > this PR addresses issues where QEMU may hang during test runs. > > Regards, >Stefan > > The following changes since commit fb7e7990342e59cf67dbd895c1a1e3fb1741df7a: > > tests/qtest/qom-test: Do not print tested properties by

Re: [PATCH 0/8] hw/cxl: CXL emulation cleanups and minor fixes for upstream

2023-01-18 Thread Gregory Price
1) No stack traces present 2) Device usage appears to work, but cxl-cli fails to create a region, i haven't checked why yet (also tried ndctl-75, same results) 3) There seems to be some other regression with the cxl_pmem_init routine, because I get a stack trace in this setup regardless of whethe

Re: [PATCH 0/8] hw/cxl: CXL emulation cleanups and minor fixes for upstream

2023-01-18 Thread Gregory Price
I apparently forgot an intro lol I tested the DOE linux branch with the 2023-1-11 QEMU branch with both volatile, non-volatile, and "legacy" (pre-my-patch) non-volatile mode. 1) *In volatile mode, there are no stack traces present (during boot*) On Wed, Jan 18, 2023 at 02:22:08PM -0500, Gregory

[PATCH 12/20] target/arm: Wrap arm_rebuild_hflags calls with tcg_enabled

2023-01-18 Thread Fabiano Rosas
This is in preparation to moving the hflags code into its own file under the tcg/ directory. Signed-off-by: Fabiano Rosas Reviewed-by: Richard Henderson --- hw/arm/boot.c | 6 +- hw/intc/armv7m_nvic.c | 20 +--- target/arm/arm-powerctl.c | 7 +-- target

[PATCH 02/20] target/arm: wrap psci call with tcg_enabled

2023-01-18 Thread Fabiano Rosas
From: Claudio Fontana for "all" builds (tcg + kvm), we want to avoid doing the psci check if tcg is built-in, but not enabled. Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson Signed-off-by: Fabiano Rosas --- target/arm/helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deleti

[PATCH 18/20] tests/qtest: Restrict bcm2835-dma-test to CONFIG_RASPI

2023-01-18 Thread Fabiano Rosas
We will soon enable the build without TCG, which does not support many machines, so only run the bcm2835-dma-test when the corresponding machine is present. Signed-off-by: Fabiano Rosas Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- tests/qtest

[PATCH 01/20] target/arm: rename handle_semihosting to tcg_handle_semihosting

2023-01-18 Thread Fabiano Rosas
From: Claudio Fontana make it clearer from the name that this is a tcg-only function. Signed-off-by: Claudio Fontana Signed-off-by: Fabiano Rosas Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- target/arm/helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH 04/20] target/arm: Move PC alignment check

2023-01-18 Thread Fabiano Rosas
Move this earlier to make the next patch diff cleaner. While here update the comment slightly to not give the impression that the misalignment affects only TCG. Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Fabiano Rosas --- target/arm/machine.c | 18 +++

[PATCH 17/20] target/arm: Move cortex sysregs into cpregs.c

2023-01-18 Thread Fabiano Rosas
The file cpu_tcg.c is about to be moved into the tcg/ directory, so move the register definitions into cpregs.c along with all the others. Signed-off-by: Fabiano Rosas Reviewed-by: Richard Henderson --- target/arm/cpregs.c| 59 ++ target/arm/cpregs.h

[PATCH 07/20] target/arm: Move define_debug_regs() to cpregs.c

2023-01-18 Thread Fabiano Rosas
The debug_helper.c file will move into a tcg-specific directory, so take the cpregs code out of it. That code needs to be present in KVM builds as well. Signed-off-by: Fabiano Rosas Reviewed-by: Richard Henderson --- target/arm/cpregs.c | 384 ++ target

[PATCH 15/20] target/arm: Don't access TCG code when debugging with KVM

2023-01-18 Thread Fabiano Rosas
When TCG is disabled this part of the code should not be reachable, so wrap it with an ifdef for now. Signed-off-by: Fabiano Rosas Reviewed-by: Richard Henderson --- target/arm/ptw.c | 4 1 file changed, 4 insertions(+) diff --git a/target/arm/ptw.c b/target/arm/ptw.c index 4bda0590c7..2a

[PATCH 09/20] target/arm: move translate modules to tcg/

2023-01-18 Thread Fabiano Rosas
Introduce the target/arm/tcg directory. Its purpose is to hold the TCG code that is selected by CONFIG_TCG. Signed-off-by: Claudio Fontana Signed-off-by: Fabiano Rosas Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- MAINTAINERS

[PATCH 20/20] tests/avocado: Tag TCG tests with accel:tcg

2023-01-18 Thread Fabiano Rosas
This allows the test to be skipped when TCG is not present in the QEMU binary. Signed-off-by: Fabiano Rosas Reviewed-by: Richard Henderson --- tests/avocado/boot_linux_console.py | 1 + tests/avocado/reverse_debugging.py | 8 2 files changed, 9 insertions(+) diff --git a/tests/avocad

[PATCH 00/20] target/arm: CONFIG_TCG=n part 1

2023-01-18 Thread Fabiano Rosas
These are the already reviewed patches from the first half of my previous series: https://lore.kernel.org/r/20230113140419.4013-1-faro...@suse.de This unbreaks the --disable-tcg build, but there are issues in runtime that are still being hashed out in the other series. For the build _with_ TCG, t

[PATCH 08/20] target/arm: Wrap breakpoint/watchpoint updates with tcg_enabled

2023-01-18 Thread Fabiano Rosas
This is in preparation for moving debug_helper.c into a TCG-specific directory. Signed-off-by: Fabiano Rosas Reviewed-by: Richard Henderson --- target/arm/cpu.c | 6 -- target/arm/machine.c | 7 +-- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/target/arm/cpu.c b/ta

[PATCH 10/20] target/arm: move helpers to tcg/

2023-01-18 Thread Fabiano Rosas
From: Claudio Fontana Signed-off-by: Claudio Fontana Signed-off-by: Fabiano Rosas Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- target/arm/meson.build | 16 ++-- target/arm/tcg-stubs.c | 23 +++ target/arm/{

[PATCH 11/20] target/arm: Move psci.c into the tcg directory

2023-01-18 Thread Fabiano Rosas
From: Claudio Fontana Signed-off-by: Claudio Fontana Signed-off-by: Fabiano Rosas Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée --- target/arm/meson.build | 1 - target/arm/tcg/meson.build | 4 target/arm/{ => tcg}/psci.c | 0 3 files changed, 4 insertions(+), 1 deletion

[PATCH 03/20] target/arm: wrap call to aarch64_sve_change_el in tcg_enabled()

2023-01-18 Thread Fabiano Rosas
From: Claudio Fontana Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson Signed-off-by: Fabiano Rosas --- target/arm/helper.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index 7c39280a83..96a668989b 1006

[PATCH 13/20] target/arm: Move hflags code into the tcg directory

2023-01-18 Thread Fabiano Rosas
The hflags are used only for TCG code, so introduce a new file hflags.c to keep that code. Signed-off-by: Fabiano Rosas Reviewed-by: Richard Henderson --- target/arm/helper.c| 361 +--- target/arm/internals.h | 2 + target/arm/tcg-stubs.c | 4

[PATCH 14/20] target/arm: Move regime_using_lpae_format into internal.h

2023-01-18 Thread Fabiano Rosas
This function is needed by common code (ptw.c), so move it along with the other regime_* functions in internal.h. When we enable the build without TCG, the tlb_helper.c file will not be present. Signed-off-by: Fabiano Rosas Reviewed-by: Richard Henderson --- target/arm/internals.h | 21 +++

[PATCH 19/20] tests/avocado: Skip tests that require a missing accelerator

2023-01-18 Thread Fabiano Rosas
If a test was tagged with the "accel" tag and the specified accelerator it not present in the qemu binary, cancel the test. We can now write tests without explicit calls to require_accelerator, just the tag is enough. Signed-off-by: Fabiano Rosas Reviewed-by: Richard Henderson --- tests/avocad

[PATCH 05/20] target/arm: Move cpregs code out of cpu.h

2023-01-18 Thread Fabiano Rosas
Since commit cf7c6d1004 ("target/arm: Split out cpregs.h") we now have a cpregs.h header which is more suitable for this code. Code moved verbatim. Signed-off-by: Fabiano Rosas Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- target/arm/cpregs.h | 98

[PATCH 16/20] cpu-defs.h: Expose CPUTLBEntryFull to non-TCG code

2023-01-18 Thread Fabiano Rosas
This struct has no dependencies on TCG code and it is being used in target/arm/ptw.c to simplify the passing around of page table walk results. Those routines can be reached by KVM code via the gdbstub breakpoint code, so take the structure out of CONFIG_TCG to make it visible when building with --

[RFC 3/3] virtio-blk: add iothread-vq-mapping parameter

2023-01-18 Thread Stefan Hajnoczi
Add the iothread-vq-mapping parameter to assign virtqueues to IOThreads. Note that this commit simply adds the VirtIOBlock->iothread_vq_mapping_list field but does not use it yet. The block layer doesn't support multi-queue yet, so we cannot safely process virtqueues from multiple IOThreads at thi

[RFC 0/3] virtio-blk: add iothread-vq-mapping parameter

2023-01-18 Thread Stefan Hajnoczi
This is a preview of the iothread-vq-mapping parameter that assigns virtqueues to IOThreads. The syntax is implemented but multiple IOThreads are not actually supported yet. The purpose of this RFC is to reach agreement on the syntax and to prepare for libvirt support. virtio-blk and virtio-scsi d

[RFC 2/3] qdev: add IOThreadVirtQueueMappingList property type

2023-01-18 Thread Stefan Hajnoczi
virtio-blk and virtio-scsi devices will need a way to specify the mapping between IOThreads and virtqueues. At the moment all virtqueues are assigned to a single IOThread or the main loop. This single thread can be a CPU bottleneck, so it is necessary to allow finer-grained assignment to spread the

[RFC 1/3] qdev-properties: alias all object class properties

2023-01-18 Thread Stefan Hajnoczi
qdev_alias_all_properties() aliases a DeviceState's qdev properties onto an Object. This is used for VirtioPCIProxy types so that --device virtio-blk-pci has properties of its embedded --device virtio-blk-device object. Currently this function is implemented using qdev properties. Change the funct

Re: [PATCH RFC 06/21] madvise: Add QEMU_MADV_COLLAPSE

2023-01-18 Thread Peter Xu
On Wed, Jan 18, 2023 at 06:51:07PM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > MADV_COLLAPSE is a new madvise() on Linux. Define it. > > I'd probably have merged this with the MADV_SPLIT one since they go > together; but also, it would be good in the commit me

Integrating with new Intel DSA hardware offloading

2023-01-18 Thread Hao Xiang .
Hi everyone, I am looking into using the new Data Streaming Accelerator (DSA) hardware acceleration feature built into the Intel Sapphire Rapids system. One of the scenarios I am investigating is the QEMU live migration feature. I noticed that during live migration, there is pretty busy work check

Re: [PATCH 00/20] target/arm: CONFIG_TCG=n part 1

2023-01-18 Thread Philippe Mathieu-Daudé
Hi Fabiano, On 18/1/23 20:34, Fabiano Rosas wrote: These are the already reviewed patches from the first half of my previous series: https://lore.kernel.org/r/20230113140419.4013-1-faro...@suse.de This unbreaks the --disable-tcg build, but there are issues in runtime that are still being hashed

Re: [PATCH 00/20] target/arm: CONFIG_TCG=n part 1

2023-01-18 Thread Fabiano Rosas
Philippe Mathieu-Daudé writes: > Hi Fabiano, > > On 18/1/23 20:34, Fabiano Rosas wrote: >> These are the already reviewed patches from the first half of my >> previous series: >> https://lore.kernel.org/r/20230113140419.4013-1-faro...@suse.de >> >> This unbreaks the --disable-tcg build, but ther

Re: completion timeouts with pin-based interrupts in QEMU hw/nvme

2023-01-18 Thread Keith Busch
Klaus, This isn't going to help your issue, but there are at least two legacy irq bugs in the nvme qemu implementation. 1. The admin queue breaks if start with legacy and later initialize msix. 2. The legacy vector is shared among all queues, but it's being deasserted when the first queue's door

Re: [PATCH v8] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-18 Thread Chuck Zmudzinski
On 1/17/2023 11:27 PM, Alex Williamson wrote: > On Tue, 17 Jan 2023 19:15:57 -0500 > Chuck Zmudzinski wrote: > > > On 1/17/2023 6:04 AM, Igor Mammedov wrote: > > > On Mon, 16 Jan 2023 13:00:53 -0500 > > > Chuck Zmudzinski wrote: > > > > > > > On 1/16/23 10:33, Igor Mammedov wrote: > > > > > O

Re: [PATCH] tcg/riscv: Use tcg_pcrel_diff in tcg_out_ldst

2023-01-18 Thread Alistair Francis
On Wed, Jan 18, 2023 at 9:05 AM Richard Henderson wrote: > > We failed to update this with the w^x split, so misses the fact > that true pc-relative offsets are usually small. > > Signed-off-by: Richard Henderson Thanks! Applied to riscv-to-apply.next Alistair > --- > tcg/riscv/tcg-target.c.

Re: [PATCH v8 1/3] hw/riscv/boot.c: consolidate all kernel init in riscv_load_kernel()

2023-01-18 Thread Alistair Francis
On Mon, Jan 16, 2023 at 10:31 PM Daniel Henrique Barboza wrote: > > The microchip_icicle_kit, sifive_u, spike and virt boards are now doing > the same steps when '-kernel' is used: > > - execute load_kernel() > - load init_rd() > - write kernel_cmdline > > Let's fold everything inside riscv_load_k

Re: [PATCH v8 3/3] hw/riscv: clear kernel_entry higher bits in load_elf_ram_sym()

2023-01-18 Thread Alistair Francis
On Mon, Jan 16, 2023 at 10:46 PM Daniel Henrique Barboza wrote: > > > > On 1/16/23 09:37, Philippe Mathieu-Daudé wrote: > > On 16/1/23 13:29, Daniel Henrique Barboza wrote: > >> Recent hw/risc/boot.c changes caused a regression in an use case with > >> the Xvisor hypervisor. Running a 32 bit QEMU

Re: [PATCH 1/2] target/arm: Introduce helper_set_rounding_mode_chkfrm

2023-01-18 Thread Alistair Francis
On Mon, Jan 16, 2023 at 2:08 AM Richard Henderson wrote: > > The new helper always validates the contents of FRM, even > if the new rounding mode is not DYN. This is required by > the vector unit. > > Track whether we've validated FRM separately from whether > we've updated fp_status with a given

Re: [PATCH 2/2] target/riscv: Remove helper_set_rod_rounding_mode

2023-01-18 Thread Alistair Francis
On Mon, Jan 16, 2023 at 2:08 AM Richard Henderson wrote: > > The only setting of RISCV_FRM_ROD is from the vector unit, > and now handled by helper_set_rounding_mode_chkfrm. > This helper is now unused. > > Signed-off-by: Richard Henderson Reviewed-by: Alistair Francis Alistair > --- > targe

Re: [PATCH 1/1] hw/riscv/virt.c: move create_fw_cfg() back to virt_machine_init()

2023-01-18 Thread Alistair Francis
On Tue, Jan 17, 2023 at 11:28 PM Daniel Henrique Barboza wrote: > > Commit 1c20d3ff6004 ("hw/riscv: virt: Add a machine done notifier") > moved the initialization of fw_cfg to the virt_machine_done() callback. > > Problem is that the validation of fw_cfg by devices such as ramfb is > done before t

Re: completion timeouts with pin-based interrupts in QEMU hw/nvme

2023-01-18 Thread Keith Busch
On Wed, Jan 18, 2023 at 09:33:05AM -0700, Keith Busch wrote: > On Wed, Jan 18, 2023 at 03:04:06PM +, Peter Maydell wrote: > > On Tue, 17 Jan 2023 at 19:21, Guenter Roeck wrote: > > > Anyway - any idea what to do to help figuring out what is happening ? > > > Add tracing support to pci interrup

Re: [PATCH v8 3/3] hw/riscv: clear kernel_entry higher bits in load_elf_ram_sym()

2023-01-18 Thread Daniel Henrique Barboza
On 1/18/23 19:45, Alistair Francis wrote: On Mon, Jan 16, 2023 at 10:46 PM Daniel Henrique Barboza wrote: On 1/16/23 09:37, Philippe Mathieu-Daudé wrote: On 16/1/23 13:29, Daniel Henrique Barboza wrote: Recent hw/risc/boot.c changes caused a regression in an use case with the Xvisor hype

Re: [PATCH 1/2] target/arm: Introduce helper_set_rounding_mode_chkfrm

2023-01-18 Thread Alistair Francis
On Wed, Jan 18, 2023 at 8:02 PM Daniel Henrique Barboza wrote: > > s/arm/riscv in subject/commit title ^ Fixed when committing Thanks! Applied to riscv-to-apply.next Alistair > > On 1/15/23 13:06, Richard Henderson wrote: > > The new helper always validates the contents of FRM, even > if the

Re: [PATCH v8 3/3] hw/riscv: clear kernel_entry higher bits in load_elf_ram_sym()

2023-01-18 Thread Bin Meng
On Mon, Jan 16, 2023 at 8:37 PM Philippe Mathieu-Daudé wrote: > > On 16/1/23 13:29, Daniel Henrique Barboza wrote: > > Recent hw/risc/boot.c changes caused a regression in an use case with > > the Xvisor hypervisor. Running a 32 bit QEMU guest with '-kernel' > > stopped working. The reason seems t

Re: [PATCH v8 3/3] hw/riscv: clear kernel_entry higher bits in load_elf_ram_sym()

2023-01-18 Thread Bin Meng
On Mon, Jan 16, 2023 at 8:30 PM Daniel Henrique Barboza wrote: > > Recent hw/risc/boot.c changes caused a regression in an use case with > the Xvisor hypervisor. Running a 32 bit QEMU guest with '-kernel' > stopped working. The reason seems to be that Xvisor is using 64 bit to > encode the 32 bit

Re: [PATCH 1/1] hw/riscv/virt.c: move create_fw_cfg() back to virt_machine_init()

2023-01-18 Thread Alistair Francis
On Tue, Jan 17, 2023 at 11:28 PM Daniel Henrique Barboza wrote: > > Commit 1c20d3ff6004 ("hw/riscv: virt: Add a machine done notifier") > moved the initialization of fw_cfg to the virt_machine_done() callback. > > Problem is that the validation of fw_cfg by devices such as ramfb is > done before t

Re: [PATCH v5 2/2] riscv: Allow user to set the satp mode

2023-01-18 Thread Alistair Francis
On Wed, Jan 18, 2023 at 10:19 PM Andrew Jones wrote: > > On Wed, Jan 18, 2023 at 10:28:46AM +1000, Alistair Francis wrote: > > On Wed, Jan 18, 2023 at 2:32 AM Andrew Jones > > wrote: > > > > > > On Fri, Jan 13, 2023 at 11:34:53AM +0100, Alexandre Ghiti wrote: > ... > > > > + > > > > +/* Get

Re: [PATCH v2 1/6] hw/riscv/boot.c: calculate fdt size after fdt_pack()

2023-01-18 Thread Alistair Francis
On Tue, Jan 17, 2023 at 3:35 AM Daniel Henrique Barboza wrote: > > fdt_pack() can change the fdt size, meaning that fdt_totalsize() can > contain a now deprecated (bigger) value. > > Signed-off-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis Alistair > --- > hw/riscv/boot.c | 7 +++

Re: completion timeouts with pin-based interrupts in QEMU hw/nvme

2023-01-18 Thread Alistair Francis
On Thu, Jan 19, 2023 at 9:07 AM Keith Busch wrote: > > On Wed, Jan 18, 2023 at 09:33:05AM -0700, Keith Busch wrote: > > On Wed, Jan 18, 2023 at 03:04:06PM +, Peter Maydell wrote: > > > On Tue, 17 Jan 2023 at 19:21, Guenter Roeck wrote: > > > > Anyway - any idea what to do to help figuring out

Re: [PATCH v2 2/5] target/riscv: Update VS timer whenever htimedelta changes

2023-01-18 Thread Alistair Francis
On Mon, Jan 16, 2023 at 3:20 PM Anup Patel wrote: > > Hi Alistair, > > On Tue, Jan 3, 2023 at 9:43 PM Anup Patel wrote: > > > > Hi Alistair, > > > > On Wed, Dec 28, 2022 at 11:08 AM Alistair Francis > > wrote: > > > > > > On Fri, Dec 23, 2022 at 11:14 PM Anup Patel > > > wrote: > > > > > > >

Re: [PATCH v2 2/6] hw/riscv: split fdt address calculation from fdt load

2023-01-18 Thread Alistair Francis
On Tue, Jan 17, 2023 at 3:35 AM Daniel Henrique Barboza wrote: > > A common trend in other archs is to calculate the fdt address, which is > usually straightforward, and then calling a function that loads the > fdt/dtb by using that address. > > riscv_load_fdt() is doing a bit too much in comparis

Re: [PATCH v2 4/6] hw/riscv/virt.c: calculate socket count once in create_fdt_imsic()

2023-01-18 Thread Alistair Francis
On Tue, Jan 17, 2023 at 3:36 AM Daniel Henrique Barboza wrote: > > riscv_socket_count() returns either ms->numa_state->num_nodes or 1 > depending on NUMA support. In any case the value can be retrieved only > once and used in the rest of the function. > > This will also alleviate the rename we're

Re: [PATCH v2 5/6] hw/riscv/virt.c: rename MachineState 'mc' pointers to 'ms'

2023-01-18 Thread Alistair Francis
On Tue, Jan 17, 2023 at 3:36 AM Daniel Henrique Barboza wrote: > > We have a convention in other QEMU boards/archs to name MachineState > pointers as either 'machine' or 'ms'. MachineClass pointers are usually > called 'mc'. > > The 'virt' RISC-V machine has a lot of instances where MachineState >

Re: [PATCH v2 6/6] hw/riscv/spike.c: rename MachineState 'mc' pointers to' ms'

2023-01-18 Thread Alistair Francis
On Tue, Jan 17, 2023 at 3:35 AM Daniel Henrique Barboza wrote: > > Follow the QEMU convention of naming MachineState pointers as 'ms' by > renaming the instances where we're calling it 'mc'. > > Suggested-by: Philippe Mathieu-Daudé > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Daniel He

Re: [PATCH v2 3/6] hw/riscv: simplify riscv_compute_fdt_addr()

2023-01-18 Thread Alistair Francis
On Tue, Jan 17, 2023 at 3:34 AM Daniel Henrique Barboza wrote: > > All callers are using attributes from the MachineState object. Use a > pointer to it instead of passing dram_size (which is always > machine->ram_size) and fdt (always machine->fdt). > > Signed-off-by: Daniel Henrique Barboza > --

Re: completion timeouts with pin-based interrupts in QEMU hw/nvme

2023-01-18 Thread Keith Busch
On Thu, Jan 19, 2023 at 10:41:42AM +1000, Alistair Francis wrote: > On Thu, Jan 19, 2023 at 9:07 AM Keith Busch wrote: > > --- > > diff --git a/hw/intc/sifive_plic.c b/hw/intc/sifive_plic.c > > index c2dfacf028..f8f7af08dc 100644 > > --- a/hw/intc/sifive_plic.c > > +++ b/hw/intc/sifive_plic.c > >

Re: completion timeouts with pin-based interrupts in QEMU hw/nvme

2023-01-18 Thread Alistair Francis
On Thu, Jan 19, 2023 at 12:44 PM Keith Busch wrote: > > On Thu, Jan 19, 2023 at 10:41:42AM +1000, Alistair Francis wrote: > > On Thu, Jan 19, 2023 at 9:07 AM Keith Busch wrote: > > > --- > > > diff --git a/hw/intc/sifive_plic.c b/hw/intc/sifive_plic.c > > > index c2dfacf028..f8f7af08dc 100644 > >

Announcement of aboring HAXM maintenance

2023-01-18 Thread Wang, Wenchao
Hi, Philippe, Intel decided to abort the development of HAXM and the maintenance of its QEMU part. Should we submit a patch to mark the Guest CPU Cores (HAXM) status as Orphan and remove the maintainers from the corresponding list? Meanwhile, should the code enabling HAX in QEMU once committed

Recall: Announcement of aboring HAXM maintenance

2023-01-18 Thread Wang, Wenchao
Wang, Wenchao would like to recall the message, "Announcement of aboring HAXM maintenance".

Recall: Announcement of aboring HAXM maintenance

2023-01-18 Thread Wang, Wenchao
Wang, Wenchao would like to recall the message, "Announcement of aboring HAXM maintenance".

Announcement of aborting HAXM maintenance

2023-01-18 Thread Wang, Wenchao
Hi, Philippe, Intel decided to abort the development of HAXM and the maintenance of its QEMU part. Should we submit a patch to mark the Guest CPU Cores (HAXM) status as Orphan and remove the maintainers from the corresponding list? Meanwhile, should the code enabling HAX in QEMU once committed

Re: completion timeouts with pin-based interrupts in QEMU hw/nvme

2023-01-18 Thread Keith Busch
On Thu, Jan 19, 2023 at 01:10:57PM +1000, Alistair Francis wrote: > On Thu, Jan 19, 2023 at 12:44 PM Keith Busch wrote: > > > > Further up, it says the "interrupt gateway" is responsible for > > forwarding new interrupt requests while the level remains asserted, but > > it doesn't look like anythi

<    1   2   3   >