Re: [PATCH v12 00/10] migration: Modify 'migrate' and 'migrate-incoming' QAPI commands for migration

2023-10-09 Thread Het Gala
On 10/10/2023 2:34 AM, Fabiano Rosas wrote: Het Gala writes: This is v12 patchset of modified 'migrate' and 'migrate-incoming' QAPI design for upstream review. Would like to thank all the maintainers that actively participated in the v11 patchset discussion and gave insightful suggestions

Re: [PATCH v2 08/58] i386/tdx: Adjust the supported CPUID based on TDX restrictions

2023-10-09 Thread Xiaoyao Li
On 10/10/2023 9:02 AM, Tina Zhang wrote: Hi, On 8/18/23 17:49, Xiaoyao Li wrote: According to Chapter "CPUID Virtualization" in TDX module spec, CPUID bits of TD can be classified into 6 types: 1 | As configured |

Re: [PATCH v2 3/3] target/hexagon: avoid shadowing globals

2023-10-09 Thread Philippe Mathieu-Daudé
On 9/10/23 22:53, Brian Cain wrote: On 9/10/23 08:09, Philippe Mathieu-Daudé wrote: On 6/10/23 00:22, Brian Cain wrote: The typedef `vaddr` is shadowed by `vaddr` identifiers, so we rename the identifiers to avoid shadowing the type name. This one surprises me, since we have other

Re: [PATCH v11 09/10] migration: Implement MigrateChannelList to hmp migration flow.

2023-10-09 Thread Het Gala
On 10/9/2023 8:05 PM, Fabiano Rosas wrote: Het Gala writes: On 10/4/2023 8:55 PM, Fabiano Rosas wrote: Het Gala writes: Integrate MigrateChannelList with all transport backends (socket, exec and rdma) for both src and dest migration endpoints for hmp migration. Suggested-by: Aravind

Re: [PATCH v11 08/10] migration: Implement MigrateChannelList to qmp migration flow.

2023-10-09 Thread Het Gala
On 10/9/2023 7:59 PM, Fabiano Rosas wrote: Het Gala writes: On 10/4/2023 8:51 PM, Fabiano Rosas wrote: Het Gala writes: Integrate MigrateChannelList with all transport backends (socket, exec and rdma) for both src and dest migration endpoints for qmp migration. For current series,

Re: [PATCH] hw/loongarch: remove global loaderparams variable

2023-10-09 Thread Philippe Mathieu-Daudé
Hi Thomas, On 9/10/23 23:00, Thomas Weißschuh wrote: Passing the struct around explicitly makes the control-flow more obvious. Signed-off-by: Thomas Weißschuh --- hw/loongarch/virt.c | 50 - 1 file changed, 27 insertions(+), 23 deletions(-)

[PATCH] hw/ufs: Fix incorrect register fields

2023-10-09 Thread Jeuk Kim
From: Jeuk Kim This patch fixes invalid ufs register fields. This fixes an issue reported by Bin Meng that caused ufs to fail over riscv. Signed-off-by: Jeuk Kim --- include/block/ufs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/block/ufs.h

Re: [PATCH v2 3/3] target/hexagon: avoid shadowing globals

2023-10-09 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 9/10/23 08:09, Philippe Mathieu-Daudé wrote: >> Hi Brian, >> On 6/10/23 00:22, Brian Cain wrote: >>> The typedef `vaddr` is shadowed by `vaddr` identifiers, so we rename the >>> identifiers to avoid shadowing the type name. >> This one surprises me, since we

Re: [Virtio-fs] (no subject)

2023-10-09 Thread Yajun Wu
On 10/9/2023 5:13 PM, Hanna Czenczek wrote: External email: Use caution opening links or attachments On 09.10.23 11:07, Hanna Czenczek wrote: On 09.10.23 10:21, Hanna Czenczek wrote: On 07.10.23 04:22, Yajun Wu wrote: [...] The main motivation of adding VHOST_USER_SET_STATUS is to let

[PATCH v1 0/6] linux-user/loongarch64: Add LSX/LASX sigcontext

2023-10-09 Thread Song Gao
Hi, All. This series adds save/restore sigcontext. We use extctx_flags to choces which sigcontext need save/restore. The extctx_flags default value is EXTCTX_FLAGS_FPU, we need save/restore fpu context. After a LSX/LASX instruction is execed, extctx_flags value change to

[PATCH v1 5/6] linux-user/loongarch64: Add LSX sigcontext save/restore

2023-10-09 Thread Song Gao
Signed-off-by: Song Gao --- linux-user/loongarch64/signal.c | 107 ++-- 1 file changed, 87 insertions(+), 20 deletions(-) diff --git a/linux-user/loongarch64/signal.c b/linux-user/loongarch64/signal.c index 277e9f5757..4b09e50a5f 100644 ---

[PATCH v1 2/6] target/loongarch: Add set_vec_extctx to set LSX/LASX instructions extctx_flags

2023-10-09 Thread Song Gao
Signed-off-by: Song Gao --- target/loongarch/insn_trans/trans_vec.c.inc | 12 target/loongarch/internals.h| 2 ++ 2 files changed, 14 insertions(+) diff --git a/target/loongarch/insn_trans/trans_vec.c.inc b/target/loongarch/insn_trans/trans_vec.c.inc index

[PATCH v1 4/6] linux-user/loongarch64: setup_sigframe() set 'end' context size 0

2023-10-09 Thread Song Gao
See: https://github.com/torvalds/linux/blob/master/arch/loongarch/kernel/signal.c The kernel setup_sigcontext() set end context size 0. Signed-off-by: Song Gao --- linux-user/loongarch64/signal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v1 3/6] linux-user/loongarch64: Fix setup_extcontext alloc wrong fpu_context size

2023-10-09 Thread Song Gao
See: https://github.com/torvalds/linux/blob/master/arch/loongarch/kernel/signal.c The alloc size is sizeof(struct target_fpu_context). Signed-off-by: Song Gao --- linux-user/loongarch64/signal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v1 1/6] target/loongarch: Add env->extctx_flags for user-mode setup extcontext

2023-10-09 Thread Song Gao
extctx_flags only for user-mode, and the default value is EXTCTX_FLAGS_FPU, We only need save/restore fpu context, After a LSX or LASX instruction is execed, the value change to EXTCTX_FLAGS_LSX/LASX, and we need save/restore lsx/lasx context. So if the binary no LSX/LASX instruction We only need

[PATCH v1 6/6] linux-user/loongarch64: Add LASX sigcontext save/restore

2023-10-09 Thread Song Gao
Signed-off-by: Song Gao --- linux-user/loongarch64/signal.c | 67 ++--- 1 file changed, 62 insertions(+), 5 deletions(-) diff --git a/linux-user/loongarch64/signal.c b/linux-user/loongarch64/signal.c index 4b09e50a5f..e5b7688a2e 100644 ---

Re: [Virtio-fs] (no subject)

2023-10-09 Thread Yajun Wu
On 10/9/2023 6:28 PM, German Maglione wrote: External email: Use caution opening links or attachments On Sat, Oct 7, 2023 at 4:23 AM Yajun Wu wrote: On 10/6/2023 6:34 PM, Michael S. Tsirkin wrote: External email: Use caution opening links or attachments On Fri, Oct 06, 2023 at

[PATCH v2 5/7] virtio-net: Return an error when vhost cannot enable RSS

2023-10-09 Thread Akihiko Odaki
vhost requires eBPF for RSS. Even when eBPF is not available, virtio-net reported RSS availability, and raised a warning only after the guest requested RSS, and the guest could not know that RSS is not available. Check RSS availability during device realization and return an error if RSS is

[PATCH v2 7/7] ebpf: Fix RSS error handling

2023-10-09 Thread Akihiko Odaki
calculate_rss_hash() was using hash value 0 to tell if it calculated a hash, but the hash value may be 0 on a rare occasion. Have a distinct bool value for correctness. Fixes: f3fa412de2 ("ebpf: Added eBPF RSS program.") Signed-off-by: Akihiko Odaki --- tools/ebpf/rss.bpf.c | 20

[PATCH v2 0/7] virtio-net RSS/hash report fixes

2023-10-09 Thread Akihiko Odaki
This series contains fixes and improvements for virtio-net RSS and hash reporting feature. V1 -> V2: Added patch "ebpf: Fix RSS error handling". Akihiko Odaki (7): tap: Fix virtio-net header buffer size virtio-net: Copy header only when necessary virtio-net: Disable RSS on reset

[PATCH v2 3/7] virtio-net: Disable RSS on reset

2023-10-09 Thread Akihiko Odaki
RSS is disabled by default. Fixes: 590790297c ("virtio-net: implement RSS configuration command") Signed-off-by: Akihiko Odaki --- hw/net/virtio-net.c | 70 +++-- 1 file changed, 36 insertions(+), 34 deletions(-) diff --git a/hw/net/virtio-net.c

[PATCH v2 1/7] tap: Fix virtio-net header buffer size

2023-10-09 Thread Akihiko Odaki
The largest possible virtio-net header is struct virtio_net_hdr_v1_hash. Fixes: fbbdbddec0 ("tap: allow extended virtio header with hash info") Signed-off-by: Akihiko Odaki --- net/tap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/tap.c b/net/tap.c index

[PATCH v2 4/7] virtio-net: Unify the logic to update NIC state for RSS

2023-10-09 Thread Akihiko Odaki
The code to attach or detach the eBPF program to RSS were duplicated so unify them into one function to save some code. Signed-off-by: Akihiko Odaki --- hw/net/virtio-net.c | 90 ++--- 1 file changed, 36 insertions(+), 54 deletions(-) diff --git

[PATCH v2 2/7] virtio-net: Copy header only when necessary

2023-10-09 Thread Akihiko Odaki
It is necessary to copy the header only for byte swapping. Worse, when byte swapping is not needed, the header can be larger than the buffer due to VIRTIO_NET_F_HASH_REPORT, which results in buffer overflow. Copy the header only when byte swapping is needed. Fixes: e22f0603fb ("virtio-net:

[PATCH v2 6/7] virtio-net: Do not clear VIRTIO_NET_F_RSS

2023-10-09 Thread Akihiko Odaki
Even if eBPF is not available, virtio-net can perform RSS on the user-space if vhost is disabled although such a configuration results in a warning. If vhost is enabled, the configuration will be rejected when realizing the device. Therefore, VIRTIO_NET_F_RSS should not be cleared even if eBPF is

Re: [PULL v2 0/6] vfio queue

2023-10-09 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL v2 00/25] Audio, source reorg, HVF changes for 2023-10-06

2023-10-09 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/20] Q800 for 8.2 patches

2023-10-09 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/15] NBD patches through 2023-10-05

2023-10-09 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/32] -Wshadow=local patches patches for 2023-10-06

2023-10-09 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: qemu direct kernel boot on LoongArch

2023-10-09 Thread maobibo
Thomas, Thanks for reporting this issue. It is the problem of QEMU for LoongArch system, QEMU does not support booting vmlinux with elf format without UEFI bios now. We will add support to boot vmlinux directly on QEMU LoongArch side. Regards Bibo Mao 在 2023/10/10 上午4:13, Thomas Weißschuh

[PULL 2/2] migration/dirtyrate: use QEMU_CLOCK_HOST to report start-time

2023-10-09 Thread Hyman Huang
From: Andrei Gudkov Currently query-dirty-rate uses QEMU_CLOCK_REALTIME as the source for start-time field. This translates to clock_gettime(CLOCK_MONOTONIC), i.e. number of seconds since host boot. This is not very useful. The only reasonable use case of start-time I can imagine is to check

[PULL 0/2] Dirty page rate and dirty page limit 20231010 patches

2023-10-09 Thread Hyman Huang
The following changes since commit 2f3913f4b2ad74baeb5a6f1d36efbd9ecdf1057d: Merge tag 'for_upstream' of https://git.kernel.org/pub/scm/virt/kvm/mst/qemu into staging (2023-10-05 09:01:01 -0400) are available in the Git repository at: https://github.com/newfriday/qemu.git

[PULL 1/2] migration/calc-dirty-rate: millisecond-granularity period

2023-10-09 Thread Hyman Huang
From: Andrei Gudkov This patch allows to measure dirty page rate for sub-second intervals of time. An optional argument is introduced -- calc-time-unit. For example: {"execute": "calc-dirty-rate", "arguments": {"calc-time": 500, "calc-time-unit": "millisecond"} } Millisecond granularity

Re: [QEMU][PATCH v1 2/7] xen: add pseudo RAM region for grant mappings

2023-10-09 Thread Stefano Stabellini
On Mon, 9 Oct 2023, Stefano Stabellini wrote: > On Thu, 5 Oct 2023, Vikram Garhwal wrote: > > From: Juergen Gross > > > > Add a memory region which can be used to automatically map granted > > memory. It is starting at 0x8000ULL in order to be able to > > distinguish it from normal

Re: [QEMU][PATCH v1 7/7] hw: arm: Add grant mapping.

2023-10-09 Thread Stefano Stabellini
On Thu, 5 Oct 2023, Vikram Garhwal wrote: > Enable grant ram mapping support for Xenpvh machine on ARM. > > Signed-off-by: Vikram Garhwal Reviewed-by: Stefano Stabellini > --- > hw/arm/xen_arm.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/arm/xen_arm.c b/hw/arm/xen_arm.c

Re: [QEMU][PATCH v1 6/7] xen: add map and unmap callbacks for grant region

2023-10-09 Thread Stefano Stabellini
On Thu, 5 Oct 2023, Vikram Garhwal wrote: > From: Juergen Gross > > Add the callbacks for mapping/unmapping guest memory via grants to the > special grant memory region. > > Signed-off-by: Juergen Gross > Signed-off-by: Vikram Garhwal This looks good. We need to add a check to make sure we

Re: [QEMU][PATCH v1 5/7] memory: add MemoryRegion map and unmap callbacks

2023-10-09 Thread Stefano Stabellini
On Thu, 5 Oct 2023, Vikram Garhwal wrote: > From: Juergen Gross > > In order to support mapping and unmapping guest memory dynamically to > and from qemu during address_space_[un]map() operations add the map() > and unmap() callbacks to MemoryRegionOps. > > Those will be used e.g. for Xen grant

Re: [QEMU][PATCH v1 4/7] xen: let xen_ram_addr_from_mapcache() return -1 in case of not found entry

2023-10-09 Thread Stefano Stabellini
On Thu, 5 Oct 2023, Vikram Garhwal wrote: > From: Juergen Gross > > Today xen_ram_addr_from_mapcache() will either abort() or return 0 in > case it can't find a matching entry for a pointer value. Both cases > are bad, so change that to return an invalid address instead. > > Signed-off-by:

Re: [QEMU][PATCH v1 3/7] softmmu: let qemu_map_ram_ptr() use qemu_ram_ptr_length()

2023-10-09 Thread Stefano Stabellini
On Thu, 5 Oct 2023, Vikram Garhwal wrote: > From: Juergen Gross > > qemu_map_ram_ptr() and qemu_ram_ptr_length() share quite some code, so > modify qemu_ram_ptr_length() a little bit and use it for > qemu_map_ram_ptr(), too. > > Signed-off-by: Juergen Gross > Signed-off-by: Vikram Garhwal

Re: [PATCH v17 6/9] gfxstream + rutabaga: add initial support for gfxstream

2023-10-09 Thread Gurchetan Singh
On Mon, Oct 9, 2023 at 12:11 AM Marc-André Lureau < marcandre.lur...@redhat.com> wrote: > On Fri, Oct 6, 2023 at 5:09 AM Gurchetan Singh > wrote: > > > > This adds initial support for gfxstream and cross-domain. Both > > features rely on virtio-gpu blob resources and context types, which > >

Re: [QEMU][PATCH v1 2/7] xen: add pseudo RAM region for grant mappings

2023-10-09 Thread Stefano Stabellini
On Thu, 5 Oct 2023, Vikram Garhwal wrote: > From: Juergen Gross > > Add a memory region which can be used to automatically map granted > memory. It is starting at 0x8000ULL in order to be able to > distinguish it from normal RAM. > > For this reason the xen.ram memory region is

Re: [PATCH 1/3] via-ide: Fix legacy mode emulation

2023-10-09 Thread BALATON Zoltan
On Mon, 9 Oct 2023, Mark Cave-Ayland wrote: On 09/10/2023 23:23, BALATON Zoltan wrote: On Mon, 9 Oct 2023, Mark Cave-Ayland wrote: On 08/10/2023 12:08, BALATON Zoltan wrote: On Sun, 8 Oct 2023, Mark Cave-Ayland wrote: On 05/10/2023 23:13, BALATON Zoltan wrote: The initial value for BARs

Re: [QEMU][PATCH v1 1/7] xen: when unplugging emulated devices skip virtio devices

2023-10-09 Thread Stefano Stabellini
On Thu, 5 Oct 2023, Vikram Garhwal wrote: > From: Juergen Gross > > Virtio devices should never be unplugged at boot time, as they are > similar to pci passthrough devices. > > Signed-off-by: Juergen Gross > Signed-off-by: Vikram Garhwal > --- > hw/i386/xen/xen_platform.c | 8 +++- > 1

Re: [PATCH 1/3] via-ide: Fix legacy mode emulation

2023-10-09 Thread Mark Cave-Ayland
On 09/10/2023 23:23, BALATON Zoltan wrote: On Mon, 9 Oct 2023, Mark Cave-Ayland wrote: On 08/10/2023 12:08, BALATON Zoltan wrote: On Sun, 8 Oct 2023, Mark Cave-Ayland wrote: On 05/10/2023 23:13, BALATON Zoltan wrote: The initial value for BARs were set in reset method for emulating legacy

Re: [PATCH 2/3] hw/pci-host: Add emulation of Mai Logic Articia S

2023-10-09 Thread BALATON Zoltan
On Mon, 9 Oct 2023, Mark Cave-Ayland wrote: On 09/10/2023 22:57, BALATON Zoltan wrote: On Mon, 9 Oct 2023, Mark Cave-Ayland wrote: On 08/10/2023 19:08, BALATON Zoltan wrote: On Sun, 8 Oct 2023, Mark Cave-Ayland wrote: On 05/10/2023 23:13, BALATON Zoltan wrote: The Articia S is a generic

Re: [PATCH 2/3] hw/pci-host: Add emulation of Mai Logic Articia S

2023-10-09 Thread Mark Cave-Ayland
On 09/10/2023 22:57, BALATON Zoltan wrote: On Mon, 9 Oct 2023, Mark Cave-Ayland wrote: On 08/10/2023 19:08, BALATON Zoltan wrote: On Sun, 8 Oct 2023, Mark Cave-Ayland wrote: On 05/10/2023 23:13, BALATON Zoltan wrote: The Articia S is a generic chipset supporting several different CPUs that

Re: [PATCH 1/3] via-ide: Fix legacy mode emulation

2023-10-09 Thread BALATON Zoltan
On Mon, 9 Oct 2023, Mark Cave-Ayland wrote: On 08/10/2023 12:08, BALATON Zoltan wrote: On Sun, 8 Oct 2023, Mark Cave-Ayland wrote: On 05/10/2023 23:13, BALATON Zoltan wrote: The initial value for BARs were set in reset method for emulating legacy mode at start but this does not work because

Re: [PATCH v4 03/10] hw/fsi: Introduce IBM's cfam,fsi-slave

2023-10-09 Thread Ninad Palsule
Hello Cedric, Thanks for the review. On 9/11/23 07:19, Cédric Le Goater wrote: On 9/9/23 00:28, Ninad Palsule wrote: This is a part of patchset where IBM's Flexible Service Interface is introduced. The Common FRU Access Macro (CFAM), an address space containing various "engines" that drive

Re: [PATCH 2/3] hw/pci-host: Add emulation of Mai Logic Articia S

2023-10-09 Thread BALATON Zoltan
On Mon, 9 Oct 2023, Mark Cave-Ayland wrote: On 08/10/2023 19:08, BALATON Zoltan wrote: On Sun, 8 Oct 2023, Mark Cave-Ayland wrote: On 05/10/2023 23:13, BALATON Zoltan wrote: The Articia S is a generic chipset supporting several different CPUs that were used on some PPC boards. This is a

Re: [PATCH] target/sparc: Clean up global variable shadowing

2023-10-09 Thread Mark Cave-Ayland
On 09/10/2023 10:24, Philippe Mathieu-Daudé wrote: Fix: target/sparc/translate.c:2823:66: error: declaration shadows a variable in the global scope [-Werror,-Wshadow] static void gen_load_trap_state_at_tl(TCGv_ptr r_tsptr, TCGv_env tcg_env)

Re: [PATCH 2/3] hw/pci-host: Add emulation of Mai Logic Articia S

2023-10-09 Thread Mark Cave-Ayland
On 08/10/2023 19:08, BALATON Zoltan wrote: On Sun, 8 Oct 2023, Mark Cave-Ayland wrote: On 05/10/2023 23:13, BALATON Zoltan wrote: The Articia S is a generic chipset supporting several different CPUs that were used on some PPC boards. This is a minimal emulation of the parts needed for

Re: [PATCH 1/3] via-ide: Fix legacy mode emulation

2023-10-09 Thread Mark Cave-Ayland
On 08/10/2023 12:08, BALATON Zoltan wrote: On Sun, 8 Oct 2023, Mark Cave-Ayland wrote: On 05/10/2023 23:13, BALATON Zoltan wrote: The initial value for BARs were set in reset method for emulating legacy mode at start but this does not work because PCI code resets BARs after calling device

Re: [PATCH v2 3/3] qom: Link multiple numa nodes to device using a new object

2023-10-09 Thread Alex Williamson
On Mon, 9 Oct 2023 13:30:48 +0100 Jonathan Cameron wrote: > On Sun, 8 Oct 2023 01:47:40 +0530 > wrote: > > > From: Ankit Agrawal > > > > NVIDIA GPU's support MIG (Mult-Instance GPUs) feature [1], which allows > > partitioning of the GPU device resources (including device memory) into > >

Re: [PATCH v12 09/10] migration: Implement MigrateChannelList to hmp migration flow.

2023-10-09 Thread Fabiano Rosas
Het Gala writes: > Integrate MigrateChannelList with all transport backends > (socket, exec and rdma) for both src and dest migration > endpoints for hmp migration. > > Suggested-by: Aravind Retnakaran > Signed-off-by: Het Gala > --- > migration/migration-hmp-cmds.c | 15 +-- >

Re: [PATCH v2] misc/pca9552: Fix for pca9552 not getting reset

2023-10-09 Thread Cédric Le Goater
Hello Glenn, On 10/5/23 23:10, Glenn Miles wrote: Testing of the pca9552 device on the powernv platform showed that the reset method was not being called when an instance of the device was realized. This was causing the INPUT0/INPUT1 POR values to be incorrect. Fixed by overriding the parent

Re: [PATCH v12 00/10] migration: Modify 'migrate' and 'migrate-incoming' QAPI commands for migration

2023-10-09 Thread Fabiano Rosas
Het Gala writes: > This is v12 patchset of modified 'migrate' and 'migrate-incoming' QAPI design > for upstream review. > > Would like to thank all the maintainers that actively participated in the v11 > patchset discussion and gave insightful suggestions to improve the patches. > > Link to

[PATCH] hw/loongarch: remove global loaderparams variable

2023-10-09 Thread Thomas Weißschuh
Passing the struct around explicitly makes the control-flow more obvious. Signed-off-by: Thomas Weißschuh --- hw/loongarch/virt.c | 50 - 1 file changed, 27 insertions(+), 23 deletions(-) diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c index

RE: [PATCH V4 10/10] target/arm/kvm: Write CPU state back to KVM on reset

2023-10-09 Thread Salil Mehta via
Hello, Perhaps I need to drop this patch from this patch-set as it is ARM specific. I pulled this from RFC V2 of Virtual CPU Hotplug Support on ARMv8 and is not required by other architectures trying to implement Virtual CPU Hotplug Support.

Re: [PATCH 3/3] vfio/ccw: Remove redundant definition of TYPE_VFIO_CCW

2023-10-09 Thread Cédric Le Goater
On 10/9/23 20:58, Eric Farman wrote: On Mon, 2023-10-09 at 10:20 +0800, Zhenzhong Duan wrote: No functional changes. Signed-off-by: Zhenzhong Duan I see Cedric has already queued this, but FWIW: Reviewed-by: Eric Farman I will take the new tags when I rebase. Thanks, C. ---  

RE: [PATCH v2 3/3] target/hexagon: avoid shadowing globals

2023-10-09 Thread Brian Cain
> -Original Message- > From: Philippe Mathieu-Daudé > Sent: Monday, October 9, 2023 1:43 AM > To: Brian Cain ; qemu-devel@nongnu.org > Cc: arm...@redhat.com; richard.hender...@linaro.org; > peter.mayd...@linaro.org; Matheus Bernardino (QUIC) > ; stefa...@redhat.com; a...@rev.ng; >

Re: [PATCH] ppc/pnv: Add an I2C master controller model

2023-10-09 Thread Cédric Le Goater
Hello Glenn, On 10/9/23 20:05, Glenn Miles wrote: From: Cédric Le Goater Not supported : . 10 bit addresses . multimaster . slave Signed-off-by: Cédric Le Goater Signed-off-by: Glenn Miles [milesg: fixed formatting warning] Overall it looks good ;) Some suggestions for the

[PATCH V4 10/10] target/arm/kvm: Write CPU state back to KVM on reset

2023-10-09 Thread Salil Mehta via
From: Jean-Philippe Brucker When a KVM vCPU is reset following a PSCI CPU_ON call, its power state is not synchronized with KVM at the moment. Because the vCPU is not marked dirty, we miss the call to kvm_arch_put_registers() that writes to KVM's MP_STATE. Force mp_state synchronization.

[PATCH V4 09/10] gdbstub: Add helper function to unregister GDB register space

2023-10-09 Thread Salil Mehta via
Add common function to help unregister the GDB Register Space. This shall be done in context to the CPU unrealization. Signed-off-by: Salil Mehta --- gdbstub/gdbstub.c | 15 +++ include/exec/gdbstub.h | 5 + 2 files changed, 20 insertions(+) diff --git a/gdbstub/gdbstub.c

[PATCH V4 08/10] physmem: Add helper function to destroy CPU AddressSpace

2023-10-09 Thread Salil Mehta via
Virtual CPU Hot-unplug leads to unrealization of a CPU object. This also involves destruction of the CPU AddressSpace. Add common function to help destroy the CPU AddressSpace. Signed-off-by: Salil Mehta --- include/exec/cpu-common.h | 8 include/hw/core/cpu.h | 1 +

[PATCH V4 07/10] hw/acpi: Update ACPI GED framework to support vCPU Hotplug

2023-10-09 Thread Salil Mehta via
ACPI GED shall be used to convey to the guest kernel about any CPU hot-(un)plug events. Therefore, existing ACPI GED framework inside QEMU needs to be enhanced to support CPU hotplug state and events. Co-developed-by: Keqian Zhu Signed-off-by: Keqian Zhu Signed-off-by: Salil Mehta Reviewed-by:

[PATCH V4 06/10] hw/acpi: Update GED _EVT method AML with CPU scan

2023-10-09 Thread Salil Mehta via
OSPM evaluates _EVT method to map the event. The CPU hotplug event eventually results in start of the CPU scan. Scan figures out the CPU and the kind of event(plug/unplug) and notifies it back to the guest. Update the GED AML _EVT method with the call to \\_SB.CPUS.CSCN Also, macro

[PATCH V4 05/10] hw/acpi: Update CPUs AML with cpu-(ctrl)dev change

2023-10-09 Thread Salil Mehta via
CPUs Control device(\\_SB.PCI0) register interface for the x86 arch is based on PCI and is IO port based and hence existing CPUs AML code assumes _CRS objects would evaluate to a system resource which describes IO Port address. But on ARM arch CPUs control device(\\_SB.PRES) register interface is

[PATCH V4 02/10] hw/acpi: Move CPU ctrl-dev MMIO region len macro to common header file

2023-10-09 Thread Salil Mehta via
CPU ctrl-dev MMIO region length could be used in ACPI GED and various other architecture specific places. Move ACPI_CPU_HOTPLUG_REG_LEN macro to more appropriate common header file. Signed-off-by: Salil Mehta Reviewed-by: Alex Bennée Reviewed-by: Jonathan Cameron Reviewed-by: Gavin Shan

[PATCH V4 03/10] hw/acpi: Add ACPI CPU hotplug init stub

2023-10-09 Thread Salil Mehta via
ACPI CPU hotplug related initialization should only happen if ACPI_CPU_HOTPLUG support has been enabled for particular architecture. Add cpu_hotplug_hw_init() stub to avoid compilation break. Signed-off-by: Salil Mehta Reviewed-by: Jonathan Cameron Reviewed-by: Gavin Shan ---

[PATCH V4 04/10] hw/acpi: Init GED framework with CPU hotplug events

2023-10-09 Thread Salil Mehta via
ACPI GED(as described in the ACPI 6.2 spec) can be used to generate ACPI events when OSPM/guest receives an interrupt listed in the _CRS object of GED. OSPM then maps or demultiplexes the event by evaluating _EVT method. This change adds the support of CPU hotplug event initialization in the

[PATCH V4 01/10] accel/kvm: Extract common KVM vCPU {creation, parking} code

2023-10-09 Thread Salil Mehta via
KVM vCPU creation is done once during the initialization of the VM when Qemu thread is spawned. This is common to all the architectures. Hot-unplug of vCPU results in destruction of the vCPU object in QOM but the corresponding KVM vCPU object in the Host KVM is not destroyed and its

[PATCH V4 00/10] Add architecture agnostic code to support vCPU Hotplug

2023-10-09 Thread Salil Mehta via
Virtual CPU hotplug support is being added across various architectures[1][3]. This series adds various code bits common across all architectures: 1. vCPU creation and Parking code refactor [Patch 1] 2. Update ACPI GED framework to support vCPU Hotplug [Patch 4,6,7] 3. ACPI CPUs AML code change

[PATCH v2 2/3] hw/pci-host: Add emulation of Mai Logic Articia S

2023-10-09 Thread BALATON Zoltan
The Articia S is a generic chipset supporting several different CPUs that were among others used on some PPC boards. This is a minimal emulation of the parts needed for emulating the AmigaOne board. Signed-off-by: BALATON Zoltan --- hw/pci-host/Kconfig | 5 + hw/pci-host/articia.c

[PATCH v2 3/3] hw/ppc: Add emulation of AmigaOne XE board

2023-10-09 Thread BALATON Zoltan
The AmigaOne is a rebranded MAI Teron board that uses U-Boot firmware with patches to support AmigaOS and is very similar to pegasos2 so can be easily emulated sharing most code with pegasos2. The reason to emulate it is that AmigaOS comes in different versions for AmigaOne and PegasosII which

[PATCH v2 0/3] Add emulation of AmigaOne XE board

2023-10-09 Thread BALATON Zoltan
Changes in v2: - Update comment and commit message in patch 1 (Mark) - Fix irq mapping in patch 2 (Volker) Regards, BALATON Zoltan BALATON Zoltan (3): via-ide: Fix legacy mode emulation hw/pci-host: Add emulation of Mai Logic Articia S hw/ppc: Add emulation of AmigaOne XE board

[PATCH v2 1/3] via-ide: Fix legacy mode emulation

2023-10-09 Thread BALATON Zoltan
The initial value for BARs were set in reset method for emulating legacy mode at start but this does not work because PCI code resets BARs after calling device reset method. Remove this ineffective default to avoid confusion. Instead move setting the BARs to a callback on writing the PCI config

Re: [PATCH] docs/about: Deprecate the 'next-cube' m68k machine

2023-10-09 Thread Mark Cave-Ayland
On 07/10/2023 08:23, Thomas Huth wrote: (added Natalia who was the GSoC mentor for the NeXT cube work) The machine is incomplete, and unfortunately the hoped-for improvements never happened. So it's maybe best if we mark this machine as deprecated and finally remove it again in case it gets

RE: [PATCH v2 3/3] target/hexagon: avoid shadowing globals

2023-10-09 Thread ltaylorsimpson
> -Original Message- > From: Brian Cain > Sent: Sunday, October 8, 2023 7:50 AM > To: ltaylorsimp...@gmail.com; qemu-devel@nongnu.org > Cc: arm...@redhat.com; richard.hender...@linaro.org; phi...@linaro.org; > peter.mayd...@linaro.org; Matheus Bernardino (QUIC) > ; stefa...@redhat.com;

Re: [PATCH 3/3] vfio/ccw: Remove redundant definition of TYPE_VFIO_CCW

2023-10-09 Thread Eric Farman
On Mon, 2023-10-09 at 10:20 +0800, Zhenzhong Duan wrote: > No functional changes. > > Signed-off-by: Zhenzhong Duan I see Cedric has already queued this, but FWIW: Reviewed-by: Eric Farman > --- >  include/hw/s390x/vfio-ccw.h | 2 -- >  1 file changed, 2 deletions(-) > > diff --git

[PATCH v2 0/6] scripts/migration: Fix analyze-migration.py and add a test

2023-10-09 Thread Fabiano Rosas
was: [PATCH] qtest/migration: Add a test for the analyze-migration script https://lore.kernel.org/r/20230927214756.14117-1-faro...@suse.de The analyze-migration.py script should be kept in sync with the code that generates the migration stream. The addition/removal of sections and flags from the

[PATCH v2 3/6] migration: Add capability parsing to analyze-migration.py

2023-10-09 Thread Fabiano Rosas
The script is broken when the configuration/capabilities section is present. Add support for parsing the capabilities so we can fix it in the next patch. Signed-off-by: Fabiano Rosas --- scripts/analyze-migration.py | 38 1 file changed, 38 insertions(+)

[PATCH v2 1/6] migration: Add the configuration vmstate to the json writer

2023-10-09 Thread Fabiano Rosas
From: Nikolay Borisov Make the migration json writer part of MigrationState struct, allowing the 'configuration' object be serialized to json. This will facilitate the parsing of the 'configuration' object in the next patch that fixes analyze-migration.py for arm. Signed-off-by: Nikolay

[PATCH v2 2/6] migration: Fix analyze-migration.py 'configuration' parsing

2023-10-09 Thread Fabiano Rosas
The 'configuration' state subsections are currently not being parsed and the script fails when analyzing an aarch64 stream: Traceback (most recent call last): File "./scripts/analyze-migration.py", line 625, in dump.read(dump_memory = args.memory) File "./scripts/analyze-migration.py",

[PATCH v2 6/6] tests/qtest/migration: Add a test for the analyze-migration script

2023-10-09 Thread Fabiano Rosas
Add a smoke test that migrates to a file and gives it to the script. It should catch the most annoying errors such as changes in the ram flags. After code has been merged it becomes way harder to figure out what is causing the script to fail, the person making the change is the most likely to

[PATCH v2 4/6] migration: Fix analyze-migration.py when ignore-shared is used

2023-10-09 Thread Fabiano Rosas
The script is currently broken when the x-ignore-shared capability is used: Traceback (most recent call last): File "./scripts/analyze-migration.py", line 656, in dump.read(dump_memory = args.memory) File "./scripts/analyze-migration.py", line 593, in read section.read() File

[PATCH v2 5/6] migration: Fix analyze-migration read operation signedness

2023-10-09 Thread Fabiano Rosas
The migration code uses unsigned values for 16, 32 and 64-bit operations. Fix the script to do the same. This was causing an issue when parsing the migration stream generated on the ppc64 target because one of instance_ids was larger than the 32bit signed maximum: Traceback (most recent call

[PATCH] ppc/pnv: Add an I2C master controller model

2023-10-09 Thread Glenn Miles
From: Cédric Le Goater Not supported : . 10 bit addresses . multimaster . slave Signed-off-by: Cédric Le Goater Signed-off-by: Glenn Miles [milesg: fixed formatting warning] --- hw/ppc/meson.build | 1 + hw/ppc/pnv.c | 26 ++ hw/ppc/pnv_i2c.c | 678

Re: [PATCH 2/3] target/riscv: Support discontinuous PMU counters

2023-10-09 Thread Atish Kumar Patra
On Sun, Oct 8, 2023 at 5:58 PM Alistair Francis wrote: > > On Wed, Oct 4, 2023 at 7:36 PM Rob Bradford wrote: > > > > Hi Atish, > > > > On Tue, 2023-10-03 at 13:25 -0700, Atish Kumar Patra wrote: > > > On Tue, Oct 3, 2023 at 5:51 AM Rob Bradford > > > wrote: > > > > > > > > There is no

Re: [PATCH v4 02/10] hw/fsi: Introduce IBM's scratchpad

2023-10-09 Thread Ninad Palsule
Hello Cedric, On 9/11/23 07:19, Cédric Le Goater wrote: On 9/9/23 00:28, Ninad Palsule wrote: This is a part of patchset where IBM's Flexible Service Interface is introduced. The LBUS device is embeded inside the scratchpad. The scratchpad provides a non-functional registers. There is a 1-1

Re: [PATCH v3 10/10] tests/migration-test: Add a test for postcopy hangs during RECOVER

2023-10-09 Thread Fabiano Rosas
Fabiano Rosas writes: > Peter Xu writes: > >> On Thu, Oct 05, 2023 at 06:10:20PM -0300, Fabiano Rosas wrote: >>> Peter Xu writes: >>> >>> > On Thu, Oct 05, 2023 at 10:37:56AM -0300, Fabiano Rosas wrote: >>> >> >> +/* >>> >> >> + * Make sure both QEMU instances will go into RECOVER

Re: [PATCH v4 02/10] hw/fsi: Introduce IBM's scratchpad

2023-10-09 Thread Ninad Palsule
Hello Cedric, On 9/9/23 03:37, Cédric Le Goater wrote: On 9/9/23 00:28, Ninad Palsule wrote: This is a part of patchset where IBM's Flexible Service Interface is introduced. The LBUS device is embeded inside the scratchpad. The scratchpad embedded Fixed provides a non-functional

[PATCH 2/3] hw/misc/mips_itu: Declare itc_reconfigure() in 'hw/misc/mips_itu.h'

2023-10-09 Thread Philippe Mathieu-Daudé
We already provide "hw/misc/mips_itu.h" to declare prototype related to MIPSITUState. Move itc_reconfigure() declaration there. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/misc/mips_itu.h | 2 ++ target/mips/cpu.h | 3 --- target/mips/tcg/sysemu/cp0_helper.c

[PATCH 3/3] hw/misc/mips_itu: Make MIPSITUState target agnostic

2023-10-09 Thread Philippe Mathieu-Daudé
When prototyping a heterogenous machine including the ITU, we get: include/hw/misc/mips_itu.h:76:5: error: unknown type name 'MIPSCPU' MIPSCPU *cpu0; ^ MIPSCPU is declared in the target specific "cpu.h" header, but we don't want to include it, because "cpu.h" is target specific and

[PATCH 1/3] hw/mips: Merge 'hw/mips/cpudevs.h' with 'target/mips/cpu.h'

2023-10-09 Thread Philippe Mathieu-Daudé
"hw/mips/cpudevs.h" contains declarations which are specific to the MIPS architecture; it doesn't make sense for these to be called from a non-MIPS architecture. Move the declarations to "target/mips/cpu.h". Signed-off-by: Philippe Mathieu-Daudé --- include/hw/mips/cpudevs.h | 14

[PATCH 0/3] hw/mips: Cleanup in preparation of heterogenous prototype

2023-10-09 Thread Philippe Mathieu-Daudé
Prepare few MIPS hardware to be integrated in a heterogeneous machine: - Restrict MIPS-specific HW declaration to target/mips/ - Replace MIPSCPU by ArchCPU in common HW Philippe Mathieu-Daudé (3): hw/mips: Merge 'hw/mips/cpudevs.h' with 'target/mips/cpu.h' hw/misc/mips_itu: Declare

[PATCH v2 1/2] target/s390x/kvm: Turn KVM_CAP_SYNC_REGS into a hard requirement

2023-10-09 Thread Thomas Huth
Since we already require at least kernel 3.15 in the s390x KVM code, we can assume that the KVM_CAP_SYNC_REGS capability is always there. Thus turn this into a hard requirement now. Signed-off-by: Thomas Huth --- target/s390x/kvm/kvm.c | 20 ++-- 1 file changed, 14

[PATCH v2 0/2] target/s390x/kvm: Simplify the synchronization code

2023-10-09 Thread Thomas Huth
KVM_SYNC_GPRS, KVM_SYNC_ACRS, KVM_SYNC_CRS and KVM_SYNC_PREFIX are available since kernel 3.10. Since we already require at least kernel 3.15 in the s390x KVM code, we can also assume that the KVM_CAP_SYNC_REGS sync code is always possible for these registers, and remove the related checks and

[PATCH] Revert "configure: Add workaround for ccache and clang"

2023-10-09 Thread Yonggang Luo
This reverts commit fd0e60530f10078f488fa3e9591cc7db5732989c. According to https://peter.eisentraut.org/blog/2014/12/01/ccache-and-clang-part-3 it's already fixed in new version of ccache According to https://ccache.dev/manual/4.8.html#config_run_second_cpp CCACHE_CPP2 are default to true for

[PATCH v2 2/2] target/s390x/kvm: Simplify the GPRs, ACRs, CRs and prefix synchronization code

2023-10-09 Thread Thomas Huth
KVM_SYNC_GPRS, KVM_SYNC_ACRS, KVM_SYNC_CRS and KVM_SYNC_PREFIX are available since kernel 3.10. Since we already require at least kernel 3.15 in the s390x KVM code, we can also assume that the KVM_CAP_SYNC_REGS sync code is always possible for these registers, and remove the related checks and

  1   2   3   4   >