Re: [Qemu-devel] [PATCH] trace: drop trailing empty strings

On Mon, 18 Jan 2016 20:37:58 +0300 Michael Tokarev <m...@tls.msk.ru> wrote: > 11.01.2016 20:30, Greg Kurz wrote: > > > -virtio_balloon_handle_output(const char *name, uint64_t gpa) "section > > name: %s gpa: %"PRIx64"" > > +virtio_balloon_hand

Re: [Qemu-devel] [PATCH 5/7] target-ppc: gdbstub: fix altivec registers for little-endian guests

On Mon, 18 Jan 2016 13:25:19 +1100 David Gibson <da...@gibson.dropbear.id.au> wrote: > On Fri, Jan 15, 2016 at 04:00:38PM +0100, Greg Kurz wrote: > > Altivec registers are 128-bit wide. They are stored in memory as two > > 64-bit values that must be byteswapped when the g

Re: [Qemu-devel] [PATCH 1/2] 9pfs: use error_report() instead of fprintf(stderr)

On Mon, 18 Jan 2016 17:35:25 +0100 Markus Armbruster <arm...@redhat.com> wrote: > Greg Kurz <gk...@linux.vnet.ibm.com> writes: > > > Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> > > --- I agree to all your suggestions. Thanks ! > > hw/9pf

Re: [Qemu-devel] [PATCH 0/2] 9pfs: fsdev: use error_report() instead of fprintf(stderr)

On Mon, 18 Jan 2016 17:39:28 +0100 Markus Armbruster <arm...@redhat.com> wrote: > Greg Kurz <gk...@linux.vnet.ibm.com> writes: > > > Hi, > > > > This series moves all the 9pfs/fsdev code to use error_report(), with the > > notable exception

Re: [Qemu-devel] [PATCH 1/7] target-ppc: kvm: fix floating point registers sync on little-endian hosts

On Tue, 19 Jan 2016 11:55:10 +1100 David Gibson <da...@gibson.dropbear.id.au> wrote: > On Mon, Jan 18, 2016 at 09:51:56AM +0100, Greg Kurz wrote: > > On Mon, 18 Jan 2016 13:16:44 +1100 > > David Gibson <da...@gibson.dropbear.id.au> wrote: > > > > >

[Qemu-devel] [PATCH] spapr: fix write-past-end-of-array error in cpu core device init code

This fixes a potential QEMU crash introduced by commit 3b542549661. Signed-off-by: Greg Kurz <gr...@kaod.org> --- hw/ppc/spapr_cpu_core.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c index 3a5da09b9902..8b802a

Re: [Qemu-devel] [PATCH] spapr: fix write-past-end-of-array error in cpu core device init code

On Tue, 28 Jun 2016 12:55:07 +1000 David Gibson <da...@gibson.dropbear.id.au> wrote: > On Mon, Jun 27, 2016 at 06:28:15PM +0200, Greg Kurz wrote: > > This fixes a potential QEMU crash introduced by commit 3b542549661. > > > > Signed-off-by: Greg Kurz <gr...

Re: [Qemu-devel] [PATCH] virtio: abort on fatal error instead of just exiting

Igor Mammedov <imamm...@redhat.com> > --- Makes sense indeed. Acked-by: Greg Kurz <gr...@kaod.org> FWIW, there's also a bunch of exit(1) in the device code: $ git grep 'exit(1)' hw/virtio/ hw/*/virtio* hw/*/vhost* hw/block/virtio-blk.c:exit(1); hw/block/virtio-blk.c:

[Qemu-devel] [Bug 1336794] Re: 9pfs does not honor open file handles on unlinked files

** Changed in: qemu Status: Confirmed => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1336794 Title: 9pfs does not honor open file handles on unlinked files Status in QEMU:

[Qemu-devel] [Bug 1336794] Re: 9pfs does not honor open file handles on unlinked files

** Changed in: qemu Status: New => Confirmed ** Changed in: qemu Assignee: (unassigned) => Greg Kurz (gkurz) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1336794 Title: 9pf

[Qemu-devel] [Bug 1527322] Re: segfault in thread-pool.c:246:5:

This issue was fixed with the following upstream commit: http://git.qemu.org/?p=qemu.git;a=commit;h=4b3a4f2d458ca5a7c6c16ac36a8d9ac22cc253d6 Shipped in QEMU 2.5.1 and 2.6. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of

[Qemu-devel] [PATCH] spapr: skip configuration section during migration of older machines

Since QEMU 2.4, we have a configuration section in the migration stream. This must be skipped for older machines, like it is already done for x86. Fixes: 61964c23e5ddd5a33f15699e45ce126f879e3e33 Cc: qemu-sta...@nongnu.org Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- hw/ppc/s

Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr: skip configuration section during migration of older machines

Cc'ing Dave and Juan since this is migration stuff. On Mon, 08 Feb 2016 16:59:47 +0100 Greg Kurz <gk...@linux.vnet.ibm.com> wrote: > Since QEMU 2.4, we have a configuration section in the migration stream. > This must be skipped for older machines, like it is already done for x86

Re: [Qemu-devel] [Qemu-stable] [PATCH] spapr: skip configuration section during migration of older machines

On Mon, 08 Feb 2016 16:59:47 +0100 Greg Kurz <gk...@linux.vnet.ibm.com> wrote: > Since QEMU 2.4, we have a configuration section in the migration stream. > This must be skipped for older machines, like it is already done for x86. > > Fixes: 61964c23e5ddd5a33f15699e45ce126f879e3

Re: [Qemu-devel] [PATCH] hw/intc: fix failure return for xics_alloc_block()

On Mon, 8 Feb 2016 11:45:19 +1000 David Gibson <da...@gibson.dropbear.id.au> wrote: > On Fri, Feb 05, 2016 at 09:43:40AM +0100, Greg Kurz wrote: > > From: Brian W. Hart <ha...@linux.vnet.ibm.com> > > > > xics_alloc_block() does not return a clear error code when

Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr: skip configuration section during migration of older machines

On Mon, 08 Feb 2016 16:59:47 +0100 Greg Kurz <gk...@linux.vnet.ibm.com> wrote: > Since QEMU 2.4, we have a configuration section in the migration stream. > This must be skipped for older machines, like it is already done for x86. > Ouch ! It is more complex than I thought..

Re: [Qemu-devel] [PATCH] migration: fix bad string passed to error_report()

On Thu, 4 Feb 2016 15:30:11 +0530 Amit Shah <amit.s...@redhat.com> wrote: > On (Thu) 04 Feb 2016 [10:20:07], Greg Kurz wrote: > > state->name does not contain a terminating '\0' and you may get: > > > > Machine type received is 'pseries-2.3y�?' and local is 'pser

Re: [Qemu-devel] [PATCH v4 1/6] virtio-net: use the backend cross-endian capabilities

On Fri, 5 Feb 2016 12:33:44 +0100 Cornelia Huck <cornelia.h...@de.ibm.com> wrote: > On Fri, 05 Feb 2016 11:43:11 +0100 > Greg Kurz <gk...@linux.vnet.ibm.com> wrote: > > > +static bool virtio_net_set_vnet_endian(VirtIODevice *vde

[Qemu-devel] [PATCH v2] migration: fix bad string passed to error_report()

state->name does not contain a terminating '\0' and you may get: Machine type received is 'pseries-2.3y�?' and local is 'pseries-2.4' load of migration failed: Invalid argument Let's add a precision modifier to fix this. Reviewed-by: Amit Shah <amit.s...@redhat.com> Signed-off-by: Greg

[Qemu-devel] [PATCH] migration: fix bad string passed to error_report()

state->name does not contain a terminating '\0' and you may get: Machine type received is 'pseries-2.3y�?' and local is 'pseries-2.4' load of migration failed: Invalid argument Let's add a precision modifier to fix this. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> ---

[Qemu-devel] [PATCH v4 0/6] virtio/vhost cross-endian cleanup

ackend devices It impacts patches 1 and 2, that had already been reviewed. Laurent, Cornelia, Could you please ack/nack the changes ? The series is based on Michael Tsirkin's tree: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git pci Thanks. -- Greg --- Greg Kurz (6): virtio-ne

[Qemu-devel] [PATCH v4 1/6] virtio-net: use the backend cross-endian capabilities

edhat.com> Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- v4: - fix bug with multiqueue - rename helper to virtio_net_vnet_endian_status, for better clarity on what it is used for --- hw/net/virtio-net.c | 68 - includ

[Qemu-devel] [PATCH v4 5/6] vhost: simplify vhost_needs_vring_endian()

the assert() either. This open codes the device_endian checking in vhost_needs_vring_endian(). It also adds a comment to explain the logic, as recent reviews showed the cross-endian tweaks aren't that obvious. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- hw/virtio/vhost.c

[Qemu-devel] [PATCH v4 6/6] virtio: optimize virtio_access_is_big_endian() for little-endian targets

a.h...@de.ibm.com> Reviewed-by: Laurent Vivier <lviv...@redhat.com> Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- include/hw/virtio/virtio-access.h |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/hw/virtio/virtio-access.h b/includ

[Qemu-devel] [PATCH] hw/intc: fix failure return for xics_alloc_block()

rt <ha...@linux.vnet.ibm.com> [only pass src and num to trace_xics_alloc_block_failed_no_left, added trace_xics_alloc_block_failed_no_left definition to trace-events] Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- hw/intc/xics.c | 10 ++ hw/ppc/spapr_pci.c |9 +

Re: [Qemu-devel] [PULL 45/49] net: set endianness on all backend devices

by: Michael S. Tsirkin <m...@redhat.com> > Signed-off-by: Michael S. Tsirkin <m...@redhat.com> > Reviewed-by: Greg Kurz <gk...@linux.vnet.ibm.com> > Reviewed-by: Cornelia Huck <cornelia.h...@de.ibm.com> > Reviewed-by: Jason Wang <jasow...@redhat.com> > --

[Qemu-devel] [PATCH v4 2/6] vhost-net: revert support of cross-endian vnet headers

Reviewed-by: Laurent Vivier <lviv...@redhat.com> Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- v4: - also revert Laurent's fix --- hw/net/vhost_net.c | 41 + 1 file changed, 5 insertions(+), 36 deletions(-) diff --git a/hw/net/vhost_ne

Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr: skip configuration section during migration of older machines

On Fri, 12 Feb 2016 16:24:26 +1100 David Gibson <da...@gibson.dropbear.id.au> wrote: > On Thu, Feb 11, 2016 at 04:53:40PM +, Dr. David Alan Gilbert wrote: > > * Greg Kurz (gk...@linux.vnet.ibm.com) wrote: > > > On Mon, 08 Feb 2016 16:59:47 +0100 > > > Gr

Re: [Qemu-devel] [PATCH] hw/intc: fix failure return for xics_alloc_block()

On Mon, 8 Feb 2016 09:31:49 +0100 Greg Kurz <gk...@linux.vnet.ibm.com> wrote: > On Mon, 8 Feb 2016 11:45:19 +1000 > David Gibson <da...@gibson.dropbear.id.au> wrote: > > > On Fri, Feb 05, 2016 at 09:43:40AM +0100, Greg Kurz wrote: > > > From: Bri

[Qemu-devel] [PATCH v4 3/6] virtio: move cross-endian helper to vhost

, where indeed non bi-endian targets don't have to deal with cross-endian issues. This patch moves the helper to vhost.c and gives it a more appropriate name. Reviewed-by: Cornelia Huck <cornelia.h...@de.ibm.com> Reviewed-by: Laurent Vivier <lviv...@redhat.com> Signed-off-by: G

[Qemu-devel] [PATCH v4 4/6] vhost: move virtio 1.0 check to cross-endian helper

Indeed vhost doesn't need to ask for vring endian fixing if the device is virtio 1.0, since it is already handled by the in-kernel vhost driver. This patch simply consolidates the logic into the existing helper. Reviewed-by: Cornelia Huck <cornelia.h...@de.ibm.com> Signed-off-by: Greg Ku

Re: [Qemu-devel] [Qemu-ppc] [PATCH] hw/intc: fix failure return for xics_alloc_block()

On Wed, 10 Feb 2016 10:41:16 +0100 Greg Kurz <gk...@linux.vnet.ibm.com> wrote: > On Mon, 8 Feb 2016 09:31:49 +0100 > Greg Kurz <gk...@linux.vnet.ibm.com> wrote: > > > On Mon, 8 Feb 2016 11:45:19 +1000 > > David Gibson <da...@gibson.dropbear.id.au> wrote:

[Qemu-devel] [PATCH] spapr: disable vmdesc submission for old machines

vmdesc as well for older pseries, like it is already done for pc's. This can only be observed with -cpu POWER7 because POWER8 cannot migrate from QEMU 2.2 to 2.3 (insns_flags2 mismatch). Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- hw/ppc/spapr.c |1 + 1 file changed, 1 ins

Re: [Qemu-devel] [Qemu-ppc] [PATCH] hw/intc: fix failure return for xics_alloc_block()

Just pinging Alexey as well. :) On Tue, 23 Feb 2016 18:46:44 +0100 Greg Kurz <gk...@linux.vnet.ibm.com> wrote: > On Wed, 10 Feb 2016 10:41:16 +0100 > Greg Kurz <gk...@linux.vnet.ibm.com> wrote: > > > On Mon, 8 Feb 2016 09:31:49 +0100 > > Greg Kurz

Re: [Qemu-devel] [PATCH v3 0/2] Fix migration of old pseries

On Tue, 23 Feb 2016 09:31:10 +0100 Juan Quintela <quint...@redhat.com> wrote: > Greg Kurz <gk...@linux.vnet.ibm.com> wrote: > > On Fri, 19 Feb 2016 11:11:47 +1100 > > David Gibson <da...@gibson.dropbear.id.au> wrote: > > > >> On Thu, F

Re: [Qemu-devel] [PATCH v3 0/2] Fix migration of old pseries

On Tue, 23 Feb 2016 11:01:00 +0100 Greg Kurz <gk...@linux.vnet.ibm.com> wrote: > On Tue, 23 Feb 2016 09:31:10 +0100 > Juan Quintela <quint...@redhat.com> wrote: > > Greg Kurz <gk...@linux.vnet.ibm.com> wrote: > > > On Fri, 19 Feb 201

[Qemu-devel] [PATCH 0/3] spapr_pci and xics fixes

Hi, This series fixes some issues when sPAPR allocates interrupts. Especially a potential IRQ leak (patch 2) and bogus interrupt numbers stored in the MSI table because of poor error reporting from the XICS layer (patch 3). Please review. I'd like to have this fixes in 2.6. --- Greg Kurz (3

[Qemu-devel] [PATCH 3/3] xics: report errors with the QEMU Error API

sed on previous work from Brian W. Hart. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- hw/intc/xics.c| 22 ++ hw/ppc/spapr_events.c |2 +- hw/ppc/spapr_pci.c| 18 +++--- hw/ppc/spapr_vio.c|8 +--- include/hw/ppc/xics

[Qemu-devel] [PATCH 2/3] spapr_pci: fix irq leak in RTAS ibm, change-msi

when a new allocation succeeds. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- hw/ppc/spapr_pci.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index 19dd6dbeb943..9b2b546b541c 100644 --- a/hw/ppc/spapr_pci.c ++

[Qemu-devel] [PATCH 1/3] spapr_pci: kill useless variable in rtas_ibm_change_msi()

The num local variable is initialized to zero and has no writer. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- hw/ppc/spapr_pci.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index cca9257fecc5..19dd6dbeb943

[Qemu-devel] [PATCH] spapr_rng: disable hotpluggability

hotpluggability for the spapr-rng class. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- hw/ppc/spapr_rng.c |1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/spapr_rng.c b/hw/ppc/spapr_rng.c index 8484fcf54774..a39d472b66fd 100644 --- a/hw/ppc/spapr_rng.c +++ b/hw/ppc/spapr

[Qemu-devel] [PATCH v2] xics: report errors with the QEMU Error API

. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- v2: - reverted to non-void xics_alloc() and xics_alloc_block() - consolidated error message in xics_alloc() - pass _fatal instead of NULL in spapr_events_init() --- hw/intc/xics.c| 13 + hw/ppc/spapr_even

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 0/2] Fix migration of old pseries

On Mon, 22 Feb 2016 12:09:12 +1100 David Gibson <da...@gibson.dropbear.id.au> wrote: > On Fri, Feb 19, 2016 at 08:59:44AM +0100, Greg Kurz wrote: > > On Fri, 19 Feb 2016 11:11:47 +1100 > > David Gibson <da...@gibson.dropbear.id.au> wrote: > > > > >

Re: [Qemu-devel] [PATCH v3 0/2] Fix migration of old pseries

On Fri, 19 Feb 2016 17:27:33 +0100 Greg Kurz <gk...@linux.vnet.ibm.com> wrote: > On Fri, 19 Feb 2016 15:41:10 +0100 > Laurent Vivier <lviv...@redhat.com> wrote: > > > On 18/02/2016 12:32, Greg Kurz wrote: > > > QEMU 2.4 broke the migration of o

Re: [Qemu-devel] [Qemu-ppc] [PATCH] hw/intc: fix failure return for xics_alloc_block()

On Wed, 24 Feb 2016 11:36:49 +1100 David Gibson <da...@gibson.dropbear.id.au> wrote: > On Tue, Feb 23, 2016 at 06:46:44PM +0100, Greg Kurz wrote: > > On Wed, 10 Feb 2016 10:41:16 +0100 > > Greg Kurz <gk...@linux.vnet.ibm.com> wrote: > > > > > On Mon,

Re: [Qemu-devel] [PATCH v2 2/9] ipmi: replace goto by a return statement

it excessive as a > minimum response len is currently 300 bytes and the patch checks that > at least 3 are available. > > Signed-off-by: Cédric Le Goater <c...@fr.ibm.com> > --- Reviewed-by: Greg Kurz <gk...@linux.vnet.ibm.com> > hw/ipmi/ipmi_bmc_sim.c | 140 >

Re: [Qemu-devel] [PATCH v2 4/9] ipmi: introduce a struct ipmi_sdr_compact

On Thu, 21 Jan 2016 18:18:49 +0100 Cédric Le Goater wrote: > Currently, sdr attributes are identified using byte offsets and this > can be a bit confusing. > > This patch adds a struct ipmi_sdr_compact conforming to the IPMI specs > and replaces byte offsets with names. It also

Re: [Qemu-devel] [PATCH v2 5/9] ipmi: fix SDR length value

On Thu, 21 Jan 2016 18:18:50 +0100 Cédric Le Goater wrote: > The IPMI BMC simulator populates the SDR table with a set of initial > SDRs. The length of each SDR is taken from the record itself (byte 4) > which does not include the size of the header. But, the full length >

Re: [Qemu-devel] [PATCH v2 6/9] ipmi: add get and set SENSOR_TYPE commands

On Thu, 21 Jan 2016 18:18:51 +0100 Cédric Le Goater <c...@fr.ibm.com> wrote: > Signed-off-by: Cédric Le Goater <c...@fr.ibm.com> > Acked-by: Corey Minyard <cminy...@mvista.com> > --- Reviewed-by: Greg Kurz <gk...@linux.vnet.ibm.com> Just two nits below

Re: [Qemu-devel] [PATCH v2 7/9] ipmi: add GET_SYS_RESTART_CAUSE chassis command

On Thu, 21 Jan 2016 18:18:52 +0100 Cédric Le Goater <c...@fr.ibm.com> wrote: > This is a simulator. Just return an unknown cause (0). > > Signed-off-by: Cédric Le Goater <c...@fr.ibm.com> > Acked-by: Corey Minyard <cminy...@mvista.com> > --- Reviewed-by: Gr

Re: [Qemu-devel] [PATCH v2 3/9] ipmi: replace *_MAXCMD defines

On Thu, 21 Jan 2016 18:18:48 +0100 Cédric Le Goater <c...@fr.ibm.com> wrote: > ARRAY_SIZE() is simple to use and removes the need to pre-define > the size of the command arrays. > > Signed-off-by: Cédric Le Goater <c...@fr.ibm.com> > --- Much nicer !

Re: [Qemu-devel] [PATCH v2 9/9] ipmi: add SET_SENSOR_READING command (tentative try)

s. This command is > used on this platform to set the "System Firmware Progress" sensor and > the "Boot Count" sensor. > > Signed-off-by: Cédric Le Goater <c...@fr.ibm.com> > Acked-by: Corey Minyard <cminy...@mvista.com> > --- Reviewed-by: Greg Kurz

Re: [Qemu-devel] [PATCH v2 8/9] ipmi: add ACPI power and GUID commands

On Thu, 21 Jan 2016 18:18:53 +0100 Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater > --- > > Changes since v1: > - added ACPI to command names. > > hw/ipmi/ipmi_bmc_sim.c | 49 + > 1 file changed, 49

Re: [Qemu-devel] [PATCH] net: set endianness on all backend devices

On Tue, 26 Jan 2016 11:53:21 +0100 Laurent Vivier wrote: > On 22/01/2016 07:44, Jason Wang wrote: > > > > > > On 01/21/2016 04:42 PM, Laurent Vivier wrote: > >> ping > >> > >> [added Jason in cc:] > >> > >> On 13/01/2016 20:26, Laurent Vivier wrote: > >>> commit

Re: [Qemu-devel] [Qemu-ppc] [PATCH 5/7] target-ppc: gdbstub: fix altivec registers for little-endian guests

On Wed, 20 Jan 2016 13:13:57 +1100 David Gibson <da...@gibson.dropbear.id.au> wrote: > On Tue, Jan 19, 2016 at 10:59:20AM +0100, Greg Kurz wrote: > > On Mon, 18 Jan 2016 13:25:19 +1100 > > David Gibson <da...@gibson.dropbear.id.au> wrote: > > > > >

[Qemu-devel] [PATCH v2 0/2] 9pfs: fsdev: use error_report() instead of fprintf(stderr)

This v2 does the following: - addresses Markus Ambruster's comments for patch 1 - capitalized some messages in patch 1 - added R-b tags I've pushed this series to my 9p-next branch. Thanks ! -- Greg --- Greg Kurz (2): 9pfs: use error_report() instead of fprintf(stderr) fsdev: use

[Qemu-devel] [PATCH v2 1/2] 9pfs: use error_report() instead of fprintf(stderr)

Reviewed-by: Markus Armbruster <arm...@redhat.com> Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- hw/9pfs/9p-handle.c |5 +++-- hw/9pfs/9p-local.c | 15 --- hw/9pfs/9p-proxy.c | 12 ++-- hw/9pfs/9p.c|2 +- 4 files changed, 18 inser

[Qemu-devel] [PATCH v2 2/2] fsdev: use error_report() instead of fprintf(stderr)

Only fix the code that gets built into QEMU. Reviewed-by: Markus Armbruster <arm...@redhat.com> Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- fsdev/qemu-fsdev.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/fsdev/qemu-fsdev.c b/fsdev/qemu-f

Re: [Qemu-devel] [PATCH] remove libtool support

y de-complicate > it. > > Signed-off-by: Michael Tokarev <m...@tls.msk.ru> > --- Very good idea ! Reviewed-by: Greg Kurz <gk...@linux.vnet.ibm.com> Just a few remarks: [greg@palmb qemu-master]$ grep -r libtool qemu-doc.texi:@item libtool: @uref{http://www.gnu.org/software/libtool/}

Re: [Qemu-devel] [PATCH] remove libtool support

On Wed, 27 Jan 2016 15:36:38 +0300 Michael Tokarev <m...@tls.msk.ru> wrote: > 27.01.2016 15:15, Greg Kurz wrote: > [] > > Just a few remarks: > > > > [greg@palmb qemu-master]$ grep -r libtool > > qemu-doc.texi:@item libtool: @uref{http://www.gnu.org/softwar

[Qemu-devel] [PULL 0/2] 9p minor cleanup

Greg Kurz (2): 9pfs: use error_report() instead of fprintf(stderr) fsdev: use error_report() instead of fprintf(stderr) fsdev/qemu-fsdev.c | 7 --- hw/9pfs/9p-handle.c | 5 +++-- hw/9pfs/9p-local.c | 15

[Qemu-devel] [PULL 1/2] 9pfs: use error_report() instead of fprintf(stderr)

Reviewed-by: Markus Armbruster <arm...@redhat.com> Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- hw/9pfs/9p-handle.c | 5 +++-- hw/9pfs/9p-local.c | 15 --- hw/9pfs/9p-proxy.c | 12 ++-- hw/9pfs/9p.c| 2 +- 4 files changed, 18 insertions(+),

[Qemu-devel] [PULL 2/2] fsdev: use error_report() instead of fprintf(stderr)

Only fix the code that gets built into QEMU. Reviewed-by: Markus Armbruster <arm...@redhat.com> Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- fsdev/qemu-fsdev.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/fsdev/qemu-fsdev.c b/fsdev/qemu-f

Re: [Qemu-devel] [PATCH] migration: allow configuration section to be optional

On Mon, 15 Feb 2016 13:09:51 +1100 David Gibson <da...@gibson.dropbear.id.au> wrote: > On Fri, Feb 12, 2016 at 03:44:18PM +0100, Greg Kurz wrote: > > Since QEMU 2.4, the migration stream begins with a configuration section. > > It is known to break migration of pseries ma

[Qemu-devel] [PATCH 1/2] migration: allow configuration section to be optional

-by: Dr. David Alan Gilbert <dgilb...@redhat.com> Reviewed-by: David Gibson <da...@gibson.dropbear.id.au> Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- hw/core/machine.c | 21 + include/hw/boards.h |1 + migration/savevm.c | 21 +

[Qemu-devel] [PATCH 0/2] Fix migration of old pseries

configuration for older machines (as it done for x86): it allows QEMU to accept incoming migration of older pseries with or without the configuration section. So it fixes migration from QEMU 2.3 without breaking QEMU 2.4. --- Greg Kurz (2): migration: allow configuration section to be optional

[Qemu-devel] [PATCH 2/2] spapr: fix migration of older pseries

Use the config_section machine property to fix migration of older pseries started with an older QEMU (version < 2.4 for both). Older machines started with QEMU 2.4 are not affected by this change since they send the configuration section unconditionally. Signed-off-by: Greg Kurz

Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr: skip configuration section during migration of older machines

On Mon, 15 Feb 2016 13:12:34 +1100 David Gibson <da...@gibson.dropbear.id.au> wrote: > On Fri, Feb 12, 2016 at 12:14:59PM +0100, Greg Kurz wrote: > > On Fri, 12 Feb 2016 16:24:26 +1100 > > David Gibson <da...@gibson.dropbear.id.au> wrote: > > > > > On

Re: [Qemu-devel] [PATCH 1/2] migration: allow configuration section to be optional

On Mon, 15 Feb 2016 12:23:39 +0100 Laurent Vivier <lviv...@redhat.com> wrote: > On 15/02/2016 11:15, Greg Kurz wrote: > > Since QEMU 2.4, the migration stream begins with a configuration section. > > It is known to break migration of pseries machine from older QEMU. It i

Re: [Qemu-devel] [PATCH 1/2] migration: allow configuration section to be optional

On Mon, 15 Feb 2016 15:49:17 +0100 Laurent Vivier <lviv...@redhat.com> wrote: > On 15/02/2016 13:58, Greg Kurz wrote: > > On Mon, 15 Feb 2016 12:23:39 +0100 > > Laurent Vivier <lviv...@redhat.com> wrote: > > > >> On 15/02/2016 11:15, Greg Kurz wr

Re: [Qemu-devel] [PATCH v4 0/6] virtio/vhost cross-endian cleanup

On Wed, 10 Feb 2016 11:22:20 +0100 Laurent Vivier <lviv...@redhat.com> wrote: > On 05/02/2016 11:39, Greg Kurz wrote: > > This series brings some improvements to the cross-endian support in the > > virtio and vhost code: > > - use qemu_set_vnet_be() and qemu_set_vnet_le

Re: [Qemu-devel] [PATCH v4 0/6] virtio/vhost cross-endian cleanup

On Tue, 16 Feb 2016 12:04:21 +0200 "Michael S. Tsirkin" <m...@redhat.com> wrote: > On Tue, Feb 16, 2016 at 10:57:19AM +0100, Greg Kurz wrote: > > On Wed, 10 Feb 2016 11:22:20 +0100 > > Laurent Vivier <lviv...@redhat.com> wrote: > > > On 05/02/2016

Re: [Qemu-devel] [PATCH 1/2] migration: allow configuration section to be optional

On Tue, 16 Feb 2016 10:31:35 +0100 Laurent Vivier <lviv...@redhat.com> wrote: > On 16/02/2016 10:09, Greg Kurz wrote: > > On Mon, 15 Feb 2016 15:49:17 +0100 > > Laurent Vivier <lviv...@redhat.com> wrote: > > > >> On 15/02/2016 13:58, Greg Kurz wrote:

Re: [Qemu-devel] [PATCH 1/2] migration: allow configuration section to be optional

On Tue, 16 Feb 2016 17:01:40 + "Dr. David Alan Gilbert" <dgilb...@redhat.com> wrote: > * Greg Kurz (gk...@linux.vnet.ibm.com) wrote: > > Since QEMU 2.4, the migration stream begins with a configuration section. > > It is known to break migration of

Re: [Qemu-devel] [PATCH] add CephFS support in VirtFS

On Wed, 17 Feb 2016 15:32:06 +0800 Jevon Qiao wrote: > Hi Daniel, > > Thank you for reviewing my code, please see my reply in-line. > On 15/2/16 17:17, Daniel P. Berrange wrote: > > On Sun, Feb 14, 2016 at 01:06:40PM +0800, Jevon Qiao wrote: > >> diff --git a/configure

Re: [Qemu-devel] [PATCH] add CephFS support in VirtFS

On Wed, 17 Feb 2016 16:49:33 +0800 Jevon Qiao <scaleq...@gmail.com> wrote: > On 17/2/16 16:01, Greg Kurz wrote: > > On Wed, 17 Feb 2016 15:32:06 +0800 > > Jevon Qiao <scaleq...@gmail.com> wrote: > > > >> Hi Daniel, > >> > >>

Re: [Qemu-devel] [PATCH 1/2] migration: allow configuration section to be optional

On Tue, 16 Feb 2016 17:09:52 + "Dr. David Alan Gilbert" <dgilb...@redhat.com> wrote: > * Laurent Vivier (lviv...@redhat.com) wrote: > > > > > > On 16/02/2016 10:09, Greg Kurz wrote: > > > On Mon, 15 Feb 2016 15:49:17 +0100 &

Re: [Qemu-devel] [PATCH 2/2] hw/9pfs: fix alignment issue when host filesystem block size is larger than client msize

On Wed, 17 Feb 2016 15:14:48 +0800 Jevon Qiao wrote: > Hi Aneesh, > > Thank you for reviewing my code, please see my reply in-line. Jevon, Please read comments below. > On 14/2/16 21:38, Aneesh Kumar K.V wrote: > > Jevon Qiao writes: > > > >> The

[Qemu-devel] [PATCH v2 0/3] Fix migration of old pseries

migrate a pseries-2.3 from QEMU 2.3 or QEMU 2.4 to current head without manual intervention. I could then migrate it back either to QEMU 2.3 with suppress-config-section=on or to QEMU 2.4 without manual intervention. --- Greg Kurz (3): migration: allow configuration section to be optional

[Qemu-devel] [PATCH v2 1/3] migration: allow configuration section to be optional

. Suggested-by: Dr. David Alan Gilbert <dgilb...@redhat.com> Reviewed-by: David Gibson <da...@gibson.dropbear.id.au> Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- v2: - renamed property to require-config-section --- hw/core/machine.c | 22 ++ include/

[Qemu-devel] [PATCH v2 2/3] spapr: fix migration of older pseries

Use the require-config-section machine property to fix migration of older pseries (version < 2.4) started with an older QEMU (version < 2.4). Older machines started with QEMU 2.4 are not affected by this change since they send the configuration section unconditionally. Signed-off-by: Gre

[Qemu-devel] [PATCH v2 3/3] migration: allow to suppress configuration section submission

2.4. If automatic behaviour is needed, it is up to the tooling to handle this. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- hw/core/machine.c | 21 + include/hw/boards.h |1 + migration/savevm.c |8 +++- qemu-options.hx |3 ++- 4 files c

Re: [Qemu-devel] [PATCH v2 3/3] migration: allow to suppress configuration section submission

On Thu, 18 Feb 2016 12:06:39 +0530 Amit Shah <amit.s...@redhat.com> wrote: > On (Thu) 18 Feb 2016 [13:50:25], David Gibson wrote: > > On Wed, Feb 17, 2016 at 05:06:43PM +0100, Greg Kurz wrote: > > > Since the addition of the configuration section in QEMU 2.4,

[Qemu-devel] [PATCH v3 1/2] spapr: skip configuration section during migration of older machines

that anyway because QEMU 2.3 is likely to be more widely deployed than newer QEMU versions. Fixes: 61964c23e5ddd5a33f15699e45ce126f879e3e33 Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- hw/ppc/spapr.c |1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c

[Qemu-devel] [PATCH v3 0/2] Fix migration of old pseries

v2: it now fully fixes migration of old pseries from/to QEMU 2.3 and provides a manual workaround for the QEMU 2.4/2.4.1/2.5 case. With this series, I could migrate the same pseries-2.3 instance in a full 2.3->2.6->2.5->2.6->2.4->2.6->2.3 cycle. --- Greg Kurz (2): spapr:

[Qemu-devel] [PATCH v3 2/2] migration: allow machine to enforce configuration section migration

have one. It can be set at startup: -machine enforce-config-section=on or later from the QEMU monitor: qom-set /machine enforce-config-section on It is up to the tooling to set or unset this property according to the version of the QEMU at the other end of the pipe. Signed-off-by: Greg Kurz <

[Qemu-devel] [PATCH] spapr: initialize local Error pointer

This fixes a crash in the target QEMU during migration. Fixes: c5f54f3e31bf693f70a98d4d73ea5dbe05689857 Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- hw/ppc/spapr.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index e214a3

Re: [Qemu-devel] [PATCH] spapr: initialize local Error pointer

On Thu, 18 Feb 2016 16:02:53 +0100 Markus Armbruster <arm...@redhat.com> wrote: > Greg Kurz <gk...@linux.vnet.ibm.com> writes: > > > This fixes a crash in the target QEMU during migration. > > > > Fixes: c5f54f3e31bf693f70a98d4d73ea5dbe05689857 > >

Re: [Qemu-devel] [PATCH v3 0/2] Fix migration of old pseries

On Thu, 18 Feb 2016 21:00:38 +0100 Laurent Vivier <lviv...@redhat.com> wrote: > On 18/02/2016 12:32, Greg Kurz wrote: > > QEMU 2.4 broke the migration of old pseries machine with the addition > > of configuration sections, which are sent unconditionally. > > > >

Re: [Qemu-devel] [PATCH v3 0/2] Fix migration of old pseries

On Fri, 19 Feb 2016 11:11:47 +1100 David Gibson <da...@gibson.dropbear.id.au> wrote: > On Thu, Feb 18, 2016 at 12:32:11PM +0100, Greg Kurz wrote: > > QEMU 2.4 broke the migration of old pseries machine with the addition > > of configuration sections, which are sent uncondi

Re: [Qemu-devel] [PATCH v3 0/2] Fix migration of old pseries

On Fri, 19 Feb 2016 15:41:10 +0100 Laurent Vivier <lviv...@redhat.com> wrote: > On 18/02/2016 12:32, Greg Kurz wrote: > > QEMU 2.4 broke the migration of old pseries machine with the addition > > of configuration sections, which are sent unconditionally. > > > >

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

On Wed, 9 Mar 2016 13:09:58 -0700 Eric Blake <ebl...@redhat.com> wrote: > On 03/09/2016 12:02 PM, Greg Kurz wrote: > > On Wed, 2 Mar 2016 23:41:43 +0800 > > Jevon Qiao <scaleq...@gmail.com> wrote: > > > > >> +} > >> + > >> +s

Re: [Qemu-devel] [PATCH] virtio-net: Make virtio queue sizes configurable

On Fri, 27 Nov 2015 16:02:39 +0100 Patrik Hermansson wrote: > This patch adds the option to specify virtio queue sizes. Currently the > queue sizes is hard coded to 256, which might not be suitable for all types > of applications. This patch makes it possible to specify

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

On Tue, 15 Mar 2016 00:02:48 +0800 Jevon Qiao wrote: > Ceph as a promising unified distributed storage system is widely used in the > world of OpenStack. OpenStack users deploying Ceph for block (Cinder) and > object (S3/Swift) are unsurprisingly looking at Manila and CephFS

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

On Tue, 15 Mar 2016 21:39:45 +0800 Jevon Qiao <scaleq...@gmail.com> wrote: > On 15/3/16 17:30, Greg Kurz wrote: > > On Tue, 15 Mar 2016 00:02:48 +0800 > > Jevon Qiao <scaleq...@gmail.com> wrote: > > > >> Ceph as a promising unified

Re: [Qemu-devel] [PATCH] virtio-net: Make virtio queue sizes configurable

On Tue, 15 Mar 2016 06:50:38 +0200 "Michael S. Tsirkin" wrote: > On Fri, Nov 27, 2015 at 04:02:39PM +0100, Patrik Hermansson wrote: > > This patch adds the option to specify virtio queue sizes. Currently the > > queue sizes is hard coded to 256, which might not be suitable for

Re: [Qemu-devel] [PATCH] virtio-net: Make virtio queue sizes configurable

On Mon, 14 Mar 2016 12:27:55 +0100 Greg Kurz <gk...@linux.vnet.ibm.com> wrote: > On Fri, 27 Nov 2015 16:02:39 +0100 > Patrik Hermansson <phermans...@gmail.com> wrote: > > > This patch adds the option to specify virtio queue sizes. Currently the > > queue sizes

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

On Wed, 2 Mar 2016 23:41:43 +0800 Jevon Qiao wrote: > Ceph as a promising unified distributed storage system is widely used in the > world of OpenStack. OpenStack users deploying Ceph for block (Cinder) and > object (S3/Swift) are unsurprisingly looking at Manila and CephFS

[Qemu-devel] [PATCH] spapr_rng: fix race with main loop

r in h_random()->qemu_sem_wait(). This could not happen before 60253ed1e6ec because entropy_available() used to call random_recv() unconditionally. This patch ensures the lock is held to avoid the race. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- Thomas, This is the problem mentione

Re: [Qemu-devel] [PATCH v2] spapr: compute interrupt vector address from LPCR

On Wed, 30 Mar 2016 17:38:34 +0200 Cédric Le Goater wrote: > This address is changed by the linux kernel using the H_SET_MODE hcall > and needs to be restored when migrating a spapr VM running in > TCG. This can be done using the AIL bits from the LPCR register. > > The patch

<    2   3   4   5   6   7   8   9   10   11   >