werISA.
> Signed-off-by: Cédric Le Goater <c...@fr.ibm.com>
> ---
>
Reviewed-by: Greg Kurz <gk...@linux.vnet.ibm.com>
> Changes since v1:
>
> - moved helper routine under target-ppc/
> - moved the restore of excp_prefix under cpu_post_load()
>
>
On Wed, 30 Mar 2016 19:01:31 +0200
Greg Kurz <gk...@linux.vnet.ibm.com> wrote:
> On Wed, 30 Mar 2016 17:38:34 +0200
> Cédric Le Goater <c...@fr.ibm.com> wrote:
>
> > This address is changed by the linux kernel using the H_SET_MODE hcall
> > and needs to be r
On Tue, 15 Mar 2016 00:02:48 +0800
Jevon Qiao wrote:
> Ceph as a promising unified distributed storage system is widely used in the
> world of OpenStack. OpenStack users deploying Ceph for block (Cinder) and
> object (S3/Swift) are unsurprisingly looking at Manila and CephFS
On Wed, 6 Apr 2016 09:05:21 -0600
Eric Blake wrote:
> On 04/06/2016 03:15 AM, Jason Wang wrote:
> > This patch add the capability of basic vhost net busy polling which is
> > supported by recent kernel. User could configure the maximum number of
> > us that could be spent on
property of tap
> "vhost-poll-us".
>
> Signed-off-by: Jason Wang <jasow...@redhat.com>
> ---
Thanks for this feature Jason !
Tested-by: Greg Kurz <gk...@linux.vnet.ibm.com>
> hw/net/vhost_net.c| 2 +-
> hw/scsi/vhost-scsi.c
On Mon, 21 Mar 2016 13:25:53 +0800
Jason Wang wrote:
> Hi:
>
> This series enable vhost-kernel busy polling support. It's done
> through introducing a new property for tap backend - 'vhost_poll_us'
> which is the maximum number of us could be spent for busy polling.
>
>
/16 22:16, Jevon Qiao wrote:
> > On 15/3/16 21:46, Greg Kurz wrote:
> >> On Tue, 15 Mar 2016 21:39:45 +0800
> >> Jevon Qiao <scaleq...@gmail.com> wrote:
> >>
> >>> On 15/3/16 17:30, Greg Kurz wrote:
> >>>> On Tue, 15 Mar 201
On Wed, 6 Apr 2016 09:49:34 +0800
Jason Wang <jasow...@redhat.com> wrote:
> On 04/05/2016 11:54 PM, Greg Kurz wrote:
> > On Mon, 21 Mar 2016 13:25:53 +0800
> > Jason Wang <jasow...@redhat.com> wrote:
> >> > Hi:
> >> >
> >> >
On Thu, 7 Apr 2016 13:41:24 +0200
Michael Fritscher wrote:
> Good day,
>
> I'm using qemu on a Windows host. One thing I stumbled over was missing
> 9p support. I thought it was because of missing (x)attr, but Stefan Weil
> told me that 9p is supported
On Mon, 11 Apr 2016 16:37:11 +0200
Michael Fritscher wrote:
> Hello Greg,
>
> thanks for your answer! Yes, I already jumped in - I was surprised how
> fast it went. I was afraid of much bigger problems ;-) I've a already a
> V2 nearly ready :-) As a
On Tue, 12 Apr 2016 09:52:00 +0200
Michael Fritscher wrote:
> It was tested on Windows & Linux hosts, on the later no obvious regressions
> could be found. The guest was a Knoppix 7.6.0 live cd.
>
> This is WIP and a RFC - it isn't meant to be upstreamed yet. The
> threads doing IO at different runs.
>
AFAIK, no.
Why don't you simply start QEMU in the cgroup ? Unless I miss something, all
children threads, including the 9p ones, will be in the cgroup and honor the
throttle setttings.
> Regards,
> Pradeep
>
Cheers.
--
Greg
>
> On 8 A
On Thu, 7 Apr 2016 11:48:27 +0200
Pradeep Kiruvale wrote:
> Hi All,
>
> I am using virtio-9p for sharing the file between host and guest. To test
> the shared file I do read/write options in the guest.To have controlled io,
> I am using cgroup blkio.
>
> While using
o the old fashion method:
# echo $$ > /sys/fs/cgroup/blkio/test/tasks
# qemu.
This being said, QEMU is a regular userspace program that is completely cgroup
agnostic. It won't behave differently than 'dd if=/dev/sdb of=/dev/null'.
This really doesn't look like a QEMU related issue to me.
On Mon, 21 Mar 2016 12:28:26 -0500
Michael Roth <mdr...@linux.vnet.ibm.com> wrote:
> From: Greg Kurz <gk...@linux.vnet.ibm.com>
>
> Since QEMU 2.4, we have a configuration section in the migration stream.
> This must be skipped for older machines, like it is already done
Hi Laurent,
On Thu, 24 Mar 2016 09:41:59 +0100
Laurent Vivier wrote:
> On 24/03/2016 06:35, David Gibson wrote:
> > On Tue, Mar 22, 2016 at 05:33:45PM +0100, Laurent Vivier wrote:
> >> Hi David,
> >>
> >> using kvm-unit-tests, I've found a side effect of your patches: the
Hi Cedric,
On Thu, 24 Mar 2016 16:28:53 +0100
Cédric Le Goater wrote:
> This address is changed by the linux kernel using the H_SET_MODE hcall
> and needs to be migrated in order to restart a spapr VM running in
> TCG. This can be done using the AIL bits from the LPCR register.
On Mon, 21 Mar 2016 17:18:17 +0100
Thomas Huth wrote:
> On 21.03.2016 15:02, Cédric Le Goater wrote:
> > This address is changed by the linux kernel using the H_SET_MODE hcall
> > and needs to be migrated in order to restart a spapr VM running in
> > TCG. Other platforms should
f you only
> > use VMSTATE_UINTTL without the _V suffix?
>
> Yes. You are right. I think we need something like below.
>
It looks much better !
And just to be sure: this only affects TCG because excp_prefix isn't accessed by
QEMU when running with KVM, right ?
If the answer is as simple as
for clarity. No
> > functional change is expected.
> >
> > Signed-off-by: David Gibson <da...@gibson.dropbear.id.au>
>
> Greg, or Alexey, can I can an R-b for this one as well?
>
Reviewed-by: Greg Kurz <gk...@linux.vnet.ibm.com>
> > ---
> > target
On Thu, 3 Mar 2016 15:35:07 +1100
David Gibson <da...@gibson.dropbear.id.au> wrote:
> On Wed, Mar 02, 2016 at 11:06:19AM +1100, David Gibson wrote:
> > On Tue, Mar 01, 2016 at 07:03:10PM +0100, Greg Kurz wrote:
> > > The gdbstub can't access guest memory with curr
tual HPT to set, the assumption is that it must
> be a KVM managed HPT).
>
> This also has some flow-on changes to the HPT access helpers, required by
> the above changes.
>
> Reported-by: Greg Kurz <gk...@linux.vnet.ibm.com>
> Signed-off-by: David Gibson <da...@gibson.
n KVM
> matters, but there are going to be in future.
>
> Signed-off-by: David Gibson <da...@gibson.dropbear.id.au>
> ---
Reviewed-by: Greg Kurz <gk...@linux.vnet.ibm.com>
> hw/ppc/spapr.c | 13 ++---
> tar
U helpers, fixes the
issue.
Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com>
---
target-ppc/kvm.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c
index d67c169ba324..dbc37f25af2b 100644
--- a/target-ppc/kvm.c
+++ b/target-ppc/k
On Tue, 8 Mar 2016 08:51:23 +0800
Jevon Qiao wrote:
> Any further comment on this patch?
>
First comment is:
$ git show | ./scripts/checkpatch.pl - | grep ^total
total: 44 errors, 7 warnings, 975 lines checked
I'm now reading the patch and will come back with other
On Wed, 9 Mar 2016 11:10:39 +0800
Gerard Braad wrote:
> Hi All,
>
>
> It has been a while since anyone responded to this thread, and I am
> quite interested in this functionality.
> What can be done this get this merged?
>
Hi,
I'll try to spend some time on it.
Cheers.
--
On Wed, 30 Mar 2016 14:10:38 +0200
Pradeep Kiruvale wrote:
> Hi All,
>
> Is virtio-9p-pci device only supports the fsdev deices? I am trying to use
> -drive option for applying QoS for block device using Virtio-9p-pci device,
> but failing to create/add a device other
ts. So I am
> using the Virtio-9p-pci.
>
What file ?
> Basically I want to have QoS for virtio-9p-pci.
>
Can you provide a more detailed scenario on the result you want to reach ?
> Regards,
> Pradeep
>
Cheers.
--
Greg
> On 30 March 2016 at 16:13, Greg Kurz <gk..
nd to agree with Cedric... unless Paolo has a bright idea of course. :)
Acked-by: Greg Kurz <gk...@linux.vnet.ibm.com>
> scripts/checkpatch.pl |1 +
> 1 file changed, 1 insertion(+)
>
> Index: qemu-dgibson-for-2.6.git/scripts/checkpatch.pl
> =
to cut down the memory foot print of the guests.
>
If you're using KVM and your guests run the same distro or application,
you may try to use KSM (Kernel Same-page Merging) in the host.
> Regards,
> Pradeep
>
> On 31 March 2016 at 18:12, Greg Kurz <gk...@linux.vnet.ibm.com> wrote:
On Tue, 22 Mar 2016 17:35:18 -0500
Michael Roth <mdr...@linux.vnet.ibm.com> wrote:
> Quoting Greg Kurz (2016-03-22 02:49:35)
> > On Mon, 21 Mar 2016 12:28:26 -0500
> > Michael Roth <mdr...@linux.vnet.ibm.com> wrote:
> >
> > > From: Greg Kurz <gk..
The system header doesn't exist on all host platforms. Code should
include "qemu/osdep.h" instead to avoid build breaks on plafforms that don't
define CONFIG_IOVEC (like win32, if it is to support 9p one day).
Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com>
---
fsdev/9p-iov-
Hi Jevon,
On Sun, 10 Apr 2016 14:55:55 +0800
Jevon Qiao <scaleq...@gmail.com> wrote:
> Hi Greg,
>
> Thank you for spending time reviewing this patch.
> On 7/4/16 23:50, Greg Kurz wrote:
> > On Tue, 15 Mar 2016 00:02:48 +0800
> > Jevon Qiao <scaleq...@
The "9p-attr.h" header isn't needed by 9p synth and virtio 9p.
While here, also drop last references to virtio from 9p synth since it is
now transport agnostic code.
Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com>
---
hw/9pfs/9p-synth.c |4 +---
hw/9pfs/virtio-9p
The recent RFC patch to bring 9p support to Windows hosts unveiled some
nits. These two patches are preliminary cleanup.
Michael,
I'd like you to carry these patches in your patchset. Please rebase your
current work on top of them.
Thanks.
---
Greg Kurz (2):
9p: don't include
9p
On Wed, 27 Apr 2016 16:39:58 +0200
Pradeep Kiruvale wrote:
> On 27 April 2016 at 10:38, Alberto Garcia wrote:
>
> > On Wed, Apr 27, 2016 at 09:29:02AM +0200, Pradeep Kiruvale wrote:
> >
> > > Thanks for the reply. I am still in the early phase, I
sly bogus vcpu id.
Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com>
---
include/sysemu/kvm.h|2 ++
kvm-all.c |6 ++
target-ppc/translate_init.c |8
3 files changed, 16 insertions(+)
diff --git a/include/sysemu/kvm.h b/include/sysemu/kv
On Mon, 23 May 2016 21:42:23 +0530
Amit Shah <amit.s...@redhat.com> wrote:
> On (Wed) 11 May 2016 [14:10:34], Greg Kurz wrote:
> > On Wed, 11 May 2016 13:59:19 +0200
> > Paolo Bonzini <pbonz...@redhat.com> wrote:
> >
> > > On 04/05/2016 21:44, Greg Ku
On Thu, 7 Apr 2016 18:07:44 +0200
Greg Kurz <gk...@linux.vnet.ibm.com> wrote:
> On Thu, 7 Apr 2016 12:56:24 +0800
> Jason Wang <jasow...@redhat.com> wrote:
>
> > This patch add the capability of basic vhost net busy polling which is
> > supported by re
Most of the 9p code is now virtio agnostic. This patch does a final cleanup:
- drop references to Virtio from the header comments
- fix includes
Also drop a couple of leading empty lines while here.
Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com>
---
fsdev/file-op-9p.h
On Wed, 11 May 2016 13:59:19 +0200
Paolo Bonzini <pbonz...@redhat.com> wrote:
> On 04/05/2016 21:44, Greg Kurz wrote:
> > QEMU has currently two ways to prevent migration to occur:
> > - migration blocker when it depends on runtime state
> > - VMStateDescription.
On Wed, 04 May 2016 21:44:19 +0200
Greg Kurz <gk...@linux.vnet.ibm.com> wrote:
> QEMU has currently two ways to prevent migration to occur:
> - migration blocker when it depends on runtime state
> - VMStateDescription.unmigratable when migration is not supported at all
>
> T
Some systems can already provide more than 255 hardware threads.
Bumping the QEMU limit to 1024 seems reasonable:
- it has no visible overhead in top
- the limit itself has no effect on hot paths
Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com>
---
This was tested with a pseries gues
On Wed, 11 May 2016 16:20:08 +0200
Igor Mammedov <imamm...@redhat.com> wrote:
> On Wed, 11 May 2016 16:00:04 +0200
> Greg Kurz <gk...@linux.vnet.ibm.com> wrote:
>
> > Some systems can already provide more than 255 hardware threads.
> >
> > Bumping
---
As said in my other post, bumping up to 1024 seems reasonable for pseries.
Would it be a problem for the x86 target ? If it is okay for you, I'd rather
try to push this separately from your series.
Anyway,
Reviewed-by: Greg Kurz <gk...@linux.vnet.ibm.com>
> hw/arm/virt.c
On Wed, 18 May 2016 13:42:08 +0200
Kevin Wolf <kw...@redhat.com> wrote:
> Am 18.05.2016 um 13:13 hat Dr. David Alan Gilbert geschrieben:
> > * Greg Kurz (gk...@linux.vnet.ibm.com) wrote:
> > > We currently have an error path during migration that can cause
> &
bly do the same with precopy and leave the guest paused.
But since the historical default for migration errors is to restart the
source, this patch adds a call to bdrv_invalidate_cache_all() instead.
Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com>
---
v2: - follow the existing error handli
bly do the same with precopy and leave the guest paused.
But since the historical default for migration errors is to restart the
source, this patch adds a call to bdrv_invalidate_cache_all() instead.
Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com>
---
migration/migration.c |9 +
in top
- the limit itself has no effect on hot paths
We only do that for pseries at the moment and keep a 255 limit for the
ARM Virtual Machine.
Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com>
---
v2: - updated changelog
- keep 255 limit in hw/arm/virt.c
---
hw/arm/virt.c
On Wed, 18 May 2016 16:31:31 +0100
Peter Maydell <peter.mayd...@linaro.org> wrote:
> On 18 May 2016 at 14:52, Greg Kurz <gk...@linux.vnet.ibm.com> wrote:
> > Some PowerPC systems can already provide more than 255 hardware threads.
> > Igor also posted a patch recently,
Without presuming if we got there because of a user mistake or some
more subtile bug in the tooling, it doesn't hurt to log somewhere that
the device won't be functional.
Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com>
---
hw/virtio/virtio-pci.c |4
1 file changed, 4 inse
Commit "ebac1202c95a virtio-9p: use QEMU thread pool" dropped function
v9fs_init_worker_threads.
Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com>
---
hw/9pfs/coth.h |1 -
1 file changed, 1 deletion(-)
diff --git a/hw/9pfs/coth.h b/hw/9pfs/coth.h
index 209fc6a9afbc..a91
On Mon, 2 May 2016 17:49:26 +0200
Pradeep Kiruvale <pradeepkiruv...@gmail.com> wrote:
> On 2 May 2016 at 14:57, Greg Kurz <gk...@linux.vnet.ibm.com> wrote:
>
> > On Thu, 28 Apr 2016 11:45:41 +0200
> > Pradeep Kiruvale <pradeepkiruv...@gmail.com> wrote:
>
On Wed, 4 May 2016 13:47:12 +0100
"Dr. David Alan Gilbert" wrote:
> * Juan Quintela (quint...@redhat.com) wrote:
> >
> > Hi
> >
> > I am lots of times asked about what is the ToDo list for migration, that
> > was on my head, and random notes over my desk, so, trying some
>
On Fri, 6 May 2016 08:01:09 +0200
Pradeep Kiruvale <pradeepkiruv...@gmail.com> wrote:
> On 4 May 2016 at 17:40, Greg Kurz <gk...@linux.vnet.ibm.com> wrote:
>
> > On Mon, 2 May 2016 17:49:26 +0200
> > Pradeep Kiruvale <pradeepkiruv...@gmail.com> wrote:
> &g
mount_tag 'host'
Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com>
---
Since there has been some activity on 9p again since a few weeks, maybe it
is not too late for 2.6, if everybody agrees the fix is ok ?
include/migration/migration.h |1 +
migration/migration.c
On Thu, 28 Apr 2016 11:45:41 +0200
Pradeep Kiruvale <pradeepkiruv...@gmail.com> wrote:
> On 27 April 2016 at 19:12, Greg Kurz <gk...@linux.vnet.ibm.com> wrote:
>
> > On Wed, 27 Apr 2016 16:39:58 +0200
> > Pradeep Kiruvale <pradeepkiruv...@gmail.com> wrote:
On Mon, 9 May 2016 11:12:51 +0200
"Michael Fritscher" wrote:
> Hello Greg,
>
Hi Michael !
> I commented your comments :-)
>
> To summerize:
> * I didn't know where to put the win32 specific functions/wrappers -
> thanks showing me the locations!
> * Binary mode is
Hi Michael,
I have some more comments that should end up in a preliminary patch.
Cheers.
--
Greg
On Tue, 12 Apr 2016 09:52:00 +0200
Michael Fritscher wrote:
> It was tested on Windows & Linux hosts, on the later no obvious regressions
> could be found. The guest was a
One more nit in configure. See below.
Cheers.
--
Greg
On Tue, 15 Mar 2016 00:02:48 +0800
Jevon Qiao wrote:
> Ceph as a promising unified distributed storage system is widely used in the
> world of OpenStack. OpenStack users deploying Ceph for block (Cinder) and
> object
Hi Jevon,
More findings in fsdev/qemu-fsdev.c and hw/9pfs/Makefile.objs, see below.
Cheers.
--
Greg
On Tue, 15 Mar 2016 00:02:48 +0800
Jevon Qiao wrote:
> Ceph as a promising unified distributed storage system is widely used in the
> world of OpenStack. OpenStack users
More comments.
On Tue, 12 Apr 2016 09:52:00 +0200
Michael Fritscher wrote:
> It was tested on Windows & Linux hosts, on the later no obvious regressions
> could be found. The guest was a Knoppix 7.6.0 live cd.
>
> This is WIP and a RFC - it isn't meant to be upstreamed
ost directly to
qemu-devel and Cc: 9p maintainers next time :)
"Aneesh Kumar K.V" <aneesh.ku...@linux.vnet.ibm.com> (supporter:virtio-9p)
Greg Kurz <gk...@linux.vnet.ibm.com> (supporter:virtio-9p)
I'm now catching up on the background for this issue.
Cheers.
--
Greg
On Fri, 22 Jul 2016 15:42:48 +0200
Cornelia Huck <cornelia.h...@de.ibm.com> wrote:
> [...]
> > > > > On Thu, 21 Jul 2016 23:21:16 +0200
> > > > > Greg Kurz <gr...@kaod.org> wrote:
> > > > >
> > > > > > From: G
From: Greg Kurz <gk...@linux.vnet.ibm.com>
Without presuming if we got there because of a user mistake or some
more subtle bug in the tooling, it really does not make sense to
implement a non-functional device.
Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com>
Reviewed-by: Marc
On Fri, 22 Jul 2016 12:32:24 +0200
Cornelia Huck <cornelia.h...@de.ibm.com> wrote:
> On Fri, 22 Jul 2016 12:11:11 +0200
> Greg Kurz <gr...@kaod.org> wrote:
>
> > On Fri, 22 Jul 2016 10:04:35 +0200
> > Cornelia Huck <cornelia.h...@de.ibm.com> wrote:
> >
Le Mon, 25 Jul 2016 16:01:31 +1000,
David Gibson <da...@gibson.dropbear.id.au> a écrit :
> On Fri, Jul 22, 2016 at 01:10:36PM +0200, Greg Kurz wrote:
> > The goal of this patch is to have a stable core-id which does not depend
> > on any DT related semantics, whic
On Thu, 21 Jul 2016 19:02:39 +0200
Greg Kurz <gr...@kaod.org> wrote:
> On Thu, 21 Jul 2016 19:52:28 +0300
> Marcel Apfelbaum <marcel.apfelb...@gmail.com> wrote:
>
> > On 07/21/2016 06:52 PM, Greg Kurz wrote:
> > > From: Greg Kurz <gk...@linux.vnet.ibm.com&g
On Thu, 21 Jul 2016 19:52:28 +0300
Marcel Apfelbaum <marcel.apfelb...@gmail.com> wrote:
> On 07/21/2016 06:52 PM, Greg Kurz wrote:
> > From: Greg Kurz <gk...@linux.vnet.ibm.com>
> >
> > Without presuming if we got there because of a user mistake or some
&
From: Greg Kurz <gk...@linux.vnet.ibm.com>
Without presuming if we got there because of a user mistake or some
more subtle bug in the tooling, it really does not make sense to
implement a non-functional device.
Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com>
Signed-off-by: G
On Thu, 21 Jul 2016 23:21:16 +0200
Greg Kurz <gr...@kaod.org> wrote:
> From: Greg Kurz <gk...@linux.vnet.ibm.com>
>
> Without presuming if we got there because of a user mistake or some
> more subtle bug in the tooling, it really does not make sense to
> implem
As suggested by Eduardo, this series split the error handling of global
properties in two separate patches.
---
Greg Kurz (2):
qdev: ignore GlobalProperty.errp for hotplugged devices
vl: exit if a bad property value is passed to -global
hw/core/qdev-properties.c |4
kept for hotplugged devices since we don't want
QEMU to exit when doing device_add.
Reviewed-by: David Gibson <da...@gibson.dropbear.id.au>
Signed-off-by: Greg Kurz <gr...@kaod.org>
---
v3: - set directly the global property errp to _fatal
---
vl.c |1 +
1 file changed, 1 insert
This patch ensures QEMU won't terminate while hotplugging a device if the
global property cannot be set and errp points to error_fatal or error_abort.
While here, it also fixes indentation of the typename argument.
Suggested-by: Eduardo Habkost <ehabk...@redhat.com>
Signed-off-by: Greg Ku
From: Greg Kurz <gk...@linux.vnet.ibm.com>
Without presuming if we got there because of a user mistake or some
more subtle bug in the tooling, it really does not make sense to
implement a non-functional device.
Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com>
Reviewed-by: Marc
On Fri, 22 Jul 2016 11:28:48 +1000
David Gibson <da...@gibson.dropbear.id.au> wrote:
> On Fri, Jul 22, 2016 at 01:01:26AM +0200, Greg Kurz wrote:
> > This patch ensures QEMU won't terminate while hotplugging a device if the
> > global property cannot be set and errp
Le Wed, 10 Aug 2016 20:28:27 +0530 (IST),
P J P <ppan...@redhat.com> a écrit :
> +-- On Wed, 10 Aug 2016, Greg Kurz wrote --+
> | As Michael already pointed in a previous mail, this will break legal paths
> | with a component ending in ".." like "foo../bar"
:
Invalid compatibility mode "foo"
... and QEMU continues execution, ignoring the property.
With this patch, we get a single line:
qemu-system-ppc64: can't apply global host-powerpc64-cpu.compat=foo:
Invalid compatibility mode "foo"
... and QEMU exits.
Signed-off-by: Greg
On Wed, 13 Jul 2016 20:11:45 +0200
Greg Kurz <gr...@kaod.org> wrote:
> We're not supposed to abort when the user passes a bogus value.
> Since the ckecing is done in visit_type_OnOffSplit(), the call to
s/ckecing/checking :)
> abort() is legitimate. Let's add a comment to m
We're not supposed to abort when the user passes a bogus value.
Since the ckecing is done in visit_type_OnOffSplit(), the call to
abort() is legitimate. Let's add a comment to make it explicit.
Signed-off-by: Greg Kurz <gr...@kaod.org>
---
hw/core/machine.c |3 +++
1 file chan
.
---
Greg Kurz (5):
ppc: different creation paths for cpus in system and user mode
ppc: parse cpu features once
ppc: open code cpu creation for machine types
ppc: each machine type to provide vcpu_dt_id
ppc: drop vcpu_idt_id bits from the target code
hw/ppc/e500.c
for the DT for example.
With this patch, each mode has its own creation helper:
- ppc_cpu_init() is for system mode only
- cpu_init() is for user mode only
Suggested-by: Igor Mammedov <imamm...@redhat.com>
Reviewed-by: David Gibson <da...@gibson.dropbear.id.au>
Signed-off-by: Greg Kurz <
.
---
Greg Kurz (5):
ppc: different creation paths for cpus in system and user mode
ppc: parse cpu features once
ppc: open code cpu creation for machine types
ppc: each machine type to provide vcpu_dt_id
ppc: drop vcpu_idt_id bits from the target code
hw/ppc/e500.c
for the DT for example.
With this patch, each mode has its own creation helper:
- ppc_cpu_init() is for system mode only
- cpu_init() is for user mode only
Suggested-by: Igor Mammedov <imamm...@redhat.com>
Reviewed-by: David Gibson <da...@gibson.dropbear.id.au>
Signed-off-by: Greg Kurz <
-by: Greg Kurz <gr...@kaod.org>
---
hw/ppc/e500.c |2 ++
hw/ppc/mac_newworld.c |1 +
hw/ppc/mac_oldworld.c |1 +
hw/ppc/ppc.c | 26 ++
hw/ppc/ppc440_bamboo.c |1 +
hw/ppc/ppc4xx_devs.c |1 +
hw/ppc/prep.c |1 +
If we want to generate cpu_dt_id in the machine code, this must occur
before the cpu gets realized. We must open code the cpu creation to be
able to do this.
This patch just does that.
Reviewed-by: David Gibson <da...@gibson.dropbear.id.au>
Signed-off-by: Greg Kurz <gr...@kaod.org>
-
-by: Greg Kurz <gr...@kaod.org>
---
This is a standalone version of patch 2 from my latest series:
https://lists.nongnu.org/archive/html/qemu-devel/2016-07/msg02433.html
The only changes are trivial conflict fixes caused by the introduction
of ppc_cpu_init by patch 1.
---
hw/ppc/
On Thu, 14 Jul 2016 12:05:42 +1000
David Gibson <da...@gibson.dropbear.id.au> wrote:
> On Wed, Jul 13, 2016 at 02:34:32PM +0200, Greg Kurz wrote:
> > On Wed, 13 Jul 2016 11:10:21 +0200
> > Greg Kurz <gr...@kaod.org> wrote:
> >
> > > Now that propertie
the error message to be more explicit.
Signed-off-by: Greg Kurz <gr...@kaod.org>
---
target-ppc/translate_init.c |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
index 8f257fb74aa7..55688db9c9db 100644
--- a/
: -1" construct. It is
useless since max_compat is dereferenced a few lines above.
Signed-off-by: Greg Kurz <gr...@kaod.org>
---
target-ppc/translate_init.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
index
On Thu, 21 Jul 2016 16:30:06 +0200
Igor Mammedov wrote:
> On Thu, 21 Jul 2016 23:07:06 +1000
> David Gibson wrote:
>
> > On Wed, Jul 20, 2016 at 09:01:11AM +0200, Peter Krempa wrote:
> > > On Wed, Jul 20, 2016 at 11:00:05 +1000, David Gibson
On Thu, 21 Jul 2016 13:07:46 +0200
Cornelia Huck <cornelia.h...@de.ibm.com> wrote:
> On Thu, 21 Jul 2016 11:24:45 +0200
> Greg Kurz <gr...@kaod.org> wrote:
>
> > On Thu, 12 May 2016 11:45:58 +0200
> > Greg Kurz <gk...@linux.vnet.ibm.com> wrote:
> >
We abort a few lines above if kernel_xics_fd == -1.
This is only code cleanup.
Signed-off-by: Greg Kurz <gr...@kaod.org>
---
hw/intc/xics_kvm.c | 20
1 file changed, 8 insertions(+), 12 deletions(-)
diff --git a/hw/intc/xics_kvm.c b/hw/intc/xics_kvm.c
index edbd62
On Thu, 12 May 2016 11:45:58 +0200
Greg Kurz <gk...@linux.vnet.ibm.com> wrote:
> Without presuming if we got there because of a user mistake or some
> more subtile bug in the tooling, it doesn't hurt to log somewhere that
> the device won't be functional.
>
> Signed-
e call to close_htab_fd() from the htab_save_complete()
> function.
>
> Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1354341
> Signed-off-by: Thomas Huth <th...@redhat.com>
> ---
Reviewed-by: Greg Kurz <gr...@kaod.org>
> hw/ppc/spapr.c | 9 -
> 1 fi
rote:
> >
> > > On Wed, Jul 13, 2016 at 08:05:03PM +0200, Greg Kurz wrote:
> > > > When passing '-global
> > > > driver=host-powerpc64-cpu,property=compat,value=foo'
> > > > on the command line, without this patch, we get the following war
On Thu, 21 Jul 2016 18:32:40 +0300
Marcel Apfelbaum <marcel.apfelb...@gmail.com> wrote:
> On 07/21/2016 05:43 PM, Greg Kurz wrote:
> > On Thu, 21 Jul 2016 13:07:46 +0200
> > Cornelia Huck <cornelia.h...@de.ibm.com> wrote:
> >
> >> On Thu, 21
From: Greg Kurz <gk...@linux.vnet.ibm.com>
Without presuming if we got there because of a user mistake or some
more subtle bug in the tooling, it really does not make sense to
implement a non-functional device.
Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com>
Signed-off-by: G
On Fri, 15 Jul 2016 10:10:25 +0200
Thomas Huth wrote:
> Commit 86b50f2e1bef ("Disable huge page support if it is not available
> for main RAM") already made sure that huge page support is not announced
> to the guest if the normal RAM of non-NUMA configurations is not backed
>
On Mon, 18 Jul 2016 12:44:09 +0200
Greg Kurz <gr...@kaod.org> wrote:
> On Mon, 18 Jul 2016 11:33:16 +0200
> Thomas Huth <th...@redhat.com> wrote:
>
> > On 18.07.2016 11:26, Greg Kurz wrote:
> > > On Mon, 18 Jul 2016 11:04:39 +0200
> &
701 - 800 of 5451 matches
Mail list logo