On Sat, 11 Aug 2012 09:45:14 +0200
Markus Armbruster wrote:
> Luiz Capitulino writes:
>
> > On Fri, 10 Aug 2012 19:17:22 +0200
> > Markus Armbruster wrote:
> >
> >> Luiz Capitulino writes:
> >>
> >> > On Fri, 10 Aug 2012 18:35:26 +020
On Mon, 13 Aug 2012 15:50:13 +0200
Markus Armbruster wrote:
> Luiz Capitulino writes:
>
> > On Sat, 11 Aug 2012 09:45:14 +0200
> > Markus Armbruster wrote:
> >
> >> Luiz Capitulino writes:
> >>
> >> > On Fri, 10 Aug 2012 19:17:22 +020
On Fri, 10 Aug 2012 11:04:08 -0500
Anthony Liguori wrote:
> This series implements the necessary commands to implements danpb's idea to
> remove -help parsing in libvirt. We would introduce all of these commands in
> 1.2 and then change the -help output starting in 1.3.
Applied to the qmp branc
On Fri, 10 Aug 2012 18:24:10 -0500
Michael Roth wrote:
> Currently, when parsing a stream of tokens we make a copy of the token
> list at the beginning of each level of recursion so that we do not
> modify the original list in cases where we need to fall back to an
> earlier state.
>
> In the wo
On Mon, 13 Aug 2012 14:16:58 -0300
Luiz Capitulino wrote:
> On Fri, 10 Aug 2012 11:04:08 -0500
> Anthony Liguori wrote:
>
> > This series implements the necessary commands to implements danpb's idea to
> > remove -help parsing in libvirt. We would introduce all
On Fri, 29 Jun 2012 18:43:57 +0200
Juan Quintela wrote:
> We add time spent for migration to the output of "info migrate"
> command. 'total_time' means time since the start fo migration if
> migration is 'active', and total time of migration if migration is
> completed. As we are also intereste
On Mon, 13 Aug 2012 12:50:53 +0200
Juan Quintela wrote:
> Signed-off-by: Juan Quintela
> ---
> hmp.c| 4
> migration.c | 5 -
> migration.h | 1 +
> qapi-schema.json | 6 +-
> 4 files changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/hmp.c b/hmp.c
>
On Mon, 13 Aug 2012 08:59:00 -0600
Eric Blake wrote:
> On 08/13/2012 04:50 AM, Juan Quintela wrote:
> > Hi
> >
> > This modifies the output of info migrate/qmp_query_migrate to add the
> > stats that I got request for.
> >
> > - It moves total time to MigrationInfo instead of ram (luiz suggesti
-cpu-definitions (v2)
target-ppc: add implementation of query-cpu-definitions (v2)
Luiz Capitulino (41):
monitor: drop unused monitor debug code
qerror: QERR_AMBIGUOUS_PATH: drop %(object) from human msg
qerror: QERR_DEVICE_ENCRYPTED: change error message
qerror: reduce
Used to store error information, but it's unused now.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
error.c | 4
qerror.c | 4
qerror.h | 1 -
3 files changed, 9 deletions(-)
diff --git a/error.c b/error.c
index 0e10373..1f05fc4 100644
--- a/error.c
From: Anthony Liguori
This can be used in conjunction with qom-list-types to determine the supported
set of devices and their parameters.
Signed-off-by: Anthony Liguori
Signed-off-by: Luiz Capitulino
---
qapi-schema.json | 28
qmp-commands.hx | 7 +++
qmp.c
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
error.c | 5 +
error.h | 5 +
2 files changed, 10 insertions(+)
diff --git a/error.c b/error.c
index 648706a..2d34cde 100644
--- a/error.c
+++ b/error.c
@@ -64,6 +64,11 @@ bool error_is_set(Error **errp)
return
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
block.c | 1 +
qapi-schema.json | 9 ++---
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/block.c b/block.c
index 24323c1..016858b 100644
--- a/block.c
+++ b/block.c
@@ -2445,6 +2445,7
{ "error": { "class": "DeviceNotRemovable",
"data": { "device": "virtio0" },
"desc": "Device 'virtio0' is not removable" } }
Will now be emitted as:
{ "error": {
Next commit will introduce enum strings in camel case.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
scripts/qapi-types.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py
index 9b7da96..cf601ae 100644
--- a
Actually, renames it to 'object'. This must be what the original author
meant to write, as there's no 'object' in the error's data member.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
qerror.c | 2 +-
1 file changed, 1 insertion(+), 1 deleti
They have never been fully used and conflict with future error
improvements.
Also makes qerror_report() a proper function, as there's no point
in having it as a macro anymore.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
qerror.c | 20 +++-
qerror.h
ifies the code.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
qerror.c | 29 -
qerror.h | 2 +-
2 files changed, 5 insertions(+), 26 deletions(-)
diff --git a/qerror.c b/qerror.c
index d073ed7..a254f88 100644
--- a/qerror.c
+++ b/qerror.c
@@ -3
hmp.h is relying on qdict.h being provided by qapi-types.h. Fix this,
as a future commit will change qapi-types.h not to provide qdict.h.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
hmp.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/hmp.h b/hmp.h
index 8d2b0d7
It's used to indicate the special case where a valid file-descriptor
is returned (ie. success) but the connection can't be completed
w/o blocking.
This is needed because QERR_SOCKET_CONNECT_IN_PROGRESS is not
treated like an error and a future commit will drop it.
Signed-off-by: Luiz
, which are maintained as they
are today.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
qerror.h | 140 +++
1 file changed, 70 insertions(+), 70 deletions(-)
diff --git a/qerror.h b/qerror.h
index bcc93f8..4f92218 100644
They are unused since last commit.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
qerror.c | 400 ---
qerror.h | 7 --
2 files changed, 407 deletions(-)
diff --git a/qerror.c b/qerror.c
index dda1427..ccc52be
Today, the error message is only constructed when it's used. This commit
changes that to construct the error message when the error object is
built (ie. when the error is reported).
This simplifies the Error object.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
er
Besides being unused, they operate on the current error format,
which is going to be replaced soon.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
error.c | 48
error.h | 16
error_int.h | 1 -
3
From: Anthony Liguori
Signed-off-by: Anthony Liguori
Signed-off-by: Luiz Capitulino
---
target-ppc/translate_init.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
index 5742229..6fe4168 100644
--- a
ls to
qerror_report() and error_set() (and also to initialize qerror_table[]).
Next commit will update the QERR_ macros with a proper ErrorClass
value.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
error.c | 8 +++-
error.h | 5 ++-
qerror.c | 10 +++--
qerror.h
avoid emitting the RESET
event.
Signed-off-by: Luiz Capitulino
Acked-by: Gerd Hoffmann
---
vl.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/vl.c b/vl.c
index 91076f0..68fa0a0 100644
--- a/vl.c
+++ b/vl.c
@@ -1298,6 +1298,7 @@ static pid_t shutdown_pid
From: Anthony Liguori
Signed-off-by: Anthony Liguori
Signed-off-by: Luiz Capitulino
---
target-i386/cpu.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 880cfea..6d5d0d6 100644
--- a/target-i386/cpu.c
+++ b/target-i386
qerror_abort() depends on the 'file', 'func' and 'linenr' members of
QError. However, these members are going to be dropped by the next
commit, so let's drop qerror_abort() in favor of printing an error
message to stderr plus a call to abort().
Signed-off-by: L
error_get_qobject() is unused since last commit, error_set_qobject()
has never been used. Also drops error_int.h.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
error.c | 20
error_int.h | 28
qapi/qmp
t also adds the missing documentation for the WAKEUP event.
Signed-off-by: Luiz Capitulino
Acked-by: Gerd Hoffmann
---
QMP/qmp-events.txt | 13 +
vl.c | 2 +-
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt
index 9
this last time.
Let's just drop it.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
configure | 10 --
monitor.c | 65 ---
2 files changed, 75 deletions(-)
diff --git a/configure b/configure
index f
Several block/ files are relying on qerror.h being provided by
qapi-types.h. Fix this, as a future commit will change qapi-types.h
not to provide qerror.h.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
block_int.h | 1 +
1 file changed, 1 insertion(+)
diff --git a
The error_is_type() function is going to be dropped.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
hmp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hmp.c b/hmp.c
index 54c37d7..9b44dfc 100644
--- a/hmp.c
+++ b/hmp.c
@@ -793,7 +793,8 @@ void
n|reboot" } } }
qemu-ga now returns:
{ "error": { "class": "GenericError",
"desc": "Parameter 'mode' expects halt|powerdown|reboot" } }
Notice that this is also a bug fix, as qemu-ga wasn't returning the
huma
qerror will be dropped in a near future, let's reduce its public
exposure by making functions only used in qerror.c static.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
qerror.c | 10 +-
qerror.h | 5 -
2 files changed, 5 insertions(+), 10 deletions(-)
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
qapi-schema.json | 30 ++
1 file changed, 30 insertions(+)
diff --git a/qapi-schema.json b/qapi-schema.json
index a62bf68..b513935 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -3,6 +3,36
ult of the guest entering S4. So it's a good idea to
keep both events separated
Signed-off-by: Luiz Capitulino
---
QMP/qmp-events.txt | 14 ++
hw/acpi.c | 2 ++
monitor.c | 1 +
monitor.h | 1 +
4 files changed, 18 insertions(+)
diff --git a/QMP/q
This allows for changing QERR_ macros to initialize two struct members
at the same time. See next commit for more details.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
qerror.c | 276 +++
qerror.h | 2 +-
2
It's not needed. As the device name is already known, we can replace
the duplicated password prompting code by monitor_read_block_device_key().
This overly simplifies hmp_change().
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
hmp.c | 29 ++-
qapi-types.h needs only qemu-common.h. Including qapi-types-core.h
causes problems when qerror.h or error.h includes qapi-types.h.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
scripts/qapi-types.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a
This commit changes hmp_cont() to loop through all block devices
and proactively set an encryption key for any encrypted device
missing a key.
This change is needed because QERR_DEVICE_ENCRYPTED is going to be
dropped by a future commit.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus
An enum like GenericError in the schema, should generate
GENERIC_ERROR and not GENERICERROR.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
scripts/qapi-types.py | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/scripts/qapi-types.py b/scripts
Unused since last commit.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
qerror.c | 4
qerror.h | 3 ---
2 files changed, 7 deletions(-)
diff --git a/qerror.c b/qerror.c
index 5d38428..452ec69 100644
--- a/qerror.c
+++ b/qerror.c
@@ -309,10 +309,6 @@ static const
. Targets can then
override and implement this command if it makes sense for them.
Signed-off-by: Anthony Liguori
Signed-off-by: Luiz Capitulino
---
qapi-schema.json | 23 +++
qmp-commands.hx | 6 ++
qmp.c| 6 ++
3 files changed, 35 insertions(+)
diff --git a
From: Anthony Liguori
We've had a cycle to tweak. It is time to commit to supporting them.
Signed-off-by: Anthony Liguori
Signed-off-by: Luiz Capitulino
---
qapi-schema.json | 19 ---
1 file changed, 4 insertions(+), 15 deletions(-)
diff --git a/qapi-schema.json b
Match what HMP commands print on DeviceEncrypted errors.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
qerror.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qerror.c b/qerror.c
index 082de98..de0a79e 100644
--- a/qerror.c
+++ b/qerror.c
@@ -81,7 +81,7
qmp-commands.h declares several functions that have arguments of
type QDict. However, qdict.h is not included. This will cause a
build breakage when a file includes qmp-commands.h but doesn't
include qdict.h.
Signed-off-by: Luiz Capitulino
---
scripts/qapi-commands.py | 1 +
1 file chang
Add information about the new error format and improve the text a bit.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
docs/writing-qmp-commands.txt | 47 +--
1 file changed, 27 insertions(+), 20 deletions(-)
diff --git a/docs/writing
Signed-off-by: Luiz Capitulino
Reviewed-by: Eric Blake
Acked-by: Gerd Hoffmann
---
QMP/qmp-events.txt | 266 ++---
1 file changed, 130 insertions(+), 136 deletions(-)
diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt
index 10f69d1..2389370
Signed-off-by: Luiz Capitulino
Reviewed-by: Eric Blake
Acked-by: Gerd Hoffmann
---
QMP/qmp-events.txt | 12
1 file changed, 12 insertions(+)
diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt
index 2389370..df190ac 100644
--- a/QMP/qmp-events.txt
+++ b/QMP/qmp-events.txt
function receive a human message instead and the qobject is
not built anymore.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
error.c | 3 +-
error.h | 10 ++---
qerror.c | 42 +--
qerror.h | 141
Simplifies current and future users.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
error.c | 5 +
qerror.c | 10 --
qerror.h | 2 +-
3 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/error.c b/error.c
index 58f55a0..3a62592 100644
--- a/error.c
ted immediately
(qemu)
After this commit no spurious error is reported anymore.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
migration-tcp.c | 22 +-
qemu-sockets.c | 2 --
2 files changed, 9 insertions(+), 15 deletions(-)
diff --git a/migration-tcp.c b/
Helps dropping/modifying qerror functions.
Signed-off-by: Luiz Capitulino
Reviewed-by: Markus Armbruster
---
qerror.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/qerror.c b/qerror.c
index 7cb7c12..e717496 100644
--- a/qerror.c
+++ b/qerror.c
From: Anthony Liguori
This lets us provide a default implementation of a symbol which targets can
override.
Signed-off-by: Anthony Liguori
Signed-off-by: Luiz Capitulino
---
compiler.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/compiler.h b/compiler.h
index 736e770..f76921e 100644
From: Anthony Liguori
This provides the same output as -M ? but in a structured way.
Signed-off-by: Anthony Liguori
Signed-off-by: Luiz Capitulino
---
qapi-schema.json | 28
qmp-commands.hx | 6 ++
vl.c | 31 +++
3
On Tue, 14 Aug 2012 13:35:59 +0200
Markus Armbruster wrote:
> Juan Quintela writes:
>
> > Markus Armbruster wrote:
> >> Luiz Capitulino writes:
> >>
> >>> Use the in_progress argument for QERR_SOCKET_CONNECT_IN_PROGRESS. The
> >>> other e
On Tue, 14 Aug 2012 14:41:28 +0300
Alberto Garcia wrote:
> Now that the QERR_ macros no longer contain a json dictionary,
> the order of some parameters needs to be fixed for them to appear
> correctly.
> ---
> hw/ivshmem.c |3 ++-
> hw/qdev-monitor.c |2 +-
> 2 ficheiros modificado
On Tue, 14 Aug 2012 16:15:37 +0200
Alberto Garcia wrote:
> On Tue, Aug 14, 2012 at 10:42:30AM -0300, Luiz Capitulino wrote:
>
> > Additionally, we should check all old QERR_ macros to see if anyone
> > else swaps parameters like this and change them too.
>
> Yes, I also
On Tue, 14 Aug 2012 08:32:31 -0500
Anthony Liguori wrote:
> To be replaced with live block copy.
>
> Signed-off-by: Anthony Liguori
> ---
> migration.c |9 +
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/migration.c b/migration.c
> index 653a3c1..babccf4 1006
On Tue, 14 Aug 2012 15:48:37 +0200
Kevin Wolf wrote:
> Am 14.08.2012 15:32, schrieb Anthony Liguori:
> > To be replaced with live block copy.
> >
> > Signed-off-by: Anthony Liguori
>
> Might be worth adding a deprecation note in qapi-schema.json.
>
> > ---
> > migration.c |9 +
>
On Tue, 14 Aug 2012 17:02:26 +0200
Kevin Wolf wrote:
> Am 14.08.2012 16:52, schrieb Luiz Capitulino:
> > On Tue, 14 Aug 2012 15:48:37 +0200
> > Kevin Wolf wrote:
> >
> >> Am 14.08.2012 15:32, schrieb Anthony Liguori:
> >>> To be replaced with live bloc
On Tue, 14 Aug 2012 14:45:17 -0500
Anthony Liguori wrote:
> Luiz Capitulino writes:
>
> > On Tue, 14 Aug 2012 08:32:31 -0500
> > Anthony Liguori wrote:
> >
> >> To be replaced with live block copy.
> >>
> >> Signed-off-by: Anthony Liguori
On Tue, 14 Aug 2012 22:25:40 +0200
Markus Armbruster wrote:
> Anthony Liguori writes:
>
> > Luiz Capitulino writes:
> >
> >> On Tue, 14 Aug 2012 08:32:31 -0500
> >> Anthony Liguori wrote:
> >>
> >>> To be replaced with liv
On Wed, 15 Aug 2012 10:23:01 -0400
Jason Baron wrote:
> Hi,
>
> Linux
> -
> Fedora 17: installs and ran memory tests (requires ahci cdrom fixes I
> posted to install)
> Fedora 16: installs and ran memory tests
>
> Windows
> ---
> Windows 7: Wouldn't install due to this error:
On Wed, 15 Aug 2012 08:07:57 +0200
Stefan Weil wrote:
> Am 13.08.2012 19:16, schrieb Luiz Capitulino:
> > On Fri, 10 Aug 2012 11:04:08 -0500
> > Anthony Liguori wrote:
> >
> >> This series implements the necessary commands to implements danpb's idea to
> &
On Wed, 15 Aug 2012 11:33:47 +0100
"Daniel P. Berrange" wrote:
> From: "Daniel P. Berrange"
>
> Add a '-p' arg to the QMP/qmp-shell test program, which uses
> the python pprint module to pretty-print the dictionary
> returned from a command
>
> $ qmp-shell -p /tmp/qemu
> Welcome to the QMP
On Wed, 15 Aug 2012 16:54:24 +0200
"Benoît Canet" wrote:
> Signed-off-by: Benoit Canet
> ---
> qapi-schema.json | 24
> 1 file changed, 24 insertions(+)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index a92adb1..8d4df19 100644
> --- a/qapi-schema.json
> ++
On Wed, 15 Aug 2012 16:54:26 +0200
"Benoît Canet" wrote:
> This additionnal --machine=json option make qemu-img info output on
> stdout a JSON formated representation of the image informations.
>
> --machine=json was choosen instead of --format=json because the
> info command already have a -f p
On Thu, 16 Aug 2012 13:41:12 +0200
Markus Armbruster wrote:
> pc_fw_add_pflash_drv() ignores qemu_find_file() failure, and happily
> creates a drive without a medium.
>
> When pc_system_flash_init() asks for its size, bdrv_getlength() fails
> with -ENOMEDIUM, which isn't checked either. It fail
On Wed, 15 Aug 2012 13:45:42 -0500
Michael Roth wrote:
>
> Signed-off-by: Michael Roth
I've applied this series to the qmp branch for 1.2. I'll run some tests and if
all goes alright will send a pull request shortly.
> ---
> qlist.c | 13 +
> qlist.h |1 +
> 2 files changed
On Thu, 16 Aug 2012 15:50:51 +0200
Markus Armbruster wrote:
> Luiz Capitulino writes:
>
> > On Thu, 16 Aug 2012 13:41:12 +0200
> > Markus Armbruster wrote:
> >
> >> pc_fw_add_pflash_drv() ignores qemu_find_file() failure, and happily
> >> creates
On Wed, 15 Aug 2012 13:45:43 -0500
Michael Roth wrote:
> Currently, when parsing a stream of tokens we make a copy of the token
> list at the beginning of each level of recursion so that we do not
> modify the original list in cases where we need to fall back to an
> earlier state.
>
> In the wo
On Thu, 16 Aug 2012 16:32:12 +0200
Markus Armbruster wrote:
> Luiz Capitulino writes:
>
> > On Thu, 16 Aug 2012 15:50:51 +0200
> > Markus Armbruster wrote:
> >
> >> Luiz Capitulino writes:
> >>
> >> > On Thu, 16 A
On Thu, 16 Aug 2012 13:49:15 -0300
Luiz Capitulino wrote:
> > I converted more error messages to the error-reporting-infrastructure-
> > du-jour than was enjoyable, and I can tell you that the restrictions
> > that come with error_report() compared to anything-goes-fprintf() d
On Thu, 16 Aug 2012 17:12:37 +0200
Markus Armbruster wrote:
> Luiz Capitulino writes:
>
> > On Thu, 16 Aug 2012 16:32:12 +0200
> > Markus Armbruster wrote:
> >
> >> Luiz Capitulino writes:
> >>
> >> > On Thu, 16 Aug 2012 15:50:51 +020
On Wed, 15 Aug 2012 20:48:43 +0200
"Benoît Canet" wrote:
> This additionnal --machine=json option make qemu-img info output on
> stdout a JSON formated representation of the image informations.
>
> --machine=json was choosen instead of --format=json because the
> info command already have a -f p
On Thu, 16 Aug 2012 14:23:40 -0500
Michael Roth wrote:
> On Thu, Aug 16, 2012 at 10:40:05AM -0300, Luiz Capitulino wrote:
> > On Wed, 15 Aug 2012 13:45:42 -0500
> > Michael Roth wrote:
> >
> > >
> > > Signed-off-by: Michael Roth
> >
> >
val /= val2;
> ^
>
> Rewriting the code fixes this (and also a style issue).
>
> Signed-off-by: Stefan Weil
Reviewed-by: Luiz Capitulino
Although I wonder how far we're going "fixing" clang warnings/false positives...
> ---
> monitor.c |
On Fri, 17 Aug 2012 16:10:12 +0200
Markus Armbruster wrote:
> Stefan Weil writes:
>
> > ccc-analyzer reports these warnings:
> >
> > monitor.c:3532:21: warning: Division by zero
> > val %= val2;
> > ^
> > monitor.c:3530:21: warning: Division by zero
> >
On Fri, 17 Aug 2012 16:41:34 +0200
Markus Armbruster wrote:
> Luiz Capitulino writes:
>
> > On Fri, 17 Aug 2012 16:10:12 +0200
> > Markus Armbruster wrote:
> >
> >> Stefan Weil writes:
> >>
> >> > ccc-analyzer reports these warnings:
On Wed, 15 Aug 2012 17:05:44 +0200
Alexander Graf wrote:
> >> BSD
> >> ---
> >> Luiz tested these for me.
> >>
> >> OpenBSD 5.1, FreeBSD 9.0 and NetBSD all worked with the ide controller
> >> passed on the command line. AHCI didn't work.
> >
> > Sorry if I wasn't clear in my report, I've only t
On Fri, 17 Aug 2012 10:11:29 -0700 (PDT)
desi babu wrote:
> Guest-Agent : Windows 2008 Error : Relase 1.1.90
>
> error : internal error unable to execute QEMU command
> 'guest-fsfreeze-freeze': this feature or command is not currently supported.
That's correct, fsfreze is not supported on Wind
On Sun, 19 Aug 2012 12:12:29 +0200
Laszlo Ersek wrote:
> On 08/18/12 22:51, Stefan Weil wrote:
> > valgrind report:
> >
> > ==24534== 232 bytes in 2 blocks are definitely lost in loss record 1,245 of
> > 1,601
> > ==24534==at 0x4824F20: malloc (vg_replace_malloc.c:236)
> > ==24534==by 0
:
> /src/qemu/monitor.c:2575: warning: unused variable 'mon_fd_flags'
> /src/qemu/monitor.c:2574: warning: unused variable 'mon_fdset_fd'
> /src/qemu/monitor.c:2573: warning: unused variable 'mon_fdset'
>
> Signed-off-by: Blue Swirl
Reviewed-by: Luiz Capituli
On Mon, 20 Aug 2012 07:25:13 -0600
Eric Blake wrote:
> On 08/19/2012 10:39 PM, Amos Kong wrote:
> > This series converted 'sendkey' command to qapi. The raw value
> > in hexadecimal format is not supported by 'send-key' of qmp.
>
> Are we still trying to get this into 1.2, or have we missed that
On Mon, 20 Aug 2012 01:39:37 +0200
Igor Mammedov wrote:
> needed to prevent build breakage when CPU becomes a child of DeviceState
>
> Signed-off-by: Igor Mammedov
> ---
> scripts/qapi-types.py |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/qapi-types.p
On Mon, 20 Aug 2012 01:39:38 +0200
Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov
> ---
> error.h |1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/error.h b/error.h
> index 96fc203..643a372 100644
> --- a/error.h
> +++ b/error.h
> @@ -14,7 +14,6 @@
>
> #inc
On Mon, 20 Aug 2012 15:01:37 +0100
"Daniel P. Berrange" wrote:
> From: "Daniel P. Berrange"
>
> The qmp-shell code assumes the JSON response is only on a single
> line. If the QEMU monitor is configured in "pretty print" mode
> the JSON response can be multi-line. The basic Python JSON APIs
> d
On Mon, 20 Aug 2012 15:02:23 +0100
"Daniel P. Berrange" wrote:
> From: "Daniel P. Berrange"
>
> By default, the JSON reply is parsed and the corresponding python
> object printed on the console. When developing JSON client apps
> for QEMU though, it is handy to see the raw JSON document instead
On Mon, 20 Aug 2012 19:25:02 +0100
"Daniel P. Berrange" wrote:
> On Mon, Aug 20, 2012 at 03:03:11PM -0300, Luiz Capitulino wrote:
> > On Mon, 20 Aug 2012 15:01:37 +0100
> > "Daniel P. Berrange" wrote:
> >
> > > From: "Daniel P. Berr
On Mon, 20 Aug 2012 15:31:38 +0100
"Daniel P. Berrange" wrote:
> From: "Daniel P. Berrange"
>
> Add a 'query-target' QAPI command to allow management applications
> to determine what target architecture a QEMU binary is emulating
> without having to parse the binary name or -help output
>
>
On Mon, 20 Aug 2012 19:55:10 +
Blue Swirl wrote:
> On Mon, Aug 20, 2012 at 3:08 PM, Luiz Capitulino
> wrote:
> > On Sat, 18 Aug 2012 20:14:54 +
> > Blue Swirl wrote:
> >
> >> Some variables are only used on !win32, declare
> >> them only whe
On Tue, 21 Aug 2012 11:07:50 +0100
"Daniel P. Berrange" wrote:
> On Mon, Aug 20, 2012 at 04:02:39PM -0300, Luiz Capitulino wrote:
> > On Mon, 20 Aug 2012 15:31:38 +0100
> > "Daniel P. Berrange" wrote:
> >
> > > From: "Daniel P. Berrange&qu
On Mon, 20 Aug 2012 14:34:34 -0500
Michael Roth wrote:
> On Mon, Aug 20, 2012 at 10:54:29AM -0300, Luiz Capitulino wrote:
> > On Fri, 17 Aug 2012 10:11:29 -0700 (PDT)
> > desi babu wrote:
> >
> > > Guest-Agent : Windows 2008 Error : Relase 1.1.90
> > >
s fixing an important omission from my no-success-response
support:
Reviewed-by: Luiz Capitulino
Tested-by: Luiz Capitulino
> ---
> diff to v2:
> -fixed typo and field description
>
> diff to v1:
> -changed condition in qmp_command_reports_success per Paolo's advice
&
vent before quitting the src process.
>
> Signed-off-by: Yonit Halperin
Acked-by: Luiz Capitulino
> ---
> monitor.c |1 +
> monitor.h |1 +
> ui/spice-core.c |9 -
> 3 files changed, 10 insertions(+), 1 deletions(-)
>
> diff --git a/mo
ibvirt is restored and queries the migration status, it also needs
> to query spice and check if its migration has completed.
>
> Signed-off-by: Yonit Halperin
Acked-by: Luiz Capitulino
> ---
> hmp.c|2 ++
> qapi-schema.json |5 -
> ui/spice-core.c |
On Sat, 18 Aug 2012 07:02:50 -0600
Eric Blake wrote:
> On 08/18/2012 05:17 AM, Juan Quintela wrote:
> > Signed-off-by: Juan Quintela
> > ---
> > hmp.c| 4 ++--
> > migration.c | 6 +++---
> > qapi-schema.json | 14 +++---
> > qmp-commands.hx | 6 +++---
> > 4 files
101 - 200 of 5376 matches
Mail list logo
