Re: [Qgis-developer] QGIS and Coverity scans

2015-02-11 Thread Hugo Mercier
Hi Jürgen, Le 11/02/2015 14:18, Jürgen E. Fischer a écrit : Hi Hugo, On Wed, 11. Feb 2015 at 14:04:56 +0100, Hugo Mercier wrote: What would be very good is to call static analyzers during the build/testing process (as an option). Has somebody experiences with such things ? CLang static

Re: [Qgis-developer] QGIS and Coverity scans

2015-02-11 Thread Jürgen E . Fischer
Hi Hugo, On Wed, 11. Feb 2015 at 17:18:03 +0100, Hugo Mercier wrote: We have used cppcheck - but not integrated into the build process. There are also some good options for gcc (eg. -Weffc++). Good to know. A CMake option with such compilation flags can be a first pass. Using another

Re: [Qgis-developer] QGIS and Coverity scans

2015-02-11 Thread Nyall Dawson
On 12 February 2015 at 08:45, Jürgen E. j...@norbit.de wrote: I didn't know clang's scan-build[1] before Even Rouault mentioned it on #qgis. Maybe we could use that with travis. But it's not packaged in ubuntu and apparently you have to build clang to get it. It's shipped with the

Re: [Qgis-developer] QGIS and Coverity scans

2015-02-11 Thread Nyall Dawson
On 12 February 2015 at 00:18, Jürgen E. j...@norbit.de wrote: Hi Hugo, On Wed, 11. Feb 2015 at 14:04:56 +0100, Hugo Mercier wrote: I am curious about Coverity. AFAIK, the static analyzer is not open source, right ? So this works as long as they offer if freely for open source projects.

[Qgis-developer] QGIS and Coverity scans

2015-02-11 Thread Nyall Dawson
Hi all, If you've been following recent git commits, you'll have noticed a lot of Coverity related commits, and may be wondering what these are all about. Coverity Scan ( https://scan.coverity.com/ ) is a powerful automated static code analyser which is able to detect a large number of code

Re: [Qgis-developer] QGIS and Coverity scans

2015-02-11 Thread G. Allegri
That's a great thing Nyall. It proves QGIS is an industry level product from the side of code quality! Thanks from me and Gis3W. giovanni 2015-02-11 12:29 GMT+01:00 Nathan Woodrow madman...@gmail.com: Thanks to Jürgen and Martin's assistance And yours of course. This is some great

Re: [Qgis-developer] QGIS and Coverity scans

2015-02-11 Thread Richard Duivenvoorde
On 11-02-15 12:29, Nathan Woodrow wrote: Thanks to Jürgen and Martin's assistance And yours of course. This is some great stabilization to the product. Yes, thanks Nyall !! Also for communicating this to us. What about (/me not pushing, I'm a very slow writer myself...) writing a small

Re: [Qgis-developer] QGIS and Coverity scans

2015-02-11 Thread Nathan Woodrow
Thanks to Jürgen and Martin's assistance And yours of course. This is some great stabilization to the product. - Natahn On Wed Feb 11 2015 at 9:13:32 PM Nyall Dawson nyall.daw...@gmail.com wrote: Hi all, If you've been following recent git commits, you'll have noticed a lot of Coverity

Re: [Qgis-developer] QGIS and Coverity scans

2015-02-11 Thread George Silva
Congratulations to everyone. Code quality is something that matters on the long run. Since QGIS only gets better, I envision a big marathon :P. Anyone who develops software and understands what these metrics mean know they are significant, so congratulations again. George On Wed, Feb 11, 2015

Re: [Qgis-developer] QGIS and Coverity scans

2015-02-11 Thread Hugo Mercier
Hi, These are great news, thanks ! I am curious about Coverity. AFAIK, the static analyzer is not open source, right ? So this works as long as they offer if freely for open source projects. What would be very good is to call static analyzers during the build /testing process (as an option).

Re: [Qgis-developer] QGIS and Coverity scans

2015-02-11 Thread Jürgen E . Fischer
Hi Hugo, On Wed, 11. Feb 2015 at 14:04:56 +0100, Hugo Mercier wrote: I am curious about Coverity. AFAIK, the static analyzer is not open source, right ? So this works as long as they offer if freely for open source projects. Right. It's propietary. And IMHO it's also a heavy depencency

Re: [Qgis-developer] QGIS and Coverity scans

2015-02-11 Thread Nathan Woodrow
I am curious about Coverity. AFAIK, the static analyzer is not open source, right ? So this works as long as they offer if freely for open source projects. Right. It's propietary. And IMHO it's also a heavy depencency Not sure I find that to be much of a issue. Use what ever works, it

Re: [Qgis-developer] QGIS and Coverity scans

2015-02-11 Thread Hugo Mercier
Le 11/02/2015 14:24, Nathan Woodrow a écrit : I am curious about Coverity. AFAIK, the static analyzer is not open source, right ? So this works as long as they offer if freely for open source projects. Right. It's propietary. And IMHO it's also a heavy depencency Not sure I find that to