Re: [PATCH] High-performance qpsmtpd daemon

2006-05-31 Thread Gordon Rowell
Lars Roland wrote: Removing the daemonize stuff completely is going a bit to far (at least from my point of view), it should never be required (or desirable due to its crappy license) to have supervise installed FYI - we've been here before on this list - you don't need to use supervise: http:

Re: [PATCH] High-performance qpsmtpd daemon

2006-05-31 Thread Lars Roland
On 5/31/06, Gordon Rowell <[EMAIL PROTECTED]> wrote: Lars Roland wrote: > Removing the daemonize stuff completely is going a bit to far (at > least from my point of view), it should never be required (or > desirable due to its crappy license) to have supervise installed FYI - we've been here bef

Re: [PATCH] High-performance qpsmtpd daemon

2006-05-31 Thread Matt Sergeant
On 31-May-06, at 2:55 AM, Lars Roland wrote: On 5/31/06, Matt Sergeant <[EMAIL PROTECTED]> wrote: There's a couple of bugs in your patch (missing disconnect code, so QUIT never works). The following fixes that, and removes the daemonize stuff. Removing the daemonize stuff completely is going

Re: [PATCH] High-performance qpsmtpd daemon

2006-05-31 Thread Lars Roland
On 5/31/06, Matt Sergeant <[EMAIL PROTECTED]> wrote: > Removing the daemonize stuff completely is going a bit to far (at > least from my point of view), I agree. Though I do think since we now have qpsmtpd-prefork and qpsmtpd-forkserver, we should use a wrapper for daemonizing. Matt. This wo

Re: [PATCH] High-performance qpsmtpd daemon

2006-05-31 Thread John Peacock
Lars Roland wrote: This would be ideal in order to minimize code duplication and give users maximum choice (supervice/rnuit/deamonize/...). OK, I committed the code that Lars submitted (with my little change), then I applied the patch that Matt proposed (minus some whitespace changes that obs

Re: [PATCH] High-performance qpsmtpd daemon

2006-05-31 Thread Robin Bowes
John Peacock wrote: > Lars Roland wrote: >> This would be ideal in order to minimize code duplication and give >> users maximum choice (supervice/rnuit/deamonize/...). > > OK, I committed the code that Lars submitted (with my little change), > then I applied the patch that Matt proposed (minus som

Bug in 'auth'?

2006-05-31 Thread sub-qp-smtpd
I'm using a modified auth plugin as supplied in 0.32. The arguments are passed: my ( $self, $transaction, $method, $user, $passClear, $passHash, $ticket ) = @_ ; And the test condition, there should be a match on the second 'and' pair: if ( ( ( defined $passClear )