Re: Correcting plugin syntax errors

2008-07-29 Thread Matt Sergeant
On Tue, 29 Jul 2008, Jose Luis Martinez wrote: BTW: any comment on how to elaborate a testing framework. Comments from the QP-gurus would be helpful. For some in house code here that's similar to Qpsmtpd we basically have a data driven test system. You specify in a config file what plugins to

Re: Correcting plugin syntax errors

2008-07-29 Thread Peter J. Holzer
On 2008-07-28 22:54:20 -0700, Robert Spier wrote: > Matt Sergeant wrote: > > On Mon, 28 Jul 2008 20:47:39 -0400, Brian Szymanski wrote: > > > Then let's make that diff instead - remove all the "use > > > Qpsmtpd::Constants" in plugins, and add your test harness? > > > > I agree. Make your tester r

Re: Correcting plugin syntax errors

2008-07-29 Thread Jose Luis Martinez
Matt Sergeant escribió: On Mon, 28 Jul 2008 20:47:39 -0400, Brian Szymanski wrote: Then let's make that diff instead - remove all the "use Qpsmtpd::Constants" in plugins, and add your test harness? I agree. Make your tester run the same code in Qpsmtpd.pm (or is it now in Plugin.pm, I don't r

Re: Modifiying DNSBL plugin

2008-07-29 Thread Jose Luis Martinez
Jim Murray escribió: Would anyone here be kind enough to point out my stupidty and put me on the right track? Code seems OK. Is your plugin beeing executed before the relay_client flag is activated by other plugins? Jose Luis Martinez [EMAIL PROTECTED]

Re: Correcting plugin syntax errors

2008-07-29 Thread Ask Bjørn Hansen
The inspiration for the "file based plugins" were Apache::Registry in mod_perl -- hide as much of the nitty gritty as possible and allow the user to just write the code that actually does stuff for them. On that track then I think it's reasonable to add whatever boiler plate code is need