On Mon, Apr 28, 2014 at 11:02 AM, Charlie Brady
charlieb-qpsm...@budge.apana.org.au wrote:
On Mon, 28 Apr 2014, Matt Simerson wrote:
On Apr 28, 2014, at 10:57 AM, Charlie Brady
charlieb-qpsm...@budge.apana.org.au wrote:
I'm guessing that Matt didn't intend this information to be
Are all of these changes backwards compatible? If not, consider bumping up
the version number to 1.5 or 1.9 or something.
Thanks for taking this on Matt!
-R
On Mon, Aug 5, 2013 at 12:03 PM, Matt Simerson m...@tnpi.net wrote:
I intend to merge my fork directly onto the main repo. See the
Please combine this into the previous patch. Actually, I applied it
anyway, see below.
These patch dumps are really hard to deal with. They often contain
multiple overlapping patches all dealing with similar things. Also, not
all the patches are making it through. In the recent set [PATCH
On Mon, May 7, 2012 at 11:43 PM, Matt Simerson m...@tnpi.net wrote:
These 3 auth plugins all have a data store they fetch the reference
password or hash from. They then match the attemped password or hash
against the reference. This consolidates the latter portion (validating
the
+
+=head2 reject
+
+Set to a value between 1 and 6 to enable the following SPF behaviors:
+
+ 1 annotate-only, add Received-SPF header, no rejections.
Should this be reject 0? It's not really reject.
+ 2 defer on DNS failures. Assure there's always a meaningful SPF header.
+ 3
Applied.
Applied.
I'm not seeing it. What makes this one a standalone script?
On Mon, May 7, 2012 at 12:35 AM, Matt Simerson m...@tnpi.net wrote:
---
plugins/tls |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/plugins/tls b/plugins/tls
index 1be2245..c2ac7de 100644
--- a/plugins/tls
Applied with /usr/bin/true - /bin/true. A cursory check of a few systems
showed they all had /bin/true, not /usr/bin/true
Applied.
Applied.
Applied
We might want to consider factoring some of this out into a sub so we can
more easily tweak it later.
i.e.
$self-log( LOGWARN, log_fail(cannot_authenticate))
or maybe even adding fail to the class.
hrm.
-$self-log( LOGWARN, Cannot authenticate using authdeny );
+$self-log(
Applied.
Applied.
Applied.
Applied (via cherry-pick.)
On Mon, May 7, 2012 at 12:36 AM, Matt Simerson m...@tnpi.net wrote:
whitespace changes (stinkin windows newline chars)
Are there any more windows newlines hiding? Maybe we get rid of them all
at once.
-R
Applied.
Applied.
On Sun, May 6, 2012 at 11:17 AM, Matt Simerson m...@tnpi.net wrote:
enable plugin syntax checks for developers
---
t/01-syntax.t |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/01-syntax.t b/t/01-syntax.t
index d7dafd1..5be4de7 100644
--- a/t/01-syntax.t
Applied.
On Sun, May 6, 2012 at 11:18 AM, Matt Simerson m...@tnpi.net wrote:
improve readability in SMTP::auth_parse_respond
---
lib/Qpsmtpd/SMTP.pm | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/lib/Qpsmtpd/SMTP.pm b/lib/Qpsmtpd/SMTP.pm
index
Applied.
On Sun, May 6, 2012 at 11:17 AM, Matt Simerson m...@tnpi.net wrote:
confine SMTP.pm duplicate logging to LOGDEBUG
---
lib/Qpsmtpd/SMTP.pm |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/Qpsmtpd/SMTP.pm b/lib/Qpsmtpd/SMTP.pm
index 7c126dd..bb03011
Applied.
On Sun, May 6, 2012 at 11:17 AM, Matt Simerson m...@tnpi.net wrote:
SMTP.pm, add missing ; and remove useless if
---
lib/Qpsmtpd/SMTP.pm |6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/lib/Qpsmtpd/SMTP.pm b/lib/Qpsmtpd/SMTP.pm
index 7c126dd..d8734b6
I think I like the concept, I'm concerned about backwards compatibility
with people who have written log parsers. I was going to just apply it,
but ... it doesn't apply cleanly to the head of the tree, so I'm going to
skip it for now. Please re-sync and add an entry to Changes.
Thanks!
-R
On
Applied with commented out section removed.
+#if ( $hook =~ /^auth/i ) {
+#warn sprintf( run_hooks called by %s, %s, %s\n, (caller) );
+#};
On Sun, May 6, 2012 at 1:55 PM, Matt Simerson m...@tnpi.net wrote:
---
lib/Qpsmtpd.pm | 30 ++
plugins/logging/warn |
Ok, I found it's dependency, it came in out of order. Applied after a
whitespace fix.
On Sun, May 6, 2012 at 3:55 PM, Robert Spier rsp...@pobox.com wrote:
I think I like the concept, I'm concerned about backwards compatibility
with people who have written log parsers. I was going to just
Applied.
On Sun, May 6, 2012 at 1:56 PM, Matt Simerson m...@tnpi.net wrote:
removed TODO, p0f v3 doesn't need that extra info
removed some stray EOL chars
---
lib/Qpsmtpd/TcpServer.pm | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git
Applied.
On Sun, May 6, 2012 at 1:58 PM, Matt Simerson m...@tnpi.net wrote:
added vpopmail_sql db connect error handling.
---
plugins/auth/auth_vpopmail_sql |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/plugins/auth/auth_vpopmail_sql
Applied.
On Sun, May 6, 2012 at 1:58 PM, Matt Simerson m...@tnpi.net wrote:
converted comments to POD
---
plugins/check_relay | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/plugins/check_relay b/plugins/check_relay
index fcb3054..06034e7 100644
---
Applied.
On Sun, May 6, 2012 at 1:59 PM, Matt Simerson m...@tnpi.net wrote:
Command.pm, promoted strictures to 1st line of code
---
lib/Qpsmtpd/Command.pm |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/Qpsmtpd/Command.pm b/lib/Qpsmtpd/Command.pm
index
Applied.
On Sun, May 6, 2012 at 1:59 PM, Matt Simerson m...@tnpi.net wrote:
added logging and tests to check_badmailfrom
refactored several checks out of hook_mail and added LOGDEBUG
added tests for is_immune method
---
plugins/check_badmailfrom| 27 +++
Applied.
Applied.
Applied.
This CL doesn't apply because there are some whitespace changes, and it is
dependent on another CL to create the tests file.
Applied.
Applied.
Applied.
Applied.
Applied.
Applied.
Applied.
Matt,
How did you generate/mail those patches? They're getting munged and
git/patch can't apply them. I blame Apple Mail. I ended up
cherry-picking them manually from your git repository, which wasn't great,
because the emails were in a different order than in the repo, which caused
all
This change is not backward compatible.
On Apr 29, 2012 12:40 AM, GitHub nore...@github.com wrote:
Branch: refs/heads/master
Home: https://github.com/smtpd/qpsmtpd
Commit: 368ce9401bab0570b692133a158df882ceac2431
and check_badrcptto_patterns as well.
Thoughts?
Matt
On Apr 29, 2012, at 12:44 AM, Robert Spier wrote:
This change is not backward compatible.
On Apr 29, 2012 12:40 AM, GitHub nore...@github.com wrote:
Branch: refs/heads/master
Home: https://github.com/smtpd/qpsmtpd
Commit
and check_badrcptto_patterns as well.
Thoughts?
Matt
On Apr 29, 2012, at 12:44 AM, Robert Spier wrote:
This change is not backward compatible.
On Apr 29, 2012 12:40 AM, GitHub nore...@github.com wrote:
Branch: refs/heads/master
Home: https://github.com/smtpd/qpsmtpd
Commit
On Mon, Apr 23, 2012 at 8:39 AM, Matt Simerson m...@tnpi.net wrote:
On Apr 22, 2012, at 11:45 PM, Robert Spier rsp...@pobox.com wrote:
This change contains a bunch of unnecessary whitespace changes. This
can make it hard to trace back to original changes. I'm not saying there's
On Mon, Apr 23, 2012 at 1:02 PM, Matt Simerson m...@tnpi.net wrote:
On Apr 22, 2012, at 11:43 PM, Robert Spier wrote:
On Sun, Apr 22, 2012 at 2:25 PM, Matt Simerson m...@tnpi.net wrote:
Makes it much easier to figure out where that log entry came from.
---
t/plugin_tests/auth
Maybe the time has come to do a release (0.9?) and then open things up
for major cleanups/changes.
This might actually be 0.85, but that's irrelevant.
-R
I'm all in favor.
I'm doing more work on plugins right now and have a bunch more changes in
the pipes. Most of the changes
On Sat, Apr 28, 2012 at 7:54 PM, Ask Bjørn Hansen a...@develooper.comwrote:
On Apr 28, 2012, at 13:41, Robert Spier rsp...@pobox.com wrote:
One thing that would help is if you could split your changes into
multiple
pull requests -- if we're going to try using github as our mechanism
On Sun, Apr 22, 2012 at 2:25 PM, Matt Simerson m...@tnpi.net wrote:
Makes it much easier to figure out where that log entry came from.
---
t/plugin_tests/auth/auth_flat_file |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/plugin_tests/auth/auth_flat_file
This change contains a bunch of unnecessary whitespace changes. This can
make it hard to trace back to original changes. I'm not saying there's not
a need for a whitespace cleanup, but I wonder if it would be better to do
it all at once?
On Sun, Apr 22, 2012 at 2:25 PM, Matt Simerson
On Sun, Apr 22, 2012 at 2:22 PM, Matt Simerson m...@tnpi.net wrote:
---
plugins/spamassassin |9 +
1 file changed, 9 insertions(+)
diff --git a/plugins/spamassassin b/plugins/spamassassin
index 4ca890e..534d712 100644
--- a/plugins/spamassassin
+++ b/plugins/spamassassin
@@
Richard Siddall wrote:
I just noticed that 0.84 includes plugins/logging/file, which is
another version of Peter J. Holzer and Devin Carraway's file logging
plugin, similar to
packaging/rpm/files/qpsmtpd-plugins-file-connection.
I can't figure out which one is better, or newer. If we
One solution would be to add a new directory named 'backscatter' and
put both scripts in there with the same prefix (check_goodrcptto) and
with a distinguishing suffix (_postfix _qmail). That would be clear
to people that are interested in the subject.
Yes. Except backscatter isn't quite
Ask Bjørn Hansen wrote:
On Mar 10, 2011, at 6:49, Matt Sergeant wrote:
Should we have plugins/qmail and plugins/postfix dirs?
I like that idea.
I'm not sure I do. The existing directories don't really line up that
way, and I don't think we're going to have a huge number of
Tim Meadowcroft wrote:
On Thursday 10 March 2011 18:06:04 Robert Spier wrote:
Ask Bjørn Hansen wrote:
On Mar 10, 2011, at 6:49, Matt Sergeant wrote:
Should we have plugins/qmail and plugins/postfix dirs?
I like that idea.
I'm not sure I do. The existing directories don't
Todd Brunhoff wrote:
Your scripts look like they have a good deal of qmail
sophistication. Some years ago I ran qmail 1.0.3, after each major
system crash, I would revisit whether to use qmail, and eventually
decided to switch to qpsmtp+postfix because both seem to have better
I'm a little reluctant to apply this to core, as this is really
something that the Tumbleweed folks should fix on their side. Also,
this patch is only for Prefork, and it likely applies to every mode.
I'm not opposed to the concept, but would like to see it cleaned up,
and maybe factored into a
Thanks, applied as:
b7668c046879ab3e55a15bfec7d2708680cec58e
Peter J. Holzer wrote:
The mail hook sets a transaction note 'temp_resolver_failed', but the
rcpt hook queried a connection note of the same name (which didn't
exist, of course).
Now it queries the transaction note.
Robin Bowes wrote:
On 09/12/10 13:10, Robin Bowes wrote:
Hi,
I'd like to add the capability to white-list in the hosts_allow plugin.
Specifically, we have a relay that we expect to get multiple connections
from so I don't want to restrict connections from that IP.
I was
This was changed in
commit a52660a646012691f993cca821c00fe05cff08bb
Author: jaredj jar...@nmgi.com
Date: Wed Mar 25 07:38:05 2009 -0500
Spool body when $transaction-body_fh() is called
Qpsmtpd::Transaction::body_filename() calls $self-body_spool() if
the message body has not
[resending and including the list]
Tony Lambiris wrote:
Thoughts on the following changes to smtp-forward? These diffs were taken
against the svn smtp-forward checked out yesterday.
Thanks.
What are your intentions with this change? It's very much
not-backwards compatible as it changes
So if you're interested in the parsed mime functionality, your
plugin can plugin_use util/parsed-mime and the right magic happens.
Oh yeah that's right, someone *did* implement what you're talking about.
You can do it with 'plugin inheritance' (which ironically i knew nothing
about until
How about instead of hardcoding this, make deny be the default in the
sample config?
-R
Jared Johnson wrote:
Would anyone object to setting the default action to 'deny' on certain
reliable low-fp URIBL lists? Probably Spamhaus SBL-XBL and DBL and URIBL
Black. It seems like a new user
And by that, I mean..
I'm not sure I *object*, because there *are* blacklists we
trust... but in general, I think we try and avoid doing things that
could cause people to lose mail unintentionally. So I think I lean
slightly towards the consistent defaults of header tagging side.
-R
Robert
Jared Johnson wrote:
I think we should probably consider putting support for parsed messages
into core, with the parsing done lazily if requested by the API.
I forgot, we did kinda think of a couple of reasons not to want an API.
depending on where you put it, you may find QP in
Jared Johnson wrote:
- Introduces support for URIBL services that may not have worked right,
at
least out of the box, before. Defines the subtle differences between
various known URIBL services in order to maximize compatibility.
Is it worth pulling some of this config out of the
I've committed this as ab7c2601f0740fac1c3c117e7e5c0a5690348194.
I'm not 100% sure it's a good idea, but I think it's mostly a good
thing.
Charlie - It would be great if you could send patches instead of
suggestions.
-R
Charlie Brady wrote:
http://bugs.contribs.org/show_bug.cgi?id=5808
Fix committed as 9348539ed7aa03b438905f953771db14fcb4c1ea
Once again, a patch would have been great.
I haven't tested this, so any RPM users, please do.
-R
Charlie Brady wrote:
http://bugs.contribs.org/show_bug.cgi?id=6025
if ! id smtpd /dev/null 21
then
# need to create smtpd
Matt,
Could you integrate this kind of config into the tls plugin? That's
definitely nicer than hardcoding a cipher.
Thanks!
-R
Matt Simerson wrote:
Here's a chunk of code from one of my projects:
A config file setting allows an admin to choose from; all, high, medium, or
- Introduces support for URIBL services that may not have worked right, at
least out of the box, before. Defines the subtle differences between
various known URIBL services in order to maximize compatibility.
Is it worth pulling some of this config out of the code and putting it
into some
Applied: d0c9b7cbe5ec615e2e23b91072781019ad59ee19
Matt Simerson wrote:
---
plugins/greylisting |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/plugins/greylisting b/plugins/greylisting
index ebdec8f..7860b13 100644
--- a/plugins/greylisting
+++
Applied: 3a7f46aa3e75988686ef9fcae5158fc29f6a86f6
Matt Simerson wrote:
switched default TLS security in config/tls_ciphers from HIGH to HIGH:!SSLv2.
Added note for how to set the minimum level of security necessary for PCI
compliance.
---
config.sample/tls_ciphers |8 +++-
1
Thanks, Applied: 0c4a76ffe75190a82010dca5dd7e2bd4bdbe14cb
Matt Simerson wrote:
---
t/plugin_tests/check_badrcptto |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/t/plugin_tests/check_badrcptto b/t/plugin_tests/check_badrcptto
index 9f7b9c9..b9a986d 100644
---
Thanks, Applied!
d11b87e0509e1482e6c76f203d0d9cacd581db5e
Matt Simerson wrote:
renamed check_badrcptto test from foo to test_check_badrcptto_ok
---
t/plugin_tests/check_badrcptto |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/plugin_tests/check_badrcptto
Johan Almqvist wrote:
Hi!
On 11. juli 2010, at 06.36, Robert Spier wrote:
Since this is a proposed new plugin, it might be easier just to
attach the full file. It's also possible to convince git to mail
this as one thing...
Ok, I'll give it a shot.
Much better.
Please
It doesn't really matter to me, I just copied the basic perdoc part from some
other plugin too :) - maybe a note like in auth_checkpassword?
Applied, with some minor tweaks, including removing the copyright and
replacing it with attribution as
e2ee6f13e5d0e2f064143479193fbe4bbc8aeaf8.
Johan-
Since this is a proposed new plugin, it might be easier just to
attach the full file. It's also possible to convince git to mail
this as one thing...
Please include some example config in the plugin, so it is more
obvious how to use it.
Also, don't you need to rename the
Applied as 8b892c33ad456bf8f422b77292d0e288e5994643
Matt Simerson wrote:
correct copy/paste error, where auth_flat_file methods were named authsql in
auth_flat plugin
---
plugins/auth/auth_flat_file|4 ++--
t/plugin_tests/auth/auth_flat_file |6 +++---
2 files changed,
Applied, without trailing whitespace as
b1c3d2f333c807fb40b7a8e5d71086b54f69e562
Matt Simerson wrote:
added auth_vpopmail plugin, using the perl-vpopmail module
added VPOPMAIL auth methods description to docs/authentication
added SEE ALSO section to each module, noting the VPOPMAIL
Applied as 02912602842a5b2251b1455cf7206cfee3d18553 minus trailing whitespace.
Matt Simerson wrote:
rewrote the plugin using Mail::SPF, which is the replacement for
Mail::SPF::Query (by the same author). The two plugins are mutually
exclusive and SpamAssassin expects to have Mail::SPF
Applied as 671a6953b0c9503717bda10dd07f434cbd302c9c
Matt Simerson wrote:
(patch remade against latest rspier/qpsmtpd)
added remote_port, local_ip, local_port, and local_host to $qp-connection,
as the p0f plugin relies on it.
added notes to TcpServer.pm and the p0f plugin noting the
Applied as
cc2d8ccca6a7fafe2c08b7d180e81aeae8eb1b35
should there be a local_port option too?
Matt Simerson wrote:
(updated patch against rspier/qpsmtpd)
The p0f plugin defaulted to binding to TCPLOCALIP, which doesn't work
when the mail server is running behind a firewall with a private
Applied as
b81d464c872867f8df65847f522db6a0df4a96bf
Matt Simerson wrote:
- these changes are in the previous TCPLOCAL patch. Documented here.
added p0f config option
added POD docs to explain usage
modified $dbdir selection logic. The previous logic failed when QPHOME was
not selected
Applied as
e13952164df61ac289f9f124a7a8bc63d290d4bc
Something isn't right with the test config, unrelated to this CL, but
it looks like the greylisting test might not be being run.
Matt Simerson wrote:
added to MANIFEST
plugins/check_bogus_bounce (already committed to abh/head)
Does anyone else have any opinions on doing a massive perltidy? I'm
on the fence.
At the very least I'd go for the equivalent of a M-x untabify, but at
the point you're doing that, it's almost worth going all the day.
-R
Is it possible to merge this into smtp-forward and have config
options? Or factor out common code into a shared module?
Jason Mills wrote:
=head1 NAME
smtptls-forward
=head1 DESCRIPTION
This plugin forwards the mail via SMTP TLS to a specified server, rather than
delivering the
Matt Simerson wrote:
On May 11, 2010, at 9:19 PM, Robert Spier wrote:
FWIW, I'm still a little concerned about potentially breaking the p0f
plugin for people using the other qpsmtpd engines, but I'm happier to
have someone properly maintaining it, and we'll deal with fallout
later
As previously noted, the greylisting tests are not run unless the
greylisting plugin is enabled. It is not enabled in the
config.sample/plugins file.
This seems like a hole in our testing framework. I suspect we should
have a t/config/ directory or similar, so we run all the tests, even
the
First, thanks Matt for the bundle of patches, and for being willing to
have some back and forth and comments.
Second, I believe I've applied any outstanding patches I know about
that were sent to the mailing list recently. If I've ignored a patch,
please let me know, and I'll take a look. I
$ git am /tmp/285.eml
Applying: added p0f support to greylisting
fatal: corrupt patch at line 12
Patch failed at 0001 added p0f support to greylisting
When you have resolved this problem run git am --resolved.
If you would prefer to skip this patch, instead run git am --skip.
To restore the
Applied to my tree (via cherry-pick, as the email is mangled) as
5f81fd792594912882136afd33205683cfe786a8
Matt Simerson wrote:
---
lib/Apache/Qpsmtpd.pm |2 --
lib/Qpsmtpd/ConfigServer.pm |2 --
plugins/content_log |1 -
plugins/logging/file|1 -
Applied manually to my tree as e8cb1c3e94c9effc596aafb0442434d07098fc5d
another mangled patch.
General comments:
Please try and limit lines to 80 characters.
Please try and make the first line of the patch description short
(iirc, git likes 60 characters) and then use the 3rd and further
Matt Simerson wrote:
spamassassin plugin sets $username to first recipient in list when
spamd_user config option is set to 'vpopmail'. This allows per-user SA
prefs to function.
Can this be a config option, instead of magic ?
From: Matt Simerson msimer...@perl.org
Uh, no.
---
[Also sending to the list]
(Matt, the way you sent these patches was... odd.)
Robert Spier wrote:
Applied to my tree, manually, because something is mangling your
patches.
e4f5b86b4126b0fb2cf5f91ba2deaaebaec46af5
Matt Simerson wrote:
---
plugins/auth/auth_flat_file
$ git am /tmp/270.eml
Applying: Patch for p0f plugin
fatal: corrupt patch at line 11
Patch failed at 0001 Patch for p0f plugin
Matt Simerson wrote:
plugins/ident/p0f: added pod sections, added local_ip option
TcpServer.pm: added remote_port, local_ip, local_port, and local_host to
Assuming
http://github.com/msimerson/qpsmtpd/commit/6948c27205ebdec045604bd8d6bf6a3a04c35a8a
is the output of this experiment...
I'm not convinced that one big tidy is actually worth the
hassle/mess.
If we were to just fix the big issues, I think that would help most
places without causing the
Matt Simerson wrote:
On May 9, 2010, at 11:30 PM, Robert Spier wrote:
Applied manually to my tree as
e8cb1c3e94c9effc596aafb0442434d07098fc5d
another mangled patch.
I'm new to git, so I've been creating and emailing the patches per the
instructions in docs/development.pod
Applied to my tree as 08f8e7af496c22317445f0c34c5eb7dd2caec97c.
(I perltidy'd it first)
Matt Simerson wrote:
New and improved!
With POD! (because JP said so:
http://www.nntp.perl.org/group/perl.qpsmtpd/2005/06/msg3145.html)
Includes usage notes and a perl script useful for diagnosing a
Committed to my tree as 0ae24edc55804c4749a9da880ec45050bead629e.
(Trailing whtiespace cleaned up first.)
Matt Simerson wrote:
updates to auth_vpopmail_sql module
- moved vpopmail database parameters into config files
- added LIMITATIONS section to POD, noting no support for alias
Yes, they're applying cleanly.
-R
Matt Simerson wrote:
The last two patches (recently sent) are repeats, as the previous
versions were 'mangled'. Can someone confirm that they arrived and
apply cleanly? I sent them directly to the list via 'git send-email',
so I'm hoping that
1 - 100 of 352 matches
Mail list logo
