Avneesh,
You missed to update the Makefile infrastructure for the new directory
“make dist” does not add the new qpb directory to the tar it
creates.
(This causes theCentOS package fail to build on my CI system)
- Martin
On 11 Mar 2016, at 12:21, Avneesh Sachdev wrote:
Infrastructure that a
Continous Integration Result: FAILED
See below for issues.
This is an EXPERIMENTAL automated CI system.
For questions and feedback, feel free to email
Martin Winter .
Patches applied :
Patchwork 1857: http://patchwork.quagga.net/patch/1857
[quagga-dev,14880,1/3] bgpd, lib: Remove RESTRIC
There is actually a bug in “make check”
failing the “testcli” does not return an error exist status.
So my CI system didn’t detect the error initially, but then noticed
during the dejagnu log parsing the failure…
(It does for [most] other failures).
I’m going to add a hack to check for “FAIL:”
Ignore this first result from the CI system
Parsing of the result failed.
See the other CI email for real results (which still failed)
- Martin
On 11 Mar 2016, at 14:12, cisys...@netdef.org wrote:
Continous Integration Result: FAILED
See below for issues.
This is an EXPERIMENTAL automated CI
Martin -
I've pushed this patch to master.
donald
On Fri, Mar 11, 2016 at 6:15 PM, Martin Winter <
mwin...@opensourcerouting.org> wrote:
> Basic testing of the patch shows that this fixed the issue.
>
> I can do a run after it is committed to a branch
> (I would suggest to commit to master)
>
>
Basic testing of the patch shows that this fixed the issue.
I can do a run after it is committed to a branch
(I would suggest to commit to master)
Let’s hope that there aren’t more bad issues.
Full compliance run takes approx 1..2 days (Ubuntu 14.04 first), then
another 1..2 days (FreeBSD 10).
Continous Integration Result: SUCCESSFUL
Congratulations, this patch passed basic tests
Tested-by: NetDEF CI System
This is an EXPERIMENTAL automated CI system.
For questions and feedback, feel free to email
Martin Winter .
Patches applied :
Patchwork 1865: http://patchwork.quagga.net/patch/
On 11 Mar 2016, at 13:39, Paul Jakma wrote:
On Fri, 11 Mar 2016, Donald Sharp wrote:
The addition of a MIN(X,Y) with a stream_getc in the Y
causes a double read of the stream due to the way that
MIN is defined.
Ah bugger, Lou had noted that crash and I had fixed that incredibly
dumb bug, bu
Need to fix my log parsing for this case on the CI system, but basically
the “make check” for libzebra fails on all these systems:
11-Mar-2016 12:45:40=== libzebra tests ===
11-Mar-2016 12:45:40
11-Mar-2016 12:45:40Schedule of variations:
11-Mar-2016 12:45:40un
On Fri, 11 Mar 2016, Donald Sharp wrote:
The RESTRICTED_NODE command is not used, introduces code
complexity and provides no additional levels of security.
The only way to get into RESTRICTED_NODE is to add, under
vty configuration the command 'anonymous restricted', and
then telnet to a daemon
On Fri, 11 Mar 2016, Donald Sharp wrote:
The addition of a MIN(X,Y) with a stream_getc in the Y
causes a double read of the stream due to the way that
MIN is defined.
Ah bugger, Lou had noted that crash and I had fixed that incredibly dumb
bug, but with all back and forth between the public t
I just sent an email with the patch to fix this issue.
The issue stems from the usage of MIN(X, stream_getc(s)) right above where
the crash is happening.
MIN double accesses the stream.
donald
On Fri, Mar 11, 2016 at 3:29 PM, Martin Winter <
mwin...@opensourcerouting.org> wrote:
> On 11 Mar 20
The addition of a MIN(X,Y) with a stream_getc in the Y
causes a double read of the stream due to the way that
MIN is defined.
This fix removes a crash in all protocols.
Signed-off-by: Donald Sharp
---
bgpd/bgp_zebra.c | 8 ++--
isisd/isis_zebra.c | 4 +++-
ospf6d/ospf6_zebra.c | 4 +++
Continous Integration Result: FAILED
See below for issues.
This is an EXPERIMENTAL automated CI system.
For questions and feedback, feel free to email
Martin Winter .
Patches applied :
Patchwork 1857: http://patchwork.quagga.net/patch/1857
[quagga-dev,14880,1/3] bgpd, lib: Remove RESTRIC
Similar crash on FreeBSD 9.3
root@debugtest:/home/mdtancsa/quagga-1.0.20160309 # gdb bgpd
GNU gdb 6.1.1 [FreeBSD]
Copyright 2004 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under c
On 11 Mar 2016, at 5:09, Donald Sharp wrote:
> Martin -
>
> If I could get a decode of this:
>
> 2016/03/09 09:42:20 BGP: [bt 3] bgpd(+0x5c2f0) [0x7f495cb132f0]
>
> I could probably fix/narrow down the problem real fast.
Ok, did a run with full symbols and looked into the reason for it.
Here is
Infrastructure that allows protocol buffers to be used in Quagga. The
changes below comprise of:
- Build hooks
- Protobuf definitions for common types.
- Library routines for working with protobuf, including functions
that help translate between common quagga types and their protobuf
This functionality is only compiled into a developer build, It allows
test functions to be invoked by name from the vtysh as follows.
Changes:
* vtysh/vtysh.c
Handle the 'invoke function [args]' command.
Forward it the client with the given name.
* lib/vty_invoke.c
Code that
Code that allows a client to convey routes to a Forwarding Plane
Manager component using protobuf instead of netlink..
* fpm/fpm.proto
Protobuf definitions pertaining to the Forwarding Plane Manager.
In particular, this file defines the AddRoute and DeleteRoute
messages.
* fpm/fp
Hi,
This patch set is related to the use of protobuf as a
messaging/serialization format. A quick overview of the patches:
- Patch 1
Infrastructure for using protobuf in quagga. This includes
build-related changes, protobuf definitions for common quagga
types and a library of routi
Change zebra so that it can optionally use protobuf serialization when
communicating with a Forwarding Plane Manager component.
* zebra/main.c
Add the --fpm-format/-F command line option. This allows the user
to control the format (protbuf|netlink) that is used to
communicate with t
Add test functions for the zebra code that interfaces with the
Forwarding Plane Manager. These functions can be invoked in a
development build via the recently-added 'invoke' command.
For example:
# invoke zebra function zfpm_dt_benchmark_protobuf_encode 10
Changes:
* zebra/zebra_fpm_dt
* configure.ac
Add the --enable-dev-build flag. It controls the DEV_BUILD
define for autoconf and automake, which can be used to
conditionally build in code that is only intended for development..
Signed-off-by: Avneesh Sachdev
---
configure.ac | 8
1 file changed, 8 inse
The RESTRICTED_NODE command is not used, introduces code
complexity and provides no additional levels of security.
The only way to get into RESTRICTED_NODE is to add, under
vty configuration the command 'anonymous restricted', and
then telnet to a daemon, provide a password, then type
'enable' and
If a command is put into the VIEW_NODE, it is going into the
ENABLE_NODE as well. This is especially true for show commands.
As such if a command is in both consolidate it down to VIEW_NODE.
Signed-off-by: Donald Sharp
---
bgpd/bgp_encap.c | 19 ---
bgpd/bgp_route.c | 360 -
If you are in VIEW_NODE, the command should exist in ENABLE_NODE
as well. This is being done to reduce chances of code being
added to one but not the other NODE.
Signed-off-by: Donald Sharp
---
lib/command.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/command.c b/lib/command.c
in
The quagga cli is a complicated beast. This is an attempt
to reduce some code complexity and make it a bit easier
for programmers to work within it's confines.
These patches do two things:
1) Removes RESTRICTED_NODE
2) Combines the usage of VIEW_NODE and ENABLE_NODE as that
being in VIEW_NODE im
Hello.
I'm sorry for post to very old thread but I found a
project with a similar problem I think. The ClamAV.
It contains 12 licenses in source tarball:
COPYING GPL v2
COPYING.LGPLLGPL v2.1
COPYING.bzip2 BSD like
COPYING.fileBSD like
COPYING.getopt ?
COPYING.llvmBSD like
C
Yep you're right. I'll rethink the patch. As that I'm seeing compiler
warnings when I build on freebsd and I'm attempting to clean them up a bit.
donald
On Fri, Mar 11, 2016 at 1:24 AM, Timo Teras wrote:
> On Thu, 10 Mar 2016 20:16:46 -0500
> Donald Sharp wrote:
>
> > The #ifdef HAVE_STRUCT_
Martin -
If I could get a decode of this:
2016/03/09 09:42:20 BGP: [bt 3] bgpd(+0x5c2f0) [0x7f495cb132f0]
I could probably fix/narrow down the problem real fast.
thanks!
donald
On Thu, Mar 10, 2016 at 8:59 PM, Martin Winter <
mwin...@opensourcerouting.org> wrote:
> (New thread so people ac
30 matches
Mail list logo
