[quagga-dev 15402] Strawman Quagga Release Process

2016-05-26 Thread Donald Sharp
All - Lou and I have taken a first pass at the release document that was discussed in the meeting. This description was inspired by, and loosely based on the Ubuntu release process [https://wiki.ubuntu.com/UbuntuDevelopment/ReleaseProcess]. This document is available at the google doc listed bel

[quagga-dev 15401] Re: [PATCH] lib: add skiplists; use for thread sorting by default

2016-05-26 Thread Lou Berger
On 5/26/2016 1:00 PM, Christian Franke wrote: > On 05/26/2016 05:55 PM, G. Paul Ziemba wrote: >> p...@jakma.org (Paul Jakma) writes: >> >>> Cool. >>> I was going to ask if skiplist was the most appropriate DS for timer, >>> though regardless, surely a lot better than a simple list. ;) >> I recal

[quagga-dev 15400] Re: [PATCH 01/25] lib: write "exit" to config after last route-map

2016-05-26 Thread Lou Berger
Paul, I view this as a style issue/discussion. I personally think any block that accepts an exit should have the exit so that humans reading the config file don't miss the context change. As it's a style issue, I thought Donald's point on consistency across the CLI was valid. As I wasn't inter

[quagga-dev 15399] Re: [PATCH] lib: add skiplists; use for thread sorting by default

2016-05-26 Thread Christian Franke
On 05/26/2016 05:55 PM, G. Paul Ziemba wrote: > p...@jakma.org (Paul Jakma) writes: > >> Cool. > >> I was going to ask if skiplist was the most appropriate DS for timer, >> though regardless, surely a lot better than a simple list. ;) > > I recall a few years ago we (possibly on this list) did

[quagga-dev 15398] Re: [PATCH] lib: add skiplists; use for thread sorting by default

2016-05-26 Thread G. Paul Ziemba
p...@jakma.org (Paul Jakma) writes: >Cool. >I was going to ask if skiplist was the most appropriate DS for timer, >though regardless, surely a lot better than a simple list. ;) I recall a few years ago we (possibly on this list) did some experimentation with timer performance and found that the

[quagga-dev 15397] Re: [PATCH] perfect cmd table

2016-05-26 Thread Paul Jakma
Hi, Ignore the previous messages, I hadn't caught the resubmissions as the (non-automated, user-supplied) part of the subject had changed. This applies, and I'll queue it up for the next integration round. That may or may not lead to further review comments. Regardless, it still needs a good

[quagga-dev 15395] Re: Patch: Perfect command "table"

2016-05-26 Thread Paul Jakma
Hi, Your patch adds the following warnings to the build. zebra_rib.c: In function ‘rib_add_ipv4’: zebra_rib.c:1761:5: warning: implicit declaration of function ‘zebra_route_tables_create’ [-Wimplicit-function-declaration] zebra_route_tables_create(zvrf, table_id); ^ zebra_rib.c: In fu

[quagga-dev 15396] Re: Patch: Perfect command "table"

2016-05-26 Thread Paul Jakma
Hi, Also, this needs some kind of commit message to explain what it's meant to achieve and the approach the commit is taking. Thanks, Paul On Fri, 22 Jan 2016, 林守磊 wrote: Donald Patchwork reports fail again with the same reason ( http://patchwork.quagga.net/patch/1794/ ). That really hit

[quagga-dev 15394] Re: [PATCH 07/10] lib: add skiplist

2016-05-26 Thread Lou Berger
Paul, So what do you want to see? The author says: > Completely free, do whatever you want with it. > > No warranties or guaranteed of any kind, other than that it original code > written by me that I am gave to the world. I then proposed the current text as a more formal formulation to which h

[quagga-dev 15393] Re: [PATCH v2 01/30] lib: write "exit" to config after last route-map

2016-05-26 Thread Paul Jakma
For the benefit of patchwork 1751, see: https://lists.quagga.net/pipermail/quagga-dev/2016-May/015474.html https://lists.quagga.net/pipermail/quagga-dev/2016-January/014463.html On Tue, 12 Jan 2016, Lou Berger wrote: The last route-map written to config should have an "exit" at the end to retu

[quagga-dev 15392] Re: [PATCH 01/25] lib: write "exit" to config after last route-map

2016-05-26 Thread Paul Jakma
On Tue, 5 Jan 2016, Lou Berger wrote: On 1/5/2016 9:10 AM, Donald Sharp wrote: I'm not sure that exit is the right way to go here, or at least I would like some sort of agreement from everyone on what is the right thing to write and then to actually make the cli entirely consistent along thes

[quagga-dev 15391] Re: [PATCH 07/10] lib: add skiplist

2016-05-26 Thread Paul Jakma
On Tue, 17 May 2016, Lou Berger wrote: + * Permission to include in quagga provide by William Pugh on March 31, 2016 + * The author makes no claim/restriction on use. It is provided "AS IS". We probably need something a bit clearer than that, not least to satisfy other parties (e.g. Savannah