[quagga-dev 15632] CI Testresult: FAILED (Re: [quagga-dev, 15630] bgpd: eliminate RD related duplicate code in bgp_encap.c)

Continous Integration Result: FAILED See below for issues. This is an EXPERIMENTAL automated CI system. For questions and feedback, feel free to email Martin Winter . Patches applied : Patchwork 2004: http://patchwork.quagga.net/patch/2004

[quagga-dev 15631] Re: [PATCH 10/10] bgpd: add L3/L2VPN Virtual Network Control feature

Philippe, I've posted a fix to this (patch on patch) in https://github.com/LabNConsulting/quagga-vnc/commit/cd54370cb94d598aa95bd7561cc012200920d97a If you can take a look and comment that would be great. My plan is to submit a v2 of the whole patch set once issues raised have been addressed.

[quagga-dev 15630] [PATCH] bgpd: eliminate RD related duplicate code in bgp_encap.c

--- bgpd/bgp_encap.c | 45 - bgpd/bgp_mplsvpn.c | 8 bgpd/bgp_mplsvpn.h | 4 3 files changed, 8 insertions(+), 49 deletions(-) diff --git a/bgpd/bgp_encap.c b/bgpd/bgp_encap.c index d21924c..bd150ce 100644 --- a/bgpd/bgp_encap.c +++

[quagga-dev 15629] CI Testresult: PASSED (Re: [quagga-dev, 15623] lib: Clean command.c)

Continous Integration Result: SUCCESSFUL Congratulations, this patch passed basic tests Tested-by: NetDEF CI System This is an EXPERIMENTAL automated CI system. For questions and feedback, feel free to email Martin Winter . Patches applied :

[quagga-dev 15628] CI Testresult: FAILED (Re: [quagga-dev, 15621] *: Fix duplicate commands from view/enable node consolidation)

Continous Integration Result: FAILED See below for issues. This is an EXPERIMENTAL automated CI system. For questions and feedback, feel free to email Martin Winter . Patches applied : Patchwork 2002: http://patchwork.quagga.net/patch/2002

[quagga-dev 15627] Re: [PATCH v2 07/30] lib: add "show commandtree" CLI command

Paul, See below. On 6/15/2016 5:53 AM, Paul Jakma wrote: > On Tue, 12 Jan 2016, Lou Berger wrote: > >> +DEFUN (show_commandtree, >> + show_commandtree_cmd, >> + "show commandtree", >> + NO_STR >> + "Show command tree\n") >> +{ >> + /* TBD */ >> + vector cmd_vector; >> +

[quagga-dev 15626] CI Testresult: FAILED (Re: [quagga-dev,15620] lib: keep hash of node s commands to detect duplicate installs)

Continous Integration Result: FAILED See below for issues. This is an EXPERIMENTAL automated CI system. For questions and feedback, feel free to email Martin Winter . Patches applied : Patchwork 2001: http://patchwork.quagga.net/patch/2001

[quagga-dev 15625] Re: [PATCH 1/6] lib: plugin loading

On Tue, Jun 14, 2016 at 7:59 PM, David Lamparter wrote: Hello David, > > +DEFINE_MTYPE_STATIC(LIB, PLUGIN_LOADNAME, "Plugin loading name") * I got compilation problems. Some elements are not yet in the master. I will retry later. branch of quagga. error: patch

[quagga-dev 15624] Re: RFC: plugin (DSO) + hook support

Le 16/06/2016 16:58, David Lamparter a écrit : Now, for the "yes" part... there are quite a few things that make sense to modularise: - SNMP, if it stays around - Sproute's/Avneesh's Protobuf stuff - OSR's/my Cap'n Proto stuff - the entire CLI - kernel backends +1 I like the idea of

[quagga-dev 15623] [PATCH] lib: Clean command.c

Removed dead code paths and fixed a typo. Signed-off-by: Quentin Young --- lib/command.c | 69 +-- 1 file changed, 1 insertion(+), 68 deletions(-) diff --git a/lib/command.c b/lib/command.c index

[quagga-dev 15622] Re: [PATCH 06/16] bgpd: fix off-by-one in attribute flags handling

On Tue, Jun 14, 2016 at 8:07 PM, Christian Franke wrote: Hello Christian, > +static const size_t attr_flags_values_max = array_size(attr_flags_values) - > 1; This macro is very useful. Acked-by : Philippe Guibert

[quagga-dev 15621] [PATCH] *: Fix duplicate commands from view/enable node consolidation

--- bgpd/bgp_filter.c | 2 -- bgpd/bgp_mplsvpn.c | 18 -- bgpd/bgp_nexthop.c | 4 isisd/isis_spf.c | 4 isisd/isis_te.c| 2 -- lib/vty.c | 10 -- ospf6d/ospf6d.c| 37 - ospfd/ospf_ri.c| 2 --

[quagga-dev 15620] [PATCH] lib: keep hash of node's commands to detect duplicate installs

* command.h: (struct cmd_node) Add a hash, so duplicate installs of a cmd_element to a command node can be detected. To help catch strays from the VIEW/ENABLE node consolidation particularly (installs to VIEW automatically install to ENABLE too now). * command.c: (cmd_hash_{key,cmp})

[quagga-dev 15619] Re: RFC: plugin (DSO) + hook support

On Thu, Jun 16, 2016 at 09:31:20AM -0400, Donald Sharp wrote: > I personally don't see allot of value in making snmp support runtime > -vs- compile time, At the very least, it's a nice halfway step to kicking it out ;) > but as a proof of concept I think it's fine for what it is. Yay, mission

[quagga-dev 15618] Re: [PATCH 16/16] vtysh: fix a memory leak in vtysh_client_execute

Acked-by: Donald Sharp On Tue, Jun 14, 2016 at 2:07 PM, Christian Franke wrote: > From: Christian Franke > > buf is dynamically allocated and needs to be freed in the error handling > path too. > > Signed-off-by:

[quagga-dev 15617] Re: [PATCH 15/16] vtysh: handle case if there is no match in "write terminal $daemon"

Acked-by: Donald Sharp On Tue, Jun 14, 2016 at 2:07 PM, Christian Franke wrote: > From: Christian Franke > > While the DEFUN should match the list of clients registered in > vtysh, it seems better to handle the case

[quagga-dev 15616] Re: [PATCH 14/16] ripd: print md5 auth digest correctly

Acked-by: Donald Sharp On Tue, Jun 14, 2016 at 2:07 PM, Christian Franke wrote: > From: Christian Franke > > The dump of the md5 hash was missing one byte of the hash. > > Signed-off-by: Christian Franke

[quagga-dev 15615] Re: [PATCH 13/16] pimd: don't leak original_s_route on error

Acked-by: Donald Sharp On Tue, Jun 14, 2016 at 2:07 PM, Christian Franke wrote: > From: Christian Franke > > original_s_route is allocated on the heap and was not freed during the > error case. > > Signed-off-by:

[quagga-dev 15614] Re: RFC: plugin (DSO) + hook support

I personally don't see allot of value in making snmp support runtime -vs- compile time, but as a proof of concept I think it's fine for what it is. I do see value in shared libraries though. Should we be thinking a bit bigger? Could we modify the protocols to all be shared libraries that could

[quagga-dev 15613] Re: Round 8

Nothing but old habits, so easy to change. I've been favoring clang (much better warnings) which defaults to it in any case... Cheers, Lou On June 16, 2016 5:49:00 AM Paul Jakma wrote: On Thu, 16 Jun 2016, Paul Jakma wrote: If it's trivial like declaring stuff in the

[quagga-dev 15611] Re: Round 8

On Thu, 16 Jun 2016, Paul Jakma wrote: If it's trivial like declaring stuff in the first clause of a for, I'm happy to change it. Oh, but... also be good to fix whatever it is that prevents you running your compiler in C99+ mode. ;) regards, -- Paul Jakma | p...@jakma.org | @pjakma | Key

[quagga-dev 15609] Re: Comments on Tools and Maintainer Doc please! (Was Re: Call for Agenda)

Paul Jakma wrote: > Note, mailman can be configured to filter messages and block HTML, or > else convert it to text. See the 'content filtering' section Vincent. It > just needs to be turned on. the please-don't-post-html war was lost years ago and nothing is going to roll back the clock on that.

[quagga-dev 15610] Re: Round 8

On Wed, 15 Jun 2016, Lou Berger wrote: Why use -std=gnu99? Before these changes quagga, e.g., the current release, compiled fine without the flag. If it's trivial like declaring stuff in the first clause of a for, I'm happy to change it. regards, -- Paul Jakma | p...@jakma.org | @pjakma |

[quagga-dev 15608] Re: Comments on Tools and Maintainer Doc please! (Was Re: Call for Agenda)

On Wed, 15 Jun 2016, Vincent JARDIN wrote: PS: please, stop posting some HTML emails. I'll add: "PPPS: Please trim extraneous quoted text from replies!" Note, mailman can be configured to filter messages and block HTML, or else convert it to text. See the 'content filtering' section

[quagga-dev 15606] Re: Call for Agenda

Hi Donald, all, Concerning the Maintainer document, I add a comment I would discuss on the mailing list. Is there room to define a new role named 'Reviewer' that stand between contributor and maintainer. I mean volunteer who could help maintainer to review code, that have some write access to