Re: [Rd] Should '@" now be listed in tools:::.get_internal_S3_generics() ?

2023-04-30 Thread Karolis Koncevičius
Ah, you are correct, my bad and apologies. I forgot that table is only for available methods, not for available generics. KK. > On Apr 30, 2023, at 4:49 PM, Kurt Hornik wrote: > >> Karolis Koncevičius writes: > >> But this might require a more detailed investigation. For example I >>

Re: [Rd] Should '@" now be listed in tools:::.get_internal_S3_generics() ?

2023-04-30 Thread Kurt Hornik
> Karolis Koncevičius writes: > But this might require a more detailed investigation. For example I > just noticed that even with the patch `@` is still not listed in > .S3_methods_table(). Afaict base does not register any methods for @ or @<- ? -k > KK. >> On Apr 29, 2023, at 4:44 PM,

Re: [Rd] Should '@" now be listed in tools:::.get_internal_S3_generics() ?

2023-04-30 Thread Karolis Koncevičius
But this might require a more detailed investigation. For example I just noticed that even with the patch `@` is still not listed in .S3_methods_table(). KK. > On Apr 29, 2023, at 4:44 PM, Karolis Koncevičius > wrote: > > Hello Kurt, > > With r84341 it now works on my side. > > Warm

Re: [Rd] Should '@" now be listed in tools:::.get_internal_S3_generics() ?

2023-04-29 Thread Karolis Koncevičius
Hello Kurt, With r84341 it now works on my side. Warm regards, Karolis K. > On Apr 29, 2023, at 1:24 PM, Kurt Hornik wrote: > >> Karolis Koncevičius writes: > > Can you pls try again with r84341 or later? > > Best > -k > >> A more concrete example in order to correct my vague messages

Re: [Rd] Should '@" now be listed in tools:::.get_internal_S3_generics() ?

2023-04-29 Thread Kurt Hornik
> Karolis Koncevičius writes: Can you pls try again with r84341 or later? Best -k > A more concrete example in order to correct my vague messages below. > Writing an R package that uses `@` and `@<-` as S3 generics. Line from manual > pages in .Rd files: > \method{@}{newclass}(object,

Re: [Rd] Should '@" now be listed in tools:::.get_internal_S3_generics() ?

2023-04-28 Thread Karolis Koncevičius
A more concrete example in order to correct my vague messages below. Writing an R package that uses `@` and `@<-` as S3 generics. Line from manual pages in .Rd files: \method{@}{newclass}(object, name) <- value Throws this error during R CMD check —as-cran Bad \usage lines found in

Re: [Rd] Should '@" now be listed in tools:::.get_internal_S3_generics() ?

2023-04-28 Thread Karolis Koncevičius
Thank you for such a quick reply, Gabriel, I am not too familiar with the package tools, so cannot speak too confidently, but below is how I see the issue currently. The issue is not for external packages to rely on unexported functions from tools::, rather the issue is that 'R CMD check

Re: [Rd] Should '@" now be listed in tools:::.get_internal_S3_generics() ?

2023-04-28 Thread Gabriel Becker
Karolis, It seems likely, without having looked myself, that you could be correct about the issue, but it does seem worth noting that both of the functions you have mentioned are not exported, and thus not part of the API that extension packages are allowed to use and rely on. If retrieving the

Re: [Rd] Should '@" now be listed in tools:::.get_internal_S3_generics() ?

2023-04-28 Thread Karolis Koncevičius
This issue might go deeper - I was not successful in passing R CMD checks for the usage files. R CMD check kept showing errors for `@` declarations, even thou they were identical to `$` declarations (which passed fine). Seems like the usage check functions are not prepared for `@` - also in

[Rd] Should '@" now be listed in tools:::.get_internal_S3_generics() ?

2023-04-28 Thread Karolis Koncevičius
I was building a package that uses the new generic @ and kept having errors with “roxygen2” documentation. “roxygen2” generated NAMESPACE added `@.newclass` as a newly exported function, not as a S3method. At first I thought this must be a bug in roxygen2 and they lag behind the new