Re: [rdiff-backup-users] More patches to get rdiff-backup working under cygwin/windows

2007-01-29 Thread Marc Dyksterhouse
Dean, Actually, an extra os.close was already in the except block so I don't think there is an fd leak here. ASCII 128 thru 255 are valid in FAT-32 filenames...and common outside the US. I did add 127 (0177) to the quote list since that is not a valid char. This is now in

Re: [rdiff-backup-users] More patches to get rdiff-backup working under cygwin/windows

2007-01-29 Thread dean gaudet
On Mon, 29 Jan 2007, Marc Dyksterhouse wrote: These two still need to be applied: http://www.visiwave.com/download/rdiff_backup/fs_abilities.py.2.patch http://www.visiwave.com/download/rdiff_backup/rpath.py.patch both are now committed... thanks! -dean

Re: [rdiff-backup-users] More patches to get rdiff-backup working under cygwin/windows

2007-01-28 Thread Marc Dyksterhouse
David, Yes to ssh. No to CIFS. marc David Kempe wrote: Hi Mark does this mean you are using ssh as the transport? have you happened to test these on unix to cifs(on windows)? dave Marc Dyksterhouse wrote: Note that these fixes are only needed when backing up unix to windows. Windows to

Re: [rdiff-backup-users] More patches to get rdiff-backup working under cygwin/windows

2007-01-28 Thread dean gaudet
On Mon, 29 Jan 2007, Marc Dyksterhouse wrote: Dean, I looked into what was happening with fsync under cygwin. Turns out fsync returns EACCES for any file so I added that to the except clause to prevent the exception from being re-raised. After fixing that, a few more exceptions where

Re: [rdiff-backup-users] More patches to get rdiff-backup working under cygwin/windows

2007-01-27 Thread dean gaudet
On Fri, 26 Jan 2007, Marc Dyksterhouse wrote: http://www.visiwave.com/download/rdiff_backup/rpath.py.patch can you provide more information on why this is necessary? i'm assuming it's because cygwin/windows can't do an fsync in some situation... would it be possible to put another

[rdiff-backup-users] More patches to get rdiff-backup working under cygwin/windows

2007-01-26 Thread Marc Dyksterhouse
Hi all, I had some issues backing up a linux machine to a Windows box using rdiff-backup. I got passed all my (known) issues today so I wanted to submit the fixes so others could take advantage of them. I started with version 1.1.7. Note that these fixes are only needed when backing up

Re: [rdiff-backup-users] More patches to get rdiff-backup working under cygwin/windows

2007-01-26 Thread David Kempe
Hi Mark does this mean you are using ssh as the transport? have you happened to test these on unix to cifs(on windows)? dave Marc Dyksterhouse wrote: Note that these fixes are only needed when backing up unix to windows. Windows to windows or windows to unix shouldn't need this. Well,