Re: [Replicant] [PATCH] fix #1853 "Ecryption" typo in Settings App

2018-10-08 Thread Denis 'GNUtoo' Carikli
On Mon, 08 Oct 2018 13:55:00 + Joonas Kylmälä wrote: > Hi, Hi, > Denis 'GNUtoo' Carikli: > > On Sun, 2 Sep 2018 21:17:21 +0200 > > Fil wrote: > > > >> From e17c05cfe9665ff1ec9dffbf46f90be18e44fa3d Mon Sep 17 00:00:00 > >> 2001 From: Fil Bergamo > >> Date: Sun, 2 Sep 2018 16:44:44 +

Re: [Replicant] [PATCH] fix #1853 "Ecryption" typo in Settings App

2018-10-08 Thread Joonas Kylmälä
Hi, Denis 'GNUtoo' Carikli: > On Sun, 2 Sep 2018 21:17:21 +0200 > Fil wrote: > >> From e17c05cfe9665ff1ec9dffbf46f90be18e44fa3d Mon Sep 17 00:00:00 2001 >> From: Fil Bergamo >> Date: Sun, 2 Sep 2018 16:44:44 + >> Subject: [PATCH] fix #1853 "Ecryption" typo in Settings App > Maybe mention th

Re: [Replicant] [PATCH] fix #1853 "Ecryption" typo in Settings App

2018-09-03 Thread kurtis
Joonas Kylmälä: > Denis 'GNUtoo' Carikli: >> On Sun, 2 Sep 2018 21:17:21 +0200 >> Fil wrote: >> >>> From e17c05cfe9665ff1ec9dffbf46f90be18e44fa3d Mon Sep 17 00:00:00 2001 >>> From: Fil Bergamo >>> Date: Sun, 2 Sep 2018 16:44:44 + >>> Subject: [PATCH] fix #1853 "Ecryption" typo in Settings App

Re: [Replicant] [PATCH] fix #1853 "Ecryption" typo in Settings App

2018-09-03 Thread Joonas Kylmälä
Denis 'GNUtoo' Carikli: > On Sun, 2 Sep 2018 21:17:21 +0200 > Fil wrote: > >> From e17c05cfe9665ff1ec9dffbf46f90be18e44fa3d Mon Sep 17 00:00:00 2001 >> From: Fil Bergamo >> Date: Sun, 2 Sep 2018 16:44:44 + >> Subject: [PATCH] fix #1853 "Ecryption" typo in Settings App > Maybe mention the fac

Re: [Replicant] [PATCH] fix #1853 "Ecryption" typo in Settings App

2018-09-03 Thread Denis 'GNUtoo' Carikli
On Sun, 2 Sep 2018 21:17:21 +0200 Fil wrote: > From e17c05cfe9665ff1ec9dffbf46f90be18e44fa3d Mon Sep 17 00:00:00 2001 > From: Fil Bergamo > Date: Sun, 2 Sep 2018 16:44:44 + > Subject: [PATCH] fix #1853 "Ecryption" typo in Settings App Maybe mention the fact that the #1853 is a bug. Something

Re: [Replicant] [PATCH] fix #1853 "Ecryption" typo in Settings App

2018-09-03 Thread Denis 'GNUtoo' Carikli
On Sun, 02 Sep 2018 18:15:00 + Joonas Kylmälä wrote: > I can test it and push after the upstream merges. All the (non-merge) > commits to this point have contained the Signed-off-by line Thanks for spotting that. It's important to have Signed-off-by to be able to send patches upstream: Some p

Re: [Replicant] [PATCH] fix #1853 "Ecryption" typo in Settings App

2018-09-02 Thread Fil
On 09/02/2018 08:15 PM, Joonas Kylmälä wrote: > Hi, > > I can test it and push after the upstream merges. All the (non-merge) > commits to this point have contained the Signed-off-by line but it seems > like Replicant project has not formally established a meaning for it? I > have taken it's meani

Re: [Replicant] [PATCH] fix #1853 "Ecryption" typo in Settings App

2018-09-02 Thread Joonas Kylmälä
Hi, I can test it and push after the upstream merges. All the (non-merge) commits to this point have contained the Signed-off-by line but it seems like Replicant project has not formally established a meaning for it? I have taken it's meaning as that one certifies it is originally created by the p

[Replicant] [PATCH] fix #1853 "Ecryption" typo in Settings App

2018-09-02 Thread Fil
Hi, I finally found 5 minutes to correct the infamous typo mentioned in issue #1853[1] Thanks to Kurtis for doing the biggest job of researching the exact string inside the tree. Please find the related patch attached to this email. Can anybody push it and confirm? Thanks, Happy hacking, Fil