Re: [Repoze-dev] repoze.what quickstart and the authtkt authenticator

2010-11-24 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/23/2010 09:36 PM, Jim Hunziker wrote: Is there a reason why the AuthTktCookiePlugin isn't set up as an authenticator in the repoze.what quickstart? Adding it to authenticators in setup_sql_auth is the only way I can see being able to check

[Repoze-dev] [issue169] repoze.profile: useless profile recorded when application is a generator

2010-11-24 Thread jkarp
New submission from jkarp johnk...@gmail.com: When repoze.profile is given an application to wrap that takes the form of a generator, you end up with a useless profile that has only the entries string:1(module) and {method 'disable' of '_lsprof.Profiler' objects}. This is because the way the

[Repoze-dev] [issue169] repoze.profile: useless profile recorded when application is a generator

2010-11-24 Thread Tres Seaver
Tres Seaver tsea...@agendaless.com added the comment: Thanks for the report! I agree that your suggested solution is probably the correct one, with the exception that I would have it apply 'list()' only for results which were generators: hmm, how do I detect that? -- assignedto: -

[Repoze-dev] [issue169] repoze.profile: useless profile recorded when application is a generator

2010-11-24 Thread Tres Seaver
Tres Seaver tsea...@agendaless.com added the comment: Fix checked in on the trunk for the next release. -- status: chatting - resolved __ Repoze Bugs b...@bugs.repoze.org http://bugs.repoze.org/issue169 __

[Repoze-dev] [issue169] repoze.profile: useless profile recorded when application is a generator

2010-11-24 Thread jkarp
jkarp johnk...@gmail.com added the comment: I tried the changes you made; I don't they fix it. You made it iterate inside __call__, but that is not enough, iteration needs to happen inside self.profiler.runctx() or the profiler won't capture the execution. The change I originally suggested

[Repoze-dev] [issue169] repoze.profile: useless profile recorded when application is a generator

2010-11-24 Thread Tres Seaver
Tres Seaver tsea...@agendaless.com added the comment: I just checked in a change which moves the conditional list inside the profiled code. Please give it a try. I made creation of the list condition in order to avoid injecting any unnecessary overhead into the profiled code. I'm probably