Re: Marking review as "Submitted" using API

Great! Thanks. Christian Hammond wrote: > There's an API command up for review that will be in today which > allows you to easily mark a review request as submitted. See > http://reviews.review-board.org/r/604/ > > Christian > > -- > Christian Hammond - [EMAIL PROTECTED]

Re: Review Metrics

That sounds reasonable for your use case. This will need to be done as a custom extension later, though. I think it's too specific a use case to go into the mainline Review Board codebase. Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Wed, Oct 22, 2008 at 3:53 PM, H M <[E

Re: Review Metrics

Sure, I think keeping track of time like you described won't be enough. At least in our case, our review policy requires the reviewer to actually download the code and see if there are any warnings, does it run as expected, etc... All this will be outside of ReviewBoard. Perhaps another solu

Re: Marking review as "Submitted" using API

There's an API command up for review that will be in today which allows you to easily mark a review request as submitted. See http://reviews.review-board.org/r/604/ Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Wed, Oct 22, 2008 at 3:46 PM, H M <[EMAIL PROTECTED]> wrote:

Re: Marking review as "Submitted" using API

Attached is a snippet of Perl I came up with to set the ReviewRequest as "Submitted" using SQL. I know this is probably not a desired way to do it, but it worked for us. If there is any use for this, I can tidy it up a bit and submit it to the project. Hovanes Augie Fackler wrote: > On Oct 20

Re: Review Metrics

This goes back to a discussion that was had in the very early days of Review Board with one of my co-workers. He recommended actually keeping track on the page of the time spent. It would basically work like this: * On scrolling in the screenshot or diff viewer page, start a timer. * On idling (no

Review Metrics

We would like to see if we can gather some metrics from Reviewboard, including: * *Inspection Rate:* The number of KLOC inspected per hour. * *Defect Identification Rate:* The number of defects found in one hour of inspection time. * *Defect Density:* The amount of defects found

Re: says python-ldap not installed, but it is

Indeed now it works. Very sneaky. On Oct 22, 1:41 pm, "David Trowbridge" <[EMAIL PROTECTED]> wrote: > This was fixed in SVN last night. Can you update your install and try again? > > -David > > On Wed, Oct 22, 2008 at 10:48 AM, Brian <[EMAIL PROTECTED]> wrote: > > > When I change my authenticati

Re: says python-ldap not installed, but it is

This was fixed in SVN last night. Can you update your install and try again? -David On Wed, Oct 22, 2008 at 10:48 AM, Brian <[EMAIL PROTECTED]> wrote: > > When I change my authentication method to LDAP, I get this red text: > > LDAP authentication requires the python-ldap library, which is not >

says python-ldap not installed, but it is

When I change my authentication method to LDAP, I get this red text: LDAP authentication requires the python-ldap library, which is not installed. So, I used ubuntu hardy to apt-get install python-ldap -- this worked fine. Then I go back to the page and select LDAP again, but it still has the r

Re: OSError: [Errno 2] No such file or directory, while trying to view diff (P4)

I finally found the issue. I had to add some debug code to print (log) my path info and other stuff to track down the problem. P4 was in the path but there was a strange problem with the "patch" utility. I installed it again, ensured it was in the path and reviewed the P4 information on Apache's c