What's the mean of "ship it!"?

2012-02-14 Thread 深圳手机(王)
What's the mean of "ship it!"? I am puzzled for this question for some time. Remind the people don't forget to review the code? or the reviewer accept the result? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.

Re: What's the mean of "ship it!"?

2012-02-14 Thread Stein, Ruben
Hi, as far as I know it is the latter. Since the default workflow design for ReviewBoard is to review the code before it is committed, clicking on "ship it!" means to tell the author: "Yes, I agree to your changes: Ship it!" At this, "to ship" has the meaning of sending or committing the sugges

Post-review questions

2012-02-14 Thread 深圳手机(王)
I want to use the command Post-review on subversion(tortoise SVN). OS is winXP. Firstly, easy_install -U RBTools; 2nd: setup subversion comandline version/ 3rd : Add RB URL in SVN: reviewboard:url 4th: Add file .reviewboardrc in the root path of project ; config this file as following:

Re: Post-review questions

2012-02-14 Thread Christian Hammond
Can you run "svn info" from that directory and show me what it says? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com 2012/2/14 深圳手机(王) <825772...@qq.com> > I want to use the command Post-review on subversion(t

Re: Help please -- Installing P4 binding issue

2012-02-14 Thread Christian Hammond
The last error is actually okay. It's just due to how we handle the installation. The problem looks to be that Subversion isn't installed. You'll need to install this first, as that's part of easy_install's installation process for fetching P4PythonInstaller. Christian -- Christian Hammond - ch

Re: New BitNami Review Board Stack

2012-02-14 Thread ferna...@bitrock.com
Thanks Sridhar, looking forward to your feedback! Fernando Ruiz On Feb 13, 11:12 pm, Sridhar Srigiriraju wrote: > Fernando, > > I really appreciate the effort you have taken up. I recently finished > installing review board on our Linux server and was thoroughly frustrated > because of all the u

Re: New BitNami Review Board Stack

2012-02-14 Thread ferna...@bitrock.com
Thanks Sridhar, looking forward to your feedback! Fernando Ruiz On Feb 13, 11:12 pm, Sridhar Srigiriraju wrote: > Fernando, > > I really appreciate the effort you have taken up. I recently finished > installing review board on our Linux server and was thoroughly frustrated > because of all the u

Re: rb-site install failed - ImportError: Entry point ('console_scripts', 'rb-site') not found

2012-02-14 Thread James
Nelson, May I ask what version of Django you were on, and what version you upgraded to? I'm getting the same error on CentOS 5 with EPEL, using ReviewBoard from yum. Thanks, - James -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let

ReviewBoard 1.6.3 and Subversion 1.7.x Compatibility

2012-02-14 Thread phoke
We upgraded to SVN 1.7 when it came out late last year. Unfortunately, we realized later that ReviewBoard does not have all of the proper support for SVN 1.7. There are several other people encountering similar issues/challenges with SVN 1.7 and ReviewBoard compatibility. The main issue is due to

Re: ReviewBoard 1.6.3 and Subversion 1.7.x Compatibility

2012-02-14 Thread David Trowbridge
The critical issue is that pysvn does not yet support SVN 1.7, and generates broken results. If someone can find a workaround we're happy to integrate it, but otherwise I think we're going to wait for pysvn to update. -David On Tue, Feb 14, 2012 at 1:19 PM, phoke wrote: > We upgraded to SVN 1.

回复: What's the mean of "ship it!"?

2012-02-14 Thread 深圳手机(王)
OK. thank you very much ! -- 原始邮件 -- 发件人: "Stein, Ruben"; 发送时间: 2012年2月14日(星期二) 下午5:42 收件人: "reviewboard@googlegroups.com"; 主题: Re: What's the mean of "ship it!"? Hi, as far as I know it is the latter. Since the default workflow design for Revie