Preventing self-reviews

2012-01-04 Thread Igor Berger
Hello, A couple of minor problems: 1. It looks like when I'm looking at a review request I submitted, the Review and Ship It buttons are enabled. I'd imagine I should not be able to review my own changes. Is there a way to prevent that? 2. If I send a review request to a group I'm part of, I g

Re: Preventing self-reviews

2012-01-04 Thread Chris Tooley
When I notice bugs in my own code (often) I want them documented. On Jan 4, 2012 5:06 PM, "Igor Berger" wrote: > Hello, > > A couple of minor problems: > > 1. It looks like when I'm looking at a review request I submitted, the > Review and Ship It buttons are enabled. > I'd imagine I should not b

Re: Preventing self-reviews

2012-01-05 Thread Igor Berger
Agreed. But I want to make sure at least 1 other person looks at my changes. It's good that I can comment on a review I submitted. But I want to enforce that someone else has to click Ship It. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy use

Re: Preventing self-reviews

2012-05-30 Thread Rob Fagen
Doesn't look like this was ever answered. We've got the same situation that we want to prevent self-review (we have another mechanism for checking in without review). On Thursday, January 5, 2012 6:39:50 AM UTC-8, Igor Berger wrote: > > Agreed. But I want to make sure at least 1 other person loo

Re: Preventing self-reviews

2012-05-30 Thread Christian Hammond
Review Board actively tries to stay out of this sort of policy. We don't have anything for preventing self-reviews, and likely won't. In the end, we have no control whether a person is allowed to submit code. That's a company policy sort of thing. So, it doesn't make a lot o

Re: Preventing self-reviews

2012-05-30 Thread Rob Fagen
Thanks for the clarification. We'll look into it on our end in the pre-commit integration. On Wednesday, May 30, 2012 11:55:44 AM UTC-7, Christian Hammond wrote: > > Review Board actively tries to stay out of this sort of policy. We don't > have anything for preventing self-

Re: Preventing self-reviews

2012-07-04 Thread Dolanor Tharivae
he > pre-commit integration. > > On Wednesday, May 30, 2012 11:55:44 AM UTC-7, Christian Hammond wrote: >> >> Review Board actively tries to stay out of this sort of policy. We don't >> have anything for preventing self-reviews, and likely won't. In the end, we >