Re: Problem with uploading consecutive diffs with updates

2012-05-15 Thread Robert Dailey
This happens outside of interdiff too. There is never a reason to say something can't be fixed. It may be difficult, but not impossible. Either review-board or post-review has access to file revisions in Perforce. All you need to do is simply set your base (original) in the diff to be locked to

Re: Problem with uploading consecutive diffs with updates

2012-05-15 Thread Christian Hammond
I think there's a misunderstanding of the problem. If viewing a single diff (not comparing against two) is showing extra stuff in your change, then something is going wrong in your Perforce client, causing it to report improper revisions when building the diff. I can't say what that is, because

Re: Problem with uploading consecutive diffs with updates

2012-05-14 Thread Robert Dailey
When I say get latest I'm referring to the Get Latest Revision option in P4V. I don't use p4 directly, so I'm not sure what command it maps to. Right click in your workspace view on the folder you want to get latest changes, and click Get Latest Revision. This will pull down the latest changes in

Re: Problem with uploading consecutive diffs with updates

2012-05-14 Thread Christian Hammond
Oh! The interdiff was the key thing. So, yes, viewing a diff between uploaded diffs will give you that result. There's really not anything we can do about this. What that is really doing is taking the patched set of files in r1 and diffing them against the patched set in r2. Since there are

Re: Problem with uploading consecutive diffs with updates

2012-05-13 Thread Christian Hammond
Hi Robert, Sorry for the late reply. I've been on vacation. I'm not sure I'm fully understanding the problem you're hitting. Let me see if I have this right. You have a changelist with some code in it. You sync, new changes are pulled in. You post the new changeset to Review Board, and the diff

Re: Problem with uploading consecutive diffs with updates

2012-05-07 Thread Robert Dailey
Can someone help me out here? On Wed, May 2, 2012 at 1:37 PM, Robert Dailey rcdailey.li...@gmail.comwrote: So I'm using Perforce and I upload my initial reviews (as well as follow up changes and updates) using this command. Note that this is a Custom Tool in P4V: %C