Re: View Diff has issue in 1.7.2, and fine in 1.7.1

That's great! Thanks! Tao On Mon, Jan 28, 2013 at 5:13 PM, Christian Hammond wrote: > Okay. It's not related to the issue manager, but I suspect I know what's > causing it. It was a change that fixed a security problem, but apparently > caused another bug when using \ in filenames. > > We just d

Re: View Diff has issue in 1.7.2, and fine in 1.7.1

Okay. It's not related to the issue manager, but I suspect I know what's causing it. It was a change that fixed a security problem, but apparently caused another bug when using \ in filenames. We just did a 1.7.3 release, which didn't include a fix for this, but I'll try to get you a patch soon on

Re: View Diff has issue in 1.7.2, and fine in 1.7.1

Below is the error I got from Chrome, if need any further information, plz tell me how to, Thanks! Uncaught SyntaxError: Unexpected token ILLEGAL 172.21.78.85:856 isshow:false loader.js:14 1. Uncaught SyntaxError: Unexpected token IL

Re: View Diff has issue in 1.7.2, and fine in 1.7.1

New to reviewboard, I am not quite familiar with the system and bug fix process, I have submitted a codereview: http://reviews.reviewboard.org/r/3804/ Regards, Tao On Sunday, January 27, 2013 4:29:26 AM UTC+8, Christian Hammond wrote: > > Hi Tao, > > Can you post the fix up on http://reviews.re

Re: View Diff has issue in 1.7.2, and fine in 1.7.1

I haven't been able to reproduce this. Can you get me a stack trace from the JavaScript console, showing what's calling what? I also need to know which page you're hitting this on, and a repro case. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org V

Re: View Diff has issue in 1.7.2, and fine in 1.7.1

Hi Tao, Can you post the fix up on http://reviews.reviewboard.org? All patches must go through a review process there. Thanks! Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sat, Jan 26, 2013 at 5:41 AM,

Re: View Diff has issue in 1.7.2, and fine in 1.7.1

Hi, Christian: Thanks for your update, I will have a test after the new release, and see if the issue being resolved. And if possible, could you plz also add the fix to avoid prompting many cleartool console window when doing post-review and viewing diff? (see https://groups.google.com/forum/?

Re: View Diff has issue in 1.7.2, and fine in 1.7.1

Hi Tao, I'll look into this and see what I can do. We'll be putting out a new release this week. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Jan 25, 2013 at 12:33 AM, Tao Zhou wrote: > Hi, > > I

View Diff has issue in 1.7.2, and fine in 1.7.1

Hi, I am using Review Board 1.7.2 on Windows 7 with repository on Clearcase, and found the view diff page doesn't render correctly. if I upload several changed files in one diff by post-review, say more than 2 files, only 2 files' diff could display, and only can add comment for the first one