Re: creating multiple review requests for changes in one file

2009-01-06 Thread Arthur Kalmenson
> It would be interesting to hear from other people on this list about their > workflows. I use svn here and for the most part I just work away on multiple changes in a single workspace. When I finish a particular part, I'll post a review for only those files. Once the review is done, I commit on

Re: creating multiple review requests for changes in one file

2008-12-30 Thread Christian Hammond
Hi Tino, I'm working on user manuals for Review Board, which I'm hoping to finish up for 1.0. Right now, I'm about half way through a detailed Administration Guide. I'll try to keep in mind the workflows suggestion for the Users Guide. It would be interesting to hear from other people on this lis

Re: creating multiple review requests for changes in one file

2008-12-30 Thread Tino Breddin
Hi Christian, Thanks for the detailed explanation of your workflow. I was just looking into using git on the client side too, since I'm familiar with it and patch management is much easier just as you describe. Nevertheless I'd also like to see how other approaches which use subversion instead of

Re: creating multiple review requests for changes in one file

2008-12-30 Thread Christian Hammond
Hey Tino, What a lot of us are starting to do both at VMware and within Review Board is to use git as a form of patch management. Git can wrap around both SVN and Perforce, allowing us to do all our work within Git and then push to the proper VCS. My workflow is generally as follows: 1) Create a

Re: creating multiple review requests for changes in one file

2008-12-30 Thread Tino Breddin
I agree, my question isn't exactly related to reviewboard and I should have been more specific. The vcs in this use-case is Subversion. Having multiple subversion checkouts might be a solution but suffers from a lot of overhead too. Thanks for the hint about the patch- management system Quilt, I'l

Re: creating multiple review requests for changes in one file

2008-12-29 Thread Christian Hammond
Hi Tino, This greatly depends on the revision control system, and isn't really specific to Review Board. If you have separate independent changes you want to post to review, you need to do multiple checkouts or use some sort of a patch-management system (like Quilt). This is a more general issue o

creating multiple review requests for changes in one file

2008-12-29 Thread Tino Breddin
Hi, I am wondering how you handle changes in the same file which don't really fit into the same review request. So you would have a change for which you create a review request. Then you change other things in the same file and would like to create a review request for these changes only. Is it n