Re: Review Request 44773: Hive View : Upload Table : Tables are not deleted in case of exception.

2016-03-14 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44773/#review123385 --- Ship it! Ship It! - DIPAYAN BHOWMICK On March 14, 2016, 6:16

Re: Review Request 44700: Ambari Views : each view should have separate log file for better troubleshooting

2016-03-14 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44700/#review123386 --- contrib/views/capacity-scheduler/src/main/resources/view.log4j.pr

Re: Review Request 44611: file path spills out of notification panel

2016-03-14 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44611/#review123387 --- Ship it! Ship It! - DIPAYAN BHOWMICK On March 10, 2016, 6:46

Re: Review Request 44557: Hive View : Upload table not handling detached cluster properly

2016-03-14 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44557/#review123390 --- Ship it! Ship It! - DIPAYAN BHOWMICK On March 9, 2016, 7:34

Re: Review Request 44713: Ambari names jar 'ojdbc6.jar' even though it is actually ojdbc7.jar

2016-03-14 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44713/#review123403 --- Ship it! Ship It! - Dmytro Sen On Март 11, 2016, 5:11 п.п.,

Review Request 44784: Provide composite Kerberos Descriptor via the REST API

2016-03-14 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44784/ --- Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sandor

Re: Review Request 44725: After exporting blueprint from ranger enabled cluster ranger.service.https.attrib.keystore.pass is exported

2016-03-14 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44725/#review123409 --- ambari-server/src/main/java/org/apache/ambari/server/controller/i

Please add me to the ambari review mail list

2016-03-14 Thread Di Li
Please add me to to the ambari review mail list Thank you. Di Li InfoSphere BigInsights IBM Ottawa Lab Palladium Campus Email: d...@ca.ibm.com Phone: 613-270-4883, Tie-line:315-4883

Review Request 44786: AMS service failed to start

2016-03-14 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44786/ --- Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle. Bug

Re: Review Request 44265: Basic Operational Audit Logging

2016-03-14 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44265/#review123422 --- -1 on this. DO NOT PUSH THIS CODE. This should be done in a feat

Re: Review Request 44784: Provide composite Kerberos Descriptor via the REST API

2016-03-14 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44784/#review123428 --- Ship it! Ship It! - Nate Cole On March 14, 2016, 8:19 a.m.,

Re: Review Request 44786: AMS service failed to start

2016-03-14 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44786/#review123430 --- Ship it! Ship It! - Aravindan Vijayan On March 14, 2016, 2:2

Re: Review Request 44769: Config recommendations for installed services are getting cleared out

2016-03-14 Thread Goutam Tadi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44769/#review123438 --- ambari-web/app/mixins/common/configs/enhanced_configs.js (line 19

Re: Review Request 44784: Provide composite Kerberos Descriptor via the REST API

2016-03-14 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44784/#review123439 --- Ship it! ambari-server/src/main/java/org/apache/ambari/server/

Review Request 44792: AMS fails to start with TTL for column family 0 must be positive after upgrade

2016-03-14 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44792/ --- Review request for Ambari, Aravindan Vijayan and Sid Wagle. Bugs: AMBARI-15402

Re: Review Request 44457: AMBARI-15310: Host Service Summary Page does not display long service names well

2016-03-14 Thread Keta Patel
> On March 10, 2016, 7:01 p.m., Di Li wrote: > > File Attachment: AMBARI-15310 (patch-4) - AMBARI-15310_Mar09.patch > > > > > > Could you please add unit tests for the methods you added, if possible, > > to demo the text shortening behavior th

Review Request 44793: File resource timed out

2016-03-14 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44793/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-15404 https:

Re: Review Request 44793: File resource timed out

2016-03-14 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44793/#review123449 --- Ship it! Ship It! - Vitalyi Brodetskyi On March 14, 2016, 4:

Re: Review Request 44784: Provide composite Kerberos Descriptor via the REST API

2016-03-14 Thread Robert Levas
> On March 14, 2016, 12:10 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProvider.java, > > lines 122-123 > > > > > > This

Re: Review Request 44285: AMBARI-15266 - Add configurable download retries for cache misses

2016-03-14 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44285/#review123455 --- Ship it! Ship It! - Jayush Luniya On March 3, 2016, 7:56 p.m

Re: Review Request 44688: PXF should reach out to active namenode to get the delegation token on HDFS HA clusters

2016-03-14 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44688/#review123456 --- ambari-server/src/main/resources/common-services/PXF/3.0.0/packag

Re: Review Request 44792: AMS fails to start with TTL for column family 0 must be positive after upgrade

2016-03-14 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44792/ --- (Updated Март 14, 2016, 5:25 п.п.) Review request for Ambari, Aravindan Vijayan

Re: Review Request 44769: Config recommendations for installed services are getting cleared out

2016-03-14 Thread Alexandr Antonenko
> On March 14, 2016, 4:09 p.m., Goutam Tadi wrote: > > ambari-web/app/mixins/common/configs/enhanced_configs.js, line 192 > > > > > > How about ```for each ``` instead of ``` for ``` ? Any advantages that we will ge

Review Request 44795: HDP 2.3.4 package install through Ambari on SLES11 hosts fails

2016-03-14 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44795/ --- Review request for Ambari and Andrew Onischuk. Bugs: AMBARI-15405 https://i

Re: Review Request 44792: AMS fails to start with TTL for column family 0 must be positive after upgrade

2016-03-14 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44792/#review123458 --- ambari-server/src/main/java/org/apache/ambari/server/upgrade/Upgr

Re: Review Request 44792: AMS fails to start with TTL for column family 0 must be positive after upgrade

2016-03-14 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44792/#review123463 --- Ship it! Ship It! - Aravindan Vijayan On March 14, 2016, 5:2

Re: Review Request 44148: Add FreeIPA support to Ambari.

2016-03-14 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44148/#review123462 --- Ship it! Ship It! - Alejandro Fernandez On March 12, 2016, 5

Re: Review Request 44457: AMBARI-15310: Host Service Summary Page does not display long service names well

2016-03-14 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44457/#review123464 --- Ship it! Ship It! - Di Li On March 11, 2016, 8:08 p.m., Keta

Re: Review Request 44769: Config recommendations for installed services are getting cleared out

2016-03-14 Thread Goutam Tadi
> On March 14, 2016, 4:09 p.m., Goutam Tadi wrote: > > ambari-web/app/mixins/common/configs/enhanced_configs.js, line 192 > > > > > > How about ```for each ``` instead of ``` for ``` ? > > Alexandr Antonenko wrote:

Re: Review Request 44769: Config recommendations for installed services are getting cleared out

2016-03-14 Thread Goutam Tadi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44769/#review123469 --- Ship it! Ship It! - Goutam Tadi On March 14, 2016, 3:59 p.m.

Re: Review Request 44769: Config recommendations for installed services are getting cleared out

2016-03-14 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44769/#review123470 --- Ship it! Ship It! - Alexandr Antonenko On March 14, 2016, 3:

Re: Review Request 44795: HDP 2.3.4 package install through Ambari on SLES11 hosts fails

2016-03-14 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44795/#review123472 --- ambari-common/src/main/python/resource_management/core/providers/

Re: Review Request 44792: AMS fails to start with TTL for column family 0 must be positive after upgrade

2016-03-14 Thread Ajit Kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44792/#review123474 --- ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/a

Re: Review Request 44695: Alert for updating HAWQ namespace after enabling HDFS HA

2016-03-14 Thread Lav Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44695/ --- (Updated March 14, 2016, 6:37 p.m.) Review request for Ambari, Alexander Deniss

Re: Review Request 44792: AMS fails to start with TTL for column family 0 must be positive after upgrade

2016-03-14 Thread Dmytro Sen
> On Март 14, 2016, 6:34 п.п., Ajit Kumar wrote: > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml, > > line 286 > > > > > > Is it possible to leave it as it is and

Re: Review Request 44792: AMS fails to start with TTL for column family 0 must be positive after upgrade

2016-03-14 Thread Aravindan Vijayan
> On March 14, 2016, 6:34 p.m., Ajit Kumar wrote: > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml, > > line 286 > > > > > > Is it possible to leave it as it is an

Re: Review Request 44688: PXF should reach out to active namenode to get the delegation token on HDFS HA clusters

2016-03-14 Thread bhuvnesh chaudhary
> On March 14, 2016, 5:10 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py, > > line 140 > > > > > > Check for null (i.e. no active namenode) Th

Re: Review Request 44687: Update RCO : PXF should start after HDFS

2016-03-14 Thread bhuvnesh chaudhary
> On March 11, 2016, 9:06 a.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json, > > line 14 > > > > > > RCO can be defined at service level > > (https://issues.apach

Review Request 44801: Fix ArtifactResourceProviderTest to avoid set ordering issues

2016-03-14 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44801/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and

Re: Review Request 44457: AMBARI-15310: Host Service Summary Page does not display long service names well

2016-03-14 Thread Keta Patel
> On March 14, 2016, 5:47 p.m., Di Li wrote: > > Ship It! Thank you Di! - Keta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44457/#review123464

Re: Review Request 44801: Fix ArtifactResourceProviderTest to avoid set ordering issues

2016-03-14 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44801/#review123489 --- Ship it! Ship It! - Jonathan Hurley On March 14, 2016, 3:09

Re: Review Request 44801: Fix ArtifactResourceProviderTest to avoid set ordering issues

2016-03-14 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44801/#review123492 --- I +1'd this, but could you also look at: AMBARI-14013 And "Colle

Re: Review Request 44801: Fix ArtifactResourceProviderTest to avoid set ordering issues

2016-03-14 Thread Robert Levas
> On March 14, 2016, 3:39 p.m., Jonathan Hurley wrote: > > I +1'd this, but could you also look at: > > > > AMBARI-14013 > > > > And "CollectionPresentationUtils" ... I think this is the same issue, no? > > Maybe you're re-inventing the wheel when you don't have to. The issue with `ExecutionC

Re: Review Request 44148: Add FreeIPA support to Ambari.

2016-03-14 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44148/#review123498 --- ambari-server/src/main/java/org/apache/ambari/server/utils/ShellC

Review Request 44746: HiveInteractiveServer. Add 'tez-interactive-site.xml' for custom Tez used by Hive2.

2016-03-14 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44746/ --- Review request for Ambari, Jaimin Jetly and Sumit Mohanty. Repository: ambari

Review Request 44807: Ambari2400:Ambari server start fails with Required properties are not found: ['jdk.name', 'jce.name']

2016-03-14 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44807/ --- Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Dmytro Sen.

Re: Review Request 44807: Ambari2400:Ambari server start fails with Required properties are not found: ['jdk.name', 'jce.name']

2016-03-14 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44807/ --- (Updated Березень 14, 2016, 8:52 після полудня) Review request for Ambari, Andr

Re: Review Request 44807: Ambari2400:Ambari server start fails with Required properties are not found: ['jdk.name', 'jce.name']

2016-03-14 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44807/#review123508 --- Ship it! Ship It! - Dmytro Sen On Март 14, 2016, 8:52 п.п.,

Re: Review Request 44148: Add FreeIPA support to Ambari.

2016-03-14 Thread Bolke de Bruin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44148/ --- (Updated mrt 14, 2016, 9:01 p.m.) Review request for Ambari, Jaimin Jetly, Robe

Review Request 44809: RBAC: Name filter does not work for user with no role

2016-03-14 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44809/ --- Review request for Ambari and Xi Wang. Bugs: AMBARI-15411 https://issues.ap

Re: Review Request 44809: RBAC: Name filter does not work for user with no role

2016-03-14 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44809/#review123511 --- Ship it! Ship It! - Xi Wang On March 14, 2016, 2:12 p.m., Ri

Review Request 44811: AMBARI-15413 : Metrics Grafana Failed to start

2016-03-14 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44811/ --- Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Bugs: AMBA

Re: Review Request 44811: AMBARI-15413 : Metrics Grafana Failed to start

2016-03-14 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44811/#review123512 --- Ship it! Ship It! - Dmytro Sen On Март 14, 2016, 9:49 п.п.,

Re: Review Request 44352: AMBARI-15230: Move default recovery properties from ambari.properties to cluster-env.xml

2016-03-14 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44352/ --- (Updated March 14, 2016, 3 p.m.) Review request for Ambari, Jonathan Hurley, Zh

Re: Review Request 44352: AMBARI-15230: Move default recovery properties from ambari.properties to cluster-env.xml

2016-03-14 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44352/#review123513 --- Ship it! Ship It! - Sumit Mohanty On March 14, 2016, 10 p.m.

Re: Review Request 44811: AMBARI-15413 : Metrics Grafana Failed to start

2016-03-14 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44811/ --- (Updated March 14, 2016, 11:47 p.m.) Review request for Ambari, Dmytro Sen, Sum

Review Request 44814: Version Register/manage: UX edits #1

2016-03-14 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44814/ --- Review request for Ambari, Jaimin Jetly and Richard Zang. Bugs: AMBARI-15414

Re: Review Request 44814: Version Register/manage: UX edits #1

2016-03-14 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44814/#review123544 --- Ship it! Ship It! - Richard Zang On March 14, 2016, 11:57 p.

Re: Review Request 44811: AMBARI-15413 : Metrics Grafana Failed to start

2016-03-14 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44811/#review123545 --- Ship it! Ship It! - Sid Wagle On March 14, 2016, 11:47 p.m.,

Review Request 44816: Fix new HDFS AMS alerts to account for NN rpc ports

2016-03-14 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44816/ --- Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty. Bu

Review Request 44817: Grafana password is required field after upgrade from 2.2.0 to 2.2.2

2016-03-14 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44817/ --- Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Jaimin Jetly. Bug

Re: Review Request 44556: HiveInteractive. (1). Code for 'Hive Server Interactive' and related 'Tez' binaries installation. (2). Parameter declaration in 'params_linux' and 'status_params' related to

2016-03-14 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44556/ --- (Updated March 15, 2016, 12:35 a.m.) Review request for Ambari, Alejandro Ferna

Re: Review Request 44695: Alert for updating HAWQ namespace after enabling HDFS HA

2016-03-14 Thread bhuvnesh chaudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44695/#review123555 --- Ship it! Ship It! - bhuvnesh chaudhary On March 14, 2016, 6:

Re: Review Request 44556: HiveInteractive. (1). Code for 'Hive Server Interactive' and related 'Tez' binaries installation. (2). Parameter declaration in 'params_linux' and 'status_params' related to

2016-03-14 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44556/#review123558 --- ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/

Re: Review Request 44817: Grafana password is required field after upgrade from 2.2.0 to 2.2.2

2016-03-14 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44817/#review123559 --- Ship it! Ship It! - Aravindan Vijayan On March 15, 2016, 12:

Re: Review Request 44816: Fix new HDFS AMS alerts to account for NN rpc ports

2016-03-14 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44816/#review123562 --- Ship it! Ship It! - Sumit Mohanty On March 15, 2016, 12:21 a

Re: Review Request 44746: HiveInteractiveServer. Add 'tez-interactive-site.xml' for custom Tez used by Hive2.

2016-03-14 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44746/#review123567 --- Ship it! Ship It! - Sumit Mohanty On March 14, 2016, 8:27 p.

Review Request 44831: After EU Some Services Fail To Start Because of Missing JKS Files

2016-03-14 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44831/ --- Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Col

Review Request 44835: AMBARI-15420: Refactor resource_management library

2016-03-14 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44835/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Juanjo Marron,

Re: Review Request 44835: AMBARI-15420: Refactor resource_management library

2016-03-14 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44835/ --- (Updated March 15, 2016, 6:32 a.m.) Review request for Ambari, Alejandro Fernan