Review Request 45921: Not all log and PID dirs have "hadoop" group

2016-04-08 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45921/ --- Review request for Ambari and Myroslav Papirkovskyy. Bugs: AMBARI-15776 htt

Re: Review Request 45921: Not all log and PID dirs have "hadoop" group

2016-04-08 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45921/#review127750 --- Ship it! Ship It! - Myroslav Papirkovskyy On Квітень 8, 2016

Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

2016-04-08 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45904/#review127749 --- Ship it! Ship It! - Myroslav Papirkovskyy On Квітень 8, 2016

Re: Review Request 45778: AMBARI-15577: Stack Featurize HIVE service

2016-04-08 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45778/#review127756 --- Ship it! Ship It! - Jayush Luniya On April 7, 2016, 5:45 p.m

Re: Review Request 45899: After enabling NN HA with HAWQ installed, duplicate properties are seen on HAWQ config tab

2016-04-08 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45899/#review127761 --- Ship it! Ship It! - Matt On April 7, 2016, 3:26 p.m., Goutam

Review Request 45924: AMBARI-15681 : Ranger Admin/Usersync: Make log4j configurable from Ambari

2016-04-08 Thread Gautam Borad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45924/ --- Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Nat

Re: Review Request 45873: Create a new alert type that is based on timeseries metrics

2016-04-08 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45873/#review127769 --- Fix it, then Ship it! ambari-agent/src/main/python/ambari_agen

Re: Review Request 45846: AMBARI-15749 : Add AMS post processing function to show the metrics 'diff' over time.

2016-04-08 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45846/#review127773 --- Ship it! Ship It! - Dmytro Sen On Апрель 7, 2016, 11:38 п.п.

Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

2016-04-08 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45904/#review127772 --- I know that this is to support GTID on MySQL and preventing tempor

Review Request 45928: AMBARI-15719: Make list of reassignable components stack driven instead of hardcoding them in the UI code

2016-04-08 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45928/ --- Review request for Ambari and Alejandro Fernandez. Bugs: AMBARI-15719 https

Re: Review Request 45857: RU/EU PreCheck to ensure dfs.client.retry.policy.enable is set to false

2016-04-08 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45857/#review12 --- Ship it! Ship It! - Nate Cole On April 7, 2016, 5:47 p.m., A

Re: Review Request 45924: AMBARI-15681 : Ranger Admin/Usersync: Make log4j configurable from Ambari

2016-04-08 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45924/#review127779 --- ambari-common/src/main/python/resource_management/libraries/funct

Re: Review Request 45896: Atlas Integration : Support Atlas HA

2016-04-08 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45896/#review127780 --- Ship it! Look at you, back in the mix :) - Nate Cole On Apri

Re: Review Request 45914: Kerberos: Allow multiple KDC hosts to be set while enabling Kerberos

2016-04-08 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45914/#review127793 --- Ship it! Ship It! Maybe you should add some more tests with mu

Review Request 45930: After upgrading to Ambari 2.2.1, Storm widgets are gone

2016-04-08 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45930/ --- Review request for Ambari, Andrew Onischuk, Myroslav Papirkovskyy, and Vitalyi B

Re: Review Request 45930: After upgrading to Ambari 2.2.1, Storm widgets are gone

2016-04-08 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45930/#review127801 --- Ship it! Ship It! - Myroslav Papirkovskyy On Квітень 8, 2016

Re: Review Request 45930: After upgrading to Ambari 2.2.1, Storm widgets are gone

2016-04-08 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45930/ --- (Updated Апрель 8, 2016, 3:04 п.п.) Review request for Ambari, Andrew Onischuk,

Re: Review Request 45930: After upgrading to Ambari 2.2.1, Storm widgets are gone

2016-04-08 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45930/#review127802 --- ambari-server/src/main/java/org/apache/ambari/server/upgrade/Upgr

Re: Review Request 45930: After upgrading to Ambari 2.2.1, Storm widgets are gone

2016-04-08 Thread Dmytro Sen
> On Апрель 8, 2016, 3:04 п.п., Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java, > > line 574 > > > > > > Nit StormAns -> StormAnd fixed - Dmytro ---

Re: Review Request 45930: After upgrading to Ambari 2.2.1, Storm widgets are gone

2016-04-08 Thread Dmytro Sen
> On Апрель 8, 2016, 3:04 п.п., Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java, > > line 186 > > > > > > Should we initialize if Storm/Kafka are not depl

Re: Review Request 45930: After upgrading to Ambari 2.2.1, Storm widgets are gone

2016-04-08 Thread Dmytro Sen
> On Апрель 8, 2016, 3:04 п.п., Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java, > > line 186 > > > > > > Should we initialize if Storm/Kafka are not depl

Re: Review Request 45930: After upgrading to Ambari 2.2.1, Storm widgets are gone

2016-04-08 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45930/#review127807 --- Ship it! Ship It! - Sumit Mohanty On April 8, 2016, 3:04 p.m

Re: Review Request 45930: After upgrading to Ambari 2.2.1, Storm widgets are gone

2016-04-08 Thread Sumit Mohanty
> On April 8, 2016, 3:04 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java, > > line 186 > > > > > > Should we initialize if Storm/Kafka are not deplo

Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

2016-04-08 Thread Sid Wagle
> On April 8, 2016, 12:26 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java, > > lines 687-692 > > > > > > This is a very dangerous query. This can l

Re: Review Request 45928: AMBARI-15719: Make list of reassignable components stack driven instead of hardcoding them in the UI code

2016-04-08 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45928/#review127814 --- Ship it! Ship It! - Alejandro Fernandez On April 8, 2016, 12

Re: Review Request 45903: AMBARI-15775 Integrate Red Hat Satellite option in Ambari Admin

2016-04-08 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45903/#review127818 --- Ship it! Ship It! - Nate Cole On April 7, 2016, 8:36 p.m., Z

Re: Review Request 45906: HAWQ fails to connect to YARN in HA+SEC mode

2016-04-08 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45906/#review127824 --- Ship it! Ship It! - Matt On April 7, 2016, 4 p.m., Alexander

Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-08 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45892/ --- (Updated April 8, 2016, 6 p.m.) Review request for Ambari, Miklos Gergely, Robe

Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-08 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45892/#review127828 --- This is a pretty massive patch. Please allow some time for the com

Review Request 45937: Support Atlas / Storm integration

2016-04-08 Thread Tom Beerbower
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45937/ --- Review request for Ambari, John Speidel and Robert Levas. Bugs: AMBARI-14920

Re: Review Request 45937: Support Atlas / Storm integration

2016-04-08 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45937/#review127853 --- ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/

Re: Review Request 45924: AMBARI-15681 : Ranger Admin/Usersync: Make log4j configurable from Ambari

2016-04-08 Thread Jayush Luniya
> On April 8, 2016, 1:32 p.m., Nate Cole wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py, > > line 218 > > > > > > Use the AMBARI- JIRA number. +1 - Jayush ---

Re: Review Request 45924: AMBARI-15681 : Ranger Admin/Usersync: Make log4j configurable from Ambari

2016-04-08 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45924/#review127857 --- ambari-common/src/main/python/resource_management/libraries/funct

Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-08 Thread Jayush Luniya
> On April 8, 2016, 6:08 p.m., Alejandro Fernandez wrote: > > This is a pretty massive patch. Please allow some time for the community to > > review. Can the patch be broken down in more granular chunks? - Jayush --- This is an automat

Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-08 Thread Oliver Szabo
> On April 8, 2016, 6:08 p.m., Alejandro Fernandez wrote: > > This is a pretty massive patch. Please allow some time for the community to > > review. > > Jayush Luniya wrote: > Can the patch be broken down in more granular chunks? most of it is a move (the logsearch module), so its pretty

Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-08 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45892/#review127861 --- ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/

Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-08 Thread Jayush Luniya
> On April 8, 2016, 6:08 p.m., Alejandro Fernandez wrote: > > This is a pretty massive patch. Please allow some time for the community to > > review. > > Jayush Luniya wrote: > Can the patch be broken down in more granular chunks? > > Oliver Szabo wrote: > most of it is a move (the log

Re: Review Request 45937: Support Atlas / Storm integration

2016-04-08 Thread Tom Beerbower
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45937/ --- (Updated April 8, 2016, 8:09 p.m.) Review request for Ambari, John Speidel and

Re: Review Request 45937: Support Atlas / Storm integration

2016-04-08 Thread Tom Beerbower
> On April 8, 2016, 7:27 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py, > > line 195 > > > > > > Please dont use "/usr/hdp" hardcoded

Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-08 Thread Oliver Szabo
> On April 8, 2016, 6:08 p.m., Alejandro Fernandez wrote: > > This is a pretty massive patch. Please allow some time for the community to > > review. > > Jayush Luniya wrote: > Can the patch be broken down in more granular chunks? > > Oliver Szabo wrote: > most of it is a move (the log

Re: Review Request 45937: Support Atlas / Storm integration

2016-04-08 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45937/#review127875 --- Ship it! Ship It! - Robert Levas On April 8, 2016, 4:09 p.m.

Re: Review Request 45873: Create a new alert type that is based on timeseries metrics

2016-04-08 Thread Sid Wagle
> On April 8, 2016, 12:18 p.m., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/ams_alert.py, lines 66-70 > > > > > > Since this is contacting AMS, is there a better place to get this > >

Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

2016-04-08 Thread Sid Wagle
> On April 8, 2016, 12:26 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java, > > lines 687-692 > > > > > > This is a very dangerous query. This can l

Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

2016-04-08 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45904/ --- (Updated April 8, 2016, 8:56 p.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 45914: Kerberos: Allow multiple KDC hosts to be set while enabling Kerberos

2016-04-08 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45914/ --- (Updated April 8, 2016, 5:20 p.m.) Review request for Ambari, Jaimin Jetly, Jon

Review Request 45973: HAWQ Resync on Standby Fails after NN HA

2016-04-08 Thread Lav Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45973/ --- Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam Tadi,

Review Request 45974: AMBARI-15787 Server Alert definitions: Change display_name to the text from description

2016-04-08 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45974/ --- Review request for Ambari, Jonathan Hurley, Nate Cole, Richard Zang, and Yusaku

Re: Review Request 45676: AMBARI-15678: YARN service_check doesn't fail when application status is not reasonable

2016-04-08 Thread Masahiro Tanaka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45676/#review127947 --- could anyone commit this or give a comment ? - Masahiro Tanaka

Re: Review Request 45973: HAWQ Resync on Standby Fails after NN HA

2016-04-08 Thread Goutam Tadi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45973/#review127951 --- Ship it! Ship It! - Goutam Tadi On April 8, 2016, 11:54 p.m.