Review Request 46475: Provide UI validation for widget_name and description fields in Create/Edit Widget pop-up.

2016-04-20 Thread Keta Patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46475/ --- Review request for Ambari, Andrii Tkach and Di Li. Bugs: AMBARI-15979

Review Request 46467: AMBARI-16003: JS error on hosts filtering when filter for same field is used twice

2016-04-20 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46467/ --- Review request for Ambari, Zhe (Joe) Wang and Oleg Nechiporenko. Bugs:

Re: Review Request 45998: HIVE service_check doesn't work properly

2016-04-20 Thread Masahiro Tanaka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45998/#review129845 --- Thanks for the review Nate and Andrew! Could you commit this? -

Re: Review Request 45998: HIVE service_check doesn't work properly

2016-04-20 Thread Masahiro Tanaka
> On 4月 20, 2016, 1:17 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py, > > lines 117-119 > > > > > > Given how many things get

Review Request 46460: AMBARI-16002 Integrate Red Hat Satellite option in Ambari Web

2016-04-20 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46460/ --- Review request for Ambari, Jaimin Jetly, Nate Cole, Richard Zang, Xi Wang, and

Re: Review Request 46420: AMBARI-15496: /var/lib/ambari-agent/cache/cluster_configuration/configurations.json file contains various passwords in plain text in world readable file

2016-04-20 Thread Shantanu Mundkur
> On April 20, 2016, 8:14 p.m., Alejandro Fernandez wrote: > > ambari-agent/src/main/python/ambari_agent/ClusterConfiguration.py, line 132 > > > > > > Already owned by root, ok to change permissios to 600. Thanks

Re: Review Request 43926: Frameworks support for bulk delete API

2016-04-20 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43926/#review129829 --- Ship it! Ship It! - Sid Wagle On April 20, 2016, 6:45 p.m.,

Re: Review Request 43927: Add support for bulk delete host API

2016-04-20 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43927/#review129823 --- Ship it! Ship It! - Nate Cole On April 12, 2016, 2:37 p.m.,

Re: Review Request 43926: Frameworks support for bulk delete API

2016-04-20 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43926/#review129822 --- Ship it! Ship It! - Nate Cole On April 20, 2016, 2:45 p.m.,

Re: Review Request 46269: SQL constraints: Inline constraints and name them in CREATE table

2016-04-20 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46269/#review129820 --- Ship it! Ship It! - Nate Cole On April 20, 2016, 4:25 p.m.,

Review Request 45592: Fix bad entry in hbase-env.sh that were added as part of 2.2.0-2.2.1.1 upgrade

2016-04-20 Thread Ajit Kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45592/ --- Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit

Re: Review Request 45676: AMBARI-15678: YARN service_check doesn't fail when application status is not reasonable

2016-04-20 Thread Jayush Luniya
> On April 20, 2016, 8:03 a.m., Jayush Luniya wrote: > > Ship It! > > Masahiro Tanaka wrote: > Thank you, could you commit this? Ok will commit today. - Jayush --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 46427: AMBARI-15985. Service Checks for Hive Server Interactive and LLAP.

2016-04-20 Thread Swapan Shridhar
> On April 20, 2016, 8:16 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/hiveLlapSmoke.sh, > > line 24 > > > > > > Can you add a comment to what

Review Request 46452: Clean up stack scripts that refer to dfs.nameservices to use dfs.internal.nameservices as first option

2016-04-20 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46452/ --- Review request for Ambari, Alexandr Antonenko, Andrew Onischuk, Sumit Mohanty,

Re: Review Request 45792: Integrate Version Registration in Select Stack Page

2016-04-20 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45792/ --- (Updated April 20, 2016, 1:30 p.m.) Review request for Ambari, Jaimin Jetly,

Re: Review Request 46451: exception in ambari agent log for atlas metadata server script

2016-04-20 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46451/#review129794 --- Ship it! Ship It! - Alejandro Fernandez On April 20, 2016,

Re: Review Request 46427: AMBARI-15985. Service Checks for Hive Server Interactive and LLAP.

2016-04-20 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46427/#review129787 --- Ship it! Ship It! - Sumit Mohanty On April 20, 2016, 7:37

Re: Review Request 46427: AMBARI-15985. Service Checks for Hive Server Interactive and LLAP.

2016-04-20 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46427/ --- (Updated April 20, 2016, 7:37 p.m.) Review request for Ambari, Alejandro

Re: Review Request 46451: exception in ambari agent log for atlas metadata server script

2016-04-20 Thread Mahadev Konar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46451/#review129785 --- Ship it! Ship It! - Mahadev Konar On April 20, 2016, 6:52

Re: Review Request 46297: Views work for Hue to Views Migration Tool.

2016-04-20 Thread Pradarttana Panda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46297/ --- (Updated April 20, 2016, 7:17 p.m.) Review request for Ambari, DIPAYAN

Re: Review Request 46434: DataNode and RegionServer during upgrade are reported as "failed" incorrectly

2016-04-20 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46434/#review129778 ---

Re: Review Request 46427: AMBARI-15985. Service Checks for Hive Server Interactive and LLAP.

2016-04-20 Thread Swapan Shridhar
> On April 20, 2016, 6:19 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/service_check.py, > > line 175 > > > > > > Any reason we are running it

Re: Review Request 46427: AMBARI-15985. Service Checks for Hive Server Interactive and LLAP.

2016-04-20 Thread Swapan Shridhar
> On April 20, 2016, 6:21 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/hiveLlapSmoke.sh, > > line 27 > > > > > > We can't hardcode /usr/hdp, we

Re: Review Request 46271: Migrate instance specific data from one version to another.

2016-04-20 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46271/#review129766 --- Ship it! Ship It! - Alejandro Fernandez On April 20, 2016,

Re: Review Request 46449: ambari upgrade fail (upgrade of ambari packages ... not hdp (eu/standard) upgrade)

2016-04-20 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46449/#review129759 --- Fix it, then Ship it!

Re: Review Request 46448: Restart button took about 5 minutes to appear after a config change for zookeeper

2016-04-20 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46448/#review129757 --- Fix it, then Ship it!

Re: Review Request 46449: ambari upgrade fail (upgrade of ambari packages ... not hdp (eu/standard) upgrade)

2016-04-20 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46449/ --- (Updated April 20, 2016, 8:20 p.m.) Review request for Ambari, Jonathan Hurley

Review Request 46449: ambari upgrade fail (upgrade of ambari packages ... not hdp (eu/standard) upgrade)

2016-04-20 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46449/ --- Review request for Ambari, Jonathan Hurley and Vitalyi Brodetskyi. Bugs:

Review Request 46448: Restart button took about 5 minutes to appear after a config change for zookeeper

2016-04-20 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46448/ --- Review request for Ambari, Jonathan Hurley and Vitalyi Brodetskyi. Bugs:

Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

2016-04-20 Thread Don Bosco Durai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46152/#review129750 --- Looks good to me. Thanks - Don Bosco Durai On April 20, 2016,

Review Request 46445: Refactor get_stack_to_component() method

2016-04-20 Thread Juanjo Marron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46445/ --- Review request for Ambari, Alejandro Fernandez and Jayush Luniya. Bugs:

Re: Review Request 46394: Can not save roles assigned to users and groups on Manage Ambari -> Roles -> Block view

2016-04-20 Thread Keta Patel
> On April 20, 2016, 9:14 a.m., Andrii Tkach wrote: > > Ship It! Thank you Andrii! Could you please help me push in the change - Keta --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

2016-04-20 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46152/ --- (Updated April 20, 2016, 4:36 p.m.) Review request for Ambari, Alejandro

Re: Review Request 46394: Can not save roles assigned to users and groups on Manage Ambari -> Roles -> Block view

2016-04-20 Thread Keta Patel
> On April 19, 2016, 4:41 p.m., Di Li wrote: > > Ship It! Thank you Di! - Keta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46394/#review129558

Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

2016-04-20 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46152/ --- (Updated April 20, 2016, 4:20 p.m.) Review request for Ambari, Alejandro

Re: Review Request 45739: Create script to export AMS metrics and re-import into AMS to visualize using Grafana

2016-04-20 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45739/#review129742 --- Fix it, then Ship it!

Re: Review Request 46443: Ambari does not show ATS is down even when the service is down

2016-04-20 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46443/#review129741 --- Ship it! Ship It! - Dmitro Lisnichenko On April 20, 2016,

Review Request 46443: Ambari does not show ATS is down even when the service is down

2016-04-20 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46443/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-15993

Review Request 46434: DataNode and RegionServer during upgrade are reported as "failed" incorrectly

2016-04-20 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46434/ --- Review request for Ambari, Alejandro Fernandez, Miklos Gergely, Oliver Szabo,

Re: Review Request 45676: AMBARI-15678: YARN service_check doesn't fail when application status is not reasonable

2016-04-20 Thread Masahiro Tanaka
> On April 20, 2016, 8:03 a.m., Jayush Luniya wrote: > > Ship It! Thank you, could you commit this? - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45676/#review129706

Review Request 46439: Ambari2400:Deploy fails at Confirm Hosts page due to Two-way SSL authentication failure

2016-04-20 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46439/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-15992

Re: Review Request 45998: HIVE service_check doesn't work properly

2016-04-20 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45998/#review129732 --- Ship it!

Re: Review Request 46210: Services status check labels and progress bar changes for Hive, Pig and Files view

2016-04-20 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46210/#review129730 --- Ship it! Ship It! - DIPAYAN BHOWMICK On April 14, 2016,

Re: Review Request 46433: spark history server fails to start after upgrading ambari 2.2.1.0 -> 2.2.2.0 and remaining on derg

2016-04-20 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46433/#review129726 --- Ship it! Ship It! - Myroslav Papirkovskyy On Квітень 20,

Re: Review Request 46016: AMBARI-15752 Ambari support for additional config params for Ranger KMS to support HSM

2016-04-20 Thread Mugdha Varadkar
> On April 20, 2016, 7:58 a.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py, > > line 238 > > > > > > Reverse the checks to > > if

Re: Review Request 46016: AMBARI-15752 Ambari support for additional config params for Ranger KMS to support HSM

2016-04-20 Thread Mugdha Varadkar
> On April 20, 2016, 7:56 a.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py, > > line 210 > > > > > > Use default() Address in latest

Re: Review Request 46016: AMBARI-15752 Ambari support for additional config params for Ranger KMS to support HSM

2016-04-20 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46016/ --- (Updated April 20, 2016, 11:14 a.m.) Review request for Ambari, Alejandro

Re: Review Request 46398: Name in create Alert Notification should be restricted to use only alphanumerics, hyphens, spaces and underscores

2016-04-20 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46398/#review129717 --- Ship it! Ship It! - Alexandr Antonenko On April 19, 2016,

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

2016-04-20 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46405/#review129716 --- Ship it! Ship It! - Alexandr Antonenko On April 19, 2016,

Re: Review Request 46403: Blueprint processor does not replace "localhost" in "xasecure.audit.destination.hdfs.dir" property.

2016-04-20 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46403/#review129715 --- Ship it! Ship It! - Balázs Bence Sári On April 19, 2016,

Re: Review Request 46389: Using a public repo definition file is not reporting correct versions on blueprint install

2016-04-20 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46389/#review129708 --- Ship it! Ship It! - Dmitro Lisnichenko On April 19, 2016,

Re: Review Request 46403: Blueprint processor does not replace "localhost" in "xasecure.audit.destination.hdfs.dir" property.

2016-04-20 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46403/#review129707 --- Ship it! Ship It! - Daniel Gergely On ápr. 19, 2016, 8:16

Re: Review Request 45676: AMBARI-15678: YARN service_check doesn't fail when application status is not reasonable

2016-04-20 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45676/#review129706 --- Ship it! Ship It! - Jayush Luniya On April 19, 2016, 11:52

Re: Review Request 46374: AMBARI-15916 Handle upgrade scenarios when db audit option is removed for Ranger

2016-04-20 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46374/#review129705 --- Ship it! Ship It! - Jayush Luniya On April 19, 2016, 7:35

Re: Review Request 46016: AMBARI-15752 Ambari support for additional config params for Ranger KMS to support HSM

2016-04-20 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46016/#review129703 ---

Re: Review Request 45507: Enhance blueprint support for using references

2016-04-20 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45507/#review129702 --- Agree with Bob's comments here. - Jayush Luniya On March 30,

Re: Review Request 45998: HIVE service_check doesn't work properly

2016-04-20 Thread Masahiro Tanaka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45998/#review129700 --- Could anyone review this? - Masahiro Tanaka On 4月 16, 2016,

Re: Review Request 46297: Views work for Hue to Views Migration Tool.

2016-04-20 Thread Pradarttana Panda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46297/ --- (Updated April 20, 2016, 6:40 a.m.) Review request for Ambari, DIPAYAN

Re: Review Request 46358: Incorporate 'llap status check' to be used for (1). Before Hive Server Interactive start, and (2). status call.

2016-04-20 Thread Swapan Shridhar
> On April 20, 2016, 5:43 a.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py, > > line 150 > > > > > > it says llap here but