Re: Review Request 51754: AMBARI-18337 Syntax Error in Ambari HAWQ Unit test with Python 2.6

2016-09-19 Thread Masahiro Tanaka
> On 9月 10, 2016, 6:06 a.m., Lav Jain wrote: > > Ship It! Thanks Lav Jain, could you commit this? - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51754/#review148370 --

Re: Review Request 51754: AMBARI-18337 Syntax Error in Ambari HAWQ Unit test with Python 2.6

2016-09-19 Thread Masahiro Tanaka
> On 9月 17, 2016, 1:20 a.m., Alexander Denissov wrote: > > Ship It! Thanks Alexander Denissov! - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51754/#review149208 -

Review Request 52072: AMBARI-18390 : Configuration warnings during "Add Service" Wizard includes seemingly nonsensical heapsize recommendations for AMS heap sizes.

2016-09-19 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52072/ --- Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Bugs: AMBA

Re: Review Request 52068: Create authentication filter to perform Kerberos authentication for Ambari

2016-09-19 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52068/#review149557 --- ambari-server/src/main/java/org/apache/ambari/server/serveraction

Review Request 52068: Create authentication filter to perform Kerberos authentication for Ambari

2016-09-19 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52068/ --- Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, and Nate Cole

Re: Review Request 51937: Configuration Groups popup: Tooltip over properties number has too much content

2016-09-19 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51937/#review149550 --- Ship it! Ship It! - Zhe (Joe) Wang On Sept. 15, 2016, 11:48

Re: Review Request 52044: Analyze and Optimize Ambari Server Unit Tests - Group 6

2016-09-19 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52044/ --- (Updated Вер. 19, 2016, 9:10 після полудня) Review request for Ambari, Andrew O

Re: Review Request 52043: AMBARI-18419. Allow setting EclipseLink weave log level in build process

2016-09-19 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52043/ --- (Updated Sept. 19, 2016, 7:21 p.m.) Review request for Ambari, Laszlo Puskas, M

Review Request 52044: Analyze and Optimize Ambari Server Unit Tests - Group 6

2016-09-19 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52044/ --- Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Sumit Mohant

Re: Review Request 51724: Add Kerberos HTTP SPNEGO authentication support to Ambari Metrics Monitor

2016-09-19 Thread Sid Wagle
> On Sept. 19, 2016, 9:18 a.m., Robert Levas wrote: > > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py, > > line 112 > > > > > > The path to the SPNEGO keytab file and the SPNEGO

Re: Review Request 51724: Add Kerberos HTTP SPNEGO authentication support to Ambari Metrics Monitor

2016-09-19 Thread Qin Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51724/ --- (Updated Sept. 19, 2016, 3:53 p.m.) Review request for Ambari, Di Li, Dmytro Se

Re: Review Request 51894: View instance cloning functionality

2016-09-19 Thread Sangeeta Ravindran
> On Sept. 19, 2016, 1:31 p.m., Di Li wrote: > > Ship It! Thank you Di. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51894/#review149466

Re: Review Request 51894: View instance cloning functionality

2016-09-19 Thread Sangeeta Ravindran
> On Sept. 18, 2016, 11:51 a.m., Alexandr Antonenko wrote: > > Ship It! Thank you Alexandr. Can you please help push the fix? - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51894/

Re: Review Request 52043: AMBARI-18419. Allow setting EclipseLink weave log level in build process

2016-09-19 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52043/#review149480 --- Ship it! - Laszlo Puskas On Sept. 19, 2016, 3:21 p.m., Attila

Review Request 52043: AMBARI-18419. Allow setting EclipseLink weave log level in build process

2016-09-19 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52043/ --- Review request for Ambari, Laszlo Puskas, Myroslav Papirkovskyy, Oliver Szabo, a

Re: Review Request 51599: AMBARI-18292 Support dispatching notifications of assigned alert states for script-based alert dispatcher

2016-09-19 Thread Jonathan Hurley
> On Sept. 3, 2016, 3:17 p.m., Jonathan Hurley wrote: > > This is not the correct way to accomplish this. Instead, when you create > > the alert target, you can specify which alert states the alert target cares > > about: > > > > ``` > > { > > "AlertTarget": { > > "name": "Simple", > >

Review Request 52038: AMBARI-18418 StackServiceDirectory debug messages are logged with placeholders

2016-09-19 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52038/ --- Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Oliver Szabo, and S

Re: Review Request 52035: Improve agent logging to add more relevant message

2016-09-19 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52035/#review149471 --- Ship it! Ship It! - Dmitro Lisnichenko On Sept. 19, 2016, 4:

Re: Review Request 52032: Optimize stack manager initialization for Ambari Server Unit Tests

2016-09-19 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52032/#review149469 --- Ship it! Ship It! - Vitalyi Brodetskyi On Вер. 19, 2016, 12:

Review Request 52035: Improve agent logging to add more relevant message

2016-09-19 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52035/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-18417 https:

Re: Review Request 51894: View instance cloning functionality

2016-09-19 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51894/#review149466 --- Ship it! Ship It! - Di Li On Sept. 16, 2016, 10:59 p.m., San

Re: Review Request 51906: AMBARI-18349 Specify role command order to make Microsoft-R service check run after YARN is started

2016-09-19 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51906/#review149463 --- Ship it! Ship It! - Balázs Bence Sári On Sept. 16, 2016, 2:5

Re: Review Request 51906: AMBARI-18349 Specify role command order to make Microsoft-R service check run after YARN is started

2016-09-19 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51906/#review149461 --- Ship it! Ship It! - Sebastian Toader On Sept. 16, 2016, 4:57

Review Request 52032: Optimize stack manager initialization for Ambari Server Unit Tests

2016-09-19 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52032/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-18416 https:

Re: Review Request 51906: AMBARI-18349 Specify role command order to make Microsoft-R service check run after YARN is started

2016-09-19 Thread Attila Doroszlai
> On Sept. 16, 2016, 7:01 p.m., Sebastian Toader wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py, > > line 188 > > > > > > Why is this needed ? There

Re: Review Request 51599: AMBARI-18292 Support dispatching notifications of assigned alert states for script-based alert dispatcher

2016-09-19 Thread yao lei
> On 九月 3, 2016, 7:17 p.m., Jonathan Hurley wrote: > > This is not the correct way to accomplish this. Instead, when you create > > the alert target, you can specify which alert states the alert target cares > > about: > > > > ``` > > { > > "AlertTarget": { > > "name": "Simple", > >

Re: Review Request 52027: Stack definition: service component 'cardinality' inheritance not working properly

2016-09-19 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52027/#review149456 --- Ship it! Ship It! - Vitalyi Brodetskyi On Вер. 19, 2016, 11:

Review Request 52027: Stack definition: service component 'cardinality' inheritance not working properly

2016-09-19 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52027/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-18415 https:

Re: Review Request 51330: Certain configuration files cannot be modified through Ambari api.

2016-09-19 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51330/#review149451 --- Ship it! Ship It! - Vitalyi Brodetskyi On Вер. 19, 2016, 10:

Re: Review Request 51330: Certain configuration files cannot be modified through Ambari api.

2016-09-19 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51330/ --- (Updated Sept. 19, 2016, 10:26 a.m.) Review request for Ambari, Dmitro Lisniche

Re: Review Request 51330: Certain configuration files cannot be modified through Ambari api.

2016-09-19 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51330/#review149450 --- Ship it! Ship It! - Vitalyi Brodetskyi On Вер. 19, 2016, 10:

Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-19 Thread Sandor Magyari
Hi Wang! The patch is committed to trunk & branch-2.5, you can close now the related review request. Please make sure, next time to attach the result of unit tests to the Testing section of review request. BR Sandor From: wang yaoxin mailto:nore...@reviews.apache.org>> on behalf of wang yaox

Re: Review Request 51724: Add Kerberos HTTP SPNEGO authentication support to Ambari Metrics Monitor

2016-09-19 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51724/#review149443 --- I think this is incorrect. The Metrics Monitor should authenticat

Re: Review Request 51961: Prerequisite checks should only check services that are getting upgraded

2016-09-19 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51961/#review149442 --- Ship it! ambari-server/src/test/java/org/apache/ambari/server/