Re: Review Request 52646: Remove Unnecessary Locks Inside Of Service Business Object Implementations

2016-10-10 Thread Sid Wagle
> On Oct. 7, 2016, 8:13 p.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java, > > line 966 > > > > > > Shouldn't we target removing the explicit refresh calls as w

Re: Review Request 52646: Remove Unnecessary Locks Inside Of Service Business Object Implementations

2016-10-10 Thread Sid Wagle
> On Oct. 7, 2016, 8:07 p.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java, > > line 447 > > > > > > Do we still need to explcitly refresh even though there is no

Review Request 52711: Logging of ambari agent scheduling activities in debug mode- AMBARI-18502.

2016-10-10 Thread Ranjan Banerjee
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52711/ --- Review request for Ambari and Nahappan Somasundaram. Bugs: AMBARI-18502 htt

Re: Review Request 52709: Deprecate old UpgradeCatalog Unit Tests

2016-10-10 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52709/ --- (Updated Oct. 10, 2016, 11:21 p.m.) Review request for Ambari, Jonathan Hurley

Review Request 52710: AMBARI-18566 Installer wizard-> Select Versions page: Selecting Red Hat Satellite option and clicking next button makes wizard stuck

2016-10-10 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52710/ --- Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramania

Re: Review Request 52654: At "Add Service Wizard", when the installation is going on, if I click the close (X) on the wizard, the service will only get INSTALLED not STARTED.

2016-10-10 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52654/#review152075 --- Ship it! Ship It! - Zhe (Joe) Wang On Oct. 7, 2016, 10:14 p.

Re: Review Request 52709: Deprecate old UpgradeCatalog Unit Tests

2016-10-10 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52709/#review152073 --- ambari-server/src/test/java/org/apache/ambari/server/security/Sec

Review Request 52709: Deprecate old UpgradeCatalog Unit Tests

2016-10-10 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52709/ --- Review request for Ambari, Jonathan Hurley and Sid Wagle. Bugs: AMBARI-18565

Re: Review Request 52528: Custom logsearch property should override default value

2016-10-10 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52528/#review152064 --- Ship it! Patch looks fine to me. Thanks. ambari-logsearch/

Re: Review Request 52583: Request/access log feature in Ambari-server

2016-10-10 Thread Amarnath reddy pappu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52583/ --- (Updated Oct. 10, 2016, 8:43 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 52583: Request/access log feature in Ambari-server

2016-10-10 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52583/#review152056 --- Fix it, then Ship it! ambari-server/src/main/java/org/apache/a

Re: Review Request 52583: Request/access log feature in Ambari-server

2016-10-10 Thread Amarnath reddy pappu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52583/ --- (Updated Oct. 10, 2016, 7:27 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 52583: Request/access log feature in Ambari-server

2016-10-10 Thread Amarnath reddy pappu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52583/ --- (Updated Oct. 10, 2016, 7:26 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 52583: Request/access log feature in Ambari-server

2016-10-10 Thread Amarnath reddy pappu
> On Oct. 6, 2016, 2:55 p.m., Nate Cole wrote: > > ambari-server/conf/unix/ambari.properties, line 78 > > > > > > Not really a path, more like "pattern" or "format". Probably disable > > by default. > > > >

Re: Review Request 52681: Add more logging to track what condition resulted in skipping agent commands

2016-10-10 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52681/#review152032 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 10, 2016, 11

Re: Review Request 52649: Create Component to Repo Version associations

2016-10-10 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52649/#review152030 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 10, 2016, 6:

Re: Review Request 52649: Create Component to Repo Version associations

2016-10-10 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52649/ --- (Updated Oct. 10, 2016, 2:27 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

2016-10-10 Thread Attila Doroszlai
> On Oct. 7, 2016, 9 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java, > > lines 332-333 > > > > > > Why is this a read/write lock? I don't think i

Re: Review Request 52456: Modify HTTP headers to follow best security practices

2016-10-10 Thread Sangeeta Ravindran
> On Oct. 9, 2016, 10:39 p.m., Robert Levas wrote: > > Ship It! > > Sangeeta Ravindran wrote: > Thank you Robert. > Can you please help push the fix? > > Robert Levas wrote: > Pushed to trunk: > > ``` > commit 34c5686c3a0f80a5c7b78ddf05bb41cb13202438 > Author: Sange

Re: Review Request 52456: Modify HTTP headers to follow best security practices

2016-10-10 Thread Robert Levas
> On Oct. 9, 2016, 6:39 p.m., Robert Levas wrote: > > Ship It! > > Sangeeta Ravindran wrote: > Thank you Robert. > Can you please help push the fix? Pushed to trunk: ``` commit 34c5686c3a0f80a5c7b78ddf05bb41cb13202438 Author: Sangeeta Ravindran Date: Mon Oct 10 11:05:40 2016 -0400

Re: Review Request 52692: Ambari startup script doesn't work on SUSE and potentially other OS's.

2016-10-10 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52692/#review151978 --- Ship it! Ship It! - Myroslav Papirkovskyy On Жов. 10, 2016,

Review Request 52692: Ambari startup script doesn't work on SUSE and potentially other OS's.

2016-10-10 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52692/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-18563 https:

Re: Review Request 52681: Add more logging to track what condition resulted in skipping agent commands

2016-10-10 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52681/#review151977 --- Ship it! Ship It! - Sandor Magyari On Oct. 10, 2016, 11:14 a

Re: Review Request 52681: Add more logging to track what condition resulted in skipping agent commands

2016-10-10 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52681/#review151975 --- ambari-server/src/main/java/org/apache/ambari/server/controller/i

Re: Review Request 52649: Create Component to Repo Version associations

2016-10-10 Thread Nate Cole
> On Oct. 7, 2016, 4:51 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql, line 875 > > > > > > can we make the name consistent, either remove the underscore or add >

Re: Review Request 52681: Add more logging to track what condition resulted in skipping agent commands

2016-10-10 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52681/#review151974 --- Ship it! Ship It! - Laszlo Puskas On Oct. 10, 2016, 11:14 a.

Review Request 52688: Capacity Scheduler View: Calculating absolute capacity for node labels and showing in sunburst chart

2016-10-10 Thread Akhil PB
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52688/ --- Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath S

Re: Review Request 52681: Add more logging to track what condition resulted in skipping agent commands

2016-10-10 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52681/#review151963 --- Ship it! Ship It! - Oliver Szabo On Oct. 10, 2016, 11:14 a.m

Review Request 52681: Add more logging to track what condition resulted in skipping agent commands

2016-10-10 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52681/ --- Review request for Ambari, Laszlo Puskas, Oliver Szabo, and Sandor Magyari. Bug