Re: Review Request 54477: Update zeppelin configuration for ambari 2.5

2016-12-07 Thread Prabhjyot Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54477/ --- (Updated Dec. 8, 2016, 7:04 a.m.) Review request for Ambari, Alejandro Fernande

Re: Review Request 54477: Update zeppelin configuration for ambari 2.5

2016-12-07 Thread Prabhjyot Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54477/ --- (Updated Dec. 8, 2016, 6:47 a.m.) Review request for Ambari, Alejandro Fernande

Re: Review Request 54477: Update zeppelin configuration for ambari 2.5

2016-12-07 Thread Prabhjyot Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54477/ --- (Updated Dec. 8, 2016, 6:14 a.m.) Review request for Ambari, Alejandro Fernande

Re: Review Request 54513: HDP 3.0 TP - move ZK, HFDS, YARN/MR into new common-services version

2016-12-07 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54513/#review158494 --- Ship it! Ship It! - Sid Wagle On Dec. 8, 2016, 12:39 a.m., A

Re: Review Request 53686: Stage and Request status should be persisted in the database

2016-12-07 Thread Jaimin Jetly
> On Nov. 14, 2016, 4:41 p.m., Jonathan Hurley wrote: > > I'm a bit worried about this review: > > - Requesting HRCs and Stages forces lazily loaded entities to be retrieved > > from the database. In large and/or cloud environments, this can lead to > > performance problems > > - There are defi

Re: Review Request 53686: Stage and Request status should be persisted in the database

2016-12-07 Thread Jaimin Jetly
> On Nov. 14, 2016, 5:03 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java, > > lines 223-230 > > > > > > This is iterating Stages won't be performant wh

Review Request 54513: HDP 3.0 TP - move ZK, HFDS, YARN/MR into new common-services version

2016-12-07 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54513/ --- Review request for Ambari, Sumit Mohanty, Swapan Shridhar, and Sid Wagle. Bugs:

Re: Review Request 54121: AMBARI-18929 : Yarn service check fails when either resource manager is down in HA enabled cluster

2016-12-07 Thread Weiwei Yang
> On 十二月 7, 2016, 5:08 p.m., Di Li wrote: > > hi Wei Wei, > > > > Can you close this one ? The corresponding JIRA is resolved now. Done, thanks. - Weiwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.a

Re: Review Request 54466: AMBARI-19118 - Ranger Admin Start failed while enabling NameNode HA

2016-12-07 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54466/#review158433 --- Ship it! Ship It! - Jaimin Jetly On Dec. 7, 2016, 11:25 p.m.

Re: Review Request 54466: AMBARI-19118 - Ranger Admin Start failed while enabling NameNode HA

2016-12-07 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54466/ --- (Updated Dec. 7, 2016, 11:25 p.m.) Review request for Ambari, Jaimin Jetly and

Re: Review Request 54339: Cookie management for Ambari LogSearch Integration

2016-12-07 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54339/ --- (Updated Dec. 7, 2016, 11 p.m.) Review request for Ambari, Miklos Gergely and R

Re: Review Request 54339: Cookie management for Ambari LogSearch Integration

2016-12-07 Thread Oliver Szabo
> On Dec. 7, 2016, 10:25 p.m., Robert Nettleton wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImpl.java, > > line 151 > > > > > > The fact that this is a sing

Re: Review Request 54339: Cookie management for Ambari LogSearch Integration

2016-12-07 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54339/#review158420 --- Fix it, then Ship it! Overall, the patch looks fine to me. J

Review Request 54501: Perf: Deploy 3000 Agent cluster and find perf bugs. Part 2

2016-12-07 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54501/ --- Review request for Ambari, Alejandro Fernandez, Dmytro Sen, and Sid Wagle. Bugs

Re: Review Request 54357: AMBARI-19077: Ambari-server: Gather dependent configuration types and password properties for a service component

2016-12-07 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54357/ --- (Updated Dec. 7, 2016, 1:48 p.m.) Review request for Ambari, Jonathan Hurley, N

Re: Review Request 54357: AMBARI-19077: Ambari-server: Gather dependent configuration types and password properties for a service component

2016-12-07 Thread Nahappan Somasundaram
> On Dec. 5, 2016, 1:36 p.m., Nate Cole wrote: > > ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py, > > lines 376-379 > > > > > > Do clients matter here? Clients have no START but do use conf

Re: Review Request 53969: When HS2Interactive is enabled, any hive config change results in a CS queue refresh

2016-12-07 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53969/#review158400 --- Ship it! Ship It! - Jaimin Jetly On Dec. 5, 2016, 11:28 p.m.

Re: Review Request 53686: Stage and Request status should be persisted in the database

2016-12-07 Thread Jaimin Jetly
> On Nov. 16, 2016, 1:43 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StatusHoldingEntity.java, > > lines 23-27 > > > > > > Documentation. This is not part of th

Re: Review Request 54491: Manage Journalnode Wizard: incorrect number of installed JournalNodes

2016-12-07 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54491/#review158382 --- Ship it! Ship It! - Alexandr Antonenko On Dec. 7, 2016, 7:19

Re: Review Request 54488: Downgrade Can Create Multiple Mappings For Latest Configs

2016-12-07 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54488/#review158380 --- Ship it! ambari-server/src/test/java/org/apache/ambari/server/

Re: Review Request 53686: Stage and Request status should be persisted in the database

2016-12-07 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53686/ --- (Updated Dec. 7, 2016, 7:45 p.m.) Review request for Ambari, Jonathan Hurley, N

Re: Review Request 54466: AMBARI-19118 - Ranger Admin Start failed while enabling NameNode HA

2016-12-07 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54466/ --- (Updated Dec. 7, 2016, 7:43 p.m.) Review request for Ambari, Jaimin Jetly and Y

Re: Review Request 53980: AMBARI-18945 Allowing user to edit service name while enabling ranger plugin

2016-12-07 Thread Mugdha Varadkar
> On Dec. 5, 2016, 7:36 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java, > > line 267 > > > > > > Same comment as Jonathan. The behavior of al

Re: Review Request 53980: AMBARI-18945 Allowing user to edit service name while enabling ranger plugin

2016-12-07 Thread Mugdha Varadkar
> On Dec. 5, 2016, 3:53 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java, > > lines 137-145 > > > > > > All of these essentially do the same thing,

Re: Review Request 53980: AMBARI-18945 Allowing user to edit service name while enabling ranger plugin

2016-12-07 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53980/ --- (Updated Dec. 7, 2016, 7:36 p.m.) Review request for Ambari, Alejandro Fernande

Review Request 54491: Manage Journalnode Wizard: incorrect number of installed JournalNodes

2016-12-07 Thread Aleksandr Kovalenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54491/ --- Review request for Ambari and Alexandr Antonenko. Bugs: AMBARI-19131 https:

Re: Review Request 54477: Update zeppelin configuration for ambari 2.5

2016-12-07 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54477/#review158366 --- Fix it, then Ship it! ambari-server/src/main/resources/common-

Re: Review Request 54488: Downgrade Can Create Multiple Mappings For Latest Configs

2016-12-07 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54488/#review158365 --- ambari-server/src/main/java/org/apache/ambari/server/state/cluste

Re: Review Request 54484: Perf: Allow Kerberizing the PERF stack

2016-12-07 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54484/#review158364 --- Ship it! Ship It! - Alejandro Fernandez On Dec. 7, 2016, 4:5

Review Request 54488: Downgrade Can Create Multiple Mappings For Latest Configs

2016-12-07 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54488/ --- Review request for Ambari, Alejandro Fernandez and Nate Cole. Bugs: AMBARI-1913

Re: Review Request 53144: Workflow Designer View: Tooltip for Edit button shows "Back"

2016-12-07 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53144/#review158351 --- hello Sangeeta, Is this one ready to be committed and closed ? -

Re: Review Request 54121: AMBARI-18929 : Yarn service check fails when either resource manager is down in HA enabled cluster

2016-12-07 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54121/#review158350 --- hi Wei Wei, Can you close this one ? The corresponding JIRA is re

Re: Review Request 54276: AMBARI-19038: Support migration of LDAP users & groups to PAM

2016-12-07 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54276/#review158348 --- Ship it! Ship It! - Di Li On Dec. 2, 2016, 8:19 p.m., Vishal

Re: Review Request 54161: Abillity to use external Solr for Log Search instead of AMBARI_INFRA_SOLR

2016-12-07 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54161/#review158346 --- Ship it! Ship It! - Robert Nettleton On Dec. 5, 2016, 2:46 p

Re: Review Request 54484: Perf: Allow Kerberizing the PERF stack

2016-12-07 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54484/ --- (Updated Дек. 7, 2016, 4:57 п.п.) Review request for Ambari, Alejandro Fernande

Review Request 54484: Perf: Allow Kerberizing the PERF stack

2016-12-07 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54484/ --- Review request for Ambari, Alejandro Fernandez, Sid Wagle, and Vitalyi Brodetsky

Re: Review Request 54080: Auto-fix common issues found by the DB consistency checker

2016-12-07 Thread Dmitro Lisnichenko
> On Dec. 6, 2016, 9:39 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java, > > line 431 > > > > > > JPA spec doesn't mention return type

Re: Review Request 54080: Auto-fix common issues found by the DB consistency checker

2016-12-07 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54080/ --- (Updated Dec. 7, 2016, 5:50 p.m.) Review request for Ambari, Jonathan Hurley an

Re: Review Request 54080: Auto-fix common issues found by the DB consistency checker

2016-12-07 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54080/ --- (Updated Dec. 7, 2016, 5:56 p.m.) Review request for Ambari, Jonathan Hurley an

Re: Review Request 54471: AMBARI-19025. Add livy.spark.master to livy.conf and update spark-blacklist.conf

2016-12-07 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54471/#review158341 --- Ship it! Ship It! - Sumit Mohanty On Dec. 7, 2016, 5:04 a.m.

Re: Review Request 54481: hbase_regionserver_shutdown_timeout should be editable all the time

2016-12-07 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54481/#review158339 --- Ship it! Ship It! - Dmitro Lisnichenko On Dec. 7, 2016, 4:53

Review Request 54482: Tooltip is not hidden on host alerts page

2016-12-07 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54482/ --- Review request for Ambari, Aleksandr Kovalenko, Alexandr Antonenko, and Andrii T

Re: Review Request 54482: Tooltip is not hidden on host alerts page

2016-12-07 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54482/#review158337 --- Ship it! Ship It! - Alexandr Antonenko On Dec. 7, 2016, 3:07

Re: Review Request 54476: Logs tab in host details page not populating any logs

2016-12-07 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54476/#review158338 --- Ship it! Ship It! - Robert Nettleton On Dec. 7, 2016, 2:10 p

Review Request 54480: Spark 2.x interpreter confgurations in Zeppelin

2016-12-07 Thread Renjith Kamath
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54480/ --- Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush Luniya,

Review Request 54481: hbase_regionserver_shutdown_timeout should be editable all the time

2016-12-07 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54481/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-19127 https:

Re: Review Request 54476: Logs tab in host details page not populating any logs

2016-12-07 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54476/#review158333 --- Ship it! Ship It! - Sebastian Toader On Dec. 7, 2016, 3:10 p

Re: Review Request 54476: Logs tab in host details page not populating any logs

2016-12-07 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54476/ --- (Updated Dec. 7, 2016, 2:10 p.m.) Review request for Ambari, Oliver Szabo, Robe

Re: Review Request 54478: Active tab is not switched

2016-12-07 Thread Aleksandr Kovalenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54478/#review158329 --- Ship it! Ship It! - Aleksandr Kovalenko On Дек. 7, 2016, 1:0

Review Request 54478: Active tab is not switched

2016-12-07 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54478/ --- Review request for Ambari, Aleksandr Kovalenko, Alexandr Antonenko, and Andrii T

Review Request 54477: Update zeppelin configuration for ambari 2.5

2016-12-07 Thread Prabhjyot Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54477/ --- Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar,

Re: Review Request 54476: Logs tab in host details page not populating any logs

2016-12-07 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54476/#review158326 --- Ship it! Ship It! - Sebastian Toader On Dec. 7, 2016, 11:37

Re: Review Request 54476: Logs tab in host details page not populating any logs

2016-12-07 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54476/#review158325 --- ambari-server/src/main/java/org/apache/ambari/server/controller/l

Re: Review Request 54474: Metrics Monitor start failed: ERROR: Cannot write pid /grid/0/pid/metric_monitor/ambari-metrics-monitor.pid

2016-12-07 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54474/#review158323 --- Ship it! Ship It! - Dmitro Lisnichenko On Dec. 7, 2016, 11:4

Re: Review Request 54476: Logs tab in host details page not populating any logs

2016-12-07 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54476/#review158322 --- Ship it! Ship It! - Oliver Szabo On Dec. 7, 2016, 10:37 a.m.

Re: Review Request 54457: AMBARI-19089 - Manage Journalnode Wizard is stuck at Add/Remove JournalNodes in Kerberized Cluster

2016-12-07 Thread Aleksandr Kovalenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54457/#review158320 --- Ship it! Ship It! - Aleksandr Kovalenko On Дек. 6, 2016, 11:

Review Request 54476: Logs tab in host details page not populating any logs

2016-12-07 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54476/ --- Review request for Ambari, Oliver Szabo, Robert Nettleton, Sumit Mohanty, and Se

Re: Review Request 54425: Perf: Web UI can't load json with host check info

2016-12-07 Thread Aleksandr Kovalenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54425/#review158319 --- Ship it! Ship It! - Aleksandr Kovalenko On Дек. 6, 2016, 6:2

Review Request 54474: Metrics Monitor start failed: ERROR: Cannot write pid /grid/0/pid/metric_monitor/ambari-metrics-monitor.pid

2016-12-07 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54474/ --- Review request for Ambari and Sid Wagle. Bugs: AMBARI-19115 https://issues.