Re: Review Request 54802: Fix version of HDFS and YARN used by HDP 3.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54802/#review159401 --- Ship it! Ship It! - Sumit Mohanty On Dec. 16, 2016, 1:41

Re: Review Request 54802: Fix version of HDFS and YARN used by HDP 3.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54802/ --- (Updated Dec. 16, 2016, 1:41 a.m.) Review request for Ambari and Sumit

Review Request 54802: Fix version of HDFS and YARN used by HDP 3.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54802/ --- Review request for Ambari and Sumit Mohanty. Bugs: AMBARI-19220

Re: Review Request 54698: Disable security hook

> On Dec. 14, 2016, 6:25 p.m., Alejandro Fernandez wrote: > > ambari-agent/pom.xml, line 57 > > > > > > Can this be moved to another project, say contrib? > > > > We're adding a dependency on ZK, so I would

Review Request 54795: Add a Maven Target for ambari-server Which Updates the Configuration Markdown

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54795/ --- Review request for Ambari, Nate Cole and Robert Nettleton. Bugs: AMBARI-19219

Re: Review Request 54756: Adding configurable timeouts to Ambari LogSearch Integration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54756/#review159369 --- Ship it! Ship It! - Jonathan Hurley On Dec. 15, 2016, 2:54

Re: Review Request 54609: AMBARI-19141 : Refinements for AMS whitelisting

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54609/ --- (Updated Dec. 15, 2016, 8:03 p.m.) Review request for Ambari, Dmytro Sen,

Re: Review Request 54756: Adding configurable timeouts to Ambari LogSearch Integration

> On Dec. 15, 2016, 3:04 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LogSearchDataRetrievalService.java, > > lines 73-74 > > > > > > This is a little odd;

Re: Review Request 54756: Adding configurable timeouts to Ambari LogSearch Integration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54756/ --- (Updated Dec. 15, 2016, 7:54 p.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 54735: AMBARI-19149. Code cleanup: empty blocks

> On Dec. 15, 2016, 5:50 p.m., Alejandro Fernandez wrote: > > ambari-server/checkstyle.xml, line 33 > > > > > > The only one I'm in favor of is "AvoidNestedBlocks". > > > > The "ignored" variable name is too

Re: Review Request 54735: AMBARI-19149. Code cleanup: empty blocks

> On Dec. 15, 2016, 12:50 p.m., Alejandro Fernandez wrote: > > ambari-server/checkstyle.xml, line 33 > > > > > > The only one I'm in favor of is "AvoidNestedBlocks". > > > > The "ignored" variable name is

Re: Review Request 54735: AMBARI-19149. Code cleanup: empty blocks

> On Dec. 15, 2016, 5:50 p.m., Alejandro Fernandez wrote: > > ambari-server/checkstyle.xml, line 33 > > > > > > The only one I'm in favor of is "AvoidNestedBlocks". > > > > The "ignored" variable name is too

Re: Review Request 54789: Integrate karma with babel preprocessor

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54789/#review159344 --- Ship it! Ship It! - Alexandr Antonenko On Dec. 15, 2016,

Re: Review Request 54735: AMBARI-19149. Code cleanup: empty blocks

> On Dec. 15, 2016, 12:50 p.m., Alejandro Fernandez wrote: > > ambari-server/checkstyle.xml, line 33 > > > > > > The only one I'm in favor of is "AvoidNestedBlocks". > > > > The "ignored" variable name is

Re: Review Request 54735: AMBARI-19149. Code cleanup: empty blocks

> On Dec. 15, 2016, 4:56 a.m., Nate Cole wrote: > > ambari-server/checkstyle.xml, lines 39-41 > > > > > > This check seems a bit restrictive, both in having to name the variable > > "ignored" and requiring some

Re: Review Request 54756: Adding configurable timeouts to Ambari LogSearch Integration

> On Dec. 15, 2016, 10:04 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LogSearchDataRetrievalService.java, > > lines 73-74 > > > > > > This is a little

Re: Review Request 54791: After rescanning yarn queue, Ambari still asks for RM to be restarted

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54791/#review159328 --- Ship it! Ship It! - Vitalyi Brodetskyi On Гру. 15, 2016,

Review Request 54791: After rescanning yarn queue, Ambari still asks for RM to be restarted

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54791/ --- Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Sid Wagle, and

Re: Review Request 54735: AMBARI-19149. Code cleanup: empty blocks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54735/#review159326 --- ambari-server/checkstyle.xml (line 33)

Re: Review Request 54788: rat check failure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54788/#review159324 --- Ship it! Ship It! - Attila Doroszlai On Dec. 15, 2016, 5:51

Review Request 54789: Integrate karma with babel preprocessor

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54789/ --- Review request for Ambari, Alexandr Antonenko and Oleg Nechiporenko. Bugs:

Re: Review Request 54756: Adding configurable timeouts to Ambari LogSearch Integration

> On Dec. 15, 2016, 3:04 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LogSearchDataRetrievalService.java, > > lines 73-74 > > > > > > This is a little odd;

Re: Review Request 54698: Disable security hook

> On Dec. 13, 2016, 3:26 p.m., Robert Levas wrote: > > ambari-agent/src/test/java/org/apache/ambari/tools/zk/ZkMigratorTest.java, > > line 38 > > > > > > This test suite should use mocks (example,

Re: Review Request 54788: rat check failure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54788/ --- (Updated Dec. 15, 2016, 4:51 p.m.) Review request for Ambari, Alejandro

Re: Review Request 53686: Stage and Request status should be persisted in the database

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53686/#review159315 ---

Review Request 54788: rat check failure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54788/ --- Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. Bugs:

Re: Review Request 54787: AMBARI-19132. Use "rm" to delete Ambari Server keytab files when disabling Kerberos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54787/#review159310 --- Ship it! Ship It! - Attila Magyar On Dec. 15, 2016, 4:21

Re: Review Request 54787: AMBARI-19132. Use "rm" to delete Ambari Server keytab files when disabling Kerberos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54787/#review159314 --- Ship it! Ship It! - Robert Levas On Dec. 15, 2016, 11:21

Re: Review Request 54756: Adding configurable timeouts to Ambari LogSearch Integration

> On Dec. 15, 2016, 10:04 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LogSearchDataRetrievalService.java, > > lines 73-74 > > > > > > This is a little

Review Request 54787: AMBARI-19132. Use "rm" to delete Ambari Server keytab files when disabling Kerberos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54787/ --- Review request for Ambari, Attila Magyar, Robert Levas, and Sebastian Toader.

Re: Review Request 54756: Adding configurable timeouts to Ambari LogSearch Integration

> On Dec. 15, 2016, 3:04 p.m., Jonathan Hurley wrote: > > Hi Jonathan, thanks for the review comments. > On Dec. 15, 2016, 3:04 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java, > > lines 5086-5090 > >

Re: Review Request 54786: DataNodes Live widget can't be edited

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54786/#review159307 --- Ship it! Ship It! - Andrii Tkach On Dec. 15, 2016, 3:39

Re: Review Request 53686: Stage and Request status should be persisted in the database

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53686/#review159228 ---

Review Request 54786: DataNodes Live widget can't be edited

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54786/ --- Review request for Ambari and Andrii Tkach. Bugs: ambari-19213

Re: Review Request 54735: AMBARI-19149. Code cleanup: empty blocks

> On Dec. 15, 2016, 10:56 a.m., Nate Cole wrote: > > ambari-server/checkstyle.xml, lines 39-41 > > > > > > This check seems a bit restrictive, both in having to name the variable > > "ignored" and requiring some

Re: Review Request 54698: Disable security hook

> On Dec. 13, 2016, 3:26 p.m., Robert Levas wrote: > > ambari-agent/src/test/java/org/apache/ambari/tools/zk/ZkMigratorTest.java, > > line 38 > > > > > > This test suite should use mocks (example,

Re: Review Request 54698: Disable security hook

> On Dec. 13, 2016, 3:26 p.m., Robert Levas wrote: > > ambari-agent/src/test/java/org/apache/ambari/tools/zk/ZkMigratorTest.java, > > line 38 > > > > > > This test suite should use mocks (example,

Re: Review Request 54735: AMBARI-19149. Code cleanup: empty blocks

> On Dec. 15, 2016, 4:56 a.m., Nate Cole wrote: > > ambari-server/checkstyle.xml, lines 39-41 > > > > > > This check seems a bit restrictive, both in having to name the variable > > "ignored" and requiring some

Re: Review Request 54756: Adding configurable timeouts to Ambari LogSearch Integration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54756/#review159298 --- Fix it, then Ship it!

Re: Review Request 54735: AMBARI-19149. Code cleanup: empty blocks

> On Dec. 15, 2016, 4:56 a.m., Nate Cole wrote: > > ambari-server/checkstyle.xml, lines 39-41 > > > > > > This check seems a bit restrictive, both in having to name the variable > > "ignored" and requiring some

Re: Review Request 54743: Add PK to hostcomponentdesiredstate Table To Support FK Relationships

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54743/#review159296 --- Ship it! Ship It! - Sandor Magyari On Dec. 15, 2016, 1:15

Re: Review Request 54698: Disable security hook

> On Dec. 13, 2016, 3:26 p.m., Robert Levas wrote: > > ambari-agent/src/test/java/org/apache/ambari/tools/zk/ZkMigratorTest.java, > > line 38 > > > > > > This test suite should use mocks (example,

Re: Review Request 54756: Adding configurable timeouts to Ambari LogSearch Integration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54756/#review159294 --- Ship it! Ship It! - Miklos Gergely On Dec. 14, 2016, 8:08

Re: Review Request 54698: Disable security hook

> On Dec. 13, 2016, 10:26 a.m., Robert Levas wrote: > > ambari-agent/src/test/java/org/apache/ambari/tools/zk/ZkMigratorTest.java, > > line 38 > > > > > > This test suite should use mocks (example,

Re: Review Request 54780: Restore styles of remove repository icon

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54780/#review159291 --- Ship it! Ship It! - Oleg Nechiporenko On Dec. 15, 2016,

Re: Review Request 54781: Fix styles for disabled buttons

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54781/#review159289 --- Ship it! Ship It! - Andriy Babiichuk On Гру. 15, 2016, 1:33

Review Request 54781: Fix styles for disabled buttons

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54781/ --- Review request for Ambari and Andriy Babiichuk. Bugs: AMBARI-19212

Review Request 54780: Restore styles of remove repository icon

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54780/ --- Review request for Ambari and Oleg Nechiporenko. Bugs: AMBARI-19211

Re: Review Request 54743: Add PK to hostcomponentdesiredstate Table To Support FK Relationships

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54743/ --- (Updated Dec. 15, 2016, 2:15 p.m.) Review request for Ambari, Attila

Re: Review Request 54698: Disable security hook

> On Dec. 14, 2016, 6:25 p.m., Alejandro Fernandez wrote: > > ambari-agent/pom.xml, line 57 > > > > > > Can this be moved to another project, say contrib? > > > > We're adding a dependency on ZK, so I would

Re: Review Request 54743: Add PK to hostcomponentdesiredstate Table To Support FK Relationships

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54743/#review159286 --- Ship it! Ship It! - Laszlo Puskas On Dec. 15, 2016, 8:55

Re: Review Request 54779: SMTP Username and SMTP Password are not highlighted

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54779/#review159285 --- Ship it! Ship It! - Andrii Tkach On Dec. 15, 2016, 12:37

Re: Review Request 54778: Separate general Log Search env properties from Log Search Portal properties

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54778/#review159284 --- Ship it! Ship It! Do not forget to copy every property value

Review Request 54779: SMTP Username and SMTP Password are not highlighted

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54779/ --- Review request for Ambari and Andrii Tkach. Bugs: ambari-19210

Review Request 54778: Separate general Log Search env properties from Log Search Portal properties

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54778/ --- Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.

Re: Review Request 54735: AMBARI-19149. Code cleanup: empty blocks

> On Dec. 15, 2016, 10:56 a.m., Nate Cole wrote: > > ambari-server/checkstyle.xml, lines 39-41 > > > > > > This check seems a bit restrictive, both in having to name the variable > > "ignored" and requiring some

Re: Review Request 54698: Disable security hook

> On Dec. 14, 2016, 6:25 p.m., Alejandro Fernandez wrote: > > ambari-agent/pom.xml, line 57 > > > > > > Can this be moved to another project, say contrib? > > > > We're adding a dependency on ZK, so I would

Re: Review Request 54777: Manage Journalnode Wizard: error on step3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54777/#review159282 --- Ship it! Ship It! - Andriy Babiichuk On Гру. 15, 2016,

Review Request 54777: Manage Journalnode Wizard: error on step3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54777/ --- Review request for Ambari and Andriy Babiichuk. Bugs: AMBARI-19208

Re: Review Request 54743: Add PK to hostcomponentdesiredstate Table To Support FK Relationships

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54743/#review159280 ---

Re: Review Request 54743: Add PK to hostcomponentdesiredstate Table To Support FK Relationships

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54743/#review159278 ---

Re: Review Request 54735: AMBARI-19149. Code cleanup: empty blocks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54735/#review159273 --- ambari-server/checkstyle.xml (lines 36 - 38)

Re: Review Request 54698: Disable security hook

> On Dec. 14, 2016, 6:25 p.m., Alejandro Fernandez wrote: > > ambari-agent/pom.xml, line 57 > > > > > > Can this be moved to another project, say contrib? > > > > We're adding a dependency on ZK, so I would

Re: Review Request 54743: Add PK to hostcomponentdesiredstate Table To Support FK Relationships

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54743/ --- (Updated Dec. 15, 2016, 9:55 a.m.) Review request for Ambari, Attila