Re: Review Request 58780: WFM: Clicking search icon in workflow dashboard throws error

2017-04-27 Thread Anita Jebaraj
> On April 28, 2017, 5:24 a.m., Padma Priya N wrote: > > Ship It! Thank you for reviewing, can you please help in pushing the changes - Anita --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 58780: WFM: Clicking search icon in workflow dashboard throws error

2017-04-27 Thread belliraj hb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58780/#review173293 --- Ship it! Ship It! - belliraj hb On April 27, 2017, 4:41

Re: Review Request 58797: AMBARI-20868 : Ranger admin start fails when Ambari Infra is turned off.

2017-04-27 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58797/#review173287 --- Ship it! Ship It! - Mugdha Varadkar On April 27, 2017, 3:51

Re: Review Request 58798: AMBARI-20873 : Atlas gc-worker logs are not generated due to incorrect configuration

2017-04-27 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58798/#review173286 --- Ship it! Ship It! - Mugdha Varadkar On April 27, 2017, 2:39

Re: Review Request 58411: AMBARI-20726: Aggregate alert does not show status properly at Maintenance Mode change

2017-04-27 Thread Qin Liu
> On April 27, 2017, 6:48 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertMaintenanceModeListener.java > > Line 136 (original), 158-162 (patched) > > >

Re: Review Request 58411: AMBARI-20726: Aggregate alert does not show status properly at Maintenance Mode change

2017-04-27 Thread Qin Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58411/ --- (Updated April 28, 2017, 2:42 a.m.) Review request for Ambari, Jonathan Hurley

Re: Review Request 58823: Trunk patch - Storm Log4J Regex Replacement on Upgrade Fails

2017-04-27 Thread Madhuvanthi Radhakrishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58823/ --- (Updated April 27, 2017, 11:14 p.m.) Review request for Ambari, Alejandro

Review Request 58823: Trunk patch - Storm Log4J Regex Replacement on Upgrade Fails

2017-04-27 Thread Madhuvanthi Radhakrishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58823/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya,

Re: Review Request 58802: Removing A Service Causes DB Verification To Produce Warnings

2017-04-27 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58802/#review173265 ---

Re: Review Request 58802: Removing A Service Causes DB Verification To Produce Warnings

2017-04-27 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58802/#review173264 --- Ship it! Ship It! - Alejandro Fernandez On April 27, 2017,

Review Request 58822: Add Log Level Filter to the Log Search config API

2017-04-27 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58822/ --- Review request for Ambari, Oliver Szabo and Robert Nettleton. Bugs:

Re: Review Request 58814: Ambari clean up for 3.0

2017-04-27 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58814/#review173263 --- Ship it! Ship It! - Alejandro Fernandez On April 27, 2017,

Re: Review Request 58815: Storm Log4J Regex Replacement on Upgrade Fails

2017-04-27 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58815/#review173262 --- Ship it! Ship It! - Alejandro Fernandez On April 27, 2017,

Re: Review Request 58815: Storm Log4J Regex Replacement on Upgrade Fails

2017-04-27 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58815/#review173256 --- Ship it! Ship It! - Jonathan Hurley On April 27, 2017, 4:36

Review Request 58815: Storm Log4J Regex Replacement on Upgrade Fails

2017-04-27 Thread Madhuvanthi Radhakrishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58815/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya,

Re: Review Request 58814: Ambari clean up for 3.0

2017-04-27 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58814/#review173250 --- Ship it! Ship It! - Robert Levas On April 27, 2017, 3:50

Review Request 58814: Ambari clean up for 3.0

2017-04-27 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58814/ --- Review request for Ambari, Robert Levas and Sumit Mohanty. Bugs: AMBARI-20879

Re: Review Request 58801: Unify repository file creation

2017-04-27 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58801/ --- (Updated April 27, 2017, 3:05 p.m.) Review request for Ambari, Dmitro

Re: Review Request 58801: Unify repository file creation

2017-04-27 Thread Nate Cole
> On April 27, 2017, 2:59 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java > > Lines 38-44 (patched) > > > > > > These are serialized to Python,

Re: Review Request 58801: Unify repository file creation

2017-04-27 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58801/#review173236 --- Ship it!

Re: Review Request 58802: Removing A Service Causes DB Verification To Produce Warnings

2017-04-27 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58802/#review173235 --- ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql

Re: Review Request 58411: AMBARI-20726: Aggregate alert does not show status properly at Maintenance Mode change

2017-04-27 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58411/#review173234 ---

Re: Review Request 58801: Unify repository file creation

2017-04-27 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58801/ --- (Updated April 27, 2017, 2:34 p.m.) Review request for Ambari, Dmitro

Re: Review Request 58802: Removing A Service Causes DB Verification To Produce Warnings

2017-04-27 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58802/#review173221 ---

Re: Review Request 58800: Changes to events format

2017-04-27 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58800/#review173220 --- Ship it! Ship It! - Sid Wagle On April 27, 2017, 2:54 p.m.,

Re: Review Request 58780: WFM: Clicking search icon in workflow dashboard throws error

2017-04-27 Thread Anita Jebaraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58780/ --- (Updated April 27, 2017, 4:41 p.m.) Review request for Ambari, belliraj hb, Di

Re: Review Request 58780: WFM: Clicking search icon in workflow dashboard throws error

2017-04-27 Thread Anita Jebaraj
> On April 27, 2017, 6:15 a.m., Padma Priya N wrote: > > contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js > > Lines 193 (patched) > > > > > > It is better to use Ember.isBlank()

Review Request 58802: Removing A Service Causes DB Verification To Produce Warnings

2017-04-27 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58802/ --- Review request for Ambari, Jonathan Hurley and Nate Cole. Bugs: AMBARI-20875

Re: Review Request 58801: Unify repository file creation

2017-04-27 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58801/#review173211 --- Fix it, then Ship it!

Re: Review Request 58411: AMBARI-20726: Aggregate alert does not show status properly at Maintenance Mode change

2017-04-27 Thread Qin Liu
> On April 26, 2017, 11:38 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertMaintenanceModeListener.java > > Line 107 (original), 124-126 (patched) > > >

Re: Review Request 58411: AMBARI-20726: Aggregate alert does not show status properly at Maintenance Mode change

2017-04-27 Thread Qin Liu
> On April 26, 2017, 5:59 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertMaintenanceModeListener.java > > Lines 170 (patched) > > > > > > Why

Re: Review Request 58797: AMBARI-20868 : Ranger admin start fails when Ambari Infra is turned off.

2017-04-27 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58797/ --- (Updated April 27, 2017, 3:51 p.m.) Review request for Ambari, Alejandro

Review Request 58801: Unify repository file creation

2017-04-27 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58801/ --- Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley. Bugs:

Review Request 58800: Changes to events format

2017-04-27 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58800/ --- Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid

Review Request 58798: AMBARI-20873 : Atlas gc-worker logs are not generated due to incorrect configuration

2017-04-27 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58798/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj,

Re: Review Request 58797: AMBARI-20868 : Ranger admin start fails when Ambari Infra is turned off.

2017-04-27 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58797/#review173196 ---

Review Request 58797: AMBARI-20868 : Ranger admin start fails when Ambari Infra is turned off.

2017-04-27 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58797/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Mugdha Varadkar,

Re: Review Request 58735: The default value for sun.security.krb5.debug property is set to false.

2017-04-27 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58735/ --- (Updated April 27, 2017, 1:36 p.m.) Review request for Ambari, Robert Levas

Re: Review Request 58735: The default value for sun.security.krb5.debug property is set to false.

2017-04-27 Thread Laszlo Puskas
> On April 26, 2017, 6:36 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/gateway-site.xml > > Line 61 (original), 61 (patched) > > > > > > Does this

Re: Review Request 58735: The default value for sun.security.krb5.debug property is set to false.

2017-04-27 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58735/ --- (Updated April 27, 2017, 1:15 p.m.) Review request for Ambari, Robert Levas

Re: Review Request 58575: Ambari Metrics Storm Sink compilation error due to storm-1.1.0-SNAPSHOT

2017-04-27 Thread Masahiro Tanaka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58575/#review173189 --- Could anyone review this? - Masahiro Tanaka On April 20, 2017,

Re: Review Request 58735: The default value for sun.security.krb5.debug property is set to fals.

2017-04-27 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58735/ --- (Updated April 27, 2017, 1:03 p.m.) Review request for Ambari, Robert Levas

Re: Review Request 58735: The default value for sun.security.krb5.debug property is set to fals.

2017-04-27 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58735/ --- (Updated April 27, 2017, 12:25 p.m.) Review request for Ambari, Robert Levas

Re: Review Request 58735: The default value for sun.security.krb5.debug property is set to fals.

2017-04-27 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58735/ --- (Updated April 27, 2017, 12:22 p.m.) Review request for Ambari, Robert Levas

Re: Review Request 58790: Create an ansynchronious status commands executor

2017-04-27 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58790/#review173185 --- Ship it! Ship It! - Myroslav Papirkovskyy On Квітень 27,

Re: Review Request 58785: AMBARI-20867.Cleanup Jsplumb specific code from WFM

2017-04-27 Thread belliraj hb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58785/#review173177 --- Ship it! Ship It! - belliraj hb On April 27, 2017, 9:24

Review Request 58785: AMBARI-20867.Cleanup Jsplumb specific code from WFM

2017-04-27 Thread Padma Priya N
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58785/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Pallav Kulshreshtha, and

Re: Review Request 58784: AMBARI-20866.Distcp should take a single command rather than list of arguments to make it easier ot use.

2017-04-27 Thread belliraj hb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58784/#review173173 --- Ship it! Ship It! - belliraj hb On April 27, 2017, 8:56

Re: Review Request 58784: AMBARI-20866.Distcp should take a single command rather than list of arguments to make it easier ot use.

2017-04-27 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58784/#review173172 --- Ship it! Ship It! - Gaurav Nagar On April 27, 2017, 8:56

Review Request 58784: AMBARI-20866.Distcp should take a single command rather than list of arguments to make it easier ot use.

2017-04-27 Thread Padma Priya N
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58784/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Pallav Kulshreshtha, and

Re: Review Request 58695: HIVE 2 -UX changes- Part1

2017-04-27 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58695/#review173167 --- Ship it! Ship It! - Nitiraj Rathore On April 27, 2017, 6:10

Re: Review Request 58618: First node in the visual explain chart is not clickable to view the json dump

2017-04-27 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58618/#review173163 --- Ship it! Ship It! - Gaurav Nagar On April 21, 2017, 1:36

Re: Review Request 58618: First node in the visual explain chart is not clickable to view the json dump

2017-04-27 Thread venkat sairam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58618/#review173162 --- Ship it! Ship It! - venkat sairam On April 21, 2017, 1:36

Re: Review Request 58695: HIVE 2 -UX changes- Part1

2017-04-27 Thread venkat sairam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58695/#review173161 --- Ship it! Ship It! - venkat sairam On April 27, 2017, 6:10

Re: Review Request 58780: WFM: Clicking search icon in workflow dashboard throws error

2017-04-27 Thread Padma Priya N
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58780/#review173160 ---

Re: Review Request 58744: Bulk action is not functional in workflow dashboard

2017-04-27 Thread Padma Priya N
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58744/#review173159 --- Ship it! Ship It! - Padma Priya N On April 26, 2017, 6:19

Re: Review Request 58497: AMBARI-20779 Create Ranger KMS HDFS audit folder as part of install

2017-04-27 Thread Mugdha Varadkar
> On April 26, 2017, 6:37 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py > > Lines 510 (patched) > > > > > > I think you still