Re: Review Request 60855: AMBARI-21463. Cross-stack upgrade, Oozie restart fails with ext-2.2.zip missing error, stack_tools.py is missing get_stack_name in __all__, disable BigInsights in UI

2017-07-13 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60855/#review180489 --- Ship it! Ship It! - Sid Wagle On July 13, 2017, 11:16 p.m.,

Review Request 60855: AMBARI-21463. Cross-stack upgrade, Oozie restart fails with ext-2.2.zip missing error, stack_tools.py is missing get_stack_name in __all__, disable BigInsights in UI

2017-07-13 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60855/ --- Review request for Ambari, Andrii Tkach, Dmytro Grinenko, Jonathan Hurley, and

Re: Review Request 60844: Support migration of LDAP users & groups to PAM

2017-07-13 Thread Robert Levas
> On July 13, 2017, 4:55 p.m., Tuong wrote: > > Juanjo and I combed thru the codes and did not see any red flag. We did > > not know the group creation codes was pushed into trunk a while back and > > got confused a bit ;)). Thanks for the review. Most of the code was taken from the IOP

Re: Review Request 60844: Support migration of LDAP users & groups to PAM

2017-07-13 Thread Robert Levas
> On July 13, 2017, 4:52 p.m., Juanjo Marron wrote: > > > > Juanjo Marron wrote: > Ship it! > > Juanjo Marron wrote: > Reviewd with Tuong Truong. > This is similar to the logic we were supporting in IOP for LDAP to PAM > migration. > > Thanks for working on it Thanks

Re: Review Request 60850: Create pre-requisite check for components missing from the target stack

2017-07-13 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60850/#review180476 --- Ship it! Ship It! - Alejandro Fernandez On July 13, 2017,

Re: Review Request 60844: Support migration of LDAP users & groups to PAM

2017-07-13 Thread Tuong via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60844/#review180474 --- Ship it! Juanjo and I combed thru the codes and did not see

Re: Review Request 60844: Support migration of LDAP users & groups to PAM

2017-07-13 Thread Juanjo Marron
> On July 13, 2017, 8:52 p.m., Juanjo Marron wrote: > > > > Juanjo Marron wrote: > Ship it! Reviewd with Tuong Truong. This is similar to the logic we were supporting in IOP for LDAP to PAM migration. Thanks for working on it - Juanjo

Re: Review Request 60844: Support migration of LDAP users & groups to PAM

2017-07-13 Thread Juanjo Marron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60844/#review180473 --- Ship it! Ship It! - Juanjo Marron On July 13, 2017, 4:03

Re: Review Request 60850: Create pre-requisite check for components missing from the target stack

2017-07-13 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60850/#review180472 --- Ship it! Ship It! - Sid Wagle On July 13, 2017, 8:27 p.m.,

Re: Review Request 60844: Support migration of LDAP users & groups to PAM

2017-07-13 Thread Juanjo Marron
> On July 13, 2017, 8:52 p.m., Juanjo Marron wrote: > > Ship it! - Juanjo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60844/#review180470

Re: Review Request 60844: Support migration of LDAP users & groups to PAM

2017-07-13 Thread Juanjo Marron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60844/#review180470 --- - Juanjo Marron On July 13, 2017, 4:03 p.m., Robert Levas

Re: Review Request 60849: AMBARI-21469. Stop Spark fails due to missing stack selector

2017-07-13 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60849/#review180467 --- Ship it! Ship It! - Jonathan Hurley On July 13, 2017, 3:48

Re: Review Request 60850: Create pre-requisite check for components missing from the target stack

2017-07-13 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60850/ --- (Updated July 13, 2017, 4:27 p.m.) Review request for Ambari, Alejandro

Re: Review Request 60850: Create pre-requisite check for components missing from the target stack

2017-07-13 Thread Jonathan Hurley
> On July 13, 2017, 4:10 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsExistInRepoCheck.java > > Lines 112 (patched) > > > > > > Can we generate a single

Re: Review Request 60849: AMBARI-21469. Stop Spark fails due to missing stack selector

2017-07-13 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60849/#review180459 --- Ship it! Ship It! - Alejandro Fernandez On July 13, 2017,

Re: Review Request 60850: Create pre-requisite check for components missing from the target stack

2017-07-13 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60850/#review180458 --- Fix it, then Ship it! Fix it and ship it.

Review Request 60850: Create pre-requisite check for components missing from the target stack

2017-07-13 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60850/ --- Review request for Ambari, Alejandro Fernandez, Nate Cole, and Sid Wagle.

Re: Review Request 60849: AMBARI-21469. Stop Spark fails due to missing stack selector

2017-07-13 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60849/#review180457 --- Ship it! Any unit test changes missed? - Sid Wagle On July

Review Request 60849: AMBARI-21469. Stop Spark fails due to missing stack selector

2017-07-13 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60849/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Sumit Mohanty,

Re: Review Request 60249: AMBARI-21234 Ambari rack awareness for Kafka

2017-07-13 Thread Ambud Sharma
> On July 12, 2017, 9:11 a.m., Sebastian Toader wrote: > > A few observations regarding the *trunk* patch: > > - HDP/2.6/services/KAFKA/metainfo.xml > > ```common-services/KAFKA/0.10.0```. This is not needed > > as HDP/2.6 already extends HDP/2.5 (see HDP/2.6/metainfo.xml) thus > >

Re: Review Request 60249: AMBARI-21234 Ambari rack awareness for Kafka

2017-07-13 Thread Ambud Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60249/ --- (Updated July 13, 2017, 5:15 p.m.) Review request for Ambari, Alejandro

Re: Review Request 60249: AMBARI-21234 Ambari rack awareness for Kafka

2017-07-13 Thread Ambud Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60249/ --- (Updated July 13, 2017, 5:14 p.m.) Review request for Ambari, Alejandro

Re: Review Request 60249: AMBARI-21234 Ambari rack awareness for Kafka

2017-07-13 Thread Ambud Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60249/ --- (Updated July 13, 2017, 5:14 p.m.) Review request for Ambari, Alejandro

Re: Review Request 60249: AMBARI-21234 Ambari rack awareness for Kafka

2017-07-13 Thread Ambud Sharma
> On July 5, 2017, 6:12 p.m., Sriharsha Chintalapani wrote: > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py > > Lines 121 (patched) > > > > > > This will add the broker.rack

Re: Review Request 60845: AMBARI-21468 Knox restart fails during EU due to wrong location to the Knox data directory

2017-07-13 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60845/#review180439 --- I have yet to find a better solution than the one I am proposing.

Review Request 60845: AMBARI-21468 Knox restart fails during EU due to wrong location to the Knox data directory

2017-07-13 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60845/ --- Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, Jonathan

Review Request 60844: Support migration of LDAP users & groups to PAM

2017-07-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60844/ --- Review request for Ambari, Attila Magyar, Anita Jebaraj, Balázs Bence Sári, Di

Re: Review Request 60838: AMBARI-21466. KNOX upgrade fails due to wrong stack root

2017-07-13 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60838/#review180433 --- Ship it! Ship It! - Sid Wagle On July 13, 2017, 11:02 a.m.,

Re: Review Request 60842: AMBARI-21460 : Add new kafka client properties to the ambari managed atlas config

2017-07-13 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60842/ --- (Updated July 13, 2017, 3:24 p.m.) Review request for Ambari, Alejandro

Review Request 60842: AMBARI-21460 : Add new kafka client properties to the ambari managed atlas config

2017-07-13 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60842/ --- Review request for Ambari, Alejandro Fernandez, Ayub Pathan, Gautam Borad,

Re: Review Request 60774: Ambari updates memory settings in blueprint incorrectly

2017-07-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60774/#review180431 --- Fix it, then Ship it! Ship It!

Re: Review Request 60814: AMBARI-21461 Spark thrift server restart fails during migration EU

2017-07-13 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60814/#review180426 --- Ship it! Ship It! - Tim Thorpe On July 12, 2017, 9 p.m., Di

Re: Review Request 60814: AMBARI-21461 Spark thrift server restart fails during migration EU

2017-07-13 Thread Di Li
> On July 12, 2017, 9:59 p.m., Alejandro Fernandez wrote: > > All I am doing is to rename the file in BI 4.0 and 4.2 stack to make it the same name as common services and BI 4.2.5. This is a quick fix for EU error. I am not reimplementing the script as that's not what this JIRA is about. The

Re: Review Request 60838: AMBARI-21466. KNOX upgrade fails due to wrong stack root

2017-07-13 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60838/#review180422 --- Ship it! Ship It! - Jonathan Hurley On July 13, 2017, 7:02

Re: Review Request 60707: BE: Extend Ambari REST API to Support User Account Management Improvements

2017-07-13 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60707/#review180421 --- Ship it! Ship It! - Jonathan Hurley On July 12, 2017, 5:56

Re: Review Request 60707: BE: Extend Ambari REST API to Support User Account Management Improvements

2017-07-13 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60707/#review180419 ---

Review Request 60838: AMBARI-21466. KNOX upgrade fails due to wrong stack root

2017-07-13 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60838/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Sumit Mohanty,

Re: Review Request 60813: Add lucene index migration script to infra solr client package

2017-07-13 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60813/ --- (Updated July 13, 2017, 10:26 a.m.) Review request for Ambari, Miklos Gergely,

Re: Review Request 60813: Add lucene index migration script to infra solr client package

2017-07-13 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60813/ --- (Updated July 13, 2017, 10:22 a.m.) Review request for Ambari, Miklos Gergely,

Re: Review Request 60813: Add lucene index migration script to infra solr client package

2017-07-13 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60813/ --- (Updated July 13, 2017, 10:15 a.m.) Review request for Ambari, Miklos Gergely,

Re: Review Request 60813: Add lucene index migration script to infra solr client package

2017-07-13 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60813/#review180412 --- Fix it, then Ship it! Ship It!