/java/org/apache/ambari/infra/job/archive/DocumentExportProperties.java
Lines 35 (patched)
<https://reviews.apache.org/r/64976/#comment274013>
mostly in ambari code, we are not using * in imports (convention)
- Oliver Szabo
On Jan. 5, 2018, 2:43 p.m., Krisztian Kasa
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64852/#review194580
---
Ship it!
Ship It!
- Oliver Szabo
On Dec. 28, 2017, 2:09 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64850/#review194527
---
Ship it!
Ship It!
- Oliver Szabo
On Dec. 27, 2017, 8:10 a.m
start from IDE as well.
- tried out logfeeder/logsearch script options (start/stop/status/help/test)
Thanks,
Oliver Szabo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64607/#review193910
---
Ship it!
Shipt It!
- Oliver Szabo
On Dec. 15, 2017, 8:57
-
>
> (Updated Dec. 14, 2017, 12:58 p.m.)
>
>
> Review request for Ambari, Miklos Gergely, Oliver Szabo, and Sid Wagle.
>
>
> Bugs: AMBARI-22514 and AMBARI-22653
> https://issues.apache.org/jira/browse/AMBARI-22514
> https://issues.a
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64553/#review193736
-------
On Dec. 13, 2017, 3:24 p.m., Oliver Szabo wrote:
>
> -
much more
(or i will get rid of this), but now i just moved the class (but review board
show as a newly added one)
- Oliver
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64553/#review193647
f: https://reviews.apache.org/r/64553/diff/4/
Changes: https://reviews.apache.org/r/64553/diff/3-4/
Testing
---
unit tests done. Check behavior from IDE + docker-compose env
Thanks,
Oliver Szabo
f: https://reviews.apache.org/r/64553/diff/3/
Changes: https://reviews.apache.org/r/64553/diff/2-3/
Testing
---
unit tests done. Check behavior from IDE + docker-compose env
Thanks,
Oliver Szabo
ogfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputSolrTest.java
5ab271a
Diff: https://reviews.apache.org/r/64553/diff/2/
Changes: https://reviews.apache.org/r/64553/diff/1-2/
Testing
---
unit tests done. Check behavior from IDE + docker-compose env
Thanks,
Oliver Szabo
7c6aca2
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputSolrTest.java
5ab271a
Diff: https://reviews.apache.org/r/64553/diff/1/
Testing
---
unit tests done. Check behavior from IDE + docker-compose env
Thanks,
Oliver Szabo
/2-3/
Testing
---
not yet.
Thanks,
Oliver Szabo
/64513/diff/1-2/
Testing
---
not yet.
Thanks,
Oliver Szabo
the mapper types as well.
But that wont hurt so +1
- Oliver Szabo
On Dec. 12, 2017, 9:39 a.m., Jungtaek Lim wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
-
ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-logsearch-conf.xml
d485017
Diff: https://reviews.apache.org/r/64513/diff/1/
Testing
---
not yet.
Thanks,
Oliver Szabo
/
Testing
---
done.
Thanks,
Oliver Szabo
eviews.apache.org/r/64349/#review192930
-------
On Dec. 5, 2017, 8:50 p.m., Oliver Szabo wrote:
>
> ---
> This is an automatically generated e-mail. To re
-5/6700/worker.log
e69de29
Diff: https://reviews.apache.org/r/64349/diff/1/
Testing
---
done, i need to write some unit tests for the filter cloning.
Thanks,
Oliver Szabo
/streamline-1-TestAgg-2-3/6701/worker.log
6a10ad9
ambari-logsearch/docker/test-logs/storm/worker-logs/streamline-2-TestAgg2-4-5/6700/worker.log
e69de29
Diff: https://reviews.apache.org/r/64349/diff/1/
Testing
---
done, i need to write some unit tests for the filter cloning.
Thanks,
Oliver
5a1edee
Diff: https://reviews.apache.org/r/64206/diff/1/
Testing
---
not required
Thanks,
Oliver Szabo
-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchAuthenticationEntryPoint.java
2fe5f7b
Diff: https://reviews.apache.org/r/64156/diff/1/
Testing
---
done
Thanks,
Oliver Szabo
1-2/
Testing
---
done
Thanks,
Oliver Szabo
ari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterKeyValue.java
b04a439
Diff: https://reviews.apache.org/r/64091/diff/1/
Testing
---
done
Thanks,
Oliver Szabo
/ambari/logsearch/solr/model/SolrServiceLogData.java
c6fdba3
Diff: https://reviews.apache.org/r/64083/diff/4/
Testing
---
done.
Thanks,
Oliver Szabo
-logsearch-server/src/main/java/org/apache/ambari/logsearch/solr/model/SolrServiceLogData.java
c6fdba3
Diff: https://reviews.apache.org/r/64083/diff/4/
Changes: https://reviews.apache.org/r/64083/diff/3-4/
Testing
---
done.
Thanks,
Oliver Szabo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64059/#review191897
---
Ship it!
Ship It!
- Oliver Szabo
On Nov. 27, 2017, 3:39 p.m
/apache/ambari/logsearch/solr/model/SolrServiceLogData.java
c6fdba3
Diff: https://reviews.apache.org/r/64083/diff/3/
Changes: https://reviews.apache.org/r/64083/diff/2-3/
Testing
---
done.
Thanks,
Oliver Szabo
/diff/1-2/
Testing
---
done.
Thanks,
Oliver Szabo
/64083/diff/1/
Testing
---
done.
Thanks,
Oliver Szabo
you reached the limit of the log
file size for long running and it started to rotate? also it is too specific so
it can be * * / * . log - * (i just use spaces to the editor not format it)
- Oliver Szabo
On Nov. 24, 2017, 9:31 a.m., Krisztia
/diff/1/
Testing
---
not required.
Thanks,
Oliver Szabo
/MetricsManagerTest.java
24042a7
Diff: https://reviews.apache.org/r/63803/diff/1/
Testing
---
done
Thanks,
Oliver Szabo
/diff/2-3/
Testing
---
done, manually, added new input file for docker env.
Thanks,
Oliver Szabo
/diff/1-2/
Testing
---
done, manually, added new input file for docker env.
Thanks,
Oliver Szabo
rch/docker/test-logs/storm/worker-logs/streamline-1-TestAgg-2-3/6701/worker.log
PRE-CREATION
Diff: https://reviews.apache.org/r/63793/diff/1/
Testing
---
done, manually, added new input file for docker env.
Thanks,
Oliver Szabo
easymock, checkstyle,
utility,junit jars
Thanks,
Oliver Szabo
/2/
Changes: https://reviews.apache.org/r/63696/diff/1-2/
Testing
---
UT done, target/libs folder does not contain easymock, checkstyle,
utility,junit jars
Thanks,
Oliver Szabo
,
utility,junit jars
Thanks,
Oliver Szabo
74ea0ef
Diff: https://reviews.apache.org/r/63617/diff/1/
Testing
---
done with docker-compose commands
Thanks,
Oliver Szabo
/main/resources/logsearch.properties
db8a0a2
Diff: https://reviews.apache.org/r/63525/diff/2/
Changes: https://reviews.apache.org/r/63525/diff/1-2/
Testing
---
done, check with 'mvn clean spring-boot:run' and with IntelliJ as well.
Thanks,
Oliver Szabo
/r/63525/diff/1/
Testing
---
done, check with 'mvn clean spring-boot:run' and with IntelliJ as well.
Thanks,
Oliver Szabo
-22331
https://issues.apache.org/jira/browse/AMBARI-22331
Repository: ambari
Description
---
Update README.md of Log Search
Diffs
-
ambari-logsearch/README.md d05f45a
Diff: https://reviews.apache.org/r/63429/diff/1/
Testing
---
not required
Thanks,
Oliver Szabo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63416/#review189600
---
Ship it!
Ship It!
- Oliver Szabo
On Oct. 30, 2017, 3:47 p.m
org/r/63393/diff/3/
Changes: https://reviews.apache.org/r/63393/diff/2-3/
Testing
---
done with docker-compose commands
Thanks,
Oliver Szabo
: https://reviews.apache.org/r/63393/diff/1-2/
Testing
---
done with docker-compose commands
Thanks,
Oliver Szabo
olr.yml 727aba1
ambari-logsearch/docker/solr662.yml b0641ed
Diff: https://reviews.apache.org/r/63393/diff/1/
Testing
---
done with docker-compose commands
Thanks,
Oliver Szabo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63362/#review189500
---
Ship it!
Ship It!
- Oliver Szabo
On Oct. 27, 2017, 4:28 p.m
://reviews.apache.org/r/63360/diff/1-2/
Testing
---
done with docker-compose up -d
Thanks,
Oliver Szabo
-logsearch/docker/solr.yml PRE-CREATION
ambari-logsearch/docker/solr662.yml PRE-CREATION
ambari-logsearch/docker/zookeeper.yml PRE-CREATION
Diff: https://reviews.apache.org/r/63360/diff/1/
Testing
---
done with docker-compose up -d
Thanks,
Oliver Szabo
---
done, with "docker-compose -f docker-compose-zookeeper.yml up -d"
Thanks,
Oliver Szabo
-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/GetShardsCommand.java
e49bfec
Diff: https://reviews.apache.org/r/63323/diff/1/
Testing
---
done.
Thanks,
Oliver Szabo
e49bfec
Diff: https://reviews.apache.org/r/63323/diff/1/
Testing
---
done.
Thanks,
Oliver Szabo
/Dockerfile 1e4135e
ambari-logsearch/pom.xml 9434365
Diff: https://reviews.apache.org/r/63298/diff/1/
Testing
---
done.
Thanks,
Oliver Szabo
Testing
---
UTs done
Thanks,
Oliver Szabo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63196/#review188895
---
Ship it!
Ship It!
- Oliver Szabo
On Oct. 21, 2017, 12:58
/6/
Changes: https://reviews.apache.org/r/63027/diff/5-6/
Testing
---
done, no UTs here, FTs are in progress
Thanks,
Oliver Szabo
done, UTs passes, FT: install Solr with these setting, also check what happens
if we adding the new xml parser.
Thanks,
Oliver Szabo
rg/r/63162/diff/1/
Testing
---
done, UTs passes, FT: install Solr with these setting, also check what happens
if we adding the new xml parser.
Thanks,
Oliver Szabo
proxies there should be
some ui changes as well)
Thanks,
Oliver Szabo
/diff/5/
Changes: https://reviews.apache.org/r/63027/diff/4-5/
Testing
---
done, no UTs here, FTs are in progress
Thanks,
Oliver Szabo
Thanks,
Oliver Szabo
progress
Thanks,
Oliver Szabo
, no UTs here, FTs are in progress
Thanks,
Oliver Szabo
/logsearch-docker.sh a2df90f
Diff: https://reviews.apache.org/r/63027/diff/1/
Testing
---
done, no UTs here, FTs are in progress
Thanks,
Oliver Szabo
> On Oct. 7, 2017, noon, Oliver Szabo wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
> > Lines 2783 (patched)
> > <https://reviews.apache.org/r/62809/diff/1/?file=1847507#file1847507line278
ion from me.
- Oliver Szabo
On Oct. 6, 2017, 3:35 p.m., Attila Doroszlai wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62805/#review187319
---
Ship it!
Ship It!
- Oliver Szabo
On Oct. 6, 2017, 8:39 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62723/#review186862
---
Ship it!
Ship It!
- Oliver Szabo
On Oct. 2, 2017, 6:12 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62666/#review186566
---
Ship it!
Ship It!
- Oliver Szabo
On Sept. 28, 2017, 3:13
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62618/#review186412
---
Ship it!
Ship It!
- Oliver Szabo
On Sept. 27, 2017, 2:33
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62576/#review186389
---
Ship it!
Shipt It!
- Oliver Szabo
On Sept. 26, 2017, 3:05
xes of the
configuration.
Diffs
-
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/InfraManager.java
185e344
Diff: https://reviews.apache.org/r/62584/diff/1/
Testing
---
manually, db file created properly
Thanks,
Oliver Szabo
/main/resources/infraManager.sh 65287b2
ambari-infra/ambari-infra-solr-client/src/main/resources/solrIndexHelper.sh
1d219d6
Diff: https://reviews.apache.org/r/62570/diff/1/
Testing
---
done manually.
Thanks,
Oliver Szabo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62562/#review186228
---
Ship it!
Ship It!
- Oliver Szabo
On Sept. 26, 2017, 10:17
/
Testing
---
done. with maven failsafe plugin and enabling xquartz
Thanks,
Oliver Szabo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62542/#review186111
---
Ship it!
Ship It!
- Oliver Szabo
On Sept. 25, 2017, 12:47
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62543/#review186110
---
Ship it!
Ship It!
- Oliver Szabo
On Sept. 25, 2017, 12:52
Diff: https://reviews.apache.org/r/62530/diff/1/
Testing
---
done manually.
Thanks,
Oliver Szabo
ain/resources/common-services/AMBARI_INFRA/0.1.0/properties/solr-client-log4j.properties.j2
0d0adc3
Diff: https://reviews.apache.org/r/62526/diff/1/
Testing
---
tested manually.
Thanks,
Oliver Szabo
-logsearch/ambari-logsearch-web/pom.xml 7a6b02e
Diff: https://reviews.apache.org/r/62460/diff/1/
Testing
---
unit tests run and passed, skipped if i addeed -DskipTests
Thanks,
Oliver Szabo
-env.sh.j2
5cc344e
ambari-web/app/data/configs/services/ambari_infra_properties.js aae7fa5
Diff: https://reviews.apache.org/r/62456/diff/1/
Testing
---
tested manually on 3 node cluster
Thanks,
Oliver Szabo
/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java
5ba0ac0
Diff: https://reviews.apache.org/r/62369/diff/1/
Testing
---
done, manually
Thanks,
Oliver Szabo
---
done. (updated unit tests)
Thanks,
Oliver Szabo
-> you cannot set that value easily on the UI with the smart configs)
Diffs
-
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-env.xml
27f001e
Diff: https://reviews.apache.org/r/62367/diff/1/
Testing
---
not required.
Thanks,
Oli
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62356/#review185482
---
Ship it!
Ship It!
- Oliver Szabo
On Sept. 15, 2017, 1:27
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61898/#review185274
---
Ship it!
Ship It!
- Oliver Szabo
On Sept. 12, 2017, 3:30
/solrDataManager.py
Lines 68 (patched)
<https://reviews.apache.org/r/61898/#comment261085>
this could be --line-delimited (by default would be the one json per line)
- Oliver Szabo
On Sept. 7, 2017, 8:33 p.m., Miklos Gergely
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62083/#review184568
---
Ship it!
Ship It!
- Oliver Szabo
On Sept. 5, 2017, 3:52 p.m
-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
0048020
Diff: https://reviews.apache.org/r/62034/diff/4/
Changes: https://reviews.apache.org/r/62034/diff/3-4/
Testing
---
done.
Thanks,
Oliver Szabo
-docker.sh 9d73eae
Diff: https://reviews.apache.org/r/62034/diff/3/
Changes: https://reviews.apache.org/r/62034/diff/2-3/
Testing
---
done.
Thanks,
Oliver Szabo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62034/
---
(Updated Sept. 1, 2017, 2:56 p.m.)
Review request for Ambari, Andrii Babiichuk,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62034/
---
Review request for Ambari, Andrii Babiichuk, Miklos Gergely, and Robert
Nettleto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62015/#review184272
---
Ship it!
Ship It!
- Oliver Szabo
On Aug. 31, 2017, 1:59 p.m
as well), but
on atlas side, external kerberos is not really handled, so maybe we can keep
this open as it can cause complications on secured environment, I would say
focus on the ranger change and keep this one open.
- Oliver Szabo
On Aug. 30, 2017, 4:04 p.m., Miklos Gergely wrote
b4902a3
ambari-logsearch/ambari-logsearch-web-new/pom.xml PRE-CREATION
Diff: https://reviews.apache.org/r/61996/diff/1/
Testing
---
done, manually, generated jar contains "dist/" folder. anyway, no mvn clean
test support yet.
Thanks,
Oliver Szabo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61971/#review184073
---
Ship it!
Ship It!
- Oliver Szabo
On Aug. 29, 2017, 4:29 p.m
know the .editorconfig file is required for us or
not)
Diffs
-
ambari-logsearch/pom.xml 2be11ee
Diff: https://reviews.apache.org/r/61937/diff/2/
Testing
---
ran mvn clean package successfully
Thanks,
Oliver Szabo
.editorconfig file is required for us or
not)
Diffs (updated)
-
ambari-logsearch/pom.xml 2be11ee
Diff: https://reviews.apache.org/r/61937/diff/2/
Changes: https://reviews.apache.org/r/61937/diff/1-2/
Testing
---
ran mvn clean package successfully
Thanks,
Oliver Szabo
/ambari-logsearch-web-new/README.md 2fb07fb
ambari-logsearch/pom.xml 2be11ee
Diff: https://reviews.apache.org/r/61937/diff/1/
Testing
---
ran mvn clean package successfully
Thanks,
Oliver Szabo
1 - 100 of 834 matches
Mail list logo
