Re: Review Request 56379: AMBARI-19418: Support setup queue priority in Ambari - Capacity scheduler view

2017-02-10 Thread Sreenath Somarajapuram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56379/#review165086 --- Ship it! Ship It! - Sreenath Somarajapuram On Feb. 10, 2017

Re: Review Request 55555: Ambari Yarn Queue Manager allows two same queue name

2017-01-17 Thread Sreenath Somarajapuram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review161841 --- Ship it! Ship It! - Sreenath Somarajapuram On Jan. 16, 2017

Re: Review Request 52688: Capacity Scheduler View: Calculating absolute capacity for node labels and showing in sunburst chart

2016-10-24 Thread Sreenath Somarajapuram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52688/#review153680 --- Ship it! Ship It! - Sreenath Somarajapuram On Oct. 19, 2016

Re: Review Request 52688: Capacity Scheduler View: Calculating absolute capacity for node labels and showing in sunburst chart

2016-10-12 Thread Sreenath Somarajapuram
src/main/resources/ui/app/controllers/queuesconf.js (line 252) <https://reviews.apache.org/r/52688/#comment221260> Is this conditional operator required? - Sreenath Somarajapuram On Oct. 10, 2016, 12

Re: Review Request 51647: AMBARI-18313: Capacity Scheduler View: Xml diff view tool to show changes made and queue capacity chart

2016-09-29 Thread Sreenath Somarajapuram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51647/#review150829 --- Ship it! Ship It! - Sreenath Somarajapuram On Sept. 28

Re: Review Request 51647: AMBARI-18313: Capacity Scheduler View: Xml diff view tool to show changes made and queue capacity chart

2016-09-28 Thread Sreenath Somarajapuram
> On Sept. 23, 2016, 10:19 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/bower.json, line 16 > > <https://reviews.apache.org/r/51647/diff/1/?file=1491590#file1491590line16> > > > > Package versiosn m

Re: Review Request 51647: AMBARI-18313: Capacity Scheduler View: Xml diff view tool to show changes made and queue capacity chart

2016-09-23 Thread Sreenath Somarajapuram
<https://reviews.apache.org/r/51647/#comment218038> PLease check where this action is called from. contrib/views/capacity-scheduler/src/main/resources/ui/bower.json (line 16) <https://reviews.apache.org/r/51647/#comment218031> Package versiosn must be fixed. - Sreenath Somar

Re: Review Request 51647: AMBARI-18313: Capacity Scheduler View: Xml diff view tool to show changes made and queue capacity chart

2016-09-23 Thread Sreenath Somarajapuram
emerick/jsdifflib.git#ce74529f9d51943db440dbd7c15d515597cda2e1; - Sreenath Somarajapuram On Sept. 6, 2016, 9:26 a.m., Akhil PB wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Re: Review Request 51452: AMBARI-18261: CapSched View: Showing warning icons to refresh or restart capsched once after configs are saved

2016-09-01 Thread Sreenath Somarajapuram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51452/#review147561 --- Ship it! Ship It! - Sreenath Somarajapuram On Sept. 1, 2016

Re: Review Request 51452: AMBARI-18261: CapSched View: Showing warning icons to refresh or restart capsched once after configs are saved

2016-08-31 Thread Sreenath Somarajapuram
ent214581> Guess it might be better to put all finds into a promise array. - Sreenath Somarajapuram On Aug. 26, 2016, 7:09 a.m., Akhil PB wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 49755: AMBARI-17602: Capacity Scheduler View - Fetching current RM configuration of queues and preemption implementation

2016-08-24 Thread Sreenath Somarajapuram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49755/#review146662 --- Ship it! Ship It! - Sreenath Somarajapuram On Aug. 23, 2016

Re: Review Request 51169: AMBARI-18178: yarn capacity scheduler queue issue

2016-08-17 Thread Sreenath Somarajapuram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51169/#review145969 --- Ship it! Ship It! - Sreenath Somarajapuram On Aug. 17, 2016

Re: Review Request 50070: Capacity Scheduler View - Fix for nodelabel api compatibility issue in HDP-2.5

2016-07-15 Thread Sreenath Somarajapuram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50070/#review142361 --- Ship it! Ship It! - Sreenath Somarajapuram On July 15, 2016

Re: Review Request 49755: Capacity Scheduler View - Fetching current RM configuration of queues and preemption implementation

2016-07-11 Thread Sreenath Somarajapuram
ent207038> Commented code. contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js (line 36) <https://reviews.apache.org/r/49755/#comment207036> Commented code. - Sreenath Somarajapuram On July 7, 2016, 1:10 p.

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-07-04 Thread Sreenath Somarajapuram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48487/#review140616 --- Ship it! Ship It! - Sreenath Somarajapuram On June 27, 2016

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-29 Thread Sreenath Somarajapuram
> On June 22, 2016, 10:12 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs, > > line 26 > > <https://reviews.apache.org/r/48487/diff/1/?file=1412307#file1412307line26> > > > &g

Re: Review Request 48686: Tez View: Improve proxy logging

2016-06-23 Thread Sreenath Somarajapuram
--- Manual testing. Verified the presence of debug and error logs in /var/log/ambari-server/tez-view/tez-view.log Thanks, Sreenath Somarajapuram

Re: Review Request 48686: Tez View: Improve proxy logging

2016-06-23 Thread Sreenath Somarajapuram
the presence of debug and error logs in /var/log/ambari-server/tez-view/tez-view.log Thanks, Sreenath Somarajapuram

Re: Review Request 48686: Tez View: Improve proxy logging

2016-06-23 Thread Sreenath Somarajapuram
in /var/log/ambari-server/tez-view/tez-view.log Thanks, Sreenath Somarajapuram

Re: Review Request 48686: Tez View: Improve proxy logging

2016-06-23 Thread Sreenath Somarajapuram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48686/#review139293 ------- On June 23, 2016, 8:04 p.m., Sreenath Somarajapuram wrote: > >

Re: Review Request 48686: Tez View: Improve proxy logging

2016-06-23 Thread Sreenath Somarajapuram
iff: https://reviews.apache.org/r/48686/diff/ Testing --- Manual testing. Verified the presence of debug and error logs in /var/log/ambari-server/tez-view/tez-view.log Thanks, Sreenath Somarajapuram

Re: Review Request 49141: Capacity Scheduler View: Javascript error causing new queue creation failed in Yarn Capacity Scheduler

2016-06-23 Thread Sreenath Somarajapuram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49141/#review139227 --- Ship it! Ship It! - Sreenath Somarajapuram On June 23, 2016

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-22 Thread Sreenath Somarajapuram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48487/#review139051 --- - Sreenath Somarajapuram On June 9, 2016, 12:05 p.m., Akhil PB

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-22 Thread Sreenath Somarajapuram
> On June 22, 2016, 10:12 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs, > > line 26 > > <https://reviews.apache.org/r/48487/diff/1/?file=1412307#file1412307line26> > > > &g

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-22 Thread Sreenath Somarajapuram
store passed? - Sreenath Somarajapuram On June 9, 2016, 12:05 p.m., Akhil PB wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-22 Thread Sreenath Somarajapuram
212> Where is the versions-table-wrap class defined? Wouldnt it cause the views/queues.js code to break? - Sreenath Somarajapuram On June 9, 2016, 12:05 p.m., Akhil PB wrote: > > --- > This is an automatically generated e-mai

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-22 Thread Sreenath Somarajapuram
> On June 22, 2016, 8:50 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js, > > line 164 > > <https://reviews.apache.org/r/48487/diff/1/?file=1412286#file1412286line164> > > > > Why ar

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-22 Thread Sreenath Somarajapuram
/serializers.js (line 164) <https://reviews.apache.org/r/48487/#comment204205> Why are we having the + after ? - Sreenath Somarajapuram On June 9, 2016, 12:05 p.m., Akhil PB wrote: > > --- > This is an automatically g

Re: Review Request 48686: Tez View: Improve proxy logging

2016-06-20 Thread Sreenath Somarajapuram
/apache/ambari/view/tez/rest/BaseRedirectionResource.java 97ee01d Diff: https://reviews.apache.org/r/48686/diff/ Testing --- Manual testing. Verified the presence of debug and error logs in /var/log/ambari-server/tez-view/tez-view.log Thanks, Sreenath Somarajapuram

Review Request 48686: Tez View: Improve proxy logging

2016-06-14 Thread Sreenath Somarajapuram
Diff: https://reviews.apache.org/r/48686/diff/ Testing --- Manual testing. Verified the presence of debug and error logs in /var/log/ambari-server/tez-view/tez-view.log Thanks, Sreenath Somarajapuram

Review Request 48582: Tez View: Load public host names

2016-06-11 Thread Sreenath Somarajapuram
/r/48582/diff/ Testing --- Manually tested Thanks, Sreenath Somarajapuram

Re: Review Request 48398: Capacity scheduler view - problem with queue percent rounding

2016-06-10 Thread Sreenath Somarajapuram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48398/#review136986 --- Ship it! Ship It! - Sreenath Somarajapuram On June 10, 2016

Re: Review Request 47643: Capacity Scheduler View - Edit and validate queue name

2016-05-23 Thread Sreenath Somarajapuram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47643/#review134326 --- Ship it! Ship It! - Sreenath Somarajapuram On May 23, 2016

Re: Review Request 47643: Capacity Scheduler View - Edit and validate queue name

2016-05-20 Thread Sreenath Somarajapuram
/templates/capsched/queuesconf/editqueue.hbs (line 50) <https://reviews.apache.org/r/47643/#comment198832> This need to be corrected. - Sreenath Somarajapuram On May 20, 2016, 9:57 a.m., Akhil PB wrote: > > --- > This is a

Review Request 47097: Tez View : Update namespace to use version info

2016-05-08 Thread Sreenath Somarajapuram
-view.js 4b7d94d Diff: https://reviews.apache.org/r/47097/diff/ Testing --- Thanks, Sreenath Somarajapuram

Re: Review Request 46770: Capacity Scheduler View: New UI - queues save integration

2016-05-05 Thread Sreenath Somarajapuram
ent195837> Can we get this removed? - Sreenath Somarajapuram On April 28, 2016, 11:43 a.m., Akhil PB wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 44704: CapSched View: Revamping the old UI

2016-04-27 Thread Sreenath Somarajapuram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44704/#review130753 --- Ship it! Ship It! - Sreenath Somarajapuram On April 27

Re: Review Request 44704: CapSched View: Revamping the old UI

2016-04-27 Thread Sreenath Somarajapuram
/controllers/queuesconf.js (line 138) <https://reviews.apache.org/r/44704/#comment194613> Where is operation defined? - Sreenath Somarajapuram On April 26, 2016, 10:43 a.m., Akhil PB wrote: > > --- > This is an automatica

Review Request 46652: Tez View : Equip the tez view shim to work with both version 1 & 2 of Tez UI

2016-04-25 Thread Sreenath Somarajapuram
against Tez UI 1 & 2. Thanks, Sreenath Somarajapuram

Re: Review Request 44704: CapSched View: Revamping the old UI

2016-04-04 Thread Sreenath Somarajapuram
/controllers/queuesconf.js (line 76) <https://reviews.apache.org/r/44704/#comment189899> Commented code. - Sreenath Somarajapuram On March 11, 2016, 10:41 a.m., Akhil PB wrote: > > --- > This is an automatically generated e

Re: Review Request 44704: CapSched View: Revamping the old UI

2016-04-04 Thread Sreenath Somarajapuram
views/editqueue.js (line 28) <https://reviews.apache.org/r/44704/#comment189893> Better to off these listeners on willDestroy. - Sreenath Somarajapuram On March 11, 2016, 10:41 a.m., Akhil PB wrote: > > --- > This is

Re: Review Request 44704: CapSched View: Revamping the old UI

2016-04-04 Thread Sreenath Somarajapuram
ib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs (line 28) <https://reviews.apache.org/r/44704/#comment189888> Whay are we having an anchor tags inside link-to? And what is the purpose fo href="view.href". - Sreenath Somarajap