Review Request 59941: Upgrade PreUpgradeCheck NullPointerException

2017-06-08 Thread wang yaoxin
/server/state/stack/UpgradePack.java b8e57c7 Diff: https://reviews.apache.org/r/59941/diff/1/ Testing --- Done! Thanks, wang yaoxin

Review Request 57415: description incorrect for result class

2017-03-08 Thread wang yaoxin
iffs - ambari-server/src/main/java/org/apache/ambari/server/api/services/Result.java 8355dcf Diff: https://reviews.apache.org/r/57415/diff/1/ Testing --- done! Thanks, wang yaoxin

Re: Review Request 57326: storm DRPC_SERVER kerberos configs duplicate

2017-03-06 Thread wang yaoxin
gt; Are these _new_ properties used anywhere? > > wang yaoxin wrote: > These new properties are not used . These new properties are not being used elsewhere - wang --- This is an automatically generated e-mail. To

Re: Review Request 57326: storm DRPC_SERVER kerberos configs duplicate

2017-03-06 Thread wang yaoxin
--- On 三月 7, 2017, 2:59 a.m., wang yaoxin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57326/ >

Re: Review Request 57326: storm DRPC_SERVER kerberos configs duplicate

2017-03-06 Thread wang yaoxin
://reviews.apache.org/r/57326/diff/1-2/ Testing --- done? File Attachments storm.png https://reviews.apache.org/media/uploaded/files/2017/03/06/35c14040-f918-4f46-83e8-be51a01d5d53__storm.png Thanks, wang yaoxin

Review Request 57326: storm DRPC_SERVER kerberos configs duplicate

2017-03-05 Thread wang yaoxin
://reviews.apache.org/r/57326/diff/1/ Testing --- done? File Attachments storm.png https://reviews.apache.org/media/uploaded/files/2017/03/06/35c14040-f918-4f46-83e8-be51a01d5d53__storm.png Thanks, wang yaoxin

Re: Review Request 53943: Improve remoteIp in audit log

2016-12-01 Thread wang yaoxin
nerated e-mail. To reply, visit: https://reviews.apache.org/r/53943/#review157255 ------- On 十一月 29, 2016, 12:16 p.m., wang yaoxin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apach

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-29 Thread wang yaoxin
space before `;` Thanks Attila, I have modified my code - wang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/#review157224 --- O

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-29 Thread wang yaoxin
/apache/ambari/server/utils/RequestUtilsTest.java 595127e Diff: https://reviews.apache.org/r/53943/diff/ Testing --- RequestUtilsTest All Tests Passsed ,Process finished with exit code 0 Thanks, wang yaoxin

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-28 Thread wang yaoxin
omatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/#review157051 --- On 十一月 29, 2016, 12:57 a.m., wang yaoxin wrote: > > --- > This is

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-28 Thread wang yaoxin
sit: https://reviews.apache.org/r/53943/#review157029 --- On 十一月 29, 2016, 12:57 a.m., wang yaoxin wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-28 Thread wang yaoxin
595127e Diff: https://reviews.apache.org/r/53943/diff/ Testing (updated) --- RequestUtilsTest All Tests Passsed ,Process finished with exit code 0 Thanks, wang yaoxin

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-28 Thread wang yaoxin
/java/org/apache/ambari/server/utils/RequestUtilsTest.java 595127e Diff: https://reviews.apache.org/r/53943/diff/ Testing --- test done! Thanks, wang yaoxin

Re: Review Request 52155: ambari server upgrade ambari to 2.1.1 duplicate key error

2016-11-20 Thread wang yaoxin
6/4c6f3d15-96cc-4c22-babe-b45b103a8c30__AMBARI-18441-02.patch Thanks, wang yaoxin

Review Request 53943: Improve remoteIp in audit log

2016-11-20 Thread wang yaoxin
--- test done! Thanks, wang yaoxin

Re: Review Request 52155: ambari server upgrade ambari to 2.1.1 duplicate key error

2016-11-15 Thread wang yaoxin
is whole section of updating if the > > `resultSet.getLong("id")` is non-null/non-zero. > > > > You can then so something like this: > > `m_hcsId.set(NumberUtils.max(m_hcsId.get(), idKey)` > > wang yaoxin wrote: > Hi Jonathan ,Thanks f

Re: Review Request 52155: ambari server upgrade ambari to 2.1.1 duplicate key error

2016-11-15 Thread wang yaoxin
6/4c6f3d15-96cc-4c22-babe-b45b103a8c30__AMBARI-18441-02.patch Thanks, wang yaoxin

Re: Review Request 52155: ambari server upgrade ambari to 2.1.1 duplicate key error

2016-11-15 Thread wang yaoxin
further agreement on this case, thanks. - wang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52155/#review150545 --- On 九月 2

Re: Review Request 52155: ambari server upgrade ambari to 2.1.1 duplicate key error

2016-09-27 Thread wang yaoxin
er/upgrade/UpgradeCatalog211.java db13612 Diff: https://reviews.apache.org/r/52155/diff/ Testing --- the unit test is UpgradeCatalog211Test.java: Process finished with exit code 0. done ! Thanks, wang yaoxin

Re: Review Request 52155: ambari server upgrade ambari to 2.1.1 duplicate key error

2016-09-22 Thread wang yaoxin
dn't this prevent the method from being executed again? > > wang yaoxin wrote: > My first upgrade test failed due to my environment issue. Since in real > production environment this failure would occur again, I am now submit the > patch for the purpose of optimiz

Re: Review Request 52155: ambari server upgrade ambari to 2.1.1 duplicate key error

2016-09-22 Thread wang yaoxin
timizing the entire section of code - wang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52155/#review150021 ------- On 九月 22, 2016, 11:08 a.m., wang yaoxin wrote: > > --

Re: Review Request 52155: ambari server upgrade ambari to 2.1.1 duplicate key error

2016-09-22 Thread wang yaoxin
s finished with exit code 0. done ! Thanks, wang yaoxin

Review Request 52155: ambari server upgrade ambari to 2.1.1 duplicate key error

2016-09-22 Thread wang yaoxin
"pk_hostcomponentstate". Diffs - ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java db13612 Diff: https://reviews.apache.org/r/52155/diff/ Testing --- the unit test is UpgradeCatalog211Test.java: Process finished with exit code 0. done ! Thanks, wang yaoxin

Re: Review Request 49802: Host Namenode Rebalance HDFS failed

2016-09-18 Thread wang yaoxin
lly generated e-mail. To reply, visit: https://reviews.apache.org/r/49802/#review148934 ------- On 九月 14, 2016, 8:07 a.m., wang yaoxin wrote: > > --- > This is an aut

Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-18 Thread wang yaoxin
#x27;s OK - wang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51843/#review149209 --- On 九月 18, 2016, 9:20 a.m., wang yaoxin wrote: > >

Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-18 Thread wang yaoxin
: https://reviews.apache.org/r/51843/diff/ Testing --- done! Thanks, wang yaoxin

Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-16 Thread wang yaoxin
/RequestEventCreatorTest.java 1074f0e Diff: https://reviews.apache.org/r/51843/diff/ Testing --- done! Thanks, wang yaoxin

Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-16 Thread wang yaoxin
: https://reviews.apache.org/r/51843/diff/ Testing --- done! Thanks, wang yaoxin

Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-16 Thread wang yaoxin
I have attach a new patch AMBARI-18374_02.patch - wang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51843/#review149186 ------

Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-16 Thread wang yaoxin
://reviews.apache.org/r/51843/diff/ Testing --- done! Thanks, wang yaoxin

Re: Review Request 49804: improve resourcemanager HA description

2016-09-14 Thread wang yaoxin
it: https://reviews.apache.org/r/49804/#review148726 --- On 九月 12, 2016, 3:24 a.m., wang yaoxin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 49802: Host Namenode Rebalance HDFS failed

2016-09-14 Thread wang yaoxin
vices/HDFS/2.1.0.2.0/package/scripts/namenode.py df02311 Diff: https://reviews.apache.org/r/49802/diff/ Testing --- done Thanks, wang yaoxin

Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-13 Thread wang yaoxin
://reviews.apache.org/r/51843/diff/ Testing --- done! Thanks, wang yaoxin

Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-13 Thread wang yaoxin
- ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java 075e328 Diff: https://reviews.apache.org/r/51843/diff/ Testing --- done! Thanks, wang yaoxin

Re: Review Request 49804: improve resourcemanager HA description

2016-09-13 Thread wang yaoxin
y, visit: https://reviews.apache.org/r/49804/#review148468 ------- On 九月 12, 2016, 3:24 a.m., wang yaoxin wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 49804: improve resourcemanager HA description

2016-09-06 Thread wang yaoxin
, visit: https://reviews.apache.org/r/49804/#review147904 --- On 九月 6, 2016, 9:57 a.m., wang yaoxin wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request 51422: ExtensionModeule's description is not corrent

2016-08-30 Thread wang yaoxin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51422/#review147280 --- Ship it! Ship It! - wang yaoxin On 八月 30, 2016, 9:07 a.m

Re: Review Request 49944: optimize log description of ambari agent stop

2016-08-15 Thread wang yaoxin
--------- On 八月 4, 2016, 1:17 a.m., wang yaoxin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49944/ >

Review Request 50742: operationStatus and taskStatus audit log should contain remoteIp message

2016-08-03 Thread wang yaoxin
43bdef9 ambari-server/src/test/java/org/apache/ambari/server/audit/OperationStatusAuditEventTest.java 038cebc ambari-server/src/test/java/org/apache/ambari/server/audit/TaskStatusAuditEventTest.java 8f769c7 Diff: https://reviews.apache.org/r/50742/diff/ Testing --- done Thanks, wang

Review Request 50067: Error message does not deliver when executing ambari-server command as a non-root user

2016-07-15 Thread wang yaoxin
this user Diffs - ambari-server/sbin/ambari-server 81cf53b Diff: https://reviews.apache.org/r/50067/diff/ Testing --- done! Thanks, wang yaoxin

Review Request 49944: optimize log description of ambari agent stop

2016-07-11 Thread wang yaoxin
/jira/browse/AMBARI-17668 Repository: ambari Description --- excute ambari agent ?going to execute kill -9?but none output log Diffs - ambari-agent/src/main/python/ambari_agent/main.py 1fc445e Diff: https://reviews.apache.org/r/49944/diff/ Testing --- done Thanks, wang

Review Request 49804: improve resourcemanager HA description

2016-07-08 Thread wang yaoxin
/jira/browse/AMBARI-17518 Repository: ambari Description --- improve the resourcemanager HA description Diffs - ambari-web/app/models/host_component.js 973b809 Diff: https://reviews.apache.org/r/49804/diff/ Testing --- done Thanks, wang yaoxin

Review Request 49802: Host Namenode Rebalance HDFS failed

2016-07-08 Thread wang yaoxin
/ Testing --- done Thanks, wang yaoxin