Review Request 65454: Install zk error when cluster just only installed zk.

2018-01-31 Thread zhangxiaolu zhangxiaolu
installed zk. when start zk, error is 'core-site not found' Diffs - ambari-server/src/main/resources/stack-hooks/before-START/scripts/params.py 6c26e01 Diff: https://reviews.apache.org/r/65454/diff/1/ Testing --- done it Thanks, zhangxiaolu zhangxiaolu

Re: Review Request 63786: zookeeper service issue

2017-12-13 Thread zhangxiaolu zhangxiaolu
https://reviews.apache.org/media/uploaded/files/2017/12/13/4c703fee-d7de-4363-92c0-4e6ec4094bed__AMBARI-22436_1.patch Thanks, zhangxiaolu zhangxiaolu

Re: Review Request 64204: zkfc show no alerts when zkfc is down

2017-12-13 Thread zhangxiaolu zhangxiaolu
---------- On 十一月 30, 2017, 11:40 a.m., zhangxiaolu zhangxiaolu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64204/ > ---

Re: Review Request 64204: zkfc show no alerts when zkfc is down

2017-11-30 Thread zhangxiaolu zhangxiaolu
.patch https://reviews.apache.org/media/uploaded/files/2017/11/30/77e10ef5-6f44-4e18-9c8f-20d9fe62d8a9__AMBARI-22557.patch Thanks, zhangxiaolu zhangxiaolu

Review Request 64204: zkfc show no alerts when zkfc is down

2017-11-30 Thread zhangxiaolu zhangxiaolu
(2)we should deal with zkfc in front. Diffs - ambari-web/app/mappers/alert_definition_summary_mapper.js 29f286e Diff: https://reviews.apache.org/r/64204/diff/1/ Testing --- done it Thanks, zhangxiaolu zhangxiaolu

Review Request 63786: zookeeper service issue

2017-11-13 Thread zhangxiaolu zhangxiaolu
mbari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/service_check.py b7c7758 Diff: https://reviews.apache.org/r/63786/diff/1/ Testing --- done Thanks, zhangxiaolu zhangxiaolu

Re: Review Request 62656: When the cluster is kerberoed, the config's group of hbase and kafka is root, Maybe should be user.group be better.

2017-09-28 Thread zhangxiaolu zhangxiaolu
ripts/hbase.py fced4fc ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/kafka.py 3f9d109 Diff: https://reviews.apache.org/r/62656/diff/1/ Testing --- done Thanks, zhangxiaolu zhangxiaolu

Review Request 62656: When the cluster is kerberoed, the config's group of hbase and kafka is root, Maybe should be user.group be better.

2017-09-28 Thread zhangxiaolu zhangxiaolu
r/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/kafka.py 3f9d109 Diff: https://reviews.apache.org/r/62656/diff/1/ Testing --- done Thanks, zhangxiaolu zhangxiaolu

Re: Review Request 57583: HDFS Bytes Written and HDFS Bytes Read maybe not correct

2017-09-14 Thread zhangxiaolu zhangxiaolu
> On 六月 9, 2017, 11:57 a.m., Dmytro Sen wrote: > > Ship It! > > zhangxiaolu zhangxiaolu wrote: > thank you for reviewing this patch. Could you be so kind as to commit the > patch for me please? Thanks in advance > > Dmytro Sen wrote: > Can't apply t

Re: Review Request 57583: HDFS Bytes Written and HDFS Bytes Read maybe not correct

2017-07-01 Thread zhangxiaolu zhangxiaolu
> On 六月 9, 2017, 11:57 a.m., Dmytro Sen wrote: > > Ship It! > > zhangxiaolu zhangxiaolu wrote: > thank you for reviewing this patch. Could you be so kind as to commit the > patch for me please? Thanks in advance > > Dmytro Sen wrote: > Can't apply t

Re: Review Request 60358: Hivesevers's status shows issue for the thrift's port conflict, when hiveservers and spark thrift server installed in the same host.

2017-06-22 Thread zhangxiaolu zhangxiaolu
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60358/#review178666 ----------- On 六月 22, 2017, 5:55 a.m., zhangxiaolu zhangxiaolu wrote: > > ---

Re: Review Request 57583: HDFS Bytes Written and HDFS Bytes Read maybe not correct

2017-06-22 Thread zhangxiaolu zhangxiaolu
20437.patch Thanks, zhangxiaolu zhangxiaolu

Review Request 60358: Hivesevers's status shows issue for the thrift's port conflict, when hiveservers and spark thrift server installed in the same host.

2017-06-21 Thread zhangxiaolu zhangxiaolu
rg/r/60358/diff/1/ Testing --- done Thanks, zhangxiaolu zhangxiaolu

Re: Review Request 57583: HDFS Bytes Written and HDFS Bytes Read maybe not correct

2017-06-21 Thread zhangxiaolu zhangxiaolu
ed e-mail. To reply, visit: https://reviews.apache.org/r/57583/#review177463 --- On 六月 9, 2017, 9:58 a.m., zhangxiaolu zhangxiaolu wrote: > > --- > This is an automatically ge

Re: Review Request 57265: null in heapmap page

2017-06-09 Thread zhangxiaolu zhangxiaolu
hments AMBARI-20290.patch https://reviews.apache.org/media/uploaded/files/2017/03/03/6f22b669-2cd5-4cd7-ae66-693a736811b0__AMBARI-20290.patch before.png https://reviews.apache.org/media/uploaded/files/2017/03/10/db183b48-6294-4103-9811-3d3c34f20a79__before.png after.png https://reviews.apache.org/media/uploaded/files/2017/03/10/2aeda32b-6d2f-40ee-91cd-16a85dc20aca__after.png Thanks, zhangxiaolu zhangxiaolu

Re: Review Request 57583: HDFS Bytes Written and HDFS Bytes Read maybe not correct

2017-06-09 Thread zhangxiaolu zhangxiaolu
fb2cc Diff: https://reviews.apache.org/r/57583/diff/1/ Testing --- done it File Attachments AMBARI-20437.patch https://reviews.apache.org/media/uploaded/files/2017/03/14/6cc045b4-f42b-4fc1-980b-62c8ec8a1154__AMBARI-20437.patch Thanks, zhangxiaolu zhangxiaolu

Review Request 59265: delete rangerKMSServer's function description issue

2017-05-15 Thread zhangxiaolu zhangxiaolu
/main/host/details.js def75d6 Diff: https://reviews.apache.org/r/59265/diff/1/ Testing --- done it Thanks, zhangxiaolu zhangxiaolu

Re: Review Request 59133: Journalnode should support bulk restart o start or stop in hosts' page

2017-05-10 Thread zhangxiaolu zhangxiaolu
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59133/#review174508 --- On 五月 10, 2017, 9:01 a.m., zhangxiaolu zhangxiaolu wrote: > > --

Re: Review Request 59133: Journalnode should support bulk restart o start or stop in hosts' page

2017-05-10 Thread zhangxiaolu zhangxiaolu
' page Diffs - ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/metainfo.xml 967c974 Diff: https://reviews.apache.org/r/59133/diff/1/ Testing --- done Thanks, zhangxiaolu zhangxiaolu

Re: Review Request 57451: The Installation of hbase-client failed

2017-04-13 Thread zhangxiaolu zhangxiaolu
, zhangxiaolu zhangxiaolu

Re: Review Request 57451: The Installation of hbase-client failed

2017-04-13 Thread zhangxiaolu zhangxiaolu
matically generated e-mail. To reply, visit: https://reviews.apache.org/r/57451/#review171749 --- On 四月 10, 2017, 7:37 a.m., zhangxiaolu zhangxiaolu wrote: > > --- > This is an autom

Re: Review Request 57451: The Installation of hbase-client failed

2017-04-13 Thread zhangxiaolu zhangxiaolu
ting the config dir is better if not existing the hdfs's config dir. - zhangxiaolu --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57451/#review171749 ---

Re: Review Request 57451: The Installation of hbase-client failed

2017-04-12 Thread zhangxiaolu zhangxiaolu
fix in HDFS Client so that it doesn't fail if hadoop conf > > dir doesn't exist. > > > > I prefer option #2 since components should all be idempotent. > > > > How frequently does this happen? Is it only during UI, or BP installs? > > zhangxiaol

Re: Review Request 57451: The Installation of hbase-client failed

2017-04-12 Thread zhangxiaolu zhangxiaolu
lls? It happened frequently especially installing all services in first time?I hasn't tested it in BP. - zhangxiaolu --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57451/#review

Re: Review Request 57451: The Installation of hbase-client failed

2017-04-11 Thread zhangxiaolu zhangxiaolu
ps://reviews.apache.org/r/57451/#review169470 ------- On 四月 10, 2017, 7:37 a.m., zhangxiaolu zhangxiaolu wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 58264: hive maybe not rely on slider

2017-04-10 Thread zhangxiaolu zhangxiaolu
------------ On 四月 11, 2017, 1:05 a.m., zhangxiaolu zhangxiaolu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58264/ &g

Re: Review Request 58264: hive maybe not rely on slider

2017-04-10 Thread zhangxiaolu zhangxiaolu
1__AMBARI-20710.patch Thanks, zhangxiaolu zhangxiaolu

Re: Review Request 57451: The Installation of hbase-client failed

2017-04-10 Thread zhangxiaolu zhangxiaolu
-151bbadd8b48__AMBARI-20368.patch Thanks, zhangxiaolu zhangxiaolu

Re: Review Request 57451: The Installation of hbase-client failed

2017-04-08 Thread zhangxiaolu zhangxiaolu
-151bbadd8b48__AMBARI-20368.patch Thanks, zhangxiaolu zhangxiaolu

Re: Review Request 57451: The Installation of hbase-client failed

2017-04-07 Thread zhangxiaolu zhangxiaolu
AMBARI-20368.patch https://reviews.apache.org/media/uploaded/files/2017/04/07/e542fd73-b2b4-4542-94d2-151bbadd8b48__AMBARI-20368.patch Thanks, zhangxiaolu zhangxiaolu

Re: Review Request 57451: The Installation of hbase-client failed

2017-04-07 Thread zhangxiaolu zhangxiaolu
(updated) AMBARI-20368.patch https://reviews.apache.org/media/uploaded/files/2017/04/07/e542fd73-b2b4-4542-94d2-151bbadd8b48__AMBARI-20368.patch Thanks, zhangxiaolu zhangxiaolu

Review Request 58264: hive maybe not rely on slider

2017-04-07 Thread zhangxiaolu zhangxiaolu
.0/metainfo.xml 6d9098f Diff: https://reviews.apache.org/r/58264/diff/1/ Testing --- done it Thanks, zhangxiaolu zhangxiaolu

Re: Review Request 58198: Repetitive operation 'Link' in hdfs.py

2017-04-05 Thread zhangxiaolu zhangxiaolu
x27;.Soory, I'm wrong.I will revoke this patch.Sorry. - zhangxiaolu --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58198/#review171116 ----------

Review Request 58198: Repetitive operation 'Link' in hdfs.py

2017-04-04 Thread zhangxiaolu zhangxiaolu
/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py 1264284 Diff: https://reviews.apache.org/r/58198/diff/1/ Testing --- done it Thanks, zhangxiaolu zhangxiaolu

Re: Review Request 57583: HDFS Bytes Written and HDFS Bytes Read maybe not correct

2017-03-15 Thread zhangxiaolu zhangxiaolu
- zhangxiaolu --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57583/#review169016 --- On 三月 14, 2017, 2:46 a.m., zhangxiaolu zhangxiaolu wrote: > > -

Re: Review Request 57451: The Installation of hbase-client failed

2017-03-15 Thread zhangxiaolu zhangxiaolu
://reviews.apache.org/r/57451/diff/1/ Testing --- done it Thanks, zhangxiaolu zhangxiaolu

Re: Review Request 57451: The Installation of hbase-client failed

2017-03-14 Thread zhangxiaolu zhangxiaolu
> On 三月 9, 2017, 8:43 p.m., Alejandro Fernandez wrote: > > +1. I agree, especially if HBase client is added on this host, and at a > > later time HDFS client is added. > > zhangxiaolu zhangxiaolu wrote: > Thank you so much for reviewing my patch on reviewboard, and

Re: Review Request 57583: HDFS Bytes Written and HDFS Bytes Read maybe not correct

2017-03-13 Thread zhangxiaolu zhangxiaolu
Attachments (updated) AMBARI-20437.patch https://reviews.apache.org/media/uploaded/files/2017/03/14/6cc045b4-f42b-4fc1-980b-62c8ec8a1154__AMBARI-20437.patch Thanks, zhangxiaolu zhangxiaolu

Review Request 57583: HDFS Bytes Written and HDFS Bytes Read maybe not correct

2017-03-13 Thread zhangxiaolu zhangxiaolu
heatmap's page,values should be $ {dfs.datanode.BytesRead._rate/1024} MB Diffs - ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json bcfb2cc Diff: https://reviews.apache.org/r/57583/diff/1/ Testing --- done it Thanks, zhangxiaolu zhangxiaolu

Re: Review Request 57265: null in heapmap page

2017-03-13 Thread zhangxiaolu zhangxiaolu
To reply, visit: https://reviews.apache.org/r/57265/#review168819 --- On 三月 13, 2017, 5:59 a.m., zhangxiaolu zhangxiaolu wrote: > > --- > This is an automatically generate

Review Request 57550: Flume should support batch restart in hosts' page likeing datanode or region

2017-03-13 Thread zhangxiaolu zhangxiaolu
so should can batch restart or stop or start. Diffs - ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/metainfo.xml b4f1058 Diff: https://reviews.apache.org/r/57550/diff/1/ Testing --- done Thanks, zhangxiaolu zhangxiaolu

Re: Review Request 57494: Description incorrect for the method ExtensionModeule

2017-03-11 Thread zhangxiaolu zhangxiaolu
Description --- ExtensionModeule's description is not corrent Diffs - ambari-server/src/main/java/org/apache/ambari/server/stack/ExtensionModule.java e3f8d0d Diff: https://reviews.apache.org/r/57494/diff/1/ Testing --- done it Thanks, zhangxiaolu zhangxiaolu

Re: Review Request 57265: null in heapmap page

2017-03-09 Thread zhangxiaolu zhangxiaolu
-- AMBARI-20290.patch https://reviews.apache.org/media/uploaded/files/2017/03/03/6f22b669-2cd5-4cd7-ae66-693a736811b0__AMBARI-20290.patch before.png https://reviews.apache.org/media/uploaded/files/2017/03/10/db183b48-6294-4103-9811-3d3c34f20a79__before.png after.png https://reviews.apache.org/media/uploaded/files/2017/03/10/2aeda32b-6d2f-40ee-91cd-16a85dc20aca__after.png Thanks, zhangxiaolu zhangxiaolu

Re: Review Request 57265: null in heapmap page

2017-03-09 Thread zhangxiaolu zhangxiaolu
alue); } } }, because the metricName is always null, the if condition cannot execute. Diffs - ambari-web/app/views/common/widget/heatmap_widget_view.js a7a919b Diff: https://reviews.apache.org/r/57265/diff/1/ Testing --- done it File Attachments ---- AMBARI-20290.patch https://reviews.apache.org/media/uploaded/files/2017/03/03/6f22b669-2cd5-4cd7-ae66-693a736811b0__AMBARI-20290.patch Thanks, zhangxiaolu zhangxiaolu

Review Request 57494: ExtensionModeule's description is not corrent

2017-03-09 Thread zhangxiaolu zhangxiaolu
mbari/server/stack/ExtensionModule.java e3f8d0d Diff: https://reviews.apache.org/r/57494/diff/1/ Testing --- done it Thanks, zhangxiaolu zhangxiaolu

Re: Review Request 57451: The Installation of hbase-client failed

2017-03-09 Thread zhangxiaolu zhangxiaolu
- zhangxiaolu --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57451/#review168511 --- On 三月 9, 2017, 8 a.m., zhangxiaolu zh

Re: Review Request 57451: The Installation of hbase-client failed

2017-03-09 Thread zhangxiaolu zhangxiaolu
://reviews.apache.org/r/57451/diff/1/ Testing --- done it Thanks, zhangxiaolu zhangxiaolu

Re: Review Request 57451: The Installation of hbase-client failed

2017-03-08 Thread zhangxiaolu zhangxiaolu
hanks, zhangxiaolu zhangxiaolu

Review Request 57451: HBase-client installed failedly

2017-03-08 Thread zhangxiaolu zhangxiaolu
Diffs - ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 20894ec Diff: https://reviews.apache.org/r/57451/diff/1/ Testing --- done it Thanks, zhangxiaolu zhangxiaolu

Re: Review Request 56918: the item of "reblance hdfs" should be hidden in NameNode menu

2017-02-21 Thread zhangxiaolu zhangxiaolu
- ambari-web/app/views/main/host/details/host_component_view.js 92cf0c6 Diff: https://reviews.apache.org/r/56918/diff/ Testing --- done it Thanks, zhangxiaolu zhangxiaolu

Review Request 56918: the item of "reblance hdfs" should be hidden in NameNode menu

2017-02-21 Thread zhangxiaolu zhangxiaolu
://reviews.apache.org/r/56918/diff/ Testing --- done it Thanks, zhangxiaolu zhangxiaolu