Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components

2017-01-16 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46268/#review161813 --- Ship it! Ship It! - Jayush Luniya On Jan. 13, 2017, 3:33 p.m

Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components

2017-01-13 Thread Mugdha Varadkar
> On Jan. 12, 2017, 10:55 p.m., Jayush Luniya wrote: > > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py, line > > 1551 > > > > > > Please run without -DskipPythonTests flag Updated unit test

Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components

2017-01-13 Thread Mugdha Varadkar
> On Jan. 12, 2017, 10:53 p.m., Jayush Luniya wrote: > > ambari-web/app/controllers/main/service/info/configs.js, line 518 > > > > > > Is this supposed to be part of the fix? Yes we need to revert the earlier UI imp

Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components

2017-01-13 Thread Mugdha Varadkar
> On Jan. 12, 2017, 10:53 p.m., Jayush Luniya wrote: > > ambari-web/app/controllers/wizard/step7_controller.js, line 539 > > > > > > Is this supposed to be part of the fix? Yes we need to revert the earlier UI imple

Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components

2017-01-13 Thread Mugdha Varadkar
> On Jan. 12, 2017, 10:57 p.m., Jayush Luniya wrote: > > Patch doesnt apply cleanly on latest trunk. Can you update the patch? @Jayush I have attached the latest patch for trunk on https://issues.apache.org/jira/secure/attachment/12847349/AMBARI-19044.2.trunk.patch - Mugdha

Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components

2017-01-13 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46268/ --- (Updated Jan. 13, 2017, 3:33 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components

2017-01-12 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46268/#review161446 --- Patch doesnt apply cleanly on latest trunk. Can you update the pat

Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components

2017-01-12 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46268/#review161445 --- ambari-server/src/test/python/stacks/2.3/common/test_stack_adviso

Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components

2017-01-12 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46268/#review161439 --- ambari-web/app/controllers/main/service/info/configs.js (line 518

Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components

2017-01-11 Thread Mugdha Varadkar
> On Jan. 9, 2017, 7:24 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-audit.xml, > > line 26 > > > > > > Do all of these properties have

Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components

2017-01-11 Thread Jayush Luniya
> On Jan. 9, 2017, 7:24 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-audit.xml, > > line 26 > > > > > > Do all of these properties have

Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components

2017-01-10 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46268/#review161095 --- Ship it! Ship It! - Alejandro Fernandez On Jan. 10, 2017, 1:

Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components

2017-01-10 Thread Mugdha Varadkar
> On Jan. 9, 2017, 7:24 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-audit.xml, > > line 26 > > > > > > Do all of these properties have

Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components

2017-01-10 Thread Mugdha Varadkar
> On Jan. 9, 2017, 7:24 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java, > > line 704 > > > > > > Please add some javadoc. Updated in latest

Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components

2017-01-10 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46268/ --- (Updated Jan. 10, 2017, 1:31 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components

2017-01-09 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46268/#review160934 --- Please be careful with on-ambari-upgrade settings. If the user is

Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components

2017-01-09 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46268/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, Jayu