Re: Review Request 47119: LogFeeder: enable/disable log level filter

2016-05-09 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47119/#review132306 --- Ship it! Ship It! - Miklos Gergely On May 9, 2016, 2:51 p.m.

Re: Review Request 47119: LogFeeder: enable/disable log level filter

2016-05-09 Thread Oliver Szabo
> On May 9, 2016, 2:42 p.m., Robert Nettleton wrote: > > Overal the patch looks fine to me, just with a few minor issues below that > > need clarification. > > > > One additional question: How is the filter itself configured to a specific > > log level? Shouldn't there be some new stack prope

Re: Review Request 47119: LogFeeder: enable/disable log level filter

2016-05-09 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47119/ --- (Updated May 9, 2016, 2:51 p.m.) Review request for Ambari, Miklos Gergely, Rob

Re: Review Request 47119: LogFeeder: enable/disable log level filter

2016-05-09 Thread Oliver Szabo
> On May 9, 2016, 2:42 p.m., Robert Nettleton wrote: > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py, > > line 275 > > > > > > This property doesn't appear to be listed

Re: Review Request 47119: LogFeeder: enable/disable log level filter

2016-05-09 Thread Robert Nettleton
> On May 9, 2016, 2:42 p.m., Robert Nettleton wrote: > > Overal the patch looks fine to me, just with a few minor issues below that > > need clarification. > > > > One additional question: How is the filter itself configured to a specific > > log level? Shouldn't there be some new stack prope

Re: Review Request 47119: LogFeeder: enable/disable log level filter

2016-05-09 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47119/#review132276 --- Fix it, then Ship it! Overal the patch looks fine to me, just w

Re: Review Request 47119: LogFeeder: enable/disable log level filter

2016-05-09 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47119/ --- (Updated May 9, 2016, 2 p.m.) Review request for Ambari, Miklos Gergely, Robert

Review Request 47119: LogFeeder: enable/disable log level filter

2016-05-09 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47119/ --- Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit Mohanty.