Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-09 Thread Akhil PB
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48487/ --- Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath S

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-22 Thread Sreenath Somarajapuram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48487/#review139032 --- contrib/views/capacity-scheduler/src/main/resources/ui/app/serial

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-22 Thread Akhil PB
> On June 22, 2016, 8:50 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js, > > line 164 > > > > > > Why are we having the + after ? Converting string

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-22 Thread Akhil PB
> On June 22, 2016, 8:50 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js, > > line 164 > > > > > > Why are we having the + after ? > > Akhil PB wrot

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-22 Thread Sreenath Somarajapuram
> On June 22, 2016, 8:50 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js, > > line 164 > > > > > > Why are we having the + after ? > > Akhil PB wrot

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-22 Thread Sreenath Somarajapuram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48487/#review139036 --- contrib/views/capacity-scheduler/src/main/resources/ui/app/compon

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-22 Thread Akhil PB
> On June 22, 2016, 10:12 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs, > > line 26 > > > > > > Where is the versions-table-wrap class

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-22 Thread Sreenath Somarajapuram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48487/#review139046 --- contrib/views/capacity-scheduler/src/main/resources/ui/app/contro

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-22 Thread Sreenath Somarajapuram
> On June 22, 2016, 10:12 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs, > > line 26 > > > > > > Where is the versions-table-wrap class

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-22 Thread Sreenath Somarajapuram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48487/#review139051 --- - Sreenath Somarajapuram On June 9, 2016, 12:05 p.m., Akhil PB w

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-24 Thread Akhil PB
> On June 22, 2016, 10:12 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js, > > line 25 > > > > > > Trailing space must be removed. W

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-24 Thread Akhil PB
> On June 22, 2016, 10:42 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js, > > line 45 > > > > > > Where is isNotOperator used? I guess its

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-26 Thread Akhil PB
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48487/ --- (Updated June 27, 2016, 5:36 a.m.) Review request for Ambari, DIPAYAN BHOWMICK,

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-29 Thread Akhil PB
> On June 22, 2016, 10:12 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs, > > line 26 > > > > > > Where is the versions-table-wrap class

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-29 Thread Sreenath Somarajapuram
> On June 22, 2016, 10:12 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs, > > line 26 > > > > > > Where is the versions-table-wrap class

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-29 Thread Akhil PB
> On June 22, 2016, 10:12 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs, > > line 26 > > > > > > Where is the versions-table-wrap class

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-29 Thread Akhil PB
> On June 22, 2016, 10:12 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs, > > line 26 > > > > > > Where is the versions-table-wrap class

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-07-04 Thread Sreenath Somarajapuram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48487/#review140616 --- Ship it! Ship It! - Sreenath Somarajapuram On June 27, 2016,