Re: Review Request 58801: Unify repository file creation

2017-04-27 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58801/ --- (Updated April 27, 2017, 3:05 p.m.) Review request for Ambari, Dmitro Lisnichen

Re: Review Request 58801: Unify repository file creation

2017-04-27 Thread Nate Cole
> On April 27, 2017, 2:59 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java > > Lines 38-44 (patched) > > > > > > These are serialized to Python, right?

Re: Review Request 58801: Unify repository file creation

2017-04-27 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58801/#review173236 --- Ship it! ambari-server/src/main/java/org/apache/ambari/server/

Re: Review Request 58801: Unify repository file creation

2017-04-27 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58801/ --- (Updated April 27, 2017, 2:34 p.m.) Review request for Ambari, Dmitro Lisnichen

Re: Review Request 58801: Unify repository file creation

2017-04-27 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58801/#review173211 --- Fix it, then Ship it! ambari-common/src/main/python/resource_m

Review Request 58801: Unify repository file creation

2017-04-27 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58801/ --- Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley. Bugs: AMBARI