Re: Review Request 61490: Upgrade Pre-Checks Should Take PATCH/SERVICE Types Into Account

2017-08-08 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61490/#review182389 --- Ship it! Ship It! - Nate Cole On Aug. 7, 2017, 11:48 p.m.,

Re: Review Request 61490: Upgrade Pre-Checks Should Take PATCH/SERVICE Types Into Account

2017-08-08 Thread Jonathan Hurley
> On Aug. 8, 2017, 1:31 a.m., Dmytro Grinenko wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java > > Line 249 (original), 255 (patched) > > > > > > could we put here

Re: Review Request 61490: Upgrade Pre-Checks Should Take PATCH/SERVICE Types Into Account

2017-08-08 Thread Jonathan Hurley
> On Aug. 8, 2017, 5:27 a.m., Dmitro Lisnichenko wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java > > Lines 326 (patched) > > > > > > cbecks Thanks! Fixed. -

Re: Review Request 61490: Upgrade Pre-Checks Should Take PATCH/SERVICE Types Into Account

2017-08-08 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61490/#review182376 --- Ship it!

Re: Review Request 61490: Upgrade Pre-Checks Should Take PATCH/SERVICE Types Into Account

2017-08-07 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61490/#review182361 --- Fix it, then Ship it! Ship It!

Review Request 61490: Upgrade Pre-Checks Should Take PATCH/SERVICE Types Into Account

2017-08-07 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61490/ --- Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.