Re: Review Request 64887: AMBARI-22403 Read the JAVA_HOME depending on the OS family during Service install (action & command) and upgrade

2018-01-04 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64887/#review194764 --- This has been pushed. Please close this review and jira. - Nate

Re: Review Request 64887: AMBARI-22403 Read the JAVA_HOME depending on the OS family during Service install (action & command) and upgrade

2018-01-04 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64887/#review194763 --- Ship it! Ship It! - Nate Cole On Jan. 3, 2018, 2:03 a.m.,

Re: Review Request 64887: AMBARI-22403 Read the JAVA_HOME depending on the OS family during Service install (action & command) and upgrade

2018-01-04 Thread Nate Cole
> On Jan. 2, 2018, 11:51 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java > > Line 633 (original) > > > > > > It's much more convenient to keep JAVA_HOME in one

Re: Review Request 64887: AMBARI-22403 Read the JAVA_HOME depending on the OS family during Service install (action & command) and upgrade

2018-01-02 Thread Yussuf Shaikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64887/ --- (Updated Jan. 3, 2018, 7:03 a.m.) Review request for Ambari and Nate Cole.

Re: Review Request 64887: AMBARI-22403 Read the JAVA_HOME depending on the OS family during Service install (action & command) and upgrade

2018-01-02 Thread Yussuf Shaikh
> On Jan. 2, 2018, 4:51 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > > Lines 3058-3065 (original), 3057-3060 (patched) > > > > > > The old logic

Re: Review Request 64887: AMBARI-22403 Read the JAVA_HOME depending on the OS family during Service install (action & command) and upgrade

2018-01-02 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64887/#review194635 ---

Review Request 64887: AMBARI-22403 Read the JAVA_HOME depending on the OS family during Service install (action & command) and upgrade

2018-01-02 Thread Yussuf Shaikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64887/ --- Review request for Ambari and Nate Cole. Bugs: AMBARI-22403