Re: Review Request 35760: Removing GcExecutorLauncher code.

2015-06-22 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35760/#review88901 --- src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java

Re: Review Request 35760: Removing GcExecutorLauncher code.

2015-06-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35760/#review88899 --- Master (2df2db9) is red with this patch. ./build-support/jenkins/b

Review Request 35760: Removing GcExecutorLauncher code.

2015-06-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35760/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-1334 https://issues

Re: Review Request 35745: Allow equals in bound variables passed via cmdline

2015-06-22 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35745/#review88878 --- Ship it! Ship It! - Zameer Manji On June 22, 2015, 4:01 p.m., Mi

Re: Review Request 35745: Allow equals in bound variables passed via cmdline

2015-06-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35745/#review88873 --- Ship it! Master (3351b09) is green with this patch. ./build-suppo

Re: Review Request 35745: Allow equals in bound variables passed via cmdline

2015-06-22 Thread Michael Leinartas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35745/ --- (Updated June 22, 2015, 11:01 p.m.) Review request for Aurora and Zameer Manji.

Re: Review Request 35745: Allow equals in bound variables passed via cmdline

2015-06-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35745/#review88863 --- Master (3351b09) is red with this patch. ./build-support/jenkins/b

Re: Review Request 35745: Allow equals in bound variables passed via cmdline

2015-06-22 Thread Michael Leinartas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35745/ --- (Updated June 22, 2015, 10:09 p.m.) Review request for Aurora. Changes --

Re: Review Request 35745: Allow equals in bound variables passed via cmdline

2015-06-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35745/#review88857 --- Master (3351b09) is green with this patch. ./build-support/jenkins

Re: Review Request 35745: Allow equals in bound variables passed via cmdline

2015-06-22 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35745/#review88850 --- Thanks for your contribution! Would you please add me to the people

Re: Review Request 35745: Allow equals in bound variables passed via cmdline

2015-06-22 Thread Michael Leinartas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35745/ --- (Updated June 22, 2015, 9:39 p.m.) Review request for Aurora. Repository: aur

Review Request 35745: Allow equals in bound variables passed via cmdline

2015-06-22 Thread Michael Leinartas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35745/ --- Review request for Aurora. Repository: aurora Description --- - Allow eq

Re: Review Request 34300: Do better sanitation on the client side when encountering unbound pystachio refs

2015-06-22 Thread Kevin Sweeney
> On June 4, 2015, 4:55 p.m., Kevin Sweeney wrote: > > src/main/python/apache/aurora/config/thrift.py, line 218 > > > > > > Why set this at all? Does the scheduler read this field? > > Brian Wickman wrote: > it is

Re: Review Request 34300: Do better sanitation on the client side when encountering unbound pystachio refs

2015-06-22 Thread Brian Wickman
> On June 4, 2015, 11:55 p.m., Kevin Sweeney wrote: > > src/main/python/apache/aurora/config/thrift.py, line 218 > > > > > > Why set this at all? Does the scheduler read this field? it is not. i will leave it up to A

Re: Review Request 35672: DbTaskStore perf: optimize queries scoped to a task ID.

2015-06-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35672/ --- (Updated June 22, 2015, 4:51 p.m.) Review request for Aurora and Maxim Khutorne

Re: Review Request 35587: Suppress task reconciliation status update logging.

2015-06-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35587/#review88806 --- Ship it! Ship It! - Bill Farner On June 19, 2015, 10:07 p.m., Ma

Re: Review Request 35672: DbTaskStore perf: optimize queries scoped to a task ID.

2015-06-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35672/#review88804 --- Ship it! Ship It! - Maxim Khutornenko On June 19, 2015, 10:43 p.

Re: Review Request 35672: DbTaskStore perf: optimize queries scoped to a task ID.

2015-06-22 Thread Maxim Khutornenko
> On June 19, 2015, 11:50 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java, line 127 > > > > > > Curious, why special treating whitespacing here and not in other place

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/#review88802 --- Ship it! Thanks! src/main/java/org/apache/aurora/scheduler/sla/Sl