Re: Review Request 35901: Add a DbCronJobStore implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35901/#review89466 --- Ship it! Master (56bb1e6) is green with this patch. ./build-suppo

Re: Review Request 35901: Add a DbCronJobStore implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35901/#review89464 --- Adding reviewer notes. src/main/java/org/apache/aurora/scheduler/s

Review Request 35901: Add a DbCronJobStore implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35901/ --- Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-415 https://i

Re: Review Request 35812: Remove "enable_legacy_constraints" flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35812/#review89453 --- Ship it! Ship It! - Maxim Khutornenko On June 26, 2015, 12:07 a.

Re: Review Request 35812: Remove "enable_legacy_constraints" flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35812/#review89452 --- Ship it! Master (56bb1e6) is green with this patch. ./build-suppo

Re: Review Request 35812: Remove "enable_legacy_constraints" flag.

> On June 25, 2015, 9:38 a.m., Bill Farner wrote: > > NEWS, line 5 > > > > > > ``` > > The scheduler command line argument enable_legacy_constraints has been > > removed, and the scheduler no longer automatically in

Re: Review Request 35812: Remove "enable_legacy_constraints" flag.

> On June 25, 2015, 10:40 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java, > > lines 75-76 > > > > > > AFAICT, these are now only referenced in test

Re: Review Request 35812: Remove "enable_legacy_constraints" flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35812/ --- (Updated June 25, 2015, 5:07 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 35886: Remove static modifier from test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35886/#review89414 --- Ship it! Master (ca15f25) is green with this patch. ./build-suppo

Re: Review Request 35886: Remove static modifier from test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35886/#review89413 --- Ship it! Ship It! - Bill Farner On June 25, 2015, 6:50 p.m., Kev

Re: Review Request 35886: Remove static modifier from test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35886/#review89411 --- Ship it! Ship It! - Zameer Manji On June 25, 2015, 11:50 a.m., K

Re: Review Request 35793: DbTaskStore: delete unreferenced job keys.

> On June 25, 2015, 6:05 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/RowGarbageCollector.java, > > line 60 > > > > > > I'd still recommend having a run counter to help us mon

Review Request 35886: Remove static modifier from test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35886/ --- Review request for Aurora, Bill Farner and Zameer Manji. Repository: aurora D

Re: Review Request 35842: Use java.util.Optional and streams in LockManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35842/#review89407 --- Ship it! Ship It! - Zameer Manji On June 25, 2015, 11:32 a.m., K

Re: Review Request 35842: Use java.util.Optional and streams in LockManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35842/#review89406 --- Ship it! Master (d28bd4f) is green with this patch. ./build-suppo

Re: Review Request 35842: Use java.util.Optional and streams in LockManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35842/#review89405 --- Ship it! Ship It! - Bill Farner On June 25, 2015, 6:32 p.m., Kev

Re: Review Request 35842: Use java.util.Optional and streams in LockManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35842/ --- (Updated June 25, 2015, 11:32 a.m.) Review request for Aurora, Bill Farner and

Re: Review Request 35793: DbTaskStore: delete unreferenced job keys.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35793/#review89404 --- Ship it! Ship It! - Maxim Khutornenko On June 24, 2015, 10:46 p.

Re: Review Request 35793: DbTaskStore: delete unreferenced job keys.

> On June 25, 2015, 6:05 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java, line 254 > > > > > > This will use a regular single threaded executor, right? Any chance t

Re: Review Request 35793: DbTaskStore: delete unreferenced job keys.

> On June 25, 2015, 6:05 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java, line 254 > > > > > > This will use a regular single threaded executor, right? Any chance t

Re: Review Request 35842: Use java.util.Optional and streams in LockManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35842/ --- (Updated June 25, 2015, 11:12 a.m.) Review request for Aurora, Bill Farner and

Re: Review Request 35842: Use java.util.Optional and streams in LockManager

> On June 24, 2015, 3:15 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/util/GuavaCollectors.java, line 36 > > > > > > I think this collector needs to be given the unordered characteristic > > because it

Re: Review Request 35793: DbTaskStore: delete unreferenced job keys.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35793/#review89393 --- Looks great! Just a couple suggestions below. src/main/java/org/ap

Re: Review Request 35847: Split http lifecycle into a composition layer.

> On June 25, 2015, 10:14 a.m., Brian Brazil wrote: > > docs/configuration-reference.md, line 449 > > > > > > If we're making this configurable, I think that we should make it apply > > to the healthcheck config too.

Re: Review Request 35498: Compute SLA stats for non-prod jobs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/#review89394 --- Ship it! src/main/java/org/apache/aurora/scheduler/sla/MetricCalcu

Re: Review Request 35812: Remove "enable_legacy_constraints" flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35812/#review89391 --- src/main/java/org/apache/aurora/scheduler/configuration/Configurati

Re: Review Request 34337: Add Docker Parameters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/#review89383 --- LGTM in general! Biggest blocker for me is ability to toggle this b

Re: Review Request 35813: Removing GC executor code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35813/#review89380 --- Ship it! Master (d28bd4f) is green with this patch. ./build-suppo

Re: Review Request 35813: Removing GC executor code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35813/ --- (Updated June 25, 2015, 4:59 p.m.) Review request for Aurora, Bill Farner and B

Re: Review Request 35813: Removing GC executor code.

> On June 25, 2015, 4:34 p.m., Bill Farner wrote: > > 25 files changed, 2 insertions(+), 2054 deletions(-) > > > > Nice! 2 requests: > > > > - Can you confirm that end-to-end tests still pass? > > - Can you add to this patch a note in NEWS under 0.9.0 that the GC executor > > has been removed

Re: Review Request 35812: Remove "enable_legacy_constraints" flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35812/#review89373 --- Ship it! NEWS (line 5)

Re: Review Request 35813: Removing GC executor code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35813/#review89372 --- Ship it! 25 files changed, 2 insertions(+), 2054 deletions(-) Nice

Re: Review Request 35847: Split http lifecycle into a composition layer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35847/#review89335 --- docs/configuration-reference.md (line 436)