Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-02-01 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42964/#review117258 --- Ship it! Master (de0029b) is green with this patch.

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-02-01 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42964/#review117260 --- Fix it, then Ship it!

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-02-01 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42964/#review117261 ---

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-02-01 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42964/#review117259 --- src/main/python/apache/aurora/client/api/scheduler_client.py

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-02-01 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42964/ --- (Updated Feb. 1, 2016, 8:05 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 42964: Add header to allow bypassing the LeaderRedirectFilter.

2016-02-01 Thread Joshua Cohen
> On Jan. 29, 2016, 9:07 p.m., Zameer Manji wrote: > > I think you also need to add a flag/option to `aurora_admin` to let > > operators take advantage of this flag. Done! - Joshua --- This is an automatically generated e-mail. To

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2016-02-01 Thread Stephan Erb
> On Feb. 1, 2016, 11:04 nachm., Bill Farner wrote: > > My apologies for the delay, there is now a merge conflict in `NEWS`. Can > > you address? Yeah, I can rebase but will take me another 24h - Stephan --- This is an automatically

Re: Review Request 43066: Bump virtualenv version for in repo tools.

2016-02-01 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43066/#review117279 --- Ship it! We now have this tooling duplicated over here:

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2016-02-01 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35990/#review117281 --- My apologies for the delay, there is now a merge conflict in

Re: Review Request 43027: Optionally enable setuid inside Docker containers

2016-02-01 Thread Benjamin Staffin
> On Jan. 31, 2016, 3:29 p.m., Stephan Erb wrote: > > With the new proposed option we'd get `--execute-as-user`, `--nosetuid`, > > and `--docker-setuid`. The last two are basically doing the same thing. > > > > Would it make sense to resolve this by pushing things up the stack and > > allow

Re: Review Request 42985: Add a flag to configure H2 LOCK_TIMEOUT.

2016-02-01 Thread Zameer Manji
> On Jan. 29, 2016, 3:32 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java, line 87 > > > > > > I suggest you raise the default to a very conservative level (like 1 > >

Re: Review Request 42985: Add a flag to configure H2 LOCK_TIMEOUT.

2016-02-01 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42985/ --- (Updated Feb. 1, 2016, 2:44 p.m.) Review request for Aurora, Joshua Cohen and

Review Request 43066: Bump virtualenv version for in repo tools.

2016-02-01 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43066/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 42953: Improve --read-json to handle multi-job files

2016-02-01 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42953/#review117293 --- Ship it! Ship It! - Bill Farner On Jan. 30, 2016, 3:08

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

2016-02-01 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35990/#review117280 --- Ship it! Ship It! - Bill Farner On Jan. 27, 2016, 2:52

Review Request 43080: Fixing duplicate instances in the UI.

2016-02-01 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43080/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-1604

Re: Review Request 43080: Fixing duplicate instances in the UI.

2016-02-01 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43080/#review117338 --- Ship it! Thanks! - Bill Farner On Feb. 1, 2016, 5:37 p.m.,

Re: Review Request 43080: Fixing duplicate instances in the UI.

2016-02-01 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43080/#review117337 --- Ship it! Master (824e396) is green with this patch.

Re: Review Request 42979: Enable ping query to prevent use of invalid pooled connections.

2016-02-01 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42979/#review117226 --- Ship it! Ship It! - Joshua Cohen On Jan. 29, 2016, 10:38

Re: Review Request 43027: Optionally enable setuid inside Docker containers

2016-02-01 Thread Stephan Erb
> On Feb. 1, 2016, 12:29 a.m., Stephan Erb wrote: > > With the new proposed option we'd get `--execute-as-user`, `--nosetuid`, > > and `--docker-setuid`. The last two are basically doing the same thing. > > > > Would it make sense to resolve this by pushing things up the stack and > > allow

Re: Review Request 42985: Add a flag to configure H2 LOCK_TIMEOUT.

2016-02-01 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42985/#review117227 --- Ship it! Ship It! - Joshua Cohen On Jan. 29, 2016, 11:23