Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review133862 --- Ship it! Master (3cbff41) is green with this patch. ./build-s

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

> On May 18, 2016, 10 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java, line 45 > > > > > > I am surprised to find this one here. Are you planning to bundle a > > defau

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/ --- (Updated May 19, 2016, 2:16 a.m.) Review request for Aurora. Bugs: AURORA-168

Re: Review Request 47561: Fixing resource slot counting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47561/#review133851 --- Ship it! src/main/java/org/apache/aurora/scheduler/resources/R

Re: Review Request 47561: Fixing resource slot counting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47561/#review133831 --- Ship it! Master (3cbff41) is green with this patch. ./build-s

Review Request 47561: Fixing resource slot counting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47561/ --- Review request for Aurora and Joshua Cohen. Repository: aurora Description --

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review133819 --- A couple of highlevel questions and thoughts below. src/main/jav

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review133816 --- Ship it! Master (3cbff41) is green with this patch. ./build-s

Re: Review Request 47495: Use 'Mesos agent' instead of 'Mesos slave' in docs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47495/#review133813 --- Ship it! Master (3cbff41) is green with this patch. ./build-s

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

> On May 17, 2016, 2:51 a.m., George Sirois wrote: > > src/main/java/org/apache/aurora/scheduler/events/Webhook.java, line 86 > > > > > > Should this be dispatched on another thread or added to a queue for > > future

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

> On May 17, 2016, 5:09 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java, line 31 > > > > > > move to previous line Done. > On May 17, 2016, 5:09 p.m., Maxim Khut

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/ --- (Updated May 18, 2016, 9:12 p.m.) Review request for Aurora. Bugs: AURORA-168

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

> On May 17, 2016, 8:56 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/events/Webhook.java, line 45 > > > > > > It would probably make sense to call `setConnectTimeout` as a > > safe-guard aga

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47550/#review133811 --- Ship it! Master (3cbff41) is green with this patch. ./build-s

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47550/#review133810 --- src/main/python/apache/aurora/client/cli/update.py (line 220)

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47550/#review133809 --- src/main/python/apache/aurora/client/cli/update.py (lines 162 - 1

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47550/#review133807 --- src/main/python/apache/aurora/client/cli/update.py (line 162)

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47550/#review133808 --- src/main/python/apache/aurora/client/cli/update.py (lines 162 - 1

Re: Review Request 47495: Use 'Mesos agent' instead of 'Mesos slave' in docs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47495/ --- (Updated May 18, 2016, 10:57 p.m.) Review request for Aurora and Joshua Cohen.

Re: Review Request 47495: Use 'Mesos agent' instead of 'Mesos slave' in docs

> On May 18, 2016, 5:38 p.m., Benjamin Staffin wrote: > > docs/operations/configuration.md, line 161 > > > > > > Maybe use `(i.e. the agent machine)` here for clarity? That phrasing is > > used in at least one other

Re: Review Request 47495: Use 'Mesos agent' instead of 'Mesos slave' in docs

> On May 18, 2016, 4:15 p.m., Joshua Cohen wrote: > > docs/getting-started/overview.md, line 56 > > > > > > s/has/had > > Benjamin Staffin wrote: > s/had been known/was/ > > Benjamin Staffin wrote: > crap, I

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47550/ --- (Updated May 18, 2016, 8:55 p.m.) Review request for Aurora. Repository: auro

Re: Review Request 47495: Use 'Mesos agent' instead of 'Mesos slave' in docs

> On May 18, 2016, 5:33 p.m., Benjamin Staffin wrote: > > docs/features/constraints.md, line 4 > > > > > > Might it be clearer to phrase this as "any random offer"? Or maybe > > that would confuse newcomers, I'm not

Review Request 47550: AURORA-1492 Improve "aurora update start" command output

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47550/ --- Review request for Aurora. Repository: aurora Description --- AURORA-149

Re: Review Request 47495: Use 'Mesos agent' instead of 'Mesos slave' in docs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47495/#review133750 --- docs/features/constraints.md (line 4)

Re: Review Request 47495: Use 'Mesos agent' instead of 'Mesos slave' in docs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47495/#review133755 --- docs/operations/configuration.md (line 161)

Re: Review Request 47495: Use 'Mesos agent' instead of 'Mesos slave' in docs

> On May 18, 2016, 2:15 p.m., Joshua Cohen wrote: > > docs/getting-started/overview.md, line 56 > > > > > > s/has/had > > Benjamin Staffin wrote: > s/had been known/was/ > > Benjamin Staffin wrote: > crap, I

Re: Review Request 47495: Use 'Mesos agent' instead of 'Mesos slave' in docs

> On May 18, 2016, 7:15 a.m., Joshua Cohen wrote: > > docs/getting-started/overview.md, line 56 > > > > > > s/has/had > > Benjamin Staffin wrote: > s/had been known/was/ crap, I meant to say s/had been/was/ -

Re: Review Request 47495: Use 'Mesos agent' instead of 'Mesos slave' in docs

> On May 18, 2016, 7:15 a.m., Joshua Cohen wrote: > > docs/getting-started/overview.md, line 56 > > > > > > s/has/had s/had been known/was/ - Benjamin --- T

Re: Review Request 47495: Use 'Mesos agent' instead of 'Mesos slave' in docs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47495/#review133741 --- Ship it! docs/getting-started/overview.md (line 56)