Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51662/#review148128 --- Please add a line to RELEASE_NOTES.md about this change.

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51662/#review148123 --- api/src/main/thrift/org/apache/aurora/gen/api.thrift (line 1214)

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148125 --- Master (8fca745) is red with this patch.

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51662/#review148122 --- Ship it! Master (8fca745) is green with this patch.

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148120 --- @ReviewBot retry - Zameer Manji On Sept. 7, 2016, 5:03 p.m.,

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51662/ --- (Updated Sept. 8, 2016, 12:30 a.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148119 --- Master (8fca745) is red with this patch.

Re: Review Request 51536: Modify the watch_secs assertion on scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/#review148118 --- Ship it! Ship It! - Zameer Manji On Sept. 7, 2016, 4:10

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148117 --- Reviewers: This is my first time causing a thrift level

Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/ --- Review request for Aurora, Joshua Cohen and Maxim Khutornenko. Bugs:

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

> On Sept. 7, 2016, 2:45 p.m., Santhosh Kumar Shanmugham wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, lines 1209-1214 > > > > > > Did we consider combining the "explicit" and "implicit"

Re: Review Request 51536: Modify the watch_secs assertion on scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/#review148111 --- Ship it! Master (19866b5) is green with this patch.

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

> On Sept. 7, 2016, 2:45 p.m., Santhosh Kumar Shanmugham wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, lines 1209-1214 > > > > > > Did we consider combining the "explicit" and "implicit"

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

> On Sept. 7, 2016, 9:45 p.m., Santhosh Kumar Shanmugham wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, lines 1209-1214 > > > > > > Did we consider combining the "explicit" and "implicit"

Re: Review Request 51536: Modify the watch_secs assertion on scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/ --- (Updated Sept. 7, 2016, 11:10 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 51536: Allow watch_secs to be set to 0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/#review148107 --- RELEASE-NOTES.md (line 37)

Re: Review Request 51536: Allow watch_secs to be set to 0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/#review148106 --- Ship it! Master (19866b5) is green with this patch.

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

> On Sept. 7, 2016, 9:45 p.m., Santhosh Kumar Shanmugham wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, lines 1209-1214 > > > > > > Did we consider combining the "explicit" and "implicit"

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

> On Sept. 7, 2016, 9:45 p.m., Santhosh Kumar Shanmugham wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, lines 1209-1214 > > > > > > Did we consider combining the "explicit" and "implicit"

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

> On Sept. 7, 2016, 2:45 p.m., Santhosh Kumar Shanmugham wrote: > > src/main/python/apache/aurora/admin/admin.py, line 342 > > > > > > 'default=0' here and the usage doc reads default as 1000. > > Karthik Anantha

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/#review148100 --- Ship it! Master (19866b5) is green with this patch.

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

> On Sept. 7, 2016, 9:45 p.m., Santhosh Kumar Shanmugham wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, lines 1209-1214 > > > > > > Did we consider combining the "explicit" and "implicit"

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/ --- (Updated Sept. 7, 2016, 10:06 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 51536: @ReviewBot Scheduler updater will not use watch_sec if health check is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/ --- (Updated Sept. 7, 2016, 10:01 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 51536: Scheduler updater will not use watch_sec if health check is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/ --- (Updated Sept. 7, 2016, 10 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 51536: Scheduler updater will not use watch_sec if health check is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/#review148095 --- Master (19866b5) is red with this patch.

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51662/#review148089 --- api/src/main/thrift/org/apache/aurora/gen/api.thrift (lines 1209

Re: Review Request 51536: Scheduler updater will not use watch_sec if health check is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/#review148092 --- Ship it! Ship It! - Joshua Cohen On Sept. 7, 2016, 9:28

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51662/#review148090 --- Ship it! Master (19866b5) is green with this patch.

Re: Review Request 51536: Scheduler updater will not use watch_sec if health check is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/ --- (Updated Sept. 7, 2016, 9:28 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 51536: Scheduler updater will not use watch_sec if health check is enabled

> On Sept. 7, 2016, 8:18 p.m., Joshua Cohen wrote: > > This change should probably be called out in RELEASE_NOTES.md? This feature will not be available to users until we relax the client-side constraint. We can add it to RELEASE_NOTES when the executor/client feature is ready. - Kai

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51662/ --- (Updated Sept. 7, 2016, 9:08 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51662/ --- (Updated Sept. 7, 2016, 9:01 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

> On Sept. 7, 2016, 6:14 p.m., Maxim Khutornenko wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, lines 944-950 > > > > > > I don't think there is much value in having this struct and the related >

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51662/#review148046 --- api/src/main/thrift/org/apache/aurora/gen/api.thrift (lines 944

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

> On Sept. 7, 2016, 10:36 a.m., Maxim Khutornenko wrote: > > Ship It! Thank you. - Santhosh Kumar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51384/#review148035

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51384/#review148035 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 7, 2016,

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

> On Sept. 2, 2016, 9:37 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > line 913 > > > > > > This will be a null ref if scheduler is called

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

> On Sept. 2, 2016, 2:37 p.m., Maxim Khutornenko wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 774 > > > > > > nit: all comments should be ended with '.'. Here and everywhere. Fixed. > On