Re: Review Request 55020: AURORA-1835 Expose finer grained offer veto stats

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55020/#review162965 --- Ship it! Ship It! - David McLaughlin On Dec. 23, 2016, 10:46

Re: Review Request 55089: AURORA-1826 Expose Thrift server request workload stats

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55089/#review162968 --- Ship it! Ship It! - David McLaughlin On Dec. 30, 2016, 5:58

Re: Review Request 55902: Capture health check output

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55902/ --- (Updated Jan. 25, 2017, 6:37 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 55902: Capture health check output

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55902/#review162993 --- Ship it! lgtm pending a clean reviewbot run. - Joshua Cohen

Re: Review Request 55902: Capture health check output

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55902/ --- (Updated Jan. 25, 2017, 6:47 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 55902: Capture health check output

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55902/#review162997 --- Master (52ddce9) is red with this patch. ./build-support/jenkins

Review Request 55951: Use --launch_info when invoking MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55951/ --- Review request for Aurora, Joshua Cohen, Stephan Erb, and Karthik Anantha Padman

Re: Review Request 55951: Use --launch_info when invoking MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55951/#review163002 --- I will add a verion check to make sure that Aurora is backward's c

Re: Review Request 55951: Use --launch_info when invoking MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55951/#review163003 --- build-support/packer/build.sh (line 20)

Re: Review Request 55902: Capture health check output

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55902/#review163004 --- @ReviewBot retry - Dmitriy Shirchenko On Jan. 25, 2017, 6:47 p.

Re: Review Request 55020: AURORA-1835 Expose finer grained offer veto stats

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55020/#review163005 --- Ship it! Ship It! - Joshua Cohen On Dec. 23, 2016, 10:46 p.m

Re: Review Request 55951: Use --launch_info when invoking MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55951/#review163006 --- Ship it! Master (52ddce9) is green with this patch. ./build-s

Re: Review Request 55902: Capture health check output

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55902/#review163009 --- Ship it! Master (52ddce9) is green with this patch. ./build-s

Re: Review Request 55951: Use --launch_info when invoking MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55951/#review163018 --- The code change itself is fine. However, it's implications are a l

Re: Review Request 55902: Capture health check output

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55902/#review163020 --- Ship it! Ship It! - Zameer Manji On Jan. 25, 2017, 10:47 a.m

Re: Review Request 55951: Use --launch_info when invoking MesosContainerizer.

> On Jan. 25, 2017, 1:07 p.m., Stephan Erb wrote: > > The code change itself is fine. However, it's implications are a little bit > > horrible :) > > > > * We can only apply it once we have released 0.17 (build against Mesos 1.1) > > * Mesos broke +-1 version compatibility here, so users have t

Re: Review Request 55951: Use --launch_info when invoking MesosContainerizer.

> On Jan. 25, 2017, 11:21 a.m., Joshua Cohen wrote: > > src/main/python/apache/thermos/common/process_util.py, lines 25-37 > > > > > > Rather than continuing to manually construct a json representation of a > > proto

Re: Review Request 55951: Use --launch_info when invoking MesosContainerizer.

> On Jan. 25, 2017, 11:21 a.m., Joshua Cohen wrote: > > build-support/packer/build.sh, line 20 > > > > > > This should probably be reverted? The current end-to-end test breaks since the Mesos-1.2.0 is not available i

Re: Review Request 55089: AURORA-1826 Expose Thrift server request workload stats

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55089/#review163042 --- src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftI

Re: Review Request 55089: AURORA-1826 Expose Thrift server request workload stats

> On Jan. 25, 2017, 3:11 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > line 427 > > > > > > This annotation can be very missleading when adding a ne

Re: Review Request 55951: Use --launch_info when invoking MesosContainerizer.

> On Jan. 25, 2017, 1:07 p.m., Stephan Erb wrote: > > The code change itself is fine. However, it's implications are a little bit > > horrible :) > > > > * We can only apply it once we have released 0.17 (build against Mesos 1.1) > > * Mesos broke +-1 version compatibility here, so users have t