Re: Review Request 62835: Use compatible Curator session and connection timeouts

2017-10-08 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62835/#review187383 --- Ship it! commons/src/main/java/org/apache/aurora/common/zookee

Re: Review Request 62652: Remove legacy commons ZK code

2017-10-08 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62652/#review187381 --- Ship it! Ship It! - John Sirois On Oct. 8, 2017, 11:29 a.m.,

Re: Review Request 62652: Remove legacy commons ZK code

2017-10-08 Thread David McLaughlin
> On Sept. 28, 2017, 3:22 a.m., David McLaughlin wrote: > > -1. > > > > Please see here for details on the current status of curator in production: > > https://issues.apache.org/jira/browse/AURORA-1840 > > Bill Farner wrote: > Aha, there was no trace of this in the code, thanks for the po

Re: Review Request 62835: Use compatible Curator session and connection timeouts

2017-10-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62835/#review187372 --- Ship it! Master (0169b81) is green with this patch. ./build-s

Review Request 62835: Use compatible Curator session and connection timeouts

2017-10-08 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62835/ --- Review request for Aurora, John Sirois and Bill Farner. Repository: aurora De

Re: Review Request 62652: Remove legacy commons ZK code

2017-10-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62652/#review187371 --- Master (2cb257b) is green with this patch. ./build-support/jenki

Re: Review Request 62623: Use a simpler command line argument system

2017-10-08 Thread Bill Farner
> On Oct. 8, 2017, 10:08 a.m., Stephan Erb wrote: > > Is anything blocking the merge of this patch? I need to add a new flag and > > I am wondering if I should sit out until this one is merged :) Go ahead with your patch, i'll deal with the merge conflict. The only remaining area for me to add

Re: Review Request 62832: Run Jenkins tests without the Gradle daemon

2017-10-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62832/#review187369 --- Ship it! Master (2cb257b) is green with this patch. ./build-s

Re: Review Request 62832: Run Jenkins tests without the Gradle daemon

2017-10-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62832/#review187368 --- Ship it! Ship It! - Bill Farner On Oct. 8, 2017, 10:16 a.m.,

Re: Review Request 62652: Remove legacy commons ZK code

2017-10-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62652/ --- (Updated Oct. 8, 2017, 10:29 a.m.) Review request for Aurora, David McLaughlin

Review Request 62832: Run Jenkins tests without the Gradle daemon

2017-10-08 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62832/ --- Review request for Aurora and Bill Farner. Repository: aurora Description ---

Re: Review Request 62652: Remove legacy commons ZK code

2017-10-08 Thread Bill Farner
> On Sept. 27, 2017, 8:22 p.m., David McLaughlin wrote: > > -1. > > > > Please see here for details on the current status of curator in production: > > https://issues.apache.org/jira/browse/AURORA-1840 > > Bill Farner wrote: > Aha, there was no trace of this in the code, thanks for the po

Re: Review Request 62623: Use a simpler command line argument system

2017-10-08 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62623/#review187366 --- Is anything blocking the merge of this patch? I need to add a new

Re: Review Request 62829: Fix documentation of pystachio Volume struct

2017-10-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62829/#review187365 --- Ship it! Ship It! - Bill Farner On Oct. 8, 2017, 8:38 a.m.,

Re: Review Request 62831: Switch packaging release checksum to sha512

2017-10-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62831/#review187364 --- Ship it! Ship It! - Bill Farner On Oct. 8, 2017, 9:20 a.m.,

Re: Review Request 62830: Switch release checksum to sha512

2017-10-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62830/#review187363 --- Ship it! Ship It! - Bill Farner On Oct. 8, 2017, 9:15 a.m.,

Re: Review Request 62830: Switch release checksum to sha512

2017-10-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62830/#review187362 --- Ship it! Master (0f1e684) is green with this patch. ./build-s

Review Request 62831: Switch packaging release checksum to sha512

2017-10-08 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62831/ --- Review request for Aurora and Bill Farner. Repository: aurora-packaging Descr

Review Request 62830: Switch release checksum to sha512

2017-10-08 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62830/ --- Review request for Aurora and Bill Farner. Repository: aurora Description ---

Re: Review Request 62829: Fix documentation of pystachio Volume struct

2017-10-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62829/#review187361 --- Ship it! Master (0f1e684) is green with this patch. ./build-s

Review Request 62829: Fix documentation of pystachio Volume struct

2017-10-08 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62829/ --- Review request for Aurora and Zameer Manji. Repository: aurora Description --