Review Request 36613: Add Boxever as a user

2015-07-20 Thread Brian Brazil
Description --- Add Boxever as a user Diffs - README.md ef9c2f0ecf44b03e2025fe9cab62a3aa5ae30a77 Diff: https://reviews.apache.org/r/36613/diff/ Testing --- Checked the link worked. Thanks, Brian Brazil

Re: Review Request 36392: Improve diff output of aurora cli.

2015-07-14 Thread Brian Brazil
iff: https://reviews.apache.org/r/36392/diff/ Testing --- Tested in vargant environment. Thanks, Brian Brazil

Re: Review Request 36392: Improve diff output of aurora cli.

2015-07-14 Thread Brian Brazil
-- Tested in vargant environment. Thanks, Brian Brazil

Re: Review Request 36456: Upgrade isort version, which is less verbose by default.

2015-07-13 Thread Brian Brazil
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36456/#review91545 --- Ship it! - Brian Brazil On July 13, 2015, 10:15 p.m., Bill

Re: Review Request 36392: Improve diff output of aurora cli.

2015-07-10 Thread Brian Brazil
li/test_diff.py da52105b5c77419ff64e15a30a04f997f9216a7e Diff: https://reviews.apache.org/r/36392/diff/ Testing --- Tested in vargant environment. Thanks, Brian Brazil

Re: Review Request 36392: Improve diff output of aurora cli.

2015-07-10 Thread Brian Brazil
ome/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/cli/bin/thermos.py > > Everything Looks Good! > > SUCCESS: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/testing/runner.py > > Everything Looks Good! > > SUCCESS: > &g

Review Request 36392: Improve diff output of aurora cli.

2015-07-10 Thread Brian Brazil
client/cli/jobs.py 5f608419e1235f14836865b46be05d13963deb37 Diff: https://reviews.apache.org/r/36392/diff/ Testing --- Tested in vargant environment. Thanks, Brian Brazil

Re: Review Request 36305: Remove restriction that -hostname must resolve.

2015-07-09 Thread Brian Brazil
l. To reply, visit: https://reviews.apache.org/r/36305/#review91000 ------- On July 9, 2015, 10:14 a.m., Brian Brazil wrote: > > --- > This is an automatic

Re: Review Request 36305: Remove restriction that -hostname must resolve.

2015-07-09 Thread Brian Brazil
warning, as for most users this is a misconfiguration. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java b4701295922ddad44d9d5c9fa29eb95e195e1604 Diff: https://reviews.apache.org/r/36305/diff/ Testing --- Verified in Vagrant environment. Thanks, Brian Brazil

Review Request 36305: Remove restriction that -hostname must resolve.

2015-07-08 Thread Brian Brazil
va/org/apache/aurora/scheduler/http/JettyServerModule.java b4701295922ddad44d9d5c9fa29eb95e195e1604 Diff: https://reviews.apache.org/r/36305/diff/ Testing --- Verified in Vagrant environment. Thanks, Brian Brazil

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-06-26 Thread Brian Brazil
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35847/#review89513 --- Ship it! Ship It! - Brian Brazil On June 24, 2015, 10:45 p.m

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-06-26 Thread Brian Brazil
> On June 25, 2015, 10:14 a.m., Brian Brazil wrote: > > docs/configuration-reference.md, line 449 > > <https://reviews.apache.org/r/35847/diff/5/?file=991681#file991681line449> > > > > If we're making this configurable, I think that we should make it ap

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-06-25 Thread Brian Brazil
tps://reviews.apache.org/r/35847/#comment141922> If we're making this configurable, I think that we should make it apply to the healthcheck config too. Does the HealthCheckConfig also belong in lifecycle? I'd consider them pretty strongly related. - Brian Brazil On June 24, 2015, 1

Re: Review Request 32973: Allow config of the /quitquitquit and /abortabortabort endpoints.

2015-06-16 Thread Brian Brazil
/test_thermos_task_runner.py 1e21a112efcbd0a575fb8d90f78ff1e8c7f034cf Diff: https://reviews.apache.org/r/32973/diff/ Testing --- Unittests and manually in vagrant cluster. Also verified that the flaky tests pass. Thanks, Brian Brazil

Re: Review Request 32973: Allow config of the /quitquitquit and /abortabortabort endpoints.

2015-06-12 Thread Brian Brazil
/test/python/apache/aurora/executor/test_thermos_task_runner.py 1e21a112efcbd0a575fb8d90f78ff1e8c7f034cf Diff: https://reviews.apache.org/r/32973/diff/ Testing --- Unittests and manually in vagrant cluster. Also verified that the flaky tests pass. Thanks, Brian Brazil

Re: Review Request 32973: Allow config of the /quitquitquit and /abortabortabort endpoints.

2015-06-12 Thread Brian Brazil
s.apache.org/r/32973/#review87644 --- On June 11, 2015, 10:39 a.m., Brian Brazil wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 32973: Allow config of the /quitquitquit and /abortabortabort endpoints.

2015-06-11 Thread Brian Brazil
/aurora/executor/test_thermos_task_runner.py:024 > > 'pytest' imported but unused > > |import pytest > > > > > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry" @ReviewBot retry Hmm,

Re: Review Request 32973: Allow config of the /quitquitquit and /abortabortabort endpoints.

2015-06-11 Thread Brian Brazil
/test_thermos_task_runner.py 1e21a112efcbd0a575fb8d90f78ff1e8c7f034cf Diff: https://reviews.apache.org/r/32973/diff/ Testing --- Unittests and manually in vagrant cluster. Also verified that the flaky tests pass. Thanks, Brian Brazil

Re: Review Request 32973: Allow config of the /quitquitquit and /abortabortabort endpoints.

2015-06-11 Thread Brian Brazil
/test_thermos_task_runner.py 1e21a112efcbd0a575fb8d90f78ff1e8c7f034cf Diff: https://reviews.apache.org/r/32973/diff/ Testing --- Unittests and manually in vagrant cluster. Also verified that the flaky tests pass. Thanks, Brian Brazil

Re: Review Request 32973: Allow config of the /quitquitquit and /abortabortabort endpoints.

2015-06-11 Thread Brian Brazil
cutor/thermos_task_runner.py:122 Line has > > trailing whitespace. > > |self._task.graceful_shutdown_endpoint().get(), > > > > > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry"

Re: Review Request 32973: Allow config of the /quitquitquit and /abortabortabort endpoints.

2015-06-10 Thread Brian Brazil
/test/python/apache/aurora/executor/test_thermos_task_runner.py 1e21a112efcbd0a575fb8d90f78ff1e8c7f034cf Diff: https://reviews.apache.org/r/32973/diff/ Testing (updated) --- Unittests and manually in vagrant cluster. Also verified that the flaky tests pass. Thanks, Brian Brazil

Re: Review Request 33433: Revert "Revert "Make health check configurable""

2015-06-10 Thread Brian Brazil
ated e-mail. To reply, visit: https://reviews.apache.org/r/33433/#review87301 --- On June 10, 2015, 9:03 a.m., Brian Brazil wrote: > > --- > This is an automatically generated e-

Re: Review Request 33433: Revert "Revert "Make health check configurable""

2015-06-10 Thread Brian Brazil
f5f8419b42a5484dac78d5a3b5033a7d74b7aa73 src/test/python/apache/aurora/executor/common/test_health_checker.py 1b4423a1eb95cc950206a355fa657c8082c8d93f Diff: https://reviews.apache.org/r/33433/diff/ Testing --- Unittests run. Thanks, Brian Brazil

Re: Review Request 33433: Revert "Revert "Make health check configurable""

2015-05-18 Thread Brian Brazil
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33433/#review84193 --- Can this be merged in now? - Brian Brazil On April 28, 2015, 6

Re: Review Request 33433: Revert "Revert "Make health check configurable""

2015-04-27 Thread Brian Brazil
1b4423a1eb95cc950206a355fa657c8082c8d93f Diff: https://reviews.apache.org/r/33433/diff/ Testing --- Unittests run. Thanks, Brian Brazil

Re: Review Request 32973: Allow config of the /quitquitquit and /abortabortabort endpoints.

2015-04-22 Thread Brian Brazil
6b24bbb2ab7ca16f97961aabeed945b61e5b5908 Diff: https://reviews.apache.org/r/32973/diff/ Testing --- Unittests and manually in vagrant cluster. Thanks, Brian Brazil

Review Request 33433: Revert "Revert "Make health check configurable""

2015-04-22 Thread Brian Brazil
/common/test_http_signaler.py f5f8419b42a5484dac78d5a3b5033a7d74b7aa73 src/test/python/apache/aurora/executor/common/test_health_checker.py 1b4423a1eb95cc950206a355fa657c8082c8d93f Diff: https://reviews.apache.org/r/33433/diff/ Testing --- Unittests run. Thanks, Brian Brazil

Re: Review Request 33317: Upgrade to pystachio 0.8.0

2015-04-20 Thread Brian Brazil
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33317/#review80825 --- Ship it! Ship It! - Brian Brazil On April 20, 2015, 7:17 p.m

Re: Review Request 32973: Allow config of the /quitquitquit and /abortabortabort endpoints.

2015-04-08 Thread Brian Brazil
://reviews.apache.org/r/32973/diff/ Testing --- Unittests and manually in vagrant cluster. Thanks, Brian Brazil

Re: Review Request 32973: Allow config of the /quitquitquit and /abortabortabort endpoints.

2015-04-08 Thread Brian Brazil
://reviews.apache.org/r/32973/diff/ Testing --- Unittests and manually in vagrant cluster. Thanks, Brian Brazil

Re: Review Request 32973: Allow config of the /quitquitquit and /abortabortabort endpoints.

2015-04-08 Thread Brian Brazil
://reviews.apache.org/r/32973/diff/ Testing --- Unittests and manually in vagrant cluster. Thanks, Brian Brazil

Review Request 32973: Allow config of the /quitquitquit and /abortabortabort endpoints.

2015-04-08 Thread Brian Brazil
. Thanks, Brian Brazil

Re: Review Request 32295: Make health check configurable

2015-04-01 Thread Brian Brazil
still want me to make the change? - Brian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32295/#review78558 --- On M